April 2004 - Wine-devel - list.winehq.org

Re: exec-shield patch take 6
by Mike Hearn 28 Apr '04

28 Apr '04

Go Mike! Good to see this work finally turn into a patch against CVS :) On Wed, 2004-04-28 at 19:02 +0900, Mike McCormack wrote: > Description: > > This patch allows platforms using exec-shield patch against the Linux > kernel (eg. Fedora Core) to run Wine without disabling exec-shield. It also fixes the prelink case, right? :) > + vars.pe_size = 0x01000000; 0x1000000? Are you sure you didn't drop a zero somewhere? That's only 16mb.... we probably want something like 0x40000000 which reserves a gig of address space. Some very large game installers can in fact get close to this level, and as it's just non-backed address space we're reserving (for a shor time) there's no real reason to be stingy. > +/* > + * The _start function is the entry and exit point of this program > + * > + * It calls wld_start, passing a pointer to the args it receives > + * then jumps to the address wld_start returns after removing the > + * first argv[] value, and decrementing argc > + */ > +void _start(void); > +__asm ( > + ".align 4\n" > + "\t.global _start\n" > + "\t.type _start,@function\n" > +"_start:\n" > + "\tcall wld_start\n" > + "\tpush %eax\n" > + "\txor %eax,%eax\n" > + "\txor %ebx,%ebx\n" > + "\txor %ecx,%ecx\n" > + "\txor %edx,%edx\n" > + "\tret\n" > +); You know, I wonder if we couldn't make this simpler ... well, shorter, by assuming the stack is already set up and the main binary is mapped correctly, then being careful not to disturb the linker entry stack just reserve the areas we need with a few mmap syscalls, map in the real dynamic linker and do a jump. In effect, rather than repeat the work the kernel already did for everything but the real dynamic linker, insert a small shim between them. Thoughts? thanks -mike

3 2

Re: Add stub function HWND GetConsoleWindow()
by Dmitry Timoshkov 28 Apr '04

28 Apr '04

"Ylia K" <k_ilya(a)ukr.net> wrote: > * dlls/kernel/kernel32.spec, dlls/kernel/console.c, include/wincon.h > Ilya Korniyko <k_ilya(a)ukr.net> > Add stub function HWND GetConsoleWindow() > > It is for excelent file manager FAR Manager (www.rarlab.com) > FAR Manager doesn't run without this patch. > With patch it runs - good on winXP, very bad on winME. I'm wondering how your patch works at all, the call should smash the stack since it misses WINAPI modifier. -- Dmitry.

3 3

Re: SetFocus
by Alexandre Julliard 27 Apr '04

27 Apr '04

Ulrich Czekalla <ulrich.czekalla(a)utoronto.ca> writes: > ChangeLog: > Ulrich Czekalla <ulrich(a)codeweavers.com> > Trying to set focus to an invisible window should fail I don't think that's correct, setting focus to an invisible window seems to work fine on Windows. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: RPCRT4: reimplement UuidCreate() with Win32 APIs (resubmit)
by Juan Lang 27 Apr '04

27 Apr '04

Alexandre wrote: > I don't think rpcrt4 should depend on iphlpapi, it > doesn't on Windows AFAICS. Right, rpcrt4 precedes iphlpapi. However, iphlpapi was created to allow you to do things that were platform-specific and often undocumented. In this case, rpcrt4 is trying to get the MAC address. On Windows 9x, you used to use WsControl for this, and this calls the appropriate VxD. Wine's WsControl forwards to iphlpapi instead (on Win9x iphlpapi calls WsControl). On Windows NT, you use a DeviceIoControl on the network device driver. Wine doesn't implement any of these. Wine could use ioctl on a UNIX fd, but I doubt this is what Hans wants to do, since he's trying to implement this using Win32. It appears to me that this is the most straightforward way to get the MAC address in Wine (but since I wrote iphlapi, you could count on me saying that ;) ) --Juan __________________________________ Do you Yahoo!? Win a $20,000 Career Makeover at Yahoo! HotJobs http://hotjobs.sweepstakes.yahoo.com/careermakeover

1 0

Re: RPCRT4: reimplement UuidCreate() with Win32 APIs (resubmit)
by Alexandre Julliard 27 Apr '04

27 Apr '04

Hans Leidekker <hans(a)it.vu.nl> writes: > Anything wrong with this one? > > Changelog: > Reimplement UuidCreate() with Win32 APIs. I don't think rpcrt4 should depend on iphlpapi, it doesn't on Windows AFAICS. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: 2 Fatal Problems With Winesetuptk-0.73 (BOTH Sourceforge Release Formats)
by Ivan Leo Murray-Smith 27 Apr '04

27 Apr '04

If you build a binary for older versions of Linux, let me know and I'll put your binary on the sourceforge page. AFAIK winesetuptk will only work correctly with the itcl/tck libs shiped in the tarball. Ivan.

1 0

Winsock help...
by António Serra 27 Apr '04

27 Apr '04

Hi all! I'm porting a windows application to Linux using the winelib. I created a project with KDevelop and include all ( at least I think all ) the .dll.so needed by my project. After compiling a linker error message appears, saying that /windows/D/ HICOD2000/j2kserver/j2kserver/kdu_server.cpp:2894: undefined reference to `WSAWaitForMultipleEvents' . It happens that I included the ws2_32.dll.so in my project. Am I missing something? TIA -- ______________________ António Serra aserra.wine(a)iol.pt ______________________

2 1

Re: GetTimeZoneInformation patch
by Rein Klazes 27 Apr '04

27 Apr '04

On Tue, 27 Apr 2004 10:03:13 -0400, you wrote: > I was looking through the source code and noticed a FIXME for the > GetTimeZoneInformation API in dlls/kernel/time.c saying that the function > needed to return a different value if Daylight Savings Time was in effect. I > implemented that feature, and also made the function return the proper value > if DST was not in effect for the version being simulated. > > I have enclosed the patch for the file against the latest source package. > > Here is the ChangeLog entry (I didn't patch the ChangeLog file): > > * dlls/kernel/time.c > William Lahti <computerman413(a)ezrs.com> > > - Fixed return values in GetTimeZoneInformation Three remarks: - you are using ftime() of which my man page says: | These days the contents of the timezone and dstflag fields are undefined. and | This function is obsolete. Don't use it. Have a look at the implementation of GetDaylightFlag() or use it directly. - You state that on NT, 2K and XP the return code is TIME_ZONE_ID_UNKNOWN when the daylight saving time is not in effect. This is only true if the transition dates are undefined. This is true in the current implementation, but those transition dates are a bigger FIXME then the correct return value. - I am not sure if it is worth the trouble to be so correct for windows 9x. The NT return value is not impossible under win9x and unless there is an application that depends on it, Wine defaults to the NT behavior. Rein. -- Rein Klazes rklazes(a)xs4all.nl

1 0

Re: MDI fix attempt
by Dmitry Timoshkov 27 Apr '04

27 Apr '04

"Krzysztof Foltman" <kfoltman(a)portal.onet.pl> wrote: > Applying this patch makes MDI Window menu behave as follows: > > - if no child windows are present, no separator is added (or it is > removed if it was present before) > - if any child windows are present (and visible), a separator is added > after last item of the original Window menu (unless it was already there) Is there a real bug you are trying to fix? When I last time worked with MDI code including Window menu handling I did a lot of tests under Windows. Did you? -- Dmitry.

2 6

Re: Winetest: outstanding issues (USING)
by Dimitrie O. Paun 27 Apr '04

27 Apr '04

Now for the second installment: USING (Feri) ----------------------- A. winetest Winetest will have to support a new option -B <filename> This will add a new section to the report, just before the test results, called "Build Info". The body of this section will be read from <filename>, with each time indented (say 4 spaces), and a blank line to end it (for neatness). B. Dissect & gather Need only recognize the "Build Info" section as optional, and ignore it for now. Maybe dissect should do that as a rule, ignore sections it doesn't understand. This way we can easily add more data in the future, without needing to constantly patch dissect. Such sections would have all lines indented, and would end with a blank line. BTW Feri, can we indent the body of our current sections? Would that break stuff? It would be nice to, would make the report more readable. We should be more forgiving with the parsing, like HTML is. The idea would be: "we should look only for stuff that we need for the report, additional stuff should be ignored. Moreover, non-essential stuff should be optional, and if not present/parsed, don't display". -- Dimi.

4 8