May 2004 - Wine-devel - list.winehq.org

Re: Repaint the whole nonclient window area on SetWindowPos(SWP_FRAMECHANGED)
by Alexandre Julliard 27 May '04

27 May '04

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > SetWindowPos(SWP_FRAMECHANGED) causes the whole nonclient window area > to be repainted. > > Also, according to the tests Windows always repaints windows before > SetWindowPos has finished. > > This patch reduces number of message test failures from 56 to 47. The message order is wrong because we rely on X expose events to repaint the window. This is one of the reasons we need to go back to not using X windows for every window; but until that is done, your fix is going to cause every window to be repainted twice. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Add a test for accessing classes from another thread
by Alexandre Julliard 27 May '04

27 May '04

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > somebody on the ReactOS mailing list mentioned that Windows stores class > information in the per thread list, not a per process or per module list. > That would effecively meant that accessing classes or creating windows > from other threads would fail. > > So, I decided to write a test for that. The test passes under Wine. Not for me: class.c:258: Test failed: GetLastError() should be set to ERROR_CLASS_HAS_WINDOWS class.c:258: Test failed: GetLastError() should be set to ERROR_CLASS_HAS_WINDOWS -- Alexandre Julliard julliard(a)winehq.org

1 0

atoi and undefined usage
by andrejoh＠c2i.net 27 May '04

27 May '04

The atoi() function has undefined usage when trying to convert numbers outside the range of int. When parsing numbers >= 2^31, GNU libc seems to truncate the number to 2^31-1; however, with MSVC, such a number would wrap, and when cast to an unsigned integer, numbers within an unsigned int are preserved. Should Wine care about such undefined behaviour? Currently, it seems Wine uses the GNU libc implementation, giving a different result than when running in Windows. (In my case, an IP address was given as a string, and ended up as "127.255.255.255" when running in Wine. I've now fixed that specific bug in the source code, but with other programs, that might not be an option...) -- Try Anarchy Online http://www.anarchy-online.com/content/downloads/tryout/ Netiquette guidelines ftp://ftp.rfc-editor.org/in-notes/rfc1855.txt How to quote properly http://www.i-hate-computers.demon.co.uk/ Hvordan sitere riktig http://home.online.no/~vidaandr/news/OBSquoting.html

2 1

Re: test for GetAcceptLanguagesA
by Martin Fuchs 27 May '04

27 May '04

On 27.05.2004 04:09:34 Alexandre Julliard wrote: > Stefan Leichter <Stefan.Leichter(a)camLine.com> writes: > > before removing the acsii calls from GetAcceptLanguagesW, i like to see > the > > results of the attached tests. This will hopefuly save me some work when > > rewriting the function. The tests passes on my Win2k system. > But they fail on Wine, so I can't apply the patch. I've seen some test cases wrapped in TODO sections, for example: todo_wine { SetWindowLong(hwnd1, GWL_EXSTYLE, GetWindowLong(hwnd1,GWL_EXSTYLE)|WS_EX_TOPMOST); ret = GetWindowLong(hwnd1,GWL_EXSTYLE)&WS_EX_TOPMOST? TRUE: FALSE; ok(!ret, "SetWindowExStyle(hwnd1, WS_EX_TOPMOST)\n"); } This prints a warning message about something yet to to in Wine, but the test doesn't fail. Can't you use this also for the patch in question? Regards, Martin

1 0

having problem in understanding debug channels
by zeeshaan umer 27 May '04

27 May '04

hi, its zee here, i am a student and i have just came to know about wine 2-3 weeks ago. i have started studying it for exploration purpose. its quite a great effort of u people. really it is........ nways the problem i m having is that i m not clearly understanding debug channels. i actually was trying to be a part of developers of wine and i tried to implement an API but when i wrote and included it in the source it could not be compiled i got an error " invalid debug channel specification ' ZEE_DEFAULT_DEBUG_CHANNEL( );' " i de have define ZEE_DEFAULT_DEBUG_CHANNEL in debug.h but frankly i have not actually understood the complete philosphy of these debug channels that how they work and how are they defined properly. plz,.......anybody help me. i m a student so dont mind if it is really rediculous type of problem......:-) zeeshan xeshaan(a)yahoo.co.in Yahoo! India Matrimony: Find your partner online.

2 1

Re: Additional downloads for winehq
by Ivan 27 May '04

27 May '04

OK, I don't see the utility of having a 3rd party download section just to list one download. But what about dcom95? We have a message in oleaut that tells the user to download dcom95, and it provides a link to sf, but we can't host dom on sf because it isn't open source, and people can download it free from m$ anyway. But Alexandre doesn't like long links, and the link to the dcom95 download page is just too long. It's http://www.microsoft.com/downloads/details.aspx?familyid=d7a4de78-81a9-4db7… and we want to keep the error log short. Ivan.

2 1

Re: Re: test for GetAcceptLanguagesA
by Pouech Eric DMI AEI CAEN 27 May '04

27 May '04

> Its not a fault of the tests that they fail on wine, its a fault of > wine. For my understanding the test are created to show that either the > behaviour of wine is correct (when the test succeeds) or that something > left to do one wine (when a test fails)!? check out the todo_wine construct in winetest Alexandre point is not that you cannot add a test that currently fails in Wine. His point is that you cannot add a test that will make the test process fail. The todo_wine is done for that: 1/ it marks a test as failing on wine 2/ it will report it (but not make the test fail) 3/ it will also make the test process fail if the test succeeds (so that we can remove the todo_wine mark) A+

1 0

Re: test for GetAcceptLanguagesA
by Alexandre Julliard 27 May '04

27 May '04

Stefan Leichter <Stefan.Leichter(a)camLine.com> writes: > before removing the acsii calls from GetAcceptLanguagesW, i like to see the > results of the attached tests. This will hopefuly save me some work when > rewriting the function. The tests passes on my Win2k system. But they fail on Wine, so I can't apply the patch. -- Alexandre Julliard julliard(a)winehq.org

4 3

[Janitorial]: Missing inversion im Bit manipulation
by Uwe Bonnes 27 May '04

27 May '04

Changelog: wine/dlls/winmm/winmm.c: Add obvious missing inversion -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- Index: wine/dlls/winmm/winmm.c =================================================================== RCS file: /home/wine/wine/dlls/winmm/winmm.c,v retrieving revision 1.33 diff -u -w -r1.33 winmm.c --- wine/dlls/winmm/winmm.c 27 Feb 2004 21:29:32 -0000 1.33 +++ wine/dlls/winmm/winmm.c 27 May 2004 07:56:13 -0000 @@ -1983,7 +1983,7 @@ lpMidiHdr = (LPMIDIHDR)msg->lParam; lpMidiHdr->lpNext = 0; lpMidiHdr->dwFlags |= MHDR_INQUEUE; - lpMidiHdr->dwFlags &= MHDR_DONE; + lpMidiHdr->dwFlags &= ~MHDR_DONE; lpMidiHdr->dwOffset = 0; break;

1 0

Re: Additional downloads for winehq
by Jeremy Newman 27 May '04

27 May '04

I don't think these belong on the download page. That would confuse the users. IMO the download page should only contain links to download Wine. All this should go in a HowTo or in the docs. I know we have the 3rd party tools section there. I was opposed to that as well. We just cleaned up the download page, and you people want to clutter it up again! <g> Btw, your link to the download page in the second patch in wrong. it should be: http://www.winehq.org/download (we need to keep consistent on the .org thing) On Wed, 2004-05-26 at 18:09, Ivan wrote: > These downloads can be useful for lots of wine users. > > Ivan.

1 0