September 2004 - Wine-devel

epoll patch - status?
by Shachar Shemesh 12 Sep '04

12 Sep '04

Hi Alexandre, I'm sorry for being a pest about this. I was wondering whether there is anything that needs to be done on that one in order to facilitate committing this patch? Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

5 14

Re: IShellFolder::CompareIDs partially undocumented take 2
by Vitaliy Margolen 12 Sep '04

12 Sep '04

Is there are any problems with this patch? Tests do confirm it. Vitaliy Margolen Saturday, September 4, 2004, 9:48:41 PM, Vitaliy Margolen wrote: > Since my previous patch wasn't excepted here it is again. This time with more fixes > and tests. > Also it _is_ documented that CompareIDs returns result in lower 16 bits. And this function > returns only -1/0/1 as a result. > Vitaliy Margolen > changelog: > dlls/shell32/shlfolder.c > IShellFolder::CompareIDs - return only -1/0/1 in lower 16 bit.

1 0

W->A calls
by Joris Huizer 11 Sep '04

11 Sep '04

Hello, By accident, I removed the emails of the thread I started, but I'll look it up if necessary; I found this old wine issue of some time ago.. I think the patch it has there could be helpfull http://winehq.org/?issue=229#About%20Converting%20W-%3EA%20Calls However, I don't know how to make simple tests.. as I'd really need to test wether the code I write works, and works properly :p How do I write tests for that? I'm running linux (in practice, I never boot into windows) so how should I do this (testing without windows environment)? How are tests supposed to run? I hope you can give some clues on that; I found there are many W->A calls in dlls/winmm/winmm.c (according to the janitorial page) so I might start there (hoping not all of them are so tricky ;) ) Thanks for suggestions on this, Joris

7 9

Re: Correct ConvertSidToStringSidW with test
by Dimitrie O. Paun 11 Sep '04

11 Sep '04

On Sat, Sep 11, 2004 at 08:37:09AM -0700, Juan Lang wrote: > ConvertSidToStringSidW was incorrect for low-value > authorities; it put spaces in the resulting string. > This corrects that, and includes a test case for it. Content-Description: advapi32.diff Uniffied diff, please :) -- Dimi.

1 0

Re: PROPSHEET: Wizard resizing
by Filip Navara 11 Sep '04

11 Sep '04

Filip Navara wrote: > I know this patch isn't really correct, but the old code isn't correct > either. Without it about 80% of the wizards were resized incorrectly > (or not at all) and the header line wasn't hidden sometimes. Even > though I would like to code the resizing correctly it will require > major code shuffling that I can't do now due to time constraints. So I > believe for now this patch is less evil than letting the code as is. > > (I can provide more details about how it should be implemented > correctly on request) > > - Filip > > Changelog: > First attempt at correcting wizard resizing. Scratch this patch please. I'll try to implement it correctly... Regards, Filip

1 0

Wine and non ANSI charset fonts
by Andreas Rosenberg 11 Sep '04

11 Sep '04

Hello guys, after a long pause I'm back testing our application (http://appdb.winehq.org/appview.php?appId=1536) with WINE. In the meantime I've been working to prepare our application for the east european/asian market (UTF16, wide char API). This seems to work so far, but as soon as you enter text requiring non ANSI glyphs, I'm only getting "square boxes" instead of the desired characters. So I was searching for another application that uses non ANSI glyhps with WINE. I choosed Opera, because it's quite easy to install. But unfortunately Opera 7.x crashed after entering the first URL. The function "WSAStringToAddress" and some other WSA funtions were missing/stubs. Yesterday evening I fixed these problems and just sent a patch making Opera work with Wine. With Opera I'm now getting the same or similar effects. just try the Opera in Wine and go to: http://www.viatech.com.tw/big5/index/index.jsp So my question: is this a configuration problem? Konquerer displays the page correctly, so the fonts on the Linux side have the correct glyphs available. But it seems they are not available in WINE - I looked into the WINE config file and found something like this: ;;default TrueType fonts with russian koi8-r encoding "Default" = "-monotype-arial-*-*-*--*-*-*-*-*-*-koi8-r" "DefaultFixed" = "-monotype-courier new-*-*-*--*-*-*-*-*-*-koi8-r" "DefaultSerif" = "-monotype-times new roman-*-*-*--*-*-*-*-*-*-koi8-r" "DefaultSansSerif" = "-monotype-arial-*-*-*--*-*-*-*-*-*-koi8-r" This seems to define something regarding the cyrilic charset. With these lines enabled, Opera can display russian pages correctly. But what do I need to enter to get the glyphs of other character sets? (chinese, hangul, etc...) I read the Wine users guide regarding fonts, but it still does not address the character set topic.Can anybody shed some light on this? Regards Andy

2 1

Re: Implementation of WSAStringToAddress(A/W), WSAHtonl, WSAHtons
by Alexandre Julliard 10 Sep '04

10 Sep '04

Andreas Rosenberg <andreas_rosenberg(a)web.de> writes: > +INT WINAPI WSAStringToAddressW(LPCWSTR AddressString, > + INT AddressFamily, > + LPWSAPROTOCOL_INFOA lpProtocolInfo, You should have an LPWSAPROTOCOL_INFOW here instead, and convert it before calling WSAStringToAddressA. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Almost complete UpdateResource implementation
by Alexandre Julliard 10 Sep '04

10 Sep '04

Vincent Béron <vberon(a)mecano.gme.usherb.ca> writes: > + if(!updates_list) > + { > + updates_list = current_updates; > + list_init(&updates_list->entry); > + } > + else > + list_add_after(&updates_list->entry, &current_updates->entry); That's not the right way to use the list functions. updates_list should be a separate struct list, that will make things a lot easier. > + LIST_FOR_EACH(ptr, &current_updates->resources_list->entry) > + { > + current_resource = LIST_ENTRY(ptr, QUEUEDRESOURCE, entry); > + free_queuedresource(current_resource); > + } You cannot free objects that are still on list, you have to remove them first. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: CreateDirectoryA conformance test improvement
by Alexandre Julliard 10 Sep '04

10 Sep '04

Wolfgang Schwotzer <wolfgang.schwotzer(a)gmx.net> writes: > This patch provides a conformance test for my patch > sent on 06. Sept 2004. > > I have successfully tested it on Windows98 and WindowsNT4. Actually the results of that test depend on what the current directory is on the drive you are testing. If your current directory is \ you will see that it fails on Windows too. I believe the Wine code is correct, it returns ACCESS_DENIED on the root and ALREADY_EXISTS anywhere else, just like Windows. -- Alexandre Julliard julliard(a)winehq.org

1 0

COmpilation problems with older Freetype 2
by Vincent Béron 10 Sep '04

10 Sep '04

A patch by Huw broke compilation of Wine on RH8 (and probably other platforms as well) which use Freetype 2.1.3 or earlier. More specifically, FT_ENCODING_NONE is undefined. Other ft_encoding_* (or FT_ENCODING_*) problems have arised in the past, but the solution used identifiers already present in older Freetype versions. The attached patch works (and results in the same compiled code IMHO), but looks like a hack rather than a proper fix (use MS_MAKE_TAG? that has already been removed in the past to use ft_encoding_*). Vincent

1 0