September 2004 - Wine-devel

dlls/msvcrt/time.c picks up wrong CLOCKS_PER_SEC define
by Uwe Bonnes 06 Sep '04

06 Sep '04

Hallo, wine/include/msvcrt/time.h defines CLOCKS_PER_SEC conditionally: #ifndef CLOCKS_PER_SEC #define CLOCKS_PER_SEC 1000 #endif in wine/dlls/msvcrt/time.c, <time.h> is included and defines CLOCKS_PER_SEC unconditional before to 1000000l. So MSVCRT_clock returns a value 1000 times to high. How should this be fixed? Should wine/dlls/msvcrt/time.c do the define unconditional? Do we need to use a different define (e.g. MSVCRT_CLOCKS_PER_SEC) in MSVCRT_clock()? Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Re: PROPSHEET: Fix wizard regression
by Filip Navara 06 Sep '04

06 Sep '04

Filip Navara wrote: > This fixes the regression caused by the Mike McCormack's patch and > solves the problem with Macromedia Flash MX in the correct way. There > is still other problem with Macromedia Flash MX when you check the > options on the "Publish Settings" if anyone wants to jump in and solve > that... > > Changelog: > - Revert incorrect change to tab control resizing from revision 1.109. > - Move the property sheet resizing code from PROPSHEET_CreatePage to > PROPSHEET_SetCurSel. It needs to be executed on every page change > because the application can modify it during the notifications. Use the attached patch instead please. Regards, Filip

1 0

Re: Wine Developer Cheatsheet, v1
by Mike Hearn 06 Sep '04

06 Sep '04

> That's is very interesting and useful, but I think there's two things that > can be improved: first the debug delay patch, I wasn't able to find it out > searching with gmane, maybe if you can add a link to the post on gmane it > should be better :) Yeah, it's a bit of a pain keeping track of useful patches that were never merged. Maybe we need a list somewhere. > The second thing is about the coding style. As I said before, I have a patch > for shlwapi which fixes some MSXML/Borland XML Components problems with the > builtin one, which wasn't accepted for some problem about the style and the > placement of the variables. I posted it as a bug at > http://bugs.winehq.org/show_bug.cgi?id=2385 . If you can add something > about the coding style I can fix it up and repost it for inclusion. A few things that jump out at me (not really reviewed the code itself): - No C++ // style comments, I'm afraid. They aren't portable enough. - Use HeapAlloc() over malloc(), as it says in the cheatsheet - Are you sure there is a debugstr_a?? I can't think what it would do, ANSI strings can just be printed by regular printf - You have to declare all the variables at the start of a block. Yes, it's a pain. Another C portability rule. So, can't do this: LPSTR foo = bar; StrCpyA(a, b); int i; They all have to go at the top. - Minor stylistic note: you can use strcpy rather than StrCpyA. But I doubt this was a problem. - Usually best to space stuff out, ie rather than this: if ( temp_out == temp_out2 ) { temp_in += 3; continue; } use this: if ( temp_out == temp_out2 ) { temp_in += 3; continue; } ... again I doubt Alexandre would reject the patch because of this. - //if ( *temp_in == '.' ) ... wine code generally doesn't do this. If you find it hard to match up a closing brace with the statement that opened it maybe you need ... *fanfare* EMACS! :) - Is it possible to implement the ANSI version by converting to unicode then calling the wide version, rather than duplicate it? The rest looks fine, I expect it was just the C portability stuff that tripped you up. Please do try again! thanks -mike

4 4

Re: RESEND: CreateDIBitmap: Don't create monochrome bitmaps
by Huw D M Davies 06 Sep '04

06 Sep '04

Hmm, actually this requires more work, because although CreateDIBitmap is now correct, the patch is messing up the toolbar icons in IE... Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: DestroyMenu: Check if the menu is still used (fix for bug 1486)
by Dmitry Timoshkov 06 Sep '04

06 Sep '04

"Michael Kaufmann" <hallo(a)michael-kaufmann.ch> wrote: > Some applications call DestroyMenu for menus that are still displayed in > a window. We need to check if a menu is still used and set the window's > menu handle to NULL if that's the case. > > This patch fixes the important bug 1486. > > Changelog: > - DestroyMenu: Check if the menu is still displayed and adjust the > window's menu handle There is a test case in Wine (dlls/user/tests/win.c,test_SetMenu) which shows that your patch is wrong. It was said many times already that the real fix for that bug is to move all user object management into wineserver and use the same handle allocation scheme as the one used for windows. -- Dmitry.

4 4

Possible fun project/todo list item?
by Mike Hearn 06 Sep '04

06 Sep '04

The OpenSSL library we use in wininet/netconnection.c is a very unstable library, with somewhat odd licensing as well. By unstable I'm talking about the interfaces it exports: unfortunately they break backwards compatibility very frequently with the result that a build of Wine compiled on one system may bail out when using SSL on another, as the soname/abi of OpenSSL it's looking for has changed *yet again*. This also means that some distros deliberately ship older versions and just backport security fixes, as upgrading OpenSSL to newer versions is quite painful. Fedora at least does this. If anybody is looking for work to do then, addressing this problem may be useful. Probably the best way forward is to talk to the GnuTLS people (http://www.gnu.org/software/gnutls/gnutls.html) and see if you can get written confirmation from them that they have a strong commitment to binary compatibility (at least, more than OpenSSL does). It also seems to be a fairly stable project: the new maintainer is more focussed on portability enhancements and a slow release cycle than making huge changes to the code. If so, it might be worth porting wininet over to GnuTLS, or alternatively, rather than remove the OpenSSL code just add code to use GnuTLS and then fall back to OpenSSL if it cannot be found (or vice-versa). One interesting thing about GnuTLS is that it has some OpenSSL compatibility code, but from a look at their website it seems that this is GPLd. Maybe we could get an exemption from them. The downside is that while OpenSSL is frequently going to not be found as it's the wrong version, GnuTLS is also not widely installed by default so it might not get us much in the short term. The good news is that Gaim packages are often built against it, so in any modern distro that packages Gaim (which is a very popular chat client) in its repositories, there's a good chance GnuTLS is packaged as well. thanks -mike

5 11

Battlefield 1942 d3d8 crash
by Robert Reif 06 Sep '04

06 Sep '04

I get the following crash when running the Battlefield 1942 single player demo from http://www.3dgamers.com/games/battlefield1942/ fixme:ddraw:Main_DirectDraw_SetCooperativeLevel (0x40361cd8)->(00000000,00000008) trace:d3d:Direct3DCreate8 SDKVersion = dc, Created Direct3D object at 0x40362218 fixme:d3d_caps:IDirect3D8Impl_FillGLCaps found GL_VERSION ("1.5.1 NVIDIA 61.06")->(0x003d17da) fixme:d3d_caps:IDirect3D8Impl_FillGLCaps found GL_RENDERER ("GeForce FX 5200/AGP")->(0x0250) trace:d3d:IDirect3D8Impl_CreateDevice (0x40362218)->(Adptr:0, DevType: 1, FocusHwnd: 0x10022, BehFlags: 80, PresParms: 0x41fc40b8, RetDevInt: 0x41fc409c) trace:d3d:IDirect3D8Impl_AddRef (0x40362218) : AddRef from 1 trace:d3d:IDirect3DDeviceImpl_CreateStateBlock (0x40362498) : Type(1) trace:d3d:IDirect3D8Impl_CreateDevice (0x40362218)->(DepthStencil:(75,D3DFMT_D24S8), BackBufferFormat:(22,D3DFMT_X8R8G8B8)) trace:d3d:IDirect3D8Impl_CreateDevice Context created (HWND=0x10022, glContext=0x43044054, Window=41943042, VisInfo=0x43043de0) fixme:d3d:IDirect3DDevice8Impl_Reset (0x40362498) : stub trace:d3d:IDirect3DDevice8Impl_GetBackBuffer (0x40362498) : BackBuf 0 Type 0 returning (nil) wine: Unhandled exception (thread 0009), starting debugger... fixme:console:SetConsoleCtrlHandler (0x4074a8f8,1) - no error checking or testing yet WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x00000004 in 32-bit code (0x40df748b). In 32 bit mode. 0x40df748b IDirect3DSurface8Impl_AddRef [/home/wine/wine/dlls/d3d8/surface.c:59] in d3d8: movl 0x4(%esi),%eax 59 return ++(This->ref); 59 return ++(This->ref); Wine-dbg>>bt Backtrace: =>1 0x40df748b IDirect3DSurface8Impl_AddRef+0x23(iface=0x0) [/home/wine/wine/dlls/d3d8/surface.c:59] in d3d8 (0x4081e84c) 2 0x40dd7216 IDirect3DDevice8Impl_GetBackBuffer+0x76(iface=0x40362498, BackBuffer=0x0, Type=0x0, ppBackBuffer=0x41fc40a0) [/home/wine/wine/dlls/d3d8/device.c:577] in d3d8 (0x4081e864) 3 0x00848ec0 (0x00000000) Wine-dbg>

1 0

Re: Wine and industrial communication like OPC
by Rickard Svensson 06 Sep '04

06 Sep '04

Thank you, for all your answers! We have one employee who has worked a lot with Windows, and same with OPC. So I can provide same answers. * Mike Hearn - OPC is mostly used for data collection, and to a lesser degree to control industrial machines. * Juan Lang AND Robert Shearman - OPC doesn't use named pipes. OPC uses Dcom over TCP. * Mike Hearn - OPC doesn't need any new Windows (2000, XP) parts, and should work on Win 98 with the added Dcom support (not tested). * Mike Hearn - Price of OPC for Linux was when I looked at it for about a year ago 3000 - 4000$ per project you used their API in. And it only supported one of the OPC versions. Now I guess that the prices has been going down... Now I also got some questions from your answers: * Did I understand correctly. Wine doesn't have a built in support for DCom, to be abel to use Dcom I have to add the DCom support from Windows 98 to the Linux system? And the problem with that is the MS License, it stops me from distribute those XXX.dll with a Linux product (hardware and software in this case.) * We want to make a OPC server, because other computers want to get information from our system. Is there a problem in make a DCOM server, is it the "no user can acsas port under 1024 on a Linux system" problem. * What I have heard I thought DCom uset RPC??? But Juan Lang wrote that Wine doesn't have support for RPC /Rickard -- ___________________________________________________________ Sign-up for Ads Free at Mail.com http://promo.mail.com/adsfreejump.htm

2 1

Re: InternetReadFile, FTP and partial buffers
by Uwe Bonnes 06 Sep '04

06 Sep '04

>>>>> "Krzysztof" == Krzysztof Foltman <kfoltman(a)portal.onet.pl> writes: Krzysztof> Hi All, In the original WinInet FTP implementation, Krzysztof> InternetReadFile always returns complete buffers, except for Krzysztof> the last block. Some programs (probably ill-behaving ones, Krzysztof> but I wouldn't bet my head on it) rely on that fact, and stop Krzysztof> retrieving the file after the first incomplete block. I met the same problem for the HTTP implementation. The MSG_WAITALL flag sent to recv should always retrieve buffers of the requested size, if possible. Can you please try your problem with the MSG_WAITALL flag instead your patch? Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- Index: wine/dlls/wininet/internet.c =================================================================== RCS file: /home/wine/wine/dlls/wininet/internet.c,v retrieving revision 1.95 diff -u -w -r1.95 internet.c --- wine/dlls/wininet/internet.c 19 Aug 2004 19:02:17 -0000 1.95 +++ wine/dlls/wininet/internet.c 4 Sep 2004 22:09:59 -0000 @@ -1632,7 +1632,7 @@ { case WH_HHTTPREQ: if (!NETCON_recv(&((LPWININETHTTPREQW)lpwh)->netConnection, lpBuffer, - dwNumOfBytesToRead, 0, (int *)dwNumOfBytesRead)) + dwNumOfBytesToRead, MSG_WAITALL, (int *)dwNumOfBytesRead)) { *dwNumOfBytesRead = 0; retval = TRUE; /* Under windows, it seems to return 0 even if nothing was read... */

1 0

Re: Wine and industrial communication like OPC
by Juan Lang 06 Sep '04

06 Sep '04

Rickard wrote: > * Juan Lang AND Robert Shearman - OPC doesn't use > named pipes. OPC uses Dcom over TCP. > * Mike Hearn - OPC doesn't need any new Windows > (2000, XP) parts, and should work on Win 98 with the > added Dcom support (not tested). Cool! This has a chance of working then. > * Did I understand correctly. Wine doesn't have a > built in support for DCom, to be abel to use Dcom > I have to add the DCom support from Windows 98 to > the Linux system? Yes, that appears to be true. Wine's rpcrt4.dll only works between programs running in the same Wine instance. > * We want to make a OPC server, because other > computers want to get information from our system. > Is there a problem in make a DCOM server, is it the > "no user can acsas port under 1024 on a Linux > system" problem. It's a problem for lots of reasons. They add up to this: this is unimplemented in Wine, and probably won't be implemented any time soon. > * What I have heard I thought DCom uset RPC??? But > Juan Lang wrote that Wine doesn't have support for > RPC Did I? I certainly didn't mean it. But you'd need to install the DCOM98 update to have any chance of success at it for now, at least if I read the code right. --Juan __________________________________ Do you Yahoo!? New and Improved Yahoo! Mail - Send 10MB messages! http://promotions.yahoo.com/new_mail

1 0