January 2005 - Wine-devel - list.winehq.org

CreateProcess
by Ivan Leo Puoti 19 Jan '05

19 Jan '05

Today Raymond Chen posted an article about CreateProcess(), I haven't looked at our implementation but if it works differently from his description someone may want to to fix it. http://blogs.msdn.com/oldnewthing Ivan.

1 0

uses for transmit_as in NT interoperability services
by Luke Kenneth Casson Leighton 19 Jan '05

19 Jan '05

it's odd, innit? you start to explore and go "uh, duh, _that's_ what that's for". there are a number of places in the NT services that i network-reverse-engineered six years ago where i was thinking, "hm, that's not NDR-formatted..." and had to continue anyway bumbling along. the areas i encountered which were most definitely _not_ NDR-formatted, despite appearances, were: 1) Security Descriptors 2) Spoolss (spoolss.idl) Data Structures (usually in case statements with horribly large unions) 3) Service Control Manager (svcctl.idl) security descriptors that i encountered contained relative offsets of members in the structure where it _mattered_ what the offset value was, and the same thing i encountered in spoolss data. unlike NDR, pointers are tokens: if it's non-zero, it's a pointer, and the data can be "expected" at a known point because the order in which structures are added is well-defined. [no i know i haven't mentioned the difference between ptr and unique] what i believe may be being used is "transmit_as" - see an example code from entegrity.com at: http://support.entegrity.com/private/doclib/docs/osfhtm/develop/apgstyle/Ap… so, to follow the guidance and examples at the above link, to send a Security Descriptor you would create this: typedef struct { int size; [ptr, size_is(size)] *security_descriptor_blob; } SECURITY_DESCRIPTOR_BLOB; then you would do this typedef [transmit_as(SECURITY_DESCRIPTOR_BLOB)] PSECURITY_DESCRIPTOR; and then, magically, you can do THIS: NTSTATUS SamrGetSecurityDescriptor(handle_t *hnd, [in, ref] PSECURITY_DESCRIPTOR); and in the server-side thing you'd define: void PSECURITY_DESCRIPTOR_to_xmit(PSECURITY_DESCRIPTOR *sec_des, SECURITY_DESCRIPTOR_BLOB *blob) { blob->size = get_security_descriptor_actual_size(sec_des); blob->data = malloc(blob_size); memcpy(blob->data, get_security_descriptor_blob(sec_des), blob->size); } not forgetting to do this! void PSECURITY_DESCRIPTOR_free_xmit( SECURITY_DESCRIPTOR_BLOB *blob) { free(blob->data); } and i think that's just _so_ cool. only took six years to realise it's possible. ... and i'd be fascinated to know if it's _right_ :) l. -- -- <a href="http://lkcl.net">http://lkcl.net</a> --

1 0

DCE happily supports transmit_as. cool!
by Luke Kenneth Casson Leighton 19 Jan '05

19 Jan '05

http://support.entegrity.com/private/doclib/docs/osfhtm/develop/apgstyle/Ap… cool!

1 0

Re: winecfg todo's
by Mike Hearn 19 Jan '05

19 Jan '05

On Tue, 2005-01-18 at 20:59 -0500, Tom wrote: > Hello Mike, > > I am working on a update to the Known ToDo's page > and was wondering if you could provide a current > list of ToDo's ? Hi Tom, As of Jan 19th 2005 the remaining work is basically to make Wine use winecfg as well as lots of testing. Writing a patch that Alexandre is happy with to kill the config file and move it all into the registry might be tricky, especially as the tree is so unstable right now (do we really want to make it worse?) ... but that's what needs to be done. There are plenty of other things that need to be done too but they can wait until people are actually *using* the damn thing thanks -mike

1 0

Re: [OLE #45] Proxy Manager Fixes
by Bill Medland 19 Jan '05

19 Jan '05

On January 18, 2005 02:04 pm, Robert Shearman wrote: > Hi, > > I have also fixed (kinda) the issue Bill > Medland was reporting where doing a CreateInstance for an IUnknown > interface was a bit messed up (this is bad programming anyway as it > doubles the number of RPC calls required). Maybe. (After all, Microsoft aren't perfect). However since it is in the ATL code we can expect it to occur from time to time, surely. > > Rob >

2 1

Re; cleanup shlfileop.c: why does this fail?
by Rolf Kalbermatter 18 Jan '05

18 Jan '05

Joris Huizer wrote: >That line can be removed as >nFileOp = *(lpFileOp) >on the first line - the variable is never changed after that (yeah, if >we really like, we could get rid of it) >I hadn't removed it just like that, yet - but as it is useless, it can >be removed. I wouldn't do that! This first line does not just copy a pointer but the ENTIRE structure. And those parameters are sometimes overwritten inside the function. So this last line also does do something, namely copying the aborted state back into the main structure for reference by the caller. Rolf Kalbermatter

1 0

Re: Ukrainian support
by Juan Lang 18 Jan '05

18 Jan '05

Hi Oleh, > --- wine-20050111/libs/unicode/cpmap.pl.orig 2004-01-21 00:39:06.000000000 +0200 > +++ wine-20050111/libs/unicode/cpmap.pl 2005-01-14 15:22:12.000000000 +0200 > @@ -82,6 +82,7 @@ > [ 10081, "VENDORS/MICSFT/MAC/TURKISH.TXT", "Mac Turkish" ], > [ 20866, "VENDORS/MISC/KOI8-R.TXT", "Russian KOI8" ], > [ 20932, "OBSOLETE/EASTASIA/JIS/JIS0208.TXT", "EUC-JP" ], > + [ 21866, "VENDORS/MISC/KOI8-R.TXT", "Ukrainian KOI8" ], > [ 28591, "ISO8859/8859-1.TXT", "ISO 8859-1 Latin 1" ], > [ 28592, "ISO8859/8859-2.TXT", "ISO 8859-2 Latin 2 (East European)" ], > [ 28593, "ISO8859/8859-3.TXT", "ISO 8859-3 Latin 3 (South European)" ], I may be missing something, but don't you mean "VENDORS/MISC/KOI8-U.TXT"? --Juan __________________________________ Do you Yahoo!? Take Yahoo! Mail with you! Get it on your mobile phone. http://mobile.yahoo.com/maildemo

1 0

Question about testing SHQueryValueExA in shlwapi/tests/shreg.c
by Paul Vriens 18 Jan '05

18 Jan '05

Hi, I'm trying to fix the tests in shlwapi/tests/shreg.c (or Wine for that matter). One thing that puzzles me in the current code is the checks done after we receive a ERROR_MORE_DATA when we pass a size smaller than the actual data. MSDN states: If the buffer specified by pvData parameter is not large enough to hold the data, the function returns ERROR_MORE_DATA and stores the required buffer size in the variable pointed to by pcbData. In this case, the contents of the pvData buffer are undefined. If that's the case, what's the use of checking the returned buffer with something? Wine and Win98 leave the buffer intact (the contents and thus size differ however) WinXPProf and W2KProf clear (so it seems) the buffer. Cheers, Paul Vriens.

2 2

Re; cleanup shlfileop.c: why does this fail?
by Juan Lang 18 Jan '05

18 Jan '05

Hi Joris, pFromFile and pToFile are treated oddly. Pass them as WCHAR pointers to file_operation_on_data, not as pointers to WCHAR pointers. The implementation of file_operation_on_data does not behave the same way as the code it replaced. You want something like: +static int file_operation_on_data(WIN32_FIND_DATAW *wfd,SHFILEOPSTRUCTW *nFileOp, LPWSTR pFromFile,LPWSTR pToFile) +{ + LPWSTR lpFileName = wfd->cAlternateFileName; + if (!lpFileName[0]) + lpFileName = wfd->cFileName; + if (IsDotDir(lpFileName) || + (IsAttribDir(wfd->dwFileAttributes) && (nFileOp->fFlags & FOF_FILESONLY))) + { + return 0; /* next name in pTempFrom(dir) */ + } + SHFileStrCpyCatW(&pToFile[1], lpFileName, NULL); + SHFileStrCpyCatW(&pFromFile[1], lpFileName, NULL); + return SHFileOperationW (nFileOp); +} One other difference that jumps out at me: - lpFileOp->fAnyOperationsAborted = nFileOp.fAnyOperationsAborted; + /*lpFileOp->fAnyOperationsAborted = nFileOp.fAnyOperationsAborted;*/ Why this change? --Juan __________________________________ Do you Yahoo!? Yahoo! Mail - Find what you need with new enhanced search. http://info.mail.yahoo.com/mail_250

2 1

Re: [LOSTWAGES] Add Alexandre's comment about the strncpy janitorial project
by Jeremy Newman 18 Jan '05

18 Jan '05

Crap, I thought I queued up these downloads a week or so ago. Someone must have rebooted taz and killed my downloads. Argh, if it didn't take so long to dl these ISO's. Anyway, I restarted the downloads again, I hopefully should have them by the end of today. I'll move them into /home/public/iso when done. The CD keys are already in the cd keys txt file. On Tue, 2005-01-18 at 11:26 +0900, Mike McCormack wrote: > ChangeLog: > * Add Alexandre's comment about the strncpy janitorial project > plain text document attachment (janitorial-strncpy-update.diff) > Index: templates/en/janitorial.template > =================================================================== > RCS file: /home/wine/lostwages/templates/en/janitorial.template,v > retrieving revision 1.63 > diff -u -r1.63 janitorial.template > --- templates/en/janitorial.template 13 Jan 2005 19:35:16 -0000 1.63 > +++ templates/en/janitorial.template 18 Jan 2005 02:23:57 -0000 > @@ -25,6 +25,13 @@ > the <i>dst</i> buffer, and always nul terminate the buffer when we > intended to.<p> > > + Julliard > + <a href="http://www.winehq.org/hypermail/wine-devel/2005/01/0390.html">says</a>: > + "A careful review of the code to ensure that lstrcpyn semantics are really what > + we want. In several cases we know that we are copying less than the full string, > + and in that case we have to use memcpy instead, lstrcpyn won't do the right > + thing."<p> > + > <h2>Regedit fixes</h2> > > Regedit lacks a few features. We need to improve regedit to:

1 1