January 2005 - Wine-devel - list.winehq.org

Re: Disable antialiasing in palette mode (updated)
by Jakob Eriksson 26 Jan '05

26 Jan '05

I'm just a peon but wouldn't it be better for the ReactOS project if you put the code in gdi instead? They have to solve it someplace else anyway, since they don't have x11drv. Glenn Wurster wrote: >This is an updated patch based on Alexandre's comments. It uses >GetObjectW instead of GDI_GetObjPtr. > >Description: > >According to the docs for CreateFont: > >"Windows 95 with Plus!, Windows 98/Me: The display must greater than >8-bit color, it must be a single plane device, it cannot be a palette >display, and it cannot be in a multiple display monitor setup. In >addition, you must select a TrueType font into a screen DC prior to >using it in a DIBSection, otherwise antialiasing does not happen." > >Windows 2000 has been tested and it also does not antialias fonts when >writing into an 8 bit DIB. > >This patch disables antialiasing when a palette is involved. You've >seen this before in previous incarnations. The docs specify to >disable antialiasing and I've got an application which depends on >antialiasing being disabled. I've tried putting the change in the gdi >code, as well as in the x11drv code. I think it looks cleaner in the >x11drv code (no change to function prototypes) so that's where this >attempts to put it (with the caching split off into a different patch >this time). > >Author: > * Glenn Wurster (gwurster(a)scs.carleton.ca) > >Changelog: > * Disable antialiasing of fonts while working in a palette. > >Index: dlls/x11drv/xrender.c >=================================================================== >RCS file: /home/wine/wine/dlls/x11drv/xrender.c,v >retrieving revision 1.56 >diff -u -r1.56 xrender.c >--- dlls/x11drv/xrender.c 24 Jan 2005 19:32:54 -0000 1.56 >+++ dlls/x11drv/xrender.c 26 Jan 2005 04:15:27 -0000 >@@ -1013,6 +1013,25 @@ > INT *deltas = NULL, char_extra; > HRGN saved_region = 0; > UINT align = GetTextAlign( hdc ); >+ BOOL disable_antialias = FALSE; >+ AA_Type antialias = AA_None; >+ >+ /* Do we need to disable antialiasing because of palette mode? */ >+ do { >+ HBITMAP hBitmap; >+ DIBSECTION bmp; >+ >+ hBitmap = GetCurrentObject( physDev->hdc, OBJ_BITMAP ); >+ if( GetObjectW( hBitmap, sizeof(bmp), &bmp ) != sizeof(bmp) ) { >+ TRACE("bitmap is not a DIB\n"); >+ break; >+ } >+ >+ if (bmp.dsBmih.biBitCount <= 8) { >+ TRACE("Disabling antialiasing\n"); >+ disable_antialias = TRUE; >+ } >+ } while (0); > > TRACE("%p, %d, %d, %08x, %p, %s, %d, %p)\n", hdc, x, y, flags, > lprect, debugstr_wn(wstr, count), count, lpDx); >@@ -1307,14 +1326,16 @@ > > EnterCriticalSection(&xrender_cs); > entry = glyphsetCache + physDev->xrender->cache_index; >- formatEntry = entry->format[entry->aa_default]; >+ if( disable_antialias == FALSE ) >+ antialias = entry->aa_default; >+ formatEntry = entry->format[antialias]; > > for(idx = 0; idx < count; idx++) { > if( !formatEntry ) { >- UploadGlyph(physDev, glyphs[idx], entry->aa_default); >- formatEntry = entry->format[entry->aa_default]; >+ UploadGlyph(physDev, glyphs[idx], antialias); >+ formatEntry = entry->format[antialias]; > } else if( glyphs[idx] >= formatEntry->nrealized || formatEntry->realized[glyphs[idx]] == FALSE) { >- UploadGlyph(physDev, glyphs[idx], entry->aa_default); >+ UploadGlyph(physDev, glyphs[idx], antialias); > } > } > assert(formatEntry); >@@ -1354,7 +1375,7 @@ > wine_tsx11_lock(); > XSetForeground( gdi_display, physDev->gc, textPixel ); > >- if(entry->aa_default == AA_None) { >+ if(antialias == AA_None) { > for(idx = 0; idx < count; idx++) { > SharpGlyphMono(physDev, physDev->org.x + x + xoff, > physDev->org.y + y + yoff, > >

2 1

Re: [winecfg] Show detected audio systems, and offer selection
by Rob Shearman 26 Jan '05

26 Jan '05

Paul van Schayck wrote: >Hey, > >Never thought a simple popup with a few radio boxes would be this hard... > > Instead of generating the dialog box manually, why don't you store it in a resource? It will then be easier to localise and should be easier to use. You could also disable the radio boxes of drivers that cannot be used instead of hiding them and then you wouldn't have to do complicated rearranging. Rob

3 3

Q GUIDS
by Oliver Stieber 26 Jan '05

26 Jan '05

Hi, I've had to generate some GUIDs for wined3d is there a wine policy on internal GUIDs or should the ones I've generated be ok. secondly, nothing to do with GUIDS, what's the 'best' thread safe IUnknown enumerate to use for storing a heap of unique elements that will be searched for by the IUnknown pointer as well as emerated. It would be usefull if the enumerate didn't reference count because I may also need to use a call back or sorts so that when the ref count of the IUnknown gets to zero it's release can tell the enumerate to remove it from the list. ___________________________________________________________ ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com

2 1

Re: PerformanceCounterFrequency fix.
by Lionel Ulmer 26 Jan '05

26 Jan '05

> --- wine/dlls/kernel/cpu.c 2004-12-29 12:09:47.000000000 +0100 > +++ mywine/dlls/kernel/cpu.c 2005-01-19 12:39:15.000000000 +0100 > @@ -188,7 +188,8 @@ BOOL WINAPI QueryPerformanceCounter(PLAR > /* i586 optimized version */ > __asm__ __volatile__ ( "rdtsc" > : "=a" (counter->u.LowPart), "=d" (counter->u.HighPart) ); > - counter->QuadPart = counter->QuadPart / 1000; /* see below */ > + /* see below */ > + counter->QuadPart = counter->QuadPart / ( cpuHz / 1193182 ) ; > return TRUE; > } > #endif Don't we loose some precision here or are we sure that all PC clocks are exact multiples of '1193182' ? Moreover, anyone has any idea how to do this without using RDTSC (which is a bad idea on most laptops and may well be on modern CPUs too if any implement the laptop-like power saving features) ? Lionel -- Lionel Ulmer - http://www.bbrox.org/

3 6

Inconsistent test visualization
by Paul Vriens 26 Jan '05

26 Jan '05

Hi, I just had a look at http://test.winehq.org/data/200501251000/. When you look at the main overview it shows that shlwapi:path has a yellow box (144) under Win98. If you however jump to the Win98 overview, there is no shlwapi:path? The same is true for shlwapi:clsid, winmm:capture, winmm:wave and maybe more? Any ideas, Paul.

1 0

Re: Oracle - unixODBC - wine - Win32 ODBC Apple [Virus checked]
by Bill Medland 26 Jan '05

26 Jan '05

On January 25, 2005 08:03 am, Martin HEIN wrote: > Bill, > > I just upgraded to the most recent version of CrossOver Office 4.1 > Professional, a nightly build as of January 25th, 2005, and wine > reports version 20050111. (upgraded from Crossover Office 20040716) So do the "trace:odbc:....." messages display now? (Anyone at Codeweavers - Does Crossover disable the traces?) > > Furthermore I created a symbolic link from /usr/local/etc/odbcinst.ini > to /etc/odbcinst.ini, and from /usr/local/etc/odbc.ini to > /etc/odbc.ini. Shouldn't matter > > Then I added my DSN (KMPA) to the registry > HKEY_LOCAL_MACHINE\Software\ODBC\ODBC.ini, just as statet at the > unixODBC home page, actually they are quoting you! :) My entries are: > > Driver REG_SZ "unixODBC" > User REG_SZ "" > Password REG_SZ "" > Did I mention the USer and Password? It was so long ago I don't remember. Currently there is now code in the builtin odbc32.dll that attempts to replicate the unixODBC DSN information into the registry, but it may not do enough. > But when running ODBCTE32.exe I still couldn't connect to my database. As I said, that was because that exe seems to require the new "Wide" functions. It isn't going to work until the patch submitted is accepted (or rejected and a different one accepted) > Another test was running Crystal Reports 8.0 which didn't result in a > successful connection either. >From your other email I understand that it managed to do quite a bit, just not everything. What error messages? > > - Martin > > -------------------------------------------------- > T-Mobile Austria GmbH > Ing.Martin HEIN > Information Technologies / Services > Knowledge Management & Process Automation / Senior Manager > > Rennweg 97-99 > A-1030 Vienna > Fon: +43-1-79585-6337 > Fax: +43-1-79585-6584 > Mobile: +43-676-82006337 > E-Mail: Martin.HEIN(a)T-Mobile.at > Web: http://www.T-Mobile.at > -------------------------------------------------- > NOTICE AND DISCLAIMER: > This email (including attachments) is confidential. If you have > received this email in error please notify the sender immediately and > delete this email from your system without copying or disseminating it > or placing any reliance upon its contents. > -------------------------------------------------- -- Bill Medland Programmer ACCPAC International, Inc. bill.medland(a)BestSoftware.com Corporate: www.accpac.com Hosted Services: www.accpaconline.com

3 2

Resend: [wined3d] more vertex declaration work
by Raphael 25 Jan '05

25 Jan '05

Hi, I resend it (resync from current cvs) as i haven't been commited yet Regards, Raphael > > Changelog: > - VertexDeclaration device APIs > - D3D9 declarations parsing > - a little better APIs (trying to avoid compil problems) > > Todo: > - D3D8 declarations parsing (converting to d3d9 compatible using code in > d3d8) > - find a more cleaner prototype for CreateVertexDeclaration/GetDeclaration > APIs > - Use on drawing paths (implement StriddedFillFromDeclaration) > - use on d3d9 code > > Regards, > Raphael

4 6

Re: Oracle - unixODBC - wine - Win32 ODBC Apple [Virus checked]
by Bill Medland 25 Jan '05

25 Jan '05

On January 25, 2005 06:40 am, you wrote: > Bill, > > To verify an ODBC connection from a Windows-based application I'm using > 'odbct32w.exe' and 'odbcte32.exe', both from the Microsoft MDAC 2.8 > SDK. The former crashes (see attached log), the latter runs fine except > it doesn't display my unixODBC DSNs, nor can't it connect to one of the > DSNs when entered manually. > > On 24. J� 2005, at 15:29, Bill Medland wrote: > > presume you are running a program called myprog.exe from the command > > line. > > You type, at the command line, > > export WINEDEBUG=odbc > > wine myprog.exe 2>odbc.log > > and when you are finished the file "odbc.log" is empty, or contains no > > information about odbc? In particular you have no > > trace:odbc:DllMain Initializing or Finalizing proxy ODBC > > odbct32w.exe generates: Aha (There is still no indication that you are doing the WINEDEBUG; what version of Wine are you running?) I see that the program, is calling SQLDataSourcesW, the "Wide" version of SQLDataSources. That is currently not implemented. I see a patch went in for it on 24 January but I don't know when or if it will be accepted. So it is quite possible that the actual program will work if it is based on the "standard" SQL functions. -- Bill Medland mailto:billmedland(a)mercuryspeed.com http://webhome.idirect.com/~kbmed

3 2

[Janitorial] Interlocked* cleanup completed
by Paul Vriens 25 Jan '05

25 Jan '05

Hi, If there are not objections I'll send the attached patch to wine-patches. Changelog The Interlocked cleanup is completed. Cheers, Paul.

1 0

Re: PerformanceCounterFrequency fix.
by Mike Hearn 25 Jan '05

25 Jan '05

On Tue, 25 Jan 2005 19:30:04 +0100, Andreas Mohr wrote: > and that thus the Windows function is equally highly optimized, > certainly much less slow than a gettimeofday() call. These days gettimeofday() is very fast because the kernel vDSO system is used to optimize the syscall overhead. thanks -mike

1 0