October 2005 - Wine-devel - list.winehq.org

Re: ntdll: Append the file_part for \\?\ long file names too [TRY 2]
by Alexandre Julliard 17 Oct '05

17 Oct '05

James Hawkins <truiken(a)gmail.com> writes: > diff -u -p -r1.35 path.c > --- dlls/ntdll/path.c 11 Aug 2005 10:41:27 -0000 1.35 > +++ dlls/ntdll/path.c 15 Oct 2005 16:24:23 -0000 > @@ -421,6 +421,9 @@ BOOLEAN WINAPI RtlDosPathNameToNtPathNa > if (!ntpath->Buffer) return FALSE; > memcpy( ntpath->Buffer, dos_path, ntpath->MaximumLength ); > ntpath->Buffer[1] = '?'; /* change \\?\ to \??\ */ > + RtlGetFullPathName_U(dos_path, sizeof(local), local, file_part); > + if (file_part && *file_part) > + *file_part = ntpath->Buffer + ntpath->Length / sizeof(WCHAR) - strlenW(*file_part); > return TRUE; There's no reason to call RtlGetFullPathName, we already have a full path name here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: SHELL32: Use ShellLink_QueryInterface to return the right interface in IShellLink_Constructor.
by Alexandre Julliard 17 Oct '05

17 Oct '05

Mike McCormack <mike(a)codeweavers.com> writes: > @@ -1176,18 +1176,7 @@ HRESULT WINAPI IShellLink_Constructor( I > > TRACE("(%p)->()\n",sl); > > - if (IsEqualIID(riid, &IID_IUnknown) || > - IsEqualIID(riid, &IID_IShellLinkA)) > - *ppv = sl; > - else if (IsEqualIID(riid, &IID_IShellLinkW)) > - *ppv = &(sl->lpvtblw); > - else { > - LocalFree((HLOCAL)sl); > - ERR("E_NOINTERFACE\n"); > - return E_NOINTERFACE; > - } > - > - return S_OK; > + return ShellLink_QueryInterface( sl, riid, ppv ); This will leak the object if QueryInterface fails. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel: Fix [Bug:1885] - LoadLibraryA("name ")
by Vitaliy Margolen 17 Oct '05

17 Oct '05

Any reason why this patch didn't go in? It does fix the reported bug and tests show the correct behavior. Vitaliy Margolen Monday, October 10, 2005, 3:14:24 PM, Vitaliy Margolen wrote: > What's interesting this works only on winnt+. Win9x gives error > ERROR_DLL_NOT_FOUND. > I've ran some tests to find where it does this. It's done in the kernel32 not > ntdll. And ntdll fails in the same way as wine's does. > Vitaliy Margolen > changelog: > kernel: > - LoadLibrary should ignore trailing spaces in the library name.

2 1

Re: [WINEDOC] IDA workarounds
by Dimi Paun 17 Oct '05

17 Oct '05

On Sat, 2005-10-08 at 18:19 +0000, Molle Bestefich wrote: > James Hawkins suggested using native comctl32 as a workaround to get > IDA running. I don't want this sort of thing in the docs: it's too transient, and I hope we'll fix it rather then document it. If you want to capture this sort of information somewhere, the AppDB would be the place. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

3 6

HL2
by Andreas Schneider 16 Oct '05

16 Oct '05

Hi, I got wine compiling on x86_64 with some 32bit libs today and tested HL2 again. Steam updates and works just fine, but if I want to start HL2 it always throws a message "The latest version of Microsoft DirectX is required to play Half-Life 2" I've updated the DirectX version string to the latest version "Version"="4.00.09.0904" but this doesn't help. Could someone help me to debug for what else HL2 checks? The console outputs only fixme:d3d:IWineD3DImpl_GetDeviceCaps Caps support for directx9 is nonexistent at the moment! Thanks, -- andreas -- http://www.linux-gamers.net - your online gaming resource

1 1

test.winehq.org broken ?
by Stefan Leichter 16 Oct '05

16 Oct '05

Hello, during the weekend i run winetest-200510121000-paul-mingw.exe and winetest-200510131000-paul-mingw.exe on my NT4 box and clicked on the button to submit the test results. The progress bar for submitting the test results finished without error, but the test results did not show up on the web site. Does anyone else have/notice the problem? Bye Stefan

2 1

16 bit code, breakpoints?
by Ann & Jason Edmeades 16 Oct '05

16 Oct '05

Hi, How do you set breakpoints in 16 bit code, or cant you? I can add in the winedos code a debugbreak at a particular point in time, and I really want to step through some of the code following the return to see why something is happening. If I do, for example, break 0x1257:0x33f3 or *0x1257:0x33f3 it doesn't work. Jason

2 1

Re: [ World of Warcraft ] The 1.8 Patch brings the target ( or targeting ) problem back
by Jesse Allen 15 Oct '05

15 Oct '05

On 10/15/05, Christoph <cr2005(a)u-club.de> wrote: > Mike Hearn schrieb: > > Here is maybe a clue. Can anyone outline the role of imm32.dll and if it > can be involved in our problem? > imm32.dll seems to be a dll for internationalizing certain text.

1 0

correct ismbblead implementation
by Vijay Kiran Kamuju 15 Oct '05

15 Oct '05

Hi, we can use the following registrykey HKEY_LOCAL_MACHINE\ System\CurrentControlSet\Control\NLS\CodePage\EUDCCodeRange to get the correct key range and also for correct implementation of ismbblead in msvcrt its documented here http://msdn.microsoft.com/library/default.asp?url=/library/en-us/intl/unico… Thanks, Vijay

1 0

Reality check
by John Smith 15 Oct '05

15 Oct '05

There was a discussion here about 2 months ago, where I asked for a way to embed WINE config strings into Win32 executable (for example, as string resources). I was told that it is better to fix the problem rather than to create workarounds, and that fixing bugs is trivial and takes at most 2-3 days as soon as it is reproducible. I didn't argue much then but made a little experiment to prove my point. The point is the following: THE MOST DIFFICULT THING IN GETTING BUG FIXED IS TO GET SOMEBODY WORK ON IT. The same applies both to commercial environments and to open source ones equally. Experiment illustrates it very well: I've found an application that experiences the problem with sympthoms which are very similar to ours, can be installed in 5 minutes and the problem can be reproduced in 3 clicks. And I've opened a bug in WINE's bugzilla: #3270 (another one #3269 was opened for another incompatibility). Result is the following: IN 6 WEEKS NOBODY EVEN TOOK A LOOK AT BOTH THOSE BUGS. Welcome to the real world _________________________________________________________________ FREE pop-up blocking with the new MSN Toolbar get it now! http://toolbar.msn.click-url.com/go/onm00200415ave/direct/01/

13 26