November 2005 - Wine-devel - list.winehq.org

Icons not created by wineshelllink
by Dustin Navea 17 Nov '05

17 Nov '05

I have reopened bug 717, starcraft icons not created by wineshelllink, because, well, they arent... They used to be, but now it spits out an error. See the bug for more info.. Dustin

1 0

Ignore post about winrar not showing files/folders on other drives
by Dustin Navea 17 Nov '05

17 Nov '05

After the listview update, and the corresponding patch that gets winrar to start up again, winrar now shows files/folders on other drives again.. Sorry for the confusion. Dustin

1 0

WinRAR doesnt show files on drives other than the default one
by Dustin Navea 17 Nov '05

17 Nov '05

When I start WinRAR, it shows the files and folders on the drive that it starts up in, but if I switch to drive Z (the / folder on my reiser fs), nothing shows up there. This is most likely a listview bug, but I´m not sure when it stopped working. Sometime before 0.9 came out. I will file a bug for it tomorrow after work, as well as posting a DEBUGMSG=+listview log at that time.. Dustin

1 0

Regression: WinRAR now fails to start (not related to Xorg 6.8.2)
by Dustin Navea 17 Nov '05

17 Nov '05

I reverted my Xorg install to 6.8.1, so I can at least do some bug hunting, and was able to get wine to run WinRAR post 0.9, pre 0.9.1, now after updating to cvs as of about an hour or so ago, WinRAR fails to start with: err:listview:LISTVIEW_WindowProc unknown msg 108c wp=00000000 lp=00000000 wine: Unhandled page fault on read access to 0x00000014 at address 0x406e0a38 (thread 0009), starting debugger... backtrace attached, and faulty patch coming shortly speeddy(a)pipedream:/drive_c/Program Files/WinRAR$ wine WinRAR.exe fixme:shell:SHAutoComplete SHAutoComplete stub err:rebar:REBAR_AdjustBands Phase 1 failed, x=692, maxx=-4, start=0, end=0 err:rebar:REBAR_AdjustBands Phase 1 failed, x=692, maxx=-4, start=0, end=0 err:rebar:REBAR_AdjustBands Phase 1 failed, x=40, maxx=-4, start=1, end=1 err:rebar:REBAR_AdjustBands Phase 1 failed, x=692, maxx=-4, start=0, end=0 err:rebar:REBAR_AdjustBands Phase 1 failed, x=40, maxx=-4, start=1, end=1 err:rebar:REBAR_AdjustBands Phase 1 failed, x=100, maxx=-4, start=2, end=2 err:listview:LISTVIEW_WindowProc unknown msg 108c wp=00000000 lp=00000000 wine: Unhandled page fault on read access to 0x00000014 at address 0x406e0a38 (thread 0009), starting debugger... WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x00000014 in 32-bit code (0x406e0a38). In 32 bit mode. Register dump: CS:0023 SS:002b DS:002b ES:002b FS:1007 GS:0000 EIP:406e0a38 ESP:406794bc EBP:406794cc EFLAGS:00210246( - 00 -RIZP1) EAX:00000000 EBX:40752abc ECX:00000024 EDX:00000020 ESI:00000000 EDI:4067a508 Stack dump: 0x406794bc: 403bf188 40752abc 00001203 0001003c 0x406794cc: 406794f0 406e268f 0001003c 00000004 0x406794dc: 4067a508 00000000 40829784 00001203 0x406794ec: 0001003c 40679514 40805cf7 0001003c 0x406794fc: 00001203 00000004 4067a508 40829784 0x4067950c: 00001203 0001003c 40679544 40806043 0200: sel=1007 base=40018000 limit=00001fff 32-bit rw- Backtrace: =>1 0x406e0a38 HEADER_GetItemT+0xb8(hwnd=0x1003c, nItem=0x4, phdi=0x4067a508, bUnicode=0x0) [/home/speeddy/wine/dlls/comctl32/header.c:837] in comctl32 (0x406794cc) 2 0x406e268f HEADER_WindowProc(hwnd=0x1003c, msg=0x1203, wParam=0x4, lParam=0x4067a508) [/home/speeddy/wine/dlls/comctl32/header.c:1756] in comctl32 (0x406794f0) 3 0x40805cf7 WINPROC_wrapper+0x17 in user32 (0x40679514) 4 0x40806043 WINPROC_CallWndProc+0x63(proc=0x406e2330, hwnd=0x1003c, msg=0x1203, wParam=0x4, lParam=0x4067a508) [/home/speeddy/wine/dlls/user/winproc.c:417] in user32 (0x40679544) 5 0x4080b374 WINPROC_CallProc32ATo32W(func=0x406e2330, hwnd=0x1003c, msg=0x1203, wParam=0x4, lParam=0x4067a508) [/home/speeddy/wine/dlls/user/winproc.c:2993] in user32 (0x4067956c) 6 0x4080be02 CallWindowProcA(func=0x4086811e, hwnd=0x1003c, msg=0x1203, wParam=0x4, lParam=0x4067a508) [/home/speeddy/wine/dlls/user/winproc.c:3285] in user32 (0x406795a0) 7 0x407df96f call_window_proc+0x12f(hwnd=0x1003c, msg=0x1203, wparam=0x4, lparam=0x4067a508, unicode=0x0, same_thread=0x1) [/home/speeddy/wine/dlls/user/message.c:1520] in user32 (0x406795fc) 8 0x407e1509 SendMessageTimeoutA+0x1a9(hwnd=0x1003c, msg=0x1203, wparam=0x4, lparam=0x4067a508, flags=0x0, timeout=0x0, res_ptr=0x4067968c) [/home/speeddy/wine/dlls/user/message.c:2397] in user32 (0x40679668) 9 0x407e15d5 SendMessageA(hwnd=0x1003c, msg=0x1203, wparam=0x4, lparam=0x4067a508) [/home/speeddy/wine/dlls/user/message.c:2441] in user32 (0x40679694) 10 0x00462e5c in winrar (+0x62e5c) (0x00000000) 0x406e0a38 HEADER_GetItemT+0xb8 [/home/speeddy/wine/dlls/comctl32/header.c:837] in comctl32: cmpl $-1,0x14(%esi) 837 if (lpItem->iImage == I_IMAGECALLBACK) Modules: Module Address Debug info Name (67 modules) PE 0x00400000-00518000 Export winrar ELF 0x40000000-40017000 Deferred ld-linux.so.2 ELF 0x4001a000-40023000 Deferred libnss_compat.so.2 ELF 0x40023000-4002d000 Deferred libnss_nis.so.2 ELF 0x4002d000-40033000 Deferred libxxf86dga.so.1 ELF 0x40034000-4004e000 Deferred libwine.so.1 ELF 0x4004f000-40168000 Deferred libc.so.6 ELF 0x40168000-4016c000 Deferred libdl.so.2 ELF 0x4016c000-401df000 Deferred ntdll<elf> \-PE 0x40180000-401df000 \ ntdll ELF 0x401df000-402d4000 Deferred libwine_unicode.so.1 ELF 0x402d4000-402f7000 Deferred libm.so.6 ELF 0x402f7000-402ff000 Deferred libsm.so.6 ELF 0x40302000-40314000 Deferred libz.so.1 ELF 0x40314000-4032a000 Deferred libnsl.so.1 ELF 0x4032a000-40334000 Deferred libnss_files.so.2 ELF 0x40334000-40339000 Deferred libxxf86vm.so.1 ELF 0x40339000-4033c000 Deferred libxrandr.so.2 ELF 0x4033c000-4033f000 Deferred xlcdef.so.2 ELF 0x40450000-40549000 Deferred kernel32<elf> \-PE 0x40470000-40549000 \ kernel32 ELF 0x40575000-4057d000 Deferred libxrender.so.1 ELF 0x40680000-406b9000 Deferred advapi32<elf> \-PE 0x40690000-406b9000 \ advapi32 ELF 0x406b9000-40765000 Stabs comctl32<elf> \-PE 0x406c0000-40765000 \ comctl32 ELF 0x40765000-40878000 Stabs user32<elf> \-PE 0x40780000-40878000 \ user32 ELF 0x40878000-408fc000 Deferred gdi32<elf> \-PE 0x40890000-408fc000 \ gdi32 ELF 0x408fc000-4098e000 Deferred comdlg32<elf> \-PE 0x40910000-4098e000 \ comdlg32 ELF 0x4098e000-40a4d000 Deferred shell32<elf> \-PE 0x409a0000-40a4d000 \ shell32 ELF 0x40a4d000-40aa2000 Deferred shlwapi<elf> \-PE 0x40a60000-40aa2000 \ shlwapi ELF 0x40aa2000-40b25000 Deferred ole32<elf> \-PE 0x40ac0000-40b25000 \ ole32 ELF 0x40b25000-40b68000 Deferred rpcrt4<elf> \-PE 0x40b40000-40b68000 \ rpcrt4 ELF 0x40b68000-40b85000 Deferred iphlpapi<elf> \-PE 0x40b70000-40b85000 \ iphlpapi ELF 0x40b85000-40bac000 Deferred winspool.drv<elf> \-PE 0x40b90000-40bac000 \ winspool.drv ELF 0x40bac000-40bb0000 Deferred iso8859-1.so ELF 0x40bb0000-40bb9000 Deferred libxcursor.so.1 ELF 0x40bc9000-40c33000 Deferred libfreetype.so.6 ELF 0x40c33000-40cac000 Deferred winex11.drv<elf> \-PE 0x40c40000-40cac000 \ winex11.drv ELF 0x40cac000-40cc4000 Deferred libice.so.6 ELF 0x40cc4000-40cd2000 Deferred libxext.so.6 ELF 0x40cd2000-40d9c000 Deferred libx11.so.6 ELF 0x40d9c000-40e18000 Deferred libgl.so.1 ELF 0x40e18000-40e69000 Deferred libpthread.so.0 ELF 0x40e69000-40e87000 Deferred ximcp.so.2 ELF 0x40e87000-40ea3000 Deferred imm32<elf> \-PE 0x40e90000-40ea3000 \ imm32 ELF 0x40ea3000-40ed3000 Deferred uxtheme<elf> \-PE 0x40eb0000-40ed3000 \ uxtheme ELF 0x40f30000-40f44000 Deferred riched32<elf> \-PE 0x40f40000-40f44000 \ riched32 ELF 0x40f4d000-40f69000 Deferred libcups.so.2 ELF 0x40f69000-40f9a000 Deferred libssl.so.0 ELF 0x40f9a000-4109b000 Deferred libcrypto.so.0 ELF 0x414a0000-414e0000 Deferred riched20<elf> \-PE 0x414b0000-414e0000 \ riched20 ELF 0x7bf00000-7bf07000 Deferred <wine-loader> Threads: process tid prio (all id:s are in hex) 00000008 (D) C:\Program Files\WinRAR\WinRAR.exe 00000009 0 <== WineDbg terminated on pid 0x8

2 4

Re: setupapi: implement SetupGetInfFileListW and SetupGetInfInformationW
by Robert Shearman 17 Nov '05

17 Nov '05

Steven Edwards wrote: >Documented here: > >http://msdn.microsoft.com/library/default.asp?url=/library/en-us/setupapi/s… >http://msdn.microsoft.com/library/default.asp?url=/library/en-us/setupapi/s… > >Changelog: >Hervé Poussineau (hpoussin(a)reactos.com) >Implement SetupGetInfFileListW and SetupGetInfInformationW >Inf file parser now accept UNICODE files with FF FE header > > >------------------------------------------------------------------------ > >Index: dlls/setupapi/parser.c >=================================================================== >RCS file: /home/wine/wine/dlls/setupapi/parser.c,v >retrieving revision 1.20 >diff -u -r1.20 parser.c >--- dlls/setupapi/parser.c 12 Sep 2005 22:07:53 -0000 1.20 >+++ dlls/setupapi/parser.c 24 Sep 2005 06:52:23 -0000 > > ... >@@ -951,12 +956,20 @@ > WCHAR *new_buff = HeapAlloc( GetProcessHeap(), 0, size * sizeof(WCHAR) ); > if (new_buff) > { >- DWORD len = MultiByteToWideChar( CP_ACP, 0, buffer, size, new_buff, size ); >+ DWORD len = MultiByteToWideChar( CP_ACP, 0, buffer, size, new_buff, >+ size * sizeof(WCHAR) ); > err = parse_buffer( file, new_buff, new_buff + len, error_line ); > HeapFree( GetProcessHeap(), 0, new_buff ); > } > } >- else err = parse_buffer( file, buffer, (WCHAR *)((char *)buffer + size), error_line ); >+ else >+ { >+ WCHAR *new_buff = (WCHAR *)buffer; >+ /* Some UNICODE files may start with the UNICODE marker */ >+ if (*new_buff == 0xfeff) >+ new_buff++; >+ err = parse_buffer( file, new_buff, (WCHAR *)((char *)new_buff + size), error_line ); >+ } > > Any time a Zero-Width Non-breaking Space is specifically skipped like this it is a bug. You should *never* have to do this if you use the right functions (isspaceW, etc). Is there some other bug lurking that made this change necessary? -- Rob Shearman

2 4

Measuring Wine's API completeness
by Michael Jung 16 Nov '05

16 Nov '05

Hello everybody, talking to David Gümbel today the idea came up that it might be worth it to introduce an additional section in the comments that document the exported APIs. Something like 'IMPLEMENTATION STATUS', which would document the author's opinion on how complete the implementation of a given API is. We could introduce a classification scheme similar to: STUBBED: Well, stubbed. SKETCHY: Implemented just enough to make a specific application or a small set of applications happy. SUBSTANTIAL: Implemented a substantial part of the API (Perhaps as much as is documented on MSDN). COMPLETE: The author of this API considers the implementation complete. REVIEWED: The code was reviewed for completeness and correctness. It would be cool for various reasons, if we could do this in a machine readable way: 1. We could generate the 'Wine DLLs Status' page automatically with every release and we would have a historical record in cvs, which gives another view on the progress we make. 2. We could establish guidelines like "A patch, which touches an API marked REVIEWED can only go into cvs, if reviewed by n people other than the author". 3. Tools like ITOMIG's ganymede, which try to give an estimate on how well an application can be expected to work on wine by doing a static analysis to figure out the used APIs, could apply this information. Since COM classes, which account for a substantial part of win32, are not directly exposed via the APIs, we probably would have to think about a similar machine parsable documentation scheme here. What do people think about this? Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

8 13

Re: [MSVCRT]: undname tests.
by Uwe Bonnes 16 Nov '05

16 Nov '05

>>>>> "Eric" == Eric Pouech <eric.pouech(a)wanadoo.fr> writes: Eric> ChangeLog: As some people tend to toy with __UnDName, this patch Eric> provides a sample of the joy of MSC symbol mangling Eric, the biggest problem I encountered with undname was that native msvcrt always returns something, at least the original input if nothing is understood. Wine undname however returned nothing when something was unknown to out implementation, resulting in a crash when the application dereferenced the NULL buffer returned... Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

Compilerflags for Bogus code
by Detlef Riekenberg 16 Nov '05

16 Nov '05

Hi GCC did not warn us on this bogus code (dlls/user/tests/monitor.c): ret = EnumDisplayDevicesA(NULL, num, &dd, 0), "EnumDisplayDevices fails \n"; This Line is in CVS since 28 Sep.2005 Should we have stronger Compiler-Flags? Patch already send. http://www.winehq.org/pipermail/wine-patches/2005-November/022161.html -- By By ... ... Detlef

2 1

AlphaBlend crashing msn messenger
by Maarten Lankhorst 16 Nov '05

16 Nov '05

Fix AlphaBlend() to extract the right part of the source DIB. (http://www.winehq.com/hypermail/wine-patches/2005/08/0331.html) After some regression testing, It looks like this patch is the one that breaks signing into msn messenger. I m not sure why, so Im interested in finding out why it happens. I tried it with MSN Messenger 6.2.0208, everything works ok until I try to sign in, then it crashes with an error message like this: trace:bitblt:GdiAlphaBlend 0x3b80 0,0 485x422 -> 0xa480 0,0 83x62 op=00 flags=00 srcconstalpha=ff alphafmt=01 err:syslevel:_CheckNotSysLevel Holding lock 0x404f0340 level 3 wine: Unhandled exception (thread 0009), starting debugger... Without your patch, MSN signs in properly.

2 1

About stderr for usage messages
by Vitaly Lipatov 16 Nov '05

16 Nov '05

We are use stderr for print usage or info message in wine programs such as eject winedump winebuild wine main (dlls/kernel/process.c) It is broken behavior: info messages usually expected from stdout stream. Will I do patch agaist it? -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

2 3