November 2005 - Wine-devel - list.winehq.org

Re: kernel/comm.c: Don't leak file handles
by Paul Vriens 03 Nov '05

03 Nov '05

On Thu, 2005-11-03 at 10:55 +0100, Uwe Bonnes wrote: > Changelog: > dlls/kernel/comm.c: COMM_WaitCommEvent > Release the file handle when creating thread > > Spotted by Cihan Altinay, also fixes then problem with pending characters in > our comm-test when TXD-RXD loopback is enabled. Hi Uwe, you forgot the patch :-). Cheers, Paul.

1 0

dlls/kernel/comm.c: not releasing file descriptors?
by Cihan Altinay 03 Nov '05

03 Nov '05

Hi, I am trying to get G-Ware[1] to run under wine which provides a user interface to set up Echo Canceller Units made by ClearOne. The unit is connected to the serial port (com1 = ttyS0). The only way I can start the program at all is by configuring wine to act as Windows 95/98 and using native COM dll's. Furthermore, 'GWare.exe' starts 'PSRServe.exe' under native Windows but not under wine so I do the following in a bash file: wine C:\\Program\ Files\\G-Ware\\PSRServe.exe & wine C:\\Program\ Files\\G-Ware\\GWare.exe When I connect to the device I get endless fixme:comm:COMM_WaitCommEvent EV_RXFLAG not handled messages before communication breaks with this: wine client error:3bc: pipe: Too many open files After investigating I found out that indeed the number of open pipes to ttyS0 increases statically so I tried to find the reason and suspect the following (using the CVS checkout from 20051102): In the function COMM_WaitCommEvent in /dlls/kernel/comm.c line 2106 a thread is created for WaitCommEventService. However, in this branch of the if-statement fd is not released (using release_comm_fd). Releasing fd seems to work and the number of open pipes don't get past 200-300. I am new to wine development and this is just a guess and I might be totally wrong. Unfortunately this does not fix the communication with the device (It reports timeouts and errors retrieving values etc). I guess this has to do with the first fixme messages I mentioned. Can anybody tell me what EV_RXFLAG is used for? Using WINEDEBUG=+tid,+comm I compared the output to what Sysinternals PortMon[2] gives me on native Windows and it really looks promising. Is there a way to display the actual data that was sent/received through the serial port? I tried WINEDEBUG=+io which does not work. The program uses threads so there might as well be other issues. Cheers, Cihan --- [1] http://www.clearone.com/docs/downloads/G-Ware5.0.6.zip (20MB) [2] http://www.sysinternals.com/Utilities/Portmon.html

2 1

Re:DirectSound, new patch available for testing
by Robbert Xerox 03 Nov '05

03 Nov '05

Hi Davin,Two questions about this: the patch fails here at hunk 5 with current cvs. 2nd question: is creating the key \HKEY_CURRENT_USER\Software\Wine\Alsa Driver\UseDirectHW necessary? If so, i'll have to do that manually (in regedit) i guess, as winecfg does not create such a key anywhere. And is this some undocumented key that also has some effects without your patch? thanks in advance for your answer. ___________________________________________________________ Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail http://uk.messenger.yahoo.com

4 3

Re: SHELL32: some fixes for shelllink's IContextMenu::InvokeCommand method
by Martin Fuchs 03 Nov '05

03 Nov '05

Hello Mike, On 03.11.2005 07:24:42 Mike McCormack wrote: > ChangeLog: > Pass the correct verb. > Add a space between extra parameters. > Wait for ShellExecute to complete. [...] > if( ShellExecuteExW( &sei ) ) >+ { >+ if (sei.hProcess) >+ WaitForSingleObject(sei.hProcess, 10000); > r = S_OK; >+ } > else > r = E_FAIL; You should add an "CloseHandle(sei.hProcess);" after the wait call to avoid the handle leak. Regards, Martin

1 0

RE: alt-tab task switching form a wine app
by Anthony R. Tuel 03 Nov '05

03 Nov '05

-----Original Message----- From: Robert Shearman [mailto:rob(a)codeweavers.com] Sent: Wed 11/2/2005 12:43 PM To: Anthony R. Tuel Cc: wine-devel(a)winehq.org Subject: Re: alt-tab task switching form a wine app Anthony R. Tuel wrote: > It seems when I have an app up running under wine (lotus notes 6.5.4 > in my case) and I switch to another app (using a gaim messaging window > in my case) using alt tab, when I come back to my notes window its as > if I'm still holding the alt key. Not sure if this happens in other > apps, but its really noticible in notes since it uses the alt key for > all sorts of keyboard shortcuts. So if i'm writing a new email in > notes, someone sends me an IM, I alt-tab switch over to gaim, when I > switch back to notes and want to hit enter for a new line, it brings > up the font properties windows (alt+enter being the font properties > shortcut). This seems to happen with both 20050930 and the .9 > releases at least. Has anyone else seen this issue? > Yes. It is a known bug when using the Metacity WM. We have a hack in CrossOver that works around it based on a patch somebody sent to wine-patches within the last year. -- Rob Shearman ------------------------------------------------------------------------------ Is there a bug open on this? I would hvae thought that a patch put forth like a year ago would have made it into the official wine builds by now.

1 0

Re: [LOSTWAGES] fix .htaccess
by Jeremy Newman 03 Nov '05

03 Nov '05

I've run into this before. Problem is that if I use a local URL it breaks the website images for the 404 page. This is due to the local path not matching what the URL reads. I get around it by using the redirect. I did fix the code in the website so when the 404 page is loaded, it correctly sends the 404 header. Let me know if that works better for you. On Wed, 2005-11-02 at 11:26 +0100, Jonathan Ernst wrote: > http://httpd.apache.org/docs/1.3/mod/core.html#errordocument > > Note that when you specify an ErrorDocument that points to a remote URL > (ie. anything with a method such as "http" in front of it), Apache *will > send a redirect to the client to tell it where to find the document, > even if the document ends up being on the same server*. This has several > implications, the most important being *that the client will not receive > the original error status code*, but instead will receive a redirect > status code. This in turn can confuse web robots and other clients > which try to determine if a URL is valid using the status code. > > I was using linkchecker (http://linkchecker.sourceforge.net/) to check > for deadlinks and wondered why some people could still find some > deadlinks on winehq. That's because our 404 handler doesn't send an > Error 404 message to the user agent. > > This change will make apache send a 404 instead of a redirect and will > let the original address in the browser's address bar instead of > changing it to the /site/404 file. It will also make it easier to check > for deadlinks as the error code will be correct now.

2 1

[d3d8] D3DCOLOR fixup + bug fix
by Raphael 02 Nov '05

02 Nov '05

Hi, Same as the previous wined3d patch + minor fix on UBYTE4 handling Regards, Raphael

1 0

Re: DirectSound problems - dlls/dsound/mixer.c
by Jesse Allen 02 Nov '05

02 Nov '05

Hi Davin, Juergen and I have tested Diablo 2 with your patch and found it has improved the sound. But there is still more to do: ---------- Forwarded message ---------- From: Juergen Wieczorek <juergenw_(a)web.de> Date: Oct 31, 2005 3:58 PM Subject: Re: Fwd: DirectSound problems - dlls/dsound/mixer.c To: Jesse Allen <the3dfxdude(a)gmail.com> Sorry, but things are a bit weird with the supplied wine-0.9 for FC3. In order to counter-proof, I did a rpmbuild -bb ... with the *unpatched* sources from wine-0.9-1fc3-winehq and also ended up with dead sound, until I set winecfg to "OSS"! Then sound worked with patched or unpatched mixer.c source. Strangely, when I installed the provided binary FC3.rpm, winecfg works only with "ALSA" sound setting. Obviously there is something wrong with the build specs of this package, I have to check later. As for the patched mixer.c source: Sound is now much more fluid and not crackling perpetually, but some long drawn sounds like power-ups have a jarring note to them. Also walking around on the map with the mouse button pressed down produces a jarring noise when in the vicinity of moving flames like those at waypoints or near any sort of open fire. Ths stops when you're at some distance from the flames. Here is my resp. console output for reference: err:dsound:DSOUND_PhaseCancel length not a multiple of block size, len = 2454, block size = 4 err:dsound:DSOUND_PhaseCancel length not a multiple of block size, len = 2482, block size = 4 err:dsound:DSOUND_PhaseCancel length not a multiple of block size, len = 2498, block size = 4 err:dsound:DSOUND_PhaseCancel length not a multiple of block size, len = 2550, block size = 4 err:dsound:DSOUND_PhaseCancel length not a multiple of block size, len = 3966, block size = 4 err:dsound:DSOUND_PhaseCancel length not a multiple of block size, len = 3026, block size = 4 fixme:wave:DSD_CreateSecondaryBuffer (0x7fe72db8,0x7fa6842c,e0,0,0x70ff007c,0x70ee3bec,0x70ff00 58): stub fixme:wave:DSD_CreateSecondaryBuffer (0x7fe72db8,0x7fa6842c,e0,0,0x70ed007c,0x721000f4,0x70ed00 58): stub fixme:wave:DSD_CreateSecondaryBuffer (0x7fe72db8,0x7fa6842c,e0,0,0x70ed01b4,0x70ee508c,0x70ed01 90): stub fixme:wave:DSD_CreateSecondaryBuffer (0x7fe72db8,0x7fa6842c,e0,0,0x70ed02ec,0x70ed03dc,0x70ed02 c8): stub fixme:wave:DSD_CreateSecondaryBuffer (0x7fe72db8,0x7fa6842c,e0,0,0x70ed047c,0x70ed058c,0x70ed04 58): stub fixme:wave:DSD_CreateSecondaryBuffer (0x7fe72db8,0x7fa6842c,e0,0,0x70ed062c,0x70ed073c,0x70ed06 08): stub fixme:wave:DSD_CreateSecondaryBuffer (0x7fe72db8,0x7fa6842c,e0,0,0x70ed07dc,0x70ed08ec,0x70ed07 b8): stub fixme:wave:DSD_CreateSecondaryBuffer (0x7fe72db8,0x7fa6842c,e0,0,0x70ed098c,0x70ed0a9c,0x70ed09 68): stub All in all, much better now, but still a way from being nice. -- Juergen Wieczorek Hamburg / Germany

3 5

Re: [d3d8] FillVertexShaderInputARBHW wrong color order for D3DCOLOR?
by Raphael 02 Nov '05

02 Nov '05

On Wednesday 02 November 2005 11:46, Christoph Frick wrote: > On Wed, Nov 02, 2005 at 11:39:17AM +0100, fenix(a)club-internet.fr wrote: > > You are right, it's a known problem. > > See DirectDraw7 to Wined3d recent thread, it's related about > > drawPrimitiveStriddedSlow. We have 3 solutions: > > - when app use VertexBuffer: precompilation of VB to be OpenGL compliant > > on unlock - using vertex/pixel shaders to do the needed tricks > > - for each frame transform all colors in software before rendering > > (yuckk) > > would you enlighten my, why i was not able to write my own data in the > glVertex... method? because this is something precompiled and "source" > is already somewhere in the graphics hardware and i can not write data > from the heap into it? because, as you said, it doesn't have the good format. D3D format isn't supported by OpenGL (it's ARGB and we need it to be in RGBA, see D3DCOLOR_* macros on d3d8_private.h) Ex of msdn: http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/dx81_c/dir… http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/dx81_c/dir… Regards, Raphael

1 0

alt-tab task switching form a wine app
by Anthony R. Tuel 02 Nov '05

02 Nov '05

It seems when I have an app up running under wine (lotus notes 6.5.4 in my case) and I switch to another app (using a gaim messaging window in my case) using alt tab, when I come back to my notes window its as if I'm still holding the alt key. Not sure if this happens in other apps, but its really noticible in notes since it uses the alt key for all sorts of keyboard shortcuts. So if i'm writing a new email in notes, someone sends me an IM, I alt-tab switch over to gaim, when I switch back to notes and want to hit enter for a new line, it brings up the font properties windows (alt+enter being the font properties shortcut). This seems to happen with both 20050930 and the .9 releases at least. Has anyone else seen this issue?

4 3