December 2005 - Wine-devel - list.winehq.org

Re: advpack: Handle dwFlags for DelNode with tests
by James Hawkins 03 Dec '05

03 Dec '05

On 12/1/05, James Hawkins <truiken(a)gmail.com> wrote: > Hi, > > I changed the invalid CharPrev != "\\" comparison to string[len] != '\\'. > > Changelog > * Use DelNode itself for the directory recursion. > * Handle the dwFlags parameter. > * Factor out file creation and deletion. > * Add test cases for DelNode and make them pass. > Anything wrong with this? -- James Hawkins

1 0

Re: [MSI] DllCanUnloadNow
by James Hawkins 03 Dec '05

03 Dec '05

On 12/3/05, Christian Gmeiner <christian.gmeiner(a)students.fh-vorarlberg.ac.at> wrote: > It also fixes some spacing stuff. Whitespace changes need to go in a separate patch, if at all. -- James Hawkins

1 0

Re: [OLE #155] Fix Invoking dispinterface Functions
by Robert Shearman 02 Dec '05

02 Dec '05

Robert Shearman wrote: > ChangeLog: > Fix invoking dispinterface functions by using the internal > representation of the function, not the one returned to applications. I've just noticed that this function now has some duplicated code, so don't use this patch. I'll send a replacement one with a correction. -- Rob Shearman

1 0

wglGetPixelFormatAttribivARB unexpected RenderType(100)
by Toan T Nguyen 02 Dec '05

02 Dec '05

Hi, I compile and run Quake2Evolved in linux using winelib. Although every seems fine, there's this error printed out when Q2E scans for the best pixel format: err:opengl:wglGetPixelFormatAttribivARB unexpected RenderType(100) I look up my /usr/include/GL/glxATI.h and found these lines: #ifndef GLX_ATI_pixel_format_float #define GLX_ATI_pixel_format_float 1 #define GLX_RGBA_FLOAT_ATI_BIT 0x00000100 #endif // GLX_ATI_pixel_format_float Bests, Toan

1 0

DBGRID32.OCX fix - RFC
by Alex Villacís Lasso 02 Dec '05

02 Dec '05

I would like to know if the attached patch (which prevents DBGRID32.OCX from crashing, as well as adding additional debugging information when a reference is not found) would step on anybody's toes (especially Robert Shearman, since he is sending several oleaut32 patches himself). As of 2005-12-01 CVS, any VisualBasic application that tries to use DBGRID32.OCX will systematically crash unless the patch is applied. However, since Robert Shearman is sending oleaut32 fixes, I think he might implement some functionality that will, as a side effect, fix the DBGRID32.OCX bug. Alex Villacís Lasso

2 3

Steam regression of the day
by Ivan Gyurdiev 02 Dec '05

02 Dec '05

The networking bug has been fixed, but another problem is that I can't see any of the text. Appdb mentions something about installing tahoma.ttf from a Windows installation, which makes no sense to me, since I could see Steam displayed fine earlier, making this a regression. Any suggestions as to what might have caused this (or maybe it was a Steam upgrade?). Also - Steam has a keyboard focus bug, with a documented patch here (from Stefan Dosinger): http://www.winehq.org/hypermail/wine-patches/2005/03/0504.html Previously he reported that the patch might break other apps, but if it fixes Steam, then it must be on the right track - surely it can be changed so it's acceptable for Wine CVS. I don't understand why a known bug with a known patch remains unfixed.

2 4

Re: msvidc32: Remove unused DllMain() function
by Dmitry Timoshkov 02 Dec '05

02 Dec '05

"Francois Gouget" <fgouget(a)free.fr> wrote: > msvideo1.c defines a DllMain() function but: > * it is not exported in the spec file > * it is not referenced in any way anywhere else > * the native dll does not export a DllMain function either DllMain does not need to be exported to define an entry point of the DLL. Moreover, DllMain of msvidc32 initializes MSVIDC32_hModule which is used later on. -- Dmitry.

1 0

Unnormal slowness in Heroes 4 (X11DRV_BitBlt?)
by Marinescu-Ghetau Iulian 02 Dec '05

02 Dec '05

See http://bugs.winehq.org/show_bug.cgi?id=3902 Hey guys, a bit of help here! I did the following changes: -added member to X_PHYSBITMAP: XRectangle modified_rect; -added 2 functions: /*********************************************************************** * X11DRV_SetBoundRect */ void X11DRV_SetBoundRect(X_PHYSBITMAP *physBitmap, INT x, INT y, INT width, INT height) { XRectangle *t; INT xMin,yMin,xMax,yMax; if (!physBitmap) return; t = &(physBitmap->modified_rect); if ( t->width && t->height && /*already a valid rect inside*/ width && height ) /*not trying to invalidate rect*/ { //calculate the union of the two rectangles xMin = ((t->x < x)?t->x:x); yMin = ((t->y < y)?t->y:y); xMax = ((t->x + t->width > x + width)?(t->x + t->width):(x + width)); yMax = ((t->y + t->height > y + height)?(t->y + t->height):(y + height)); t->x = xMin; t->y = yMin; t->width = xMax - xMin; t->height = yMax - yMin; } else { t->x = x; t->y = y; t->width = width; t->height = height; } TRACE("(%p,%d,%d,%d,%d)\n", physBitmap->hbitmap, t->x, t->y, t->width, t->height); } /*********************************************************************** * X11DRV_GetBoundRect */ UINT X11DRV_GetBoundRect(X_PHYSBITMAP *physBitmap, INT *x, INT *y, INT *width, INT *height) { DIBSECTION dib; XRectangle *t; if (!physBitmap || GetObjectW( physBitmap->hbitmap, sizeof(dib), &dib ) != sizeof(dib)) { ERR("called for non-DIBSection!?\n"); return 1; } t = &(physBitmap->modified_rect); /* we should check for oversize values */ if ( (t->width > 0) && (t->height > 0) && (t->x < dib.dsBm.bmWidth) && (t->y < dib.dsBm.bmHeight) ) { *x = t->x; *y = t->y; if (t->x + t->width > dib.dsBm.bmWidth) *width = dib.dsBm.bmWidth - t->x; else *width = t->width; if (t->y + t->height > dib.dsBm.bmHeight) *height = dib.dsBm.bmHeight - t->y; else *height = t->height; } else { *x = 0; *y = 0; *width = dib.dsBm.bmWidth; *height = dib.dsBm.bmHeight; } TRACE("(%p,%d,%d,%d,%d)\n", physBitmap->hbitmap, *x, *y, *width, *height); return 0; } -changed X11DRV_DIB_DoUpdateDIBSection like this: static void X11DRV_DIB_DoUpdateDIBSection(X_PHYSBITMAP *physBitmap, BOOL toDIB) { INT x,y,width,height; if ( X11DRV_GetBoundRect(physBitmap,&x,&y,&width,&height) ) return; /*invalidate bound rect*/ X11DRV_SetBoundRect(physBitmap,0,0,0,0); X11DRV_DIB_DoCopyDIBSection(physBitmap, toDIB, physBitmap->colorMap, physBitmap->nColorMap, physBitmap->pixmap, x, y, x, y, width, height); } - and finally, a GDI function calls it like this (for example bitblt): X11DRV_SetBoundRect(physDevDst->bitmap,xDst,yDst,width,height); X11DRV_CoerceDIBSection( physDevDst, DIB_Status_GdiMod, FALSE ); if (physDevDst != physDevSrc) { X11DRV_SetBoundRect(physDevSrc->bitmap,xSrc,ySrc,width,height); X11DRV_CoerceDIBSection( physDevSrc, DIB_Status_GdiMod, FALSE ); } result = BITBLT_InternalStretchBlt( physDevDst, xDst, yDst, width, height, physDevSrc, xSrc, ySrc, width, height, rop ); END: if (physDevDst != physDevSrc) X11DRV_UnlockDIBSection( physDevSrc, FALSE ); X11DRV_UnlockDIBSection( physDevDst, TRUE ); What am i doing wrong, i mean is my logic correct ?

1 0

Re: [msxml] libuuid
by Huw D M Davies 02 Dec '05

02 Dec '05

On Thu, Dec 01, 2005 at 10:02:25PM +0100, Raphael wrote: > Hi, > > Changelog: > - add needed uuid generation I don't think libuuid should contain the msxml2 uuids; at least the version I have doesn't. Huw.

2 2

D3D7 & WineD3D success
by Stefan Dösinger 02 Dec '05

02 Dec '05

Hello! Today I have finally managed to get some useable graphics with D3D7 and WineD3D. The Tomb Raider 3 Demo is running. :) The only visible problem I can see are textures: They only have a solid color, all other things seem to work. I've uploaded a screenshot to http://doesi.gmxhome.de/tomb3-2.png , if anyone wants to have a look. I'll try to fix the textures and get some more games running, then I'll upload a beta patch somewhere for others to try. (Well, if anyone is interested, I can mail the current code too). Greetings, Stefan

6 7