February 2005 - Wine-devel - list.winehq.org

Subject: Re: Faster TlsAlloc() or zero_bit_scan
by Dietrich Teickner 11 Feb '05

11 Feb '05

Not all You can every write in c/c++. Sometime You need a call for a library function. I think, that can be one and I think, not only TlsAlloc use a zero_bit_scan. Dietrich On Thu, 10 Feb 2005 18:59:21 +0100, Dietrich Teickner wrote: >> I have a suggestion for a faster implementation of the zero_bit_scan in >> RtlFindClearBits [NTDLL.@] >> (rlbitmap.c) for e.g. TlsAlloc() >> The main is the usage of the instruction 'bsf eax, eax' >> >> This I have implemented in the new experimental odinxp-tree for finding >> the first zero_bit in the first 'bytecount' bytes of the bitmap addr. Does this actually make a noticeable difference? Rewriting stuff in assembly for theoretical performance improvements isn't so great, as far fewer people can read/write assembly than C. thanks -mike

1 0

Faster TlsAlloc() or zero_bit_scan
by Dietrich Teickner 11 Feb '05

11 Feb '05

Hi, I have a suggestion for a faster implementation of the zero_bit_scan in RtlFindClearBits [NTDLL.@] (rlbitmap.c) for e.g. TlsAlloc() The main is the usage of the instruction 'bsf eax, eax' This I have implemented in the new experimental odinxp-tree for finding the first zero_bit in the first 'bytecount' bytes of the bitmap addr. Dietrich public _search_zero_bit ;int CDECL search_zero_bit(int bytecount, void *addr); _search_zero_bit proc near push esi push edx mov esi, [esp+16] mov edx, [esp+12] inc edx loop: add esi, 4 mov eax, -1 dec edx ;not found jz short found xor eax, dword ptr [esi - 4] jz loop bsf eax, eax jz short loop sub esi, 4 sub esi, [esp+16] shl esi, 5-2 add eax, esi found: pop edx pop esi ret _search_zero_bit endp

3 2

Rewriting the User Guide Question: FreeBSD
by Scott Ritchie 11 Feb '05

11 Feb '05

Ok so I'm going through the User Guide's getting/installing/compiling chapters. Essentially my idea is to cannibalize most of it, since the information is outdated, wrong, or at best duplicitous. However, while combing through the User Guide, I realized that there's some stuff I don't know much about - namely, FreeBSD. So, if you're a Wine FreeBSD guru, take a moment to peek at the existing "Getting Wine" chapter on the web site, and tell me if any of that information is at all relevant. My suspicion is that FreeBSD has advanced quite a bit since the guide was written, and that all that information is rather useless. My goal is to eliminate most of the distro-specific stuff anyway, since there are better places for it. Thanks, Scott Ritchie Chief Executive Officer of further Wine documentation

1 0

mmtimer resolution question
by Robert Reif 11 Feb '05

11 Feb '05

I'm trying to track down a problem with the direct sound regression tests when run in emulation mode using the wave api. I'm getting a lot of FIXMEs and poor quality playback. The dsound mixer callback routine expects to be called every 10 ms but is being called twice every 20 ms. Setting the timer resolution to 1 ms didn't help. I hacked the mmtimer to run at the requested 10 ms interval and the playback problems disappeared. Since the mmtimer thread uses WaitForSingleObject(sleep_time) for it's timer source, has something changed recently which would explain this behavior?

1 0

Problems with wine-patches
by Paul Vriens 10 Feb '05

10 Feb '05

Hi, I'm not able to send (what I think is normal) email to wine-patches anymore. The Test mail worked. Any ideas? Cheers, Paul.

7 10

Text Alignment, how is it handled ?
by George Ginden 10 Feb '05

10 Feb '05

Hi the following code part is not working in Wine as it work (as supposed) in Windows. HRight = GetDlgItem (hDlg,IDC_RIGHT); Edit_SetText(HRight, "Right"); How is text alignment, in a edit field, handled ? It looks like the Edit_SetText function is mapped to SetWindowText, which calls X11DRV_SetWindowText... But again, text alignment doesn't work. Can I do something ? PS: c source code is attacched Regards. /* ** Ditta..........:TeamSystem spa ** Programmatore..:Stefano Peraldini ** Nome programma.:Test Wine ** Data...........:04/02/2005 ** */ //INCLUDE #include <windows.h> #include <WindowsX.h> #include "resource.h" //VARIABILI GLOBALI HWND hUnaligned, HCenter, HRight; HDC hdc; //PROTOTIPI BOOL CALLBACK DlgProc (HWND, UINT, WPARAM, LPARAM); //MAIN int WINAPI WinMain (HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpszCmdLine, int nCmdShow) { // Visualizzazione e controllo errore visualizzazione dialog if (DialogBox (hInstance, (LPCSTR) IDD_DIALOG1, NULL, DlgProc) == -1) MessageBox (NULL, "Errore visualizzazione dialog!!","Test Wine", MB_ICONQUESTION | MB_OK); return 0; } //DLGPROC della dialog1 BOOL CALLBACK DlgProc (HWND hDlg, UINT message, WPARAM wParam, LPARAM lParam) { //Switch per la gestione dei messaggi provenienti dalla dialog1 switch (message) { //Gestione del VM_CLOSE case WM_CLOSE: return TRUE; break; //Impostazione dialog1 case WM_INITDIALOG: { hUnaligned = GetDlgItem (hDlg,IDC_UNALIGNED); HCenter = GetDlgItem (hDlg,IDC_CENTER); HRight = GetDlgItem (hDlg,IDC_RIGHT); //Edit Box Unaligned Edit_SetText(hUnaligned, "Unaligned"); //Edit Box Center Edit_SetText(HCenter, "Center"); //Edit Box Right Edit_SetText(HRight, "Right"); return TRUE; } //Gestione messaggi dialog1 case WM_COMMAND: switch (LOWORD (wParam)) { case IDOK: EndDialog (hDlg, 0); return TRUE; break; // END WMCOMMAND } return FALSE; } return FALSE; }

4 4

Re: RESEND: dlls/comctl32/treeview.c: remove repainting
by Robert Shearman 10 Feb '05

10 Feb '05

yuxdwa702(a)sneakemail.com wrote: > Changelog: > tinus <yuxdwa702(a)sneakemail.com> > Scroll instead of repainting when expanding/collapsing trees > Don't repaint on hover if 'hot tracking' isn't on > > > Index: dlls/comctl32/treeview.c > =================================================================== > RCS file: /home/wine/wine/dlls/comctl32/treeview.c,v > retrieving revision 1.164 > diff -u -p -r1.164 treeview.c > --- dlls/comctl32/treeview.c 14 Jan 2005 15:13:24 -0000 1.164 > +++ dlls/comctl32/treeview.c 31 Jan 2005 01:51:30 -0000 > @@ -631,7 +631,8 @@ TREEVIEW_SendCustomDrawItemNotify(TREEVI > uItemState |= CDIS_SELECTED; > if (wineItem == infoPtr->selectedItem) > uItemState |= CDIS_FOCUS; > - if (wineItem == infoPtr->hotItem) > + /* I'm not sure of this, needs to be compared to the real thing */ Usually you find this out before submitting a patch. > + if ((infoPtr->dwStyle & TVS_TRACKSELECT) && wineItem == > infoPtr->hotItem) > uItemState |= CDIS_HOT; > @@ -5037,11 +5107,13 @@ TREEVIEW_KeyDown(TREEVIEW_INFO *infoPtr, > static LRESULT > TREEVIEW_MouseLeave (TREEVIEW_INFO * infoPtr) > { > - if (infoPtr->hotItem) > + HTREEITEM orgItem = infoPtr->hotItem; > + infoPtr->hotItem = NULL; > + > + /* remove hot effect from item */ > + if (infoPtr->dwStyle & TVS_TRACKSELECT) > { > - /* remove hot effect from item */ > - InvalidateRect(infoPtr->hwnd, &infoPtr->hotItem->rect, TRUE); > - infoPtr->hotItem = NULL; > + InvalidateRect(infoPtr->hwnd, &orgItem->rect, TRUE); > } > return 0; > } If hot tracking isn't required when TVS_TRACKSELECT isn't set, then don't call TrackMouseEvent, instead of putting these exceptions everywhere. > @@ -5080,11 +5152,11 @@ TREEVIEW_MouseMove (TREEVIEW_INFO * info > if (item != infoPtr->hotItem) > { > /* redraw old hot item */ > - if (infoPtr->hotItem) > + if (infoPtr->hotItem && (infoPtr->dwStyle & TVS_TRACKSELECT) ) > InvalidateRect(infoPtr->hwnd, &infoPtr->hotItem->rect, > TRUE); > infoPtr->hotItem = item; > /* redraw new hot item */ > - if (infoPtr->hotItem) > + if (infoPtr->hotItem && (infoPtr->dwStyle & TVS_TRACKSELECT) ) > InvalidateRect(infoPtr->hwnd, &infoPtr->hotItem->rect, > TRUE); > Same here. Don't change the hot item if the hot item isn't going to be repainted anyway. Rob

1 0

Re: rsaenh: CPGetProvParam's PP_ENUMCONTAINERS
by Alexandre Julliard 09 Feb '05

09 Feb '05

Michael Jung <mjung(a)iss.tu-darmstadt.de> writes: > Changelog: > Implemented CPGetProvParam's PP_ENUMCONTAINERS parameter type > Added corresponding test > Removed some tabs that slipped in with the last patch The test fails for me: rsaenh.c:1383: Test failed: 00000103 rsaenh.c:1391: Test failed: 0, 00000103 -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [Discuss] Recycle Bin problem with Preclick image editing software
by Mike Hearn 09 Feb '05

09 Feb '05

On Wed, 2005-02-09 at 15:34 -0500, Don Feliciano wrote: > SUCCESS! Woo Hoo! You rock... now my wife can't tell me b*tch at me > for ditching Windows. Thanks a ton. Niceness Don. Of course, it'd rock more if this had worked out of the box. I expect we're missing some shell magic for the recycle bin. Wouldn't be hard to investigate but have a million other things to do so I'll CC this to wine-devel. Context is: app has a "send to recycle bin" option to delete photos. Doesn't work. Native shell32/shfolder fixes it. If anybody is up for what is probably an easy task, figure out why and fix it so c:\Recycled is used. For bonus points we should bridge it to KDE/GNOME so if an app recycles something it appears in your actual trash can :) thanks -mike

3 2

Re: Rearrange WINPROC_CallWndProc to give clearer tracing
by Alexandre Julliard 09 Feb '05

09 Feb '05

Mike Hearn <mh(a)codeweavers.com> writes: > Yes, I realised the stack allocation might be a problem but only a while > after I sent the patch. Here's another that uses the heap. I don't think you want that either, it won't really make things less confusing if you are adding extra heap calls. You may want to look into using RelayFromExclude instead. -- Alexandre Julliard julliard(a)winehq.org

2 1