March 2005 - Wine-devel - list.winehq.org

Re: ntdll: Add NtCreateKey tests
by Robert Shearman 03 Mar '05

03 Mar '05

James Hawkins wrote: >On 03 Mar 2005 11:02:24 +0100, Alexandre Julliard <julliard(a)winehq.org> wrote: > > >>James Hawkins <truiken(a)gmail.com> writes: >> >> >> >>>I've been discerning the behavior of RegCreateKey and NtCreateKey when >>>creating a key directly under HKLM or HKU, and this test reveals that >>>NtCreateKey does check for this case and returns a >>>STATUS_INVALID_PARAMETER. >>> >>> >>This is going to break registry initialisation. Do you really have an >>app that depends on that? >> >> >> > >What are the steps I need to take to break registry initialisation? I >did wonder how anything in the real win32 registry could be created >though if you can't create a key directly under HKLM or HKU. If this >really does break initialisation, can we implement a different >create_key that has little restrictions and would only be used >internally, or would this just be scrapped entirely? > > It looks like Windows only uses RegLoadKey to create keys under HKLM and HKU. Maybe we should do the same. Rob

2 4

Re: Wine cabinet.dll FDI Conformance Test Patch
by Dimitrie O. Paun 03 Mar '05

03 Mar '05

On Wed, Mar 02, 2005 at 03:41:21PM -0800, Rizwan Kassim wrote: Good stuff guys! Here are a few comments: +#ifndef STANDALONE +#include <wine/test.h> +#define ok2 ok +#else +/* To build outside Wine tree, compile with cl -DSTANDALONE -D_X86_ tvfs.c cabinet_fdi.c FDI.lib + These are only called if standalone are used, defining ok and START_TEST, which would normally be declared in winetree */ +#include <assert.h> +#include <stdio.h> +#define START_TEST(name) main(int argc, char **argv) +#define ok(condition, msg) \ + do { if(!(condition)) { \ + fprintf(stderr,"failed at %d, msg:" msg "\n",__LINE__); \ + exit(1); \ + } } while(0) +#define ok2(condition, msg, arg) \ + do { if(!(condition)) { \ + fprintf(stderr,"failed at %d, msg:" msg "\n",__LINE__, arg); \ + exit(1); \ + } } while(0) +#define todo_wine Please get rid of this. It is useless in the Wine tree. If you need it, just put it in a private header file, and include it there. +#ifndef DEBUG_ALLOC +FNALLOC(final_alloc) { + return malloc(cb); +} +FNFREE(final_free) { + free(pv); + return; +} +#else +FNALLOC(final_alloc) { + trace(" FNALLOC just called with %d\n",cb); + return malloc(cb); +} +FNFREE(final_free) { + trace(" FNFREE just called with %d\n",pv); + free(pv); + return; +} +#endif No need for this either. It's a test after all, there's no big deal if you have a memory leak... :) +#ifdef VERBOSE + trace(" FNFDINOTIFY real just called with %d, %d \n",fdint,pfdin); +#endif Don't do it this way. Define trace such that you can use it unconditionally. In general, try to avoid using the preprocessor in the code. + trace(" Cabinet Data : cbC %d cF %d cFi %d si %d iC %d fr %d hp %d hn %d\n", + cabinfo.cbCabinet, + cabinfo.cFolders , + cabinfo.cFiles , + cabinfo.setID, + cabinfo.iCabinet, + cabinfo.fReserve , + cabinfo.hasprev , + cabinfo.hasnext ); These should fit on 2-3 lines, no? + ok2 ( cabinfo.cbCabinet == TcbCabinet, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.cFolders == TcFolders, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.cFiles == TcFiles, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.setID == TsetID, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.iCabinet == TiCabinet, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.fReserve == TfReserve, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.hasprev == Thasprev, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.hasnext == Thasnext, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); Use ok() instead of ok2(). Also, it's probably better if the message contains the values of the variables that don't match, so we know why it failed. +#ifdef TVFS_DEBUG + trace("tvfs_create called with %s, %d, %d\n", fname, buf, len); +#endif Similar to the one above, do the test inside the body of trace(), not on every use. + switch(whither) { + case SEEK_SET: { + handles[h]->pos = whence; + break; + } + case SEEK_CUR: { + handles[h]->pos += whence; + break; + } This one needs a bit of indentation, no? +int tvfs_close(int h){ + int inode = handles[h]->inode; +#ifdef TVFS_DEBUG + trace("tvfs_close called with %d\n", h); +#endif + if (!files[inode]){ + return -1; + } + free(handles[h]); + /* Currently does NOT enabled open to reuse this handle */ + return 0; + } The formatting on this is funny. It needs indenting, spaces before '{', and the opening braket for the function on a new line. +main(){ Ditto. -- Dimi.

2 1

Re: MSI trouble with ALLUSERPROFILE
by Juan Lang 03 Mar '05

03 Mar '05

> I get err with %ALLUSERPROFILE during install program: <snip> > Where I will set this env variable? (I know I can do it in shell, but > what is the right way?) Hm.. I never did get this quite right. For consistency, it should be in wine.inf. That's where USERPROFILE is: HKLM,System\CurrentControlSet\Control\Session Manager\Environment,"USERPROFILE",,"%53%" But I don't think it can go here, because setupapi (which is what interprets those funny "%53" type strings) doesn't have a magic constant for this, and there isn't a CSIDL value for it. So maybe shell32 should set it in SHELL_RegisterShellFolders? --Juan __________________________________ Celebrate Yahoo!'s 10th Birthday! Yahoo! Netrospective: 100 Moments of the Web http://birthday.yahoo.com/netrospective/

1 0

Use of STLPort with winegcc
by Boaz Harrosh 03 Mar '05

03 Mar '05

Winegcc will prepend any of the command line switches with "-I wine/include/msvcrt" if the "-no-cygwin" flag is specified. This breaks STLPort because STLPort must be first on the search path, before the regular c-runtime of the compiler. This way it can do it's tricks of what to use and what not to use from the standard c-runtime. What is the current way to solve it. I could remove the "-no-cygwin" flag and Manually add the "-I wine/include/msvcrt" and "-D__MSVCRT__". But how do I add the "-dmsvcrt" on the Winebuild command line, as it is all internal to winegcc. What would be the right way to do it? I would submit a patch, but what should I do? Just append the "-I .../msvcrt" instead of prepend, or maybe use "-isystem .../msvcrt". The docs for gcc say that "-isystem" folders will be searched before the default gcc folders but after any -I folders. Free Life Boaz

2 1

Re: MSI: Radio Buttons
by Dmitry Timoshkov 03 Mar '05

03 Mar '05

"Ulrich Czekalla" <ulrich.czekalla(a)utoronto.ca> wrote: > + if (control->hwnd) > + { > + WNDPROC oldproc = (WNDPROC) SetWindowLongW(control->hwnd, GWLP_WNDPROC, > + (LONG)MSIRadioGroup_WndProc); I'd suggest to use SetWindowLongPtrW even it's just a macro in Win32 we still need to write 64-bit clean code. -- Dmitry.

1 0

Speach rec. on Wine
by wino＠piments.com 03 Mar '05

03 Mar '05

Hi, I am trying to get Dragon Naturally Speaking to run under Wine. I have got it installed successfully from CD, now I need to get it running. I have wine-20050111 installed , a 2.6.10 kernel and a current version of IE6 since Dragon apparently needs IE installed . Some advice please. Is there any fundemental problems which make this a no-hoper, has anyone got this working so far? Any a-priori conditions or advice I should know, like what sound model to use on Linux. Where should I search for detailed info on debugging something like this? There seems to be very little detailed help for Wine which I find surprising. Maybe I have just missed it Any other advice that could save me wasting lots of time. TIA .

2 1

Re: Add all MIME types
by Mike Hearn 03 Mar '05

03 Mar '05

On Wed, 02 Mar 2005 12:56:33 +0000, Mike Hearn wrote: > Oh my god, there are a lot of these! Wouldn't it be a better long term > solution to just get the desktop environments sorted out? They should be > sharing the same MIME database now right? So why are they not all > identifying EXEs as the same MIME type? By the way, that wasn't an objection to the patch. I think it should go in. It's trivial enough and doesn't have any bad consequences except slightly less "elegance" but we can fix that one day when all the desktops are fixed :)

1 0

http://ftp.codeweavers.com/pub/crossover/office/source/office-src-4.1.0.tgz
by Grant Williamson 03 Mar '05

03 Mar '05

Hi, I am just wondering how much does the wine source located on http://ftp.codeweavers.com/pub/crossover/office/source/office-src-4.1.0.tgz differ from 20040716. I guess its codeweavers internal patched version, I see changes in there dating to January. Are there any restrictions on using this source?

3 3

Re: imagelist: style fixes
by Alexandre Julliard 03 Mar '05

03 Mar '05

"Dimitrie O. Paun" <dpaun(a)rogers.com> writes: > ChangeLog > Style fixes for consistent formatting. I knew I was going to regret applying Mike's indentation patches... Folks, please let's not start an indentation police, there's no reason to "fix" anything unless a file is really so messed up that it becomes unreadable. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [user/tests/sysparams.c] Added more SetLastError(0)'s
by Dmitry Timoshkov 03 Mar '05

03 Mar '05

"Paul Vriens" <Paul.Vriens(a)xs4all.nl> wrote: > as discussed a few times on wine-devel, there isa need to clear the > last error before calling a SPI_{GET|SET} routine. > > It appears that not every call resets the last error to 0 on succession > and thus errors will propagate and leave us in the dark. You have to set last error to some bogus value (usually 0xdeadbeef) in order to test whether an API really has changed it. -- Dmitry.

3 2