March 2005 - Wine-devel - list.winehq.org

Re: winspool: some unicodification
by Huw D M Davies 29 Mar '05

29 Mar '05

On Tue, Mar 29, 2005 at 12:26:47AM -0500, Dimitrie O. Paun wrote: > ChangeLog > Unicodify WINSPOOL_OpenDriverReg(). > > > Index: dlls/winspool/info.c > =================================================================== > RCS file: /var/cvs/wine/dlls/winspool/info.c,v > retrieving revision 1.101 > diff -u -r1.101 info.c > --- dlls/winspool/info.c 21 Feb 2005 18:33:55 -0000 1.101 > +++ dlls/winspool/info.c 29 Mar 2005 05:23:05 -0000 > @@ -70,8 +70,13 @@ > > static const char Printers[] = > "System\\CurrentControlSet\\control\\Print\\Printers\\"; > -static const char Drivers[] = > -"System\\CurrentControlSet\\control\\Print\\Environments\\%s\\Drivers\\"; > + > +static const WCHAR DriversW[] = { 'S','y','s','t','e','m','\\','\\', > + 'C','u', 'r','r','e','n','t','C','o','n','t','r','o','l','S','e','t','\\','\\', > + 'c','o','n','t','r','o','l','\\','\\', > + 'P','r','i','n','t','\\','\\', > + 'E','n','v','i','r','o','n','m','e','n','t','s','\\','\\', > + '%','s','\\','\\','D','r','i','v','e','r','s','\\','\\',0 }; > That's not quite right. I guess you need to tweak your unicodification macro ;-) Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: KERNEL32: implement CallNamedPipe
by Dmitry Timoshkov 29 Mar '05

29 Mar '05

"Mike McCormack" <mike(a)codeweavers.com> wrote: > ChangeLog: > * implement CallNamedPipe > + handle = CreateFileW( lpNamedPipeName, GENERIC_READ|GENERIC_WRITE, > + 0, NULL, OPEN_EXISTING, 0, NULL ); > + if( !handle ) > + return FALSE; CreateFile returns INVALID_HANDLE_VALUE on failure. -- Dmitry.

1 0

Re: Patch
by Dmitry Timoshkov 29 Mar '05

29 Mar '05

"Leonardo Krause" <leonardo.krause(a)serpro.gov.br> wrote: > + if ( ((keysym == 0xFF9F) || (keysym == 0x2C)) && (e->state & NumLockMask)) > + { > + if (keysym == 0xFF9F) > + return nonchar_key_vkey[keysym & 0xFF]; > + if (keysym == 0x2C) > + return keyc2vkey[0x3B]; > + } You need to at least use appropriate symbolic names instead of vague numbers. -- Dmitry.

1 0

Re: version: Use proper type for third parameter of VerQueryValue
by Dmitry Timoshkov 29 Mar '05

29 Mar '05

"James Hawkins" <truiken(a)gmail.com> wrote: > Changelog > * Use proper type for third parameter of VerQueryValue > -DWORD WINAPI VerQueryValueA(LPVOID,LPCSTR,LPVOID*,UINT*); > -DWORD WINAPI VerQueryValueW(LPVOID,LPCWSTR,LPVOID*,UINT*); > +BOOL WINAPI VerQueryValueA(const LPVOID,LPCSTR,UINT*,UINT*); > +BOOL WINAPI VerQueryValueW(const LPVOID,LPCWSTR,UINT*,UINT*); Where did you get it? PSDK agrees with current Wine definition on the 3rd param type. Also the 2nd param should not be 'const'. -- Dmitry.

3 3

AW: Hotel full again?
by Hans-Ulrich Schmid 29 Mar '05

29 Mar '05

Hi, there are only three rooms left in the Telekom Hotel (Mail adress: Rezeption.Tagungshotel-Stuttgart(a)telekom.de ) from April 29 - May 1. There is no way to get room there for April 28. The alternatives are: IB-HOTEL AM WALLGRABEN ib-hotel-stuttgart(a)internationaler-bund.de ++49.711-7876100 http://dsw.nethotels.com/smg/english/Hotels/ib_hotel_am_wallgraben_/default… Hotel Römerhof info(a)hotelroemerhof.de ++49.711-687880 http://www.hotelroemerhof.de/english/index.html See you in Stuttgart Hans-Ulrich Schmid Wirtschaftsförderung Region Stuttgart GmbH Stuttgart Region Economic Development Corporation FIR_st - Forum IT-Region Stuttgart Friedrichstr. 10 70174 Stuttgart www.first.region-stuttgart.de www.opensource.region-stuttgart.de www.competenzatlas.de www.region-stuttgart.de Tel ++49.711.22835 - 27 Tel mobil ++49.172.7310463 Fax ++49.711.22835 - 55 > -----Ursprüngliche Nachricht----- > Von: Andrew Bartlett [mailto:abartlet(a)samba.org] > Gesendet: Freitag, 25. März 2005 22:59 > An: Hans-Ulrich Schmid > Cc: wine-devel(a)winehq.org > Betreff: Hotel full again? > > > I tried to book a double room 28th April -> 1st May (sharing with > tridge), and it seems the hotel is all full again :-( > > There seems to be quite a contingent of Samba folk intending to come > along (from a poll on the samba team list), and given the number of > 'maybe' and 'probably' replies, I suspect I'm not the only > one without a > room... > > Andrew Bartlett > -- > Andrew Bartlett > http://samba.org/~abartlet/ > Authentication Developer, Samba Team http://samba.org > Student Network Administrator, Hawker College http://hawkerc.net >

1 0

Wine on slashdot
by Jonathan Ernst 29 Mar '05

29 Mar '05

http://games.slashdot.org/games/05/03/28/1843246.shtml?tid=203&tid=106 "WineCVS is an extensive script for automated installation of different versions of wine and Cedega. Today it has been updated to support wine installation with latest DX9 features. The latest patch level of the script now includes a profile for installing Wine with Oliver Stiebers Direct3D 9 patchset. A short installation instruction and some more detailed information can be found at linux-gamers.net."

2 1

Japanese 106 keyboard mapping bug + patch
by Aric Cyr 28 Mar '05

28 Mar '05

I was having a mysterious problem with my Japanese 106 keyboard in World of Warcraft. The keyboard worked just fine when logging into the game or typing messages in game, etc. However, using the macro keys for the quickbar (1 2 3 ... 0) each of the keys was off by one. The keys were mapped as: 1 = 1 2 = 1 3 = 2 4 = 3 5 = 4 ... Notice that the 1 and 2 key both mapped to one, and every key after that maps to the previous key. This only occured for the top keyboard row and text input fields all worked correctly (which was the mysterious part). Anyways, I tracked down the problem to the keyboard layout for jp106 in the x11drv/keyboard.c. For Japanese keyboards, the first printable character on the keyboard is '1' (as the shown in the main_key_JA_jp106[MAIN_LEN][4] array). However, the jp106 keyboard is defined to use the regular qwerty scan and vkey maps, which seem to define the first key as OEM, not '1'. I believe this was causing my off-by-one key problem, so created a new jp106 qwerty scan and vkey map to fix the problem. I have tested the patch with World of Warcraft, and indeed my keys are now all mapped correctly. I am not familiar with the keyboard stuff too much, so let me know if there are any problems with the patch, otherwise please commit it. I also created a bug for this, and attached the patch there as well: http://bugs.winehq.org/show_bug.cgi?id=2832 -- Aric Cyr <acyr at alumni dot uwaterloo dot ca> (http://acyr.net) gpg fingerprint: 943A 1549 47AC D766 B7F8 D551 6703 7142 C282 D542

1 0

Re: KERNEL: Implement undocumented SetCPGlobal API call
by James Hawkins 28 Mar '05

28 Mar '05

On Tue, 29 Mar 2005 11:37:43 +1100, Troy Rollo <wine(a)troy.rollo.name> wrote: > SetCPGlobal is the undocumented partner of GetACP - it is used to set the > current ANSI code page. > > ChangeLog: > Implement SetCPGlobal (an undocumented Win32 API) A patch would be good :) -- James Hawkins

1 0

Re: KERNEL: Implement undocumented SetCPGlobal API call
by James Hawkins 28 Mar '05

28 Mar '05

On Tue, 29 Mar 2005 11:37:43 +1100, Troy Rollo <wine(a)troy.rollo.name> wrote: > SetCPGlobal is the undocumented partner of GetACP - it is used to set the > current ANSI code page. > > ChangeLog: > Implement SetCPGlobal (an undocumented Win32 API) A patch would be good :) -- James Hawkins

1 0

advapi: remove signature checking code.
by Michael Jung 28 Mar '05

28 Mar '05

Hi, Microsoft signs it's cryptographic service provider (csp) dlls with a private key. advapi32 will only load csp dlls with a valid signature. We will never be able to implement this, since this would mean having access to Microsoft's private keys. Above this, Microsofts scheme doesn't give real security, since there are instructions on the web to replace advapi32's _NSAKEY with an arbitrary private key (this is if you have write access to advapi32.dll), allowing you to load a csp signed by yourself. I would like to remove the (stubbed) signature checking code from advapi32. This would clean up advapi32 somewhat and remove a FIXME message, which bothers me for some time and which confused wine users in at least two occurences. Comments anyone? Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0