April 2005 - Wine-devel - list.winehq.org

Re: powrprof: Partial implementation of powrprof.dll
by Andreas Mohr 15 Apr '05

15 Apr '05

Hi, On Fri, Apr 15, 2005 at 06:17:23AM -0600, Benjamin Cutler wrote: > Spend most of the night and some of the morning researching powrprof.dll It shows ;-) (where are the attachments?) Thank you for another stone in the wall, Andreas Mohr

1 0

Re: powrprof: Partial implementation of powrprof.dll
by Michael Stefaniuc 15 Apr '05

15 Apr '05

Benjamin Cutler wrote: > Spend most of the night and some of the morning researching powrprof.dll > and came up with the following partial implementation. > > new directory: dlls/powrprof > new files: dlls/powrprof: powrprof.c, Makefile.in, powrprof.spec, > .cvsignore > changed files: configure.ac > > Changelog: > -Added partial implementation of powrprof.dll. You forgot the patch ... bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

safedisk 1 update, get your safedisk 1 games out (Not running just yet, but getting there)
by Ivan Leo Puoti 14 Apr '05

14 Apr '05

OK, here is a little summary on where we are with safedisk, here by safedisk I always mean safedisk 1. Safedisk protected games are packed into an encrypted ICD file, in my case the game executable is called EMPIRES2.ICD. Safedisk is actually made up of a little loader, empires2.exe (But this depends on the name of the game), and a kernel mode driver, Secdrv.sys. A safedisk service is installed, and in windows a kernel mode service is just a driver. The loader starts the secdrv service, so I've hacked advapi32 to call the NT function NtLoadDriver when it detects a kernel mode service. This function, after a couple of checks, passes the call to the ntoskrnl program I've written, Microsoft has ntoskrnl<->ntdll communication done by a fancy exception rising/handling system, I have just gone for a named pipe, as we don't use ntoskrnl as a real kernel (In windows everything you do causes loads of calls to ntoskrnl, in wine ntoskrnl is seldom used at all and only handles very few calls). Ntoskrnl loads the driver, and it successfully initialises. At this point the safedisk loader communicates with its driver using DeviceIoControl, it passes an input buffer, that contains some instructions for the driver, and an output buffer that is meant to receive some well defined values that are meant to tell the user mode loader if everything is OK (For example a debugger isn't loaded). The loader also tries to get device handles for well known debuggers, this isn't an issue for us. DeviceIoControl passes the call to NtDeviceIoControlFile, that passes the call on to ntoskrnl. A windows driver handles user mode IO requests via a function called DeviceDispatchControl, it's address is put in the member of the DEVICE_OBJECT struct that the driver's initialisation function fills for the system (This is the DriverEntry routine). In wine currently a device handle is a pointer to a DEVICE_OBJECT struct, guys in #reactos have confirmed this is how things work in windows, and even if AJ thinks we should have real file handles this approach makes no sense to me whatsoever. DeviceDispatchControl in safedisk 1 check the control code passed to DeviceIoControl (It must always be 0xef002407), it then reads the input buffer, if byte 0xc in the buffer is 0x3c it checks the debug registers, other values trigger other checks. It also checks the length of both input and output buffers. It should then read the debug registers, and this should rise and exception that we will somehow handle. However for some unknown reason this doesn't happen, and the status of the IO operation is STATUS_UNSUCCESSFUL, note that this value is in the IRP sturct under Irp.IoStatus.Status, DispatchDeviceControl always returns 0. At this point I would like to know if other safedisk 1 protected games yield different results. I would love to step trough secdrv.sys with winedbg, but it just hangs or crashes. The code in ntoskrnl prints the interesting buffer values that secdrv.sys checks for, it currently prints trace:ntoskrnl:NtDeviceIoControlFile (0x40340ba8,(nil),(nil),(nil),0x4068d9c8,0xef002407,0x414e1498,0x00000514,0x414e19ac,0x00000610) trace:ntoskrnl:driver_control driver_control is at 0x405cea80 trace:ntoskrnl:driver_control Handling IoContorl, handle is 0x40340ba8, ControlCode is ef002407, OutputBufferLength is 610, InputBufferLength is 514 trace:ntoskrnl:driver_control InputBuffer[0xc] is 3c, InputBuffer[410] is 0 fixme:ntoskrnl:IofCompleteRequest stub! trace:ntoskrnl:driver_control IRP_MJ_DEVICE_CONTROL returned 0, IoStatus it c0000001, Infomation is 0 trace:ntoskrnl:driver_control Irp.UserBuffer[0x410] is 0, Irp.UserBuffer[0x40c] is 0 In case of success Irp.UserBuffer[0x410] should be 0x00000500 and Irp.UserBuffer[0x40c] should be 4. All that is needed to run safedisk up to the point where it can run ATM is at http://spazioinwind.libero.it/nonsolomicrosoft/safedisk.html Please get all your safedisk 1 games and try it out, the more people try it the better.

1 0

Heap problems ?
by Paul Vriens 14 Apr '05

14 Apr '05

Hi, is anybody having heap problems with current CVS? I'm seeing random crashes of an application and it seems to point to heap. How can I best go about testing this? Cheers, Paul.

2 1

Re: Datetime scroll fixes
by Robert Shearman 14 Apr '05

14 Apr '05

Duane Clark wrote: > Changelog: > Hour '0' corresponds to 12AM. > Scroll cleanly. > >------------------------------------------------------------------------ > >Index: dlls/comctl32/datetime.c >=================================================================== >RCS file: /home/wine/wine/dlls/comctl32/datetime.c,v >retrieving revision 1.55 >diff -u -p -r1.55 datetime.c >--- dlls/comctl32/datetime.c 14 Apr 2005 11:31:17 -0000 1.55 >+++ dlls/comctl32/datetime.c 14 Apr 2005 18:20:35 -0000 >@@ -630,8 +642,12 @@ DATETIME_Refresh (DATETIME_INFO *infoPtr > DeleteObject (hbr); > oldTextColor = SetTextColor (hdc, comctl32_color.clrWindow); > } >- else >+ else { >+ HBRUSH hbr = CreateSolidBrush (comctl32_color.clrWindow); >+ FillRect(hdc, field, hbr); >+ DeleteObject (hbr); > oldTextColor = SetTextColor (hdc, comctl32_color.clrWindowText); >+ } > > /* draw the date text using the colour set above */ > DrawTextW (hdc, txt, strlenW(txt), field, DT_RIGHT | DT_VCENTER | DT_SINGLELINE); > > This change is wrong. The reason you get the mess when using anti-aliased fonts is that you don't clear the background in the WM_VSCROLL handler. I fixed this in the patch I sent you. Rob

1 0

Re: Datetime picker updown support
by Rob Shearman 14 Apr '05

14 Apr '05

Duane Clark wrote: > This adds support for the updown control in the datetime picker > (previously it existed but did nothing). ... >@@ -874,13 +1008,23 @@ DATETIME_Size (DATETIME_INFO *infoPtr, W > TRACE("Height=%ld, Width=%ld\n", infoPtr->rcClient.bottom, infoPtr->rcClient.right); > > infoPtr->rcDraw = infoPtr->rcClient; >- >- /* set the size of the button that drops the calendar down */ >- /* FIXME: account for style that allows button on left side */ >- infoPtr->calbutton.top = infoPtr->rcDraw.top; >- infoPtr->calbutton.bottom= infoPtr->rcDraw.bottom; >- infoPtr->calbutton.left = infoPtr->rcDraw.right-15; >- infoPtr->calbutton.right = infoPtr->rcDraw.right; >+ >+ if (infoPtr->dwStyle & DTS_UPDOWN) { >+ /* the updown control seems to ignore SetWindowPos messages */ >+ DestroyWindow(infoPtr->hUpdown); >+ /* hmmm... the updown control seems to ignore the width parameter */ >+ infoPtr->hUpdown = CreateUpDownControl (WS_CHILD | WS_BORDER | WS_VISIBLE, >+ infoPtr->rcClient.right-14, 0, 20, infoPtr->rcClient.bottom, >+ infoPtr->hwndSelf, 1, 0, 0, UD_MAXVAL, UD_MINVAL, 0); >+ } >+ else { >+ /* set the size of the button that drops the calendar down */ >+ /* FIXME: account for style that allows button on left side */ >+ infoPtr->calbutton.top = infoPtr->rcDraw.top; >+ infoPtr->calbutton.bottom= infoPtr->rcDraw.bottom; >+ infoPtr->calbutton.left = infoPtr->rcDraw.right-15; >+ infoPtr->calbutton.right = infoPtr->rcDraw.right; >+ } > > /* set enable/disable button size for show none style being enabled */ > /* FIXME: these dimensions are completely incorrect */ > > This seems really wrong. You are destroying and creating the updown control on every size event?!?! That's really going to slow resizes down. Is there any evidence that the native version does it like this? Rob

3 3

Re: ole32: implement FmtIdToPropStgName & PropStgNameToFmtId
by Juan Lang 14 Apr '05

14 Apr '05

--- Alexandre Julliard <julliard(a)winehq.org> wrote: > I get a test failure here (and the heap messages are worrying too, > though they also occur without the patch): > > err:heap:HEAP_ValidateInUseArena Heap 77c10000: prev arena 77c48518 is > not prev for in-use 77c48570 > err:heap:HEAP_ValidateInUseArena Heap 77c10000: prev arena 77c48518 is > not prev for in-use 77c48570 Some tests snuck in that I didn't mean to, I'll omit those. How do I go about debugging heap errors? --Juan __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

2 1

TrashCan: Day 2
by Steven Edwards 14 Apr '05

14 Apr '05

Hi, There are still a whole set of RecycleBin APIs that need to be implemented to query and empty the trash but this should work for explorer sending files to the trash. Also note someone else will need to implement the RecycleBin ShellFolder. Thanks Steven __________________________________ Do you Yahoo!? Read only the mail you want - Yahoo! Mail SpamGuard. http://promotions.yahoo.com/new_mail

1 0

Re: ole32: implement FmtIdToPropStgName & PropStgNameToFmtId
by Alexandre Julliard 14 Apr '05

14 Apr '05

Juan Lang <juan_lang(a)yahoo.com> writes: > ChangeLog: implement FmtIdToPropStgName & PropStgNameToFmtId, with tests, > plus a few more IPropertyStorage tests I get a test failure here (and the heap messages are worrying too, though they also occur without the patch): err:heap:HEAP_ValidateInUseArena Heap 77c10000: prev arena 77c48518 is not prev for in-use 77c48570 err:heap:HEAP_ValidateInUseArena Heap 77c10000: prev arena 77c48518 is not prev for in-use 77c48570 stg_prop.c:285: Test failed: Didn't get expected type or value for property (got type 0, value 0) -- Alexandre Julliard julliard(a)winehq.org

1 0

Borrowing NTVFS layer from Samba4 for Wine?
by Daniel Kegel 14 Apr '05

14 Apr '05

Apologies if this is an old idea, but: Tridge's remarks in his recent interview make me think maybe Wine should be using the same NTVFS layer that Samba4 does. Who knows, maybe it'd be an easy fit... - Dan http://software.newsforge.com/article.pl?sid=05/04/08/2132221&from=rss NF: What are the biggest improvements that have come to fruition in Samba4 and what are the biggest ones that didn't make it or had to be significantly trimmed? Tridge: From my point of view, the biggest improvement is in the code structure. Over half the code in Samba4 is now auto-generated using a new compiler we wrote for the task. That change alone would be worth the effort for me. The code that isn't auto-generated is structured in a modular and very efficient manner. That point of view isn't what users care about, of course, but it does lead to lots and lots of user-visible improvements due to the ease of programming with the new structure. We now commonly come across situations where we say, "OK, let's start on the following feature," and a couple of hours later it's finished, where we might have spent a week or more on the same feature in Samba3. The most user-visible changes in Samba4 will be those associated with the ADS support, and the additional file system features. The file system features are what started the whole Samba4 effort -- Samba4 was initially called the "Samba NTVFS" project, referring to the new virtual file system layer that allows for NT semantics on top of both POSIX and non-POSIX file systems. One simple but important example of how the new NTVFS layer helps is the addition of support for "NT file streams." A file in a NT filesystem can have multiple "streams," where the primary stream (called ":$DATA") is the normal file data that people are used to thinking about, but there can be any number of other named streams containing other types of data, such as meta-data describing who wrote the file, or an audio stream, or even some data from an anti-virus scan of the file. Importantly, recent updates to WindowsXP use streams to store security information about where a file came from, which allows Windows to display a warning when you try to execute a file that comes from an untrusted "security zone." POSIX file systems have no concept of multiple streams, and as Samba was originally designed as a tool for representing a POSIX filesystem to Windows clients, there was no attempt to add stream support. The situation has now changed, with streams becoming a more essential feature for a file server for Windows clients, and at the same time user expectations for compatibility with WindowsNT have risen. This means we really need to support streams, but in order to do that properly, a lot of the internals of Samba needed to be updated. This is achieved in Samba4 using the new NTVFS layer, which allows streams to be represented either using an external database or using "file xattrs," which is an extension recently added to Linux, and which is also present in a number of other, Unix-like systems

4 7