May 2005 - Wine-devel - list.winehq.org

Re: [WINEDOCS] Add missing tag
by Dimi Paun 18 May '05

18 May '05

On Wed, 2005-05-18 at 10:37 +0200, Francois Gouget wrote: > Add missing <qandaentry> tag. Oops, too late, I've already committed the fix last night. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

Re: comctl32: Move mouse tracking to MouseMove [RESEND]
by Dimi Paun 18 May '05

18 May '05

On Wed, 2005-05-18 at 00:31 -0500, James Hawkins wrote: > + LVHITTESTINFO lvHitTestInfo; > + INT nItem; > + > + if (infoPtr->bLButtonDown) > + { > + lvHitTestInfo.pt = infoPtr->ptClickPos; > + nItem = LISTVIEW_HitTest(infoPtr, &lvHitTestInfo, TRUE, > TRUE); > + > + if (DragDetect(infoPtr->hwndSelf, infoPtr->ptClickPos)) > + { > + NMLISTVIEW nmlv; > + > + ZeroMemory(&nmlv, sizeof(nmlv)); Why not move the lvHitTestInfo and nItem into the inner scope: if (infoPtr->bLButtonDown && DragDetect(infoPtr->hwndSelf, infoPtr->ptClickPos)) { LVHITTESTINFO lvHitTestInfo; NMLISTVIEW nmlv; ZeroMemory(&nmlv, sizeof(nmlv)); lvHitTestInfo.pt = infoPtr->ptClickPos; nmlv.iItem = LISTVIEW_HitTest(infoPtr, &lvHitTestInfo, TRUE, TRUE); .... } -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

MSN Webcam
by Maarten Lankhorst 18 May '05

18 May '05

Status: Nearly complete, need testers. http://wiki.winehq.org/MSN_Messenger_webcam_support You need the native quartz dll, which get installed with internet explorer, as the builtin quartz doesn't work properly when changing media format on initialisation. IFilterGraph Reconnect isn't implemented, and for some reason *looks strangely at Robert* instead of a FIXME() there's a TRACE telling it is a stub...

2 1

Re: [crypt32] implementation of CryptProtectData/CryptUnprotectData
by Mike McCormack 18 May '05

18 May '05

Kees Cook wrote: > Hi, I'm back again. :) This implements the crypt32 functions > CryptProtectData and CryptUnprotectData, using a best-guess at the true > Windows opaque data format and encryption methods. It attempts to > follow the "details" in the MSDN article that described > CryptProtectData. > > Please let me know how this all looks. Hopefully I've got it mostly > right this time. If there is a more sane way to handle the structure > serialization/unserialization, I'm all ears. > > (Anyone paying really close attention will note that I uncovered some > crash bugs in rsaenh as a result of my crypt32 test cases. Make sure > you've done a "cvs update" to catch those changes before running them.) > > ChangeLog: > Implements a best-guess of CryptProtectData/CryptUnprotectData. Hi Kees, Wow. That's alot of work :) It's usually easier to review these things in smaller chunks. An easy way to do that is to submit header changes first, then stub functions, implementation of each function and a test program, all as seperate patches. A further way for your patch would be to seperate CryptProtectData and CryptUnprotectData data into to two seperate patches, though I understand they are dependent on each other to some extent. This patch looks OK to me at a quick glance, but if it's not applied, please consider breaking it up. At least that way, you'll have less to submit next time round. Mike

3 2

Re: winecfg: Add handling for drive options
by Mike McCormack 18 May '05

18 May '05

James Hawkins wrote: > case WM_COMMAND: > - if (HIWORD(wParam) == EN_CHANGE) > + switch (HIWORD(wParam)) > { I don't know if it's just my opinion, but case statements within case statements make the code more difficult to read. Would you consider creating a new function instead? eg. case WM_COMMAND: OnCommand( dialog, HIWORD(wParam), LOWORD(wParam) ); break; Mike

1 0

Re: comctl32: Move mouse tracking to MouseMove
by Dimi Paun 18 May '05

18 May '05

On Tue, 2005-05-17 at 23:18 -0500, James Hawkins wrote: > Changelog > * Store the click point in LISTVIEW_INFO. > * Move mouse tracking to MouseMove. > * Use DragDetect instead of TrackMouse. > * Remove the unused TrackMouse function. I think you've sent the wrong patch... -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

Re: Corrected the priority of operators for LISTVIEW_GetNextItem function.
by Dmitry Timoshkov 18 May '05

18 May '05

<taro-x(a)justsystem.co.jp> wrote: > Changelog: > > * dlls/comctl32/listview.c > > Corrected the priority of operators for LISTVIEW_GetNextItem function. > --- dlls/comctl32/listview.c 2005-04-14 22:58:24.000000000 +0900 > +++ dlls/comctl32/listview.c 2005-05-16 11:29:08.003084512 +0900 > @@ -5665,7 +5665,7 @@ > * so it's worth optimizing */ > if (uFlags & LVNI_FOCUSED) > { > - if (!(LISTVIEW_GetItemState(infoPtr, infoPtr->nFocusedItem, uMask) & uMask) == uMask) return -1; > + if (!((LISTVIEW_GetItemState(infoPtr, infoPtr->nFocusedItem, uMask) & uMask) == uMask)) return -1; Wouldn't it be more readable and less confusing in the below form? if ((LISTVIEW_GetItemState(infoPtr, infoPtr->nFocusedItem, uMask) & uMask) != uMask) return -1; -- Dmitry.

1 0

Re: storage32.c fix for big endian arch
by Phil Krylov 17 May '05

17 May '05

Please disregard, Pierre d'Herbemont already sent the same few hours before :) -- Ph. On Tue, 17 May 2005 21:41:41 +0400 Phil Krylov <phil(a)newstar.rinet.ru> wrote: > ChangeLog: > > Fixed storage32.c compilation in big endian architectures. > > Patch: > > Index: dlls/ole32/storage32.c > =================================================================== > RCS file: /home/wine/wine/dlls/ole32/storage32.c,v > retrieving revision 1.87 > diff -p -u -r1.87 storage32.c > --- dlls/ole32/storage32.c 14 May 2005 11:06:44 -0000 1.87 > +++ dlls/ole32/storage32.c 17 May 2005 17:20:06 -0000 > @@ -4130,8 +4130,8 @@ void StorageUtl_ReadULargeInteger(const > ULARGE_INTEGER tmp; > > memcpy(&tmp, buffer + offset, sizeof(ULARGE_INTEGER)); > - value->LowPart = htole32(tmp.HighPart); > - value->HighPart = htole32(tmp.LowPart); > + value->u.LowPart = htole32(tmp.u.HighPart); > + value->u.HighPart = htole32(tmp.u.LowPart); > #else > memcpy(value, buffer + offset, sizeof(ULARGE_INTEGER)); > #endif > @@ -4143,8 +4143,8 @@ void StorageUtl_WriteULargeInteger(BYTE* > #ifdef WORDS_BIGENDIAN > ULARGE_INTEGER tmp; > > - tmp.LowPart = htole32(value->HighPart); > - tmp.HighPart = htole32(value->LowPart); > + tmp.u.LowPart = htole32(value->u.HighPart); > + tmp.u.HighPart = htole32(value->u.LowPart); > memcpy(buffer + offset, &tmp, sizeof(ULARGE_INTEGER)); > #else > memcpy(buffer + offset, value, sizeof(ULARGE_INTEGER)); > >

1 0

[Fwd: Relationship between Wine and the proprietary versions.]
by Dimi Paun 17 May '05

17 May '05

Hi folks, I've got this request on wine-faq list (deleted the name, don't know if they want to be on wine-devel). Anyone care to write a small blurb about this? -------- Forwarded Message -------- From: XXXXX To: wine-faq(a)winehq.org Subject: Relationship between Wine and the proprietary versions. Date: Mon, 16 May 2005 21:45:11 +0200 Hi Seing Wine, Crossoveroffice and Cedega, i was wondering about the relationship between the projects. I find the concepts they are pursueing important, but i don't like their licenses. I would like Wine to be all that, so i would rather give my support to Wine than to the proprietairy projects. That is not a question of money, but out of licensing issues. So i was wondering if you could explain that in the FAQ also? -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

3 4

Wiki
by Robert van Herk 17 May '05

17 May '05

Just wanted to say, that the wiki is great! It makes it much easier to pick a project to work on. Robert

1 0