May 2005 - Wine-devel - list.winehq.org

Re: wine/dlls/setupapi parser.c
by Robert Shearman 31 May '05

31 May '05

Alexandre Julliard wrote: >Index: wine/dlls/setupapi/parser.c >diff -u -p wine/dlls/setupapi/parser.c:1.15 wine/dlls/setupapi/parser.c:1.16 >--- wine/dlls/setupapi/parser.c:1.15 Tue May 31 17:10:06 2005 >+++ wine/dlls/setupapi/parser.c Tue May 31 17:10:06 2005 >@@ -852,7 +852,9 @@ static DWORD parse_buffer( struct inf_fi > struct parser parser; > const WCHAR *pos = buffer; > >- parser.start = buffer; >+ if (*pos == 0xfeff) pos++; /* skip Unicode BOM signature */ >+ >+ parser.start = pos; > parser.end = end; > parser.file = file; > parser.line = NULL; > This shouldn't be necessary. The Unicode BOM (or Zero Width Non-Breaking Space) has CT_CTYPE1 of C1_SPACE | C1_BLANK so it should be skipped just like any other whitespace character. -- Rob Shearman

2 1

Re: Default setting for RelayExclude
by Mike Hearn 31 May '05

31 May '05

On Thu, 26 May 2005 01:15:45 +0100, Mike Hearn wrote: > Mike Hearn <mh(a)codeweavers.com> > Default setting for RelayExclude Alexandre, any reason this didn't get in? thanks -mike

2 2

Re: Fix implicit loading of 16bit GDI & USER
by Alexandre Julliard 31 May '05

31 May '05

Richard Cohen <richard(a)daijobu.co.uk> writes: > Changelog > Implicitly loaded 16bit GDI & USER need an EXE extension This is wrong, the EXE extension is present in the module filename, the loader shouldn't need to know about it. The problem is probably that GDI isn't pre-loaded, which is the case for 32-bit apps now that GDI no longer needs the local heap. What app is causing the problem? -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [Fwd: Re: Extending File Dialog to include unix file paths]
by Michael Lin 31 May '05

31 May '05

Hi Alexandre, I haven't got a reply from you on this issue yet. Please let me know what you think of the patch. Thanks, Michael Michael Lin wrote: > Hi Alexandre, > > I have made the changes as you suggested to put all the entry point in > one single library. > > Basically, I have created a new library called wineunixfs. > It currently contain modified version of filedlg.c and > filedlgbrowser.* and all their dependent files from commdlg. > > I have attached the diff file for the rest of the changes that's on > the core libraries. > I didn't attach the files in wineunixfs as you seems ok with > duplicating code there and modify it there. > > Most of the changes are contained within shell32 libraries to make it > aware of whether it is in unix or dos path mode. > There is only one exported function been added and that is > SHUnixFSGetDesktopFolder() in shell32. > > Could you please take a look at the patch and let me know if this is > "clean" and acceptable. > > Thanks, > Michael >

2 1

Re: tab: Shift selected tab text up instead of down [RESEND]
by Mike McCormack 30 May '05

30 May '05

> + if (iItem == infoPtr->iSelected) > + center_offset_v = ((drawRect->bottom - drawRect->top) - (rcText.bottom - rcText.top) - infoPtr->uVItemPadding) / 2; > + else > + center_offset_v = ((drawRect->bottom - drawRect->top) - (rcText.bottom - rcText.top) + infoPtr->uVItemPadding) / 2; Wouldn't it be clearer as: center_offset_v = (drawRect->bottom - drawRect->top) + (rcText.bottom - rcText.top); if (iItem == infoPtr->iSelected) center_offset_v -= infoPtr->uVItemPadding; else center_offset_v += infoPtr->uVItemPadding; center_offset_v /= 2; That breaks up the long lines, and eliminates the common sub-expressions... Mike

1 0

generic.ppd isn't installed anymore
by Vincent Béron 30 May '05

30 May '05

Hi, wineps/generic.ppd isn't installed anymore since a couple weeks ago (didn't had time yet to pinpoint exact patch). I think it's because only __install-lib__ and __install-dev__ is done in dlls/ now, and not __install__, which is the target actually installing wineps/generic.ppd. A quick'n dirty way is to run make -C dlls/wineps install after make install but it should really be fixed properly I guess. Vincent

1 0

Re: wine/dlls/x11drv keyboard.c
by Francois Gouget 30 May '05

30 May '05

On Sun, 29 May 2005, Alexandre Julliard wrote: [...] > Log message: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > Fix Estonian keyboard layout to better match the X11 one. I have noticed that we get a steady trickle of these. Shouldn't it be possible to get the definitions of all keyboards from the XFree sources and find some way to automatically import them? The other trickle we're seeing is with timezones. So in a similar way maybe we could get the data from the site below and import it all: http://www.timeanddate.com/library/abbreviations/timezones/ Would this make sense? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ We are Pentium of Borg. You will be approximated. Division is futile.

3 2

Re: OLEAUT32 (resend) Floating point locale, no negative zero
by Alex Villacís Lasso 30 May '05

30 May '05

Alexandre Julliard wrote: > Alex Villacis Lasso <a_villacis(a)palosanto.com> writes: > > > >> Changelog: >> * Force Single|Double conversion to BSTR to use the decimal separator >> defined by the current locale, because that is what native oleaut32 >> does, and to be consistent with later parsing of floating-point >> numbers, which uses current locale. Failure to apply this patch causes >> vartype test to fail in non-US locales with a decimal separator other >> than a period. >> * The number form "-0" is *not* allowed to be returned in a >> Single|Double conversion to BSTR in case of numeric undeflow, use >> unsigned zero instead. Some applications depend on this. Test included. >> > > > That's ugly, I think we really want to do our own formatting instead > of using the system printf and hacking the string afterwards. > > > By "our own formatting", do you mean to reimplement the %f and %lf functionality of the system printf() in a Wine-specific function? It can be done, of course, but I thought there was a good reason for the original code to rely on the system printf() for the floating-point formatting. Then there is the question of whether the potential patch is still allowed to use GetNumberFormatW for the (dwFlags & LOCALE_USE_NLS) case. This function seems to relay on the decimal separator being a period (as built by sprintfW). A more recent patch I sent used GetNumberFormatW for the non-NLS case to achieve the substitution of the period for whatever the decimal separator was in the current locale. However, GetNumberFormatW() cannot do anything about the negative zero issue, so that was still handled in the VARIANT_BstrFromReal() function of vartype.c. How much formatting should the new formatting function do? Is it enough to handle the negative zero and the decimal separator, and use sprintfW() for the LOCALE_USE_NLS case (as the current code does), or does it have to reimplement the functionality currently delegated to GetNumberFormatW()? I will start making a patch assuming the first scenario (use new function just for non-NLS case). Please answer if anybody thinks it should be done otherwise. Alex Villacís Lasso

1 0

CryptUnprotectData undeclared - cannot compile
by Pavel Troller 30 May '05

30 May '05

Hi! For some time, about 10 - 14 days, I cannot compile wine from CVS anymore. The reason is as follows: make[3]: Entering directory `/usr/src/emul/wine/dlls/crypt32/tests' ../../../tools/winegcc/winegcc -B../../../tools/winebuild -mconsole protectdata.o testlist.o -o crypt32_test.exe.so -L../../../libs/port -lwine_port -L../../../dlls -L../../../dlls/crypt32 -L../../../libs -lcrypt32 -s -L/opt/ungif/lib protectdata.o(.text+0x3b5): In function `test_cryptunprotectdata': /usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:114: undefined reference to `CryptUnprotectData' protectdata.o(.text+0x42f):/usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:120: undefined reference to `CryptUnprotectData' protectdata.o(.text+0x4b9):/usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:129: undefined reference to `CryptUnprotectData' protectdata.o(.text+0x54f):/usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:140: undefined reference to `CryptUnprotectData' protectdata.o(.text+0x702):/usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:160: undefined reference to `CryptUnprotectData' protectdata.o(.text+0x782):/usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:167: more undefined references to `CryptUnprotectData' follow collect2: ld returned 1 exit status The same reported another user on the user's list, but nobody noticed it. It would be nice to fix this problem to be able to compile wine again. With regards, Pavel Troller

4 7

Hint for Wine + Type1 + FrameMaker / Update for the Font HOWTO
by Dag Wieers 30 May '05

30 May '05

Hi Avi, Having spend endless hours looking for how to make Wine and Type1 fonts working together. I finally decided to convert my Type1 fonts to Truetype (after a hint by someone that Wine does not have Type1/Adobe support). Note: I'm not sure if this is true since there is a wine [afmdirs] section in the wine config. Wine still had troubles with (at least) some of the files. Converting Type1 fonts to Truetype fonts was easy and Framemaker actually has a hidden feature to find out which fonts are missing. When you load your FrameMaker document and you have missing fonts, it wants to reformat your file. After you allow that, just look at the available fonts, suddenly you have a few extra ones in the list that have been disabled. These are the fonts FrameMaker requires and couldn't find. Note down the names as they appear in the list, quit the document without saving (!), then go look for the Type1 fonts that match the name using grep. Open them in fontforge (http://fontforge.sourceforge.net/) if necessary change the Family Name to what you wrote down and safe it as a Truetype font. If you do that for all the files involved, everything works fine. I added this explanation to my document bits (for google) http://dag.wieers.com/howto/bits/wine-framemaker-type1.php So fontforge should definitely be part of the Font HOWTO and maybe something about Wine and Type1 support (and FrameMaker) too ? PS I included the Wine list too, as I looked there for answers first. I bet some more people will do the same and come across this thread. Hope this helps and thanks for a great resource, -- dag wieers, dag(a)wieers.com, http://dag.wieers.com/ -- [all I want is a warm bed and a kind word and unlimited power]

1 0