May 2005 - Wine-devel - list.winehq.org

Re: docs/. configure.ac
by Francois Gouget 26 May '05

26 May '05

Dimi Paun wrote: [...] > Modified files: > . : configure.ac > > Log message: > Francois Gouget <fgouget(a)codeweavers.com> > Warn the user if docbook2html is missing. Offer hints as to which > packages he needs to install. > > > Old revision New revision Changes Path > 1.2 1.3 +12 -0 docs/configure.ac Hmm, you forgot to regenerate the configure script. The problem is my autoconf version is a bit different which results in extra changes. So I prefer not to send my configure diff and let you regenerate it... -- Francois Gouget fgouget(a)codeweavers.com

2 1

Re: avoid msvfw32 crash
by Alexandre Julliard 26 May '05

26 May '05

luis lenders <lgvlenders(a)yahoo.co.uk> writes: > Index: wine/dlls/msvideo/drawdib.c > =================================================================== > RCS file: /home/wine/wine/dlls/msvideo/drawdib.c,v > retrieving revision 1.24 > diff -u -p -r1.24 drawdib.c > --- wine/dlls/msvideo/drawdib.c 17 Jan 2005 15:33:43 -0000 1.24 > +++ wine/dlls/msvideo/drawdib.c 24 May 2005 19:09:28 -0000 > @@ -242,7 +242,10 @@ BOOL VFWAPI DrawDibBegin(HDRAWDIB hdd, > TRACE("Not compressed!\n"); > dwSize = lpbi->biSize + num_colours(lpbi)*sizeof(RGBQUAD); > whdd->lpbiOut = HeapAlloc(GetProcessHeap(), 0, dwSize); > - memcpy(whdd->lpbiOut, lpbi, dwSize); > + if (whdd->lpbiOut) > + memcpy(whdd->lpbiOut, lpbi, dwSize); > + else > + ret=FALSE; Sounds like we need a check that the number of colors is reasonable. The HeapAlloc shouldn't normally fail except if the size is bogus. -- Alexandre Julliard julliard(a)winehq.org

1 0

MSI gui questions
by Stefan Dösinger 26 May '05

26 May '05

Hello, The native windows installer has support for a gui, but Wine's msi doesn't (yet). I had a look at this, and it seems that there are already some functions in dlls/msi/dialog.c which are for GUI handling. I had a look at the msi documentation in the MSDN. It appears to me that most dialogs are implemented in the msi file. Well, I tried to implement the PreActionDialog ACTION. I had no problem in adding a new function for that action. According to my observations, I have to call msi_dialog_create with the name of the dialog I want to create. Is there any reference about the dialogs' names? Do I have to write those dialogs(create the GUI), or is this done by the code in the .msi file? Thanks for your help, Stefan

2 1

Re: check for mkdir mode
by Dmitry Timoshkov 26 May '05

26 May '05

"Steven Edwards" <steven_ed4153(a)yahoo.com> wrote: > +int sys_mkdir(const char *path, mode_t mode) > +{ > +#ifdef HAVE_MKDIR_MODE > + return mkdir(path, mode); > +#else > + return mkdir(path); > +#endif > +} Wouldn't it be better to emulate mkdir(path, mode); with mkdir(path); chmod(path, mode); -- Dmitry.

2 1

Wine on Sparc
by Chuck Hall 26 May '05

26 May '05

Greetings, I have heard that people are using Wine on Solaris. I would like to know if they are using Wine on the SPARC version or the x86 version of Solaris? There does seem to be code within Wine to have it run on SPARC machines, but it currently does not seem to compile, at least on the Solaris version. I have attached a small patch that allows me to get throught the 'make depend' section of the compile. Since it is my first patch, please look at and let me know what I did wrong :) Have Fun! Chuck Hall

5 10

Question about advapi32/eventlog.c
by David Hemmo 26 May '05

26 May '05

Hello The stubs in eventlog.c return an odd value (0xcafe4242) instead of NULL. For example, in RegisterEventSourceW, NULL would be an error and would mean the register did not work. The current value doesn't tell the application that it didn't work. Is there a reason ? Thanks David Hemmo

2 1

Re: Fix Sparse Warnings for server/ (Try 2)
by Alexandre Julliard 25 May '05

25 May '05

Robert Shearman <rob(a)codeweavers.com> writes: > --- server/fd.c 24 Apr 2005 17:35:52 -0000 1.37 > +++ server/fd.c 24 May 2005 18:37:28 -0000 > @@ -898,18 +898,6 @@ static void remove_lock( struct file_loc > release_object( lock ); > } > > -/* remove all locks owned by a given process */ > -void remove_process_locks( struct process *process ) > -{ > - struct list *ptr; > - > - while ((ptr = list_head( &process->locks ))) > - { > - struct file_lock *lock = LIST_ENTRY( ptr, struct file_lock, proc_entry ); > - remove_lock( lock, 1 ); /* this removes it from the list */ > - } > -} > - Something's not right, that function should be used somewhere. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Resend: Fix ole32:moniker test for NT4
by Alexandre Julliard 25 May '05

25 May '05

Richard Cohen <richard(a)daijobu.co.uk> writes: > Rediffed against HEAD > > Richard Cohen wrote: > > ... and almost certainly Win9x, 2k, XP > > Changelog: > > + IEnum::Clone shouldn't do a Reset. > > + Don't assume the ROT is already empty when testing The tests fail here: ../../../tools/runtest -q -P wine -M ole32.dll -T ../../.. -p ole32_test.exe.so moniker.c && touch moniker.ok moniker.c:139: Test failed: Number of matches should be equal to 2 not 0 moniker.c:146: Test failed: Number of matches should be equal to 2 not 0 make[3]: *** [moniker.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: DirectX 9 patches
by Andreas 'GlaDiaC' Schneider 25 May '05

25 May '05

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, it was playable (with models) with -dxlevel 90 on Wine 20040310 and it is simple to install with installshield :) MSI: http://www.frankscorner.org/index.php?p=ishield http://www.frankscorner.org/index.php?p=msi HL2 Shots: http://www.cynapses.org/tmp/hl2_shots/ The _problem_ will be always Steam :) My Steam doesn't work since the last Steam update. Cheers, -- andreas > Okay, more info and screenshots over here: > > http://ivan.ivg2.net/hl2/ > > It's not playable, but it's exciting that > it gets this far in the first place! > > ...it has to be installed through Steam (since msi won't work). > > -- > > Ivan Gyurdiev <ivg2_at_cornell.edu> > Cornell University - -- http://www.linux-gamers.net - your online gaming resource -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFClGSFf94+j/M+P8YRAglpAKCLGaA92PoeqIQHvPcd0WyRfd/EAgCcCBIW Nbnr8xwdz+y2tksCpTBekkk= =hHXs -----END PGP SIGNATURE-----

1 0

Release notes
by Mike Hearn 25 May '05

25 May '05

Hi guys, Raphael pointed out on IRC that the great OpenGL work that went into the last release wasn't mentioned in the "What's new" list that goes out with each snapshot. As it's unreasonable to expect Alexandre to remember or mention every large piece of work that goes into any given release, how about we use the Wiki to note big items as they are checked into CVS. By "big item" I mean either: - Large improvements to a particular subsystem - Adding "gold" compatibility with a well known app - Some other end-user interesting feature For instance, I'd say "header cleanups" are less interesting to users than "OpenGL improvements for Warcraft". That's not a criticism of Alexandre, it's totally reasonable that he puts things in that he can quickly remember and as he's closer to parts of the system like import libraries and headers it's natural that this is what springs to mind first. But we can do better. If people think it's a good idea, I'll create a scratchpad page on the Wiki we can use for the next release. Anybody should be able to add things that are "big", then when doing a release Alexandre can pick and choose the ones he thinks are best to put in What's New. Thoughts? thanks -mike

2 2