June 2005 - Wine-devel - list.winehq.org

Re: [PATCH] FCI work for cabinet.dll [cabinet-fci-patch-02c.diff]
by Alexandre Julliard 20 Jun '05

20 Jun '05

"Gerold J. Wucherpfennig" <gjwucherpfennig(a)gmx.net> writes: > Please apply, it seems to be fine, so far. > > There is still some work to be done: > > - currently no support for big-endian machines > - the ERF error structure aren't used on error > - no real compression yet > - unknown behaviour if files>4GB or cabinet >4GB > - incorrect status information > - check if the maximum size for a cabinet is too small to store any data > - call pfnfcignc on exactly the same position as MS FCIAddFile in every case You should get rid of all the PFCI_INT macro uses, that's making the code really ugly and hard to read. You should do the cast once at the start of the function (preferably as part of the handle validation routine) and then pass around a pointer of the appropriate type. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Make Instruction Emulation Code More Tolerant of Bad Addresses
by Alexandre Julliard 20 Jun '05

20 Jun '05

Robert Shearman <rob(a)codeweavers.com> writes: > Therefore this patch aids in debugging. It isn't perfect because of > x86's variable length instructions, but it is fairly unlikely that an > instruction will straddle a page boundary and the first page be > readable and the second not. Putting an exception handler around the whole function would probably be a better choice, this way it would catch data accesses too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Added XEmbed embedder support
by Dimi Paun 20 Jun '05

20 Jun '05

On Mon, 2005-06-20 at 00:05 +0200, Jacek Caban wrote: > Hello. > > This patch adds support for XEmbed embedder > It implements most of it (remaining todos > are listed in comments of xembed.c). Cool stuff, I'm really excited about this work. Not to mention that this might prove useful outside of the MSHTML context. I will not comment on the fundamentals of the approach, that's more Alexandre's alley, but just a few style nits. > +struct xembed_list > +{ > + struct xembed_list *next; > + HWND hwnd; > +}; What about using the standard list from wine/list.h? > /* DIB Section sync state */ > @@ -590,6 +601,8 @@ enum x11drv_atoms > XATOM_XdndSelection, > XATOM_XdndTarget, > XATOM_XdndTypeList, > + XATOM__XEMBED, > + XATOM__XEMBED_INFO, > XATOM_WCF_DIB, > XATOM_image_gif, > XATOM_text_html, > @@ -649,6 +662,10 @@ struct x11drv_win_data > struct dce *dce; /* DCE for CS_OWNDC or CS_CLASSDC windows */ > HBITMAP hWMIconBitmap; > HBITMAP hWMIconMask; > + union { > + struct xembed_list *list; > + ULONG_PTR cnt; > + } xembed; > }; Do we really need the union? We're not that hard pressed for memory. What about just @@ -649,6 +662,10 @@ struct x11drv_win_data struct dce *dce; /* DCE for CS_OWNDC or CS_CLASSDC windows */ HBITMAP hWMIconBitmap; HBITMAP hWMIconMask; + struct xembed_list *list; + ULONG_PTR cnt; }; Also, instead of having explicit tests like these: > + if(data->xembed.cnt) Maybe we can have a BOOL win_has_embedded_children(struct x11drv_win_data *data) function to make it more explicit what we're testing for. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

2 1

Re: [Patch] winsock.h inclusion
by Alexandre Julliard 20 Jun '05

20 Jun '05

"Pierre d'Herbemont" <stegefin(a)free.fr> writes: > Alexandre, > > Using the current CVS on Darwin/Mac OS X, there are still compilation > errors related to winsock.h inclusion. The error was: > > ../../../include/winsock.h:414: error: redefinition of 'struct timeval' > > My solution is to include "wine/test.h" after every other header. You should fix wine/test.h and/or winsock.h to work properly in all cases. Otherwise the problem will keep coming back. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [shell32] Load file context menu from resources [Resent]
by Alexandre Julliard 20 Jun '05

20 Jun '05

Tobias Burnus <burnus(a)net-b.de> writes: > Second try (unchanged). Any suggestions how to improve the patch are > welcome. > > Tobias > > Changed file overview: > - shv_item_cmenu.c: Load from resources (the [currently unused] MENU > resource already exists) > - shell32_?.rc: Comment out two items (and a separator) and > copy text from IDS_SELECT, needed to match the current context menu You shouldn't comment things out like that. Either the info is needed and it should be here, or it's not needed and it should be removed completely. Commenting it out is only creating confusion. -- Alexandre Julliard julliard(a)winehq.org

1 0

Crashes due to OGL
by Robert Lunnon 20 Jun '05

20 Jun '05

I see the following X error (After fixing a bug in utah GLX) trace:ddraw:initialize enabling DirectDraw HAL trace:ddraw:d3ddevice_init_at_startup Initializing GL... @@Created GLX Context.. X Error of failed request: BadValue (integer parameter out of range for operation) Major opcode of failed request: 143 (GLX) Minor opcode of failed request: 3 (X_GLXCreateContext) Value in failed request: 0x21 Serial number of failed request: 7282 Current serial number in output stream: 7283 send_thread_signal 15 According to my GL log this request looks for visual 33 (IE vid=33) this is a non GL visual since utah GLX is allocating visuals 55 up on my system. I don't exactly know why wine should be trying to Create a GL context from a non GL visual but there you are... Bob

3 2

Wine on LinuxTag 2005
by Michael Stefaniuc 20 Jun '05

20 Jun '05

Hello guys, the LinuxTag 2005 has Wine as featured OSS project http://www.linuxtag.org/typo3site/projects.html?&L=1 (german only). Does anybody know something about this? Andi? bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

2 1

Re: Documenting debug messages (was: wine/dlls/x11drv x11drv_main.c x11drv.h palette.c)
by Dustin Navea 19 Jun '05

19 Jun '05

You are right, it is completely different, but I was just stating that I think it might be something to consider, just so that we non-developers have some clue about what different errors mean.. I, for one, would like to know what the error message in my original reply means. And having some sort of documentation on that exact error message would save everyone some time from having to close reports that are already known, as well as the advantage of not having to answer questions about that. Basically answer the question once for me, and then people can just search (using their browsers' find function) for that exact error on whatever page it gets put on, whether wiki or my own personal site. Perhaps, though, instead of asking people who contribute code and add an err to update the documentation, we should setup a script that will track cvs commit emails (and the attached patch) and just ask alexandre to explain what would cause the fixme/err/warn/etc that is in that patch (in the commit email of course).. I could probably rent a shell to run it, and have the script either update the doc itself, or have it email the explanation to me, and then update the pages myself whenever I have a chance... The first thing though would be to get the current debug messages documented somewhere, then worry about updating it. Of course, if I do go ahead and document it, I would leave the removed messages in there with a note saying "this has been removed as of (date), please update to the latest release, or latest CVS if there hasn't been a release since this was committed".. Of course if I dont have any support, then there's no sense in doing it, so I would only do this with the blessing of the other developers. Dustin Brian Vincent wrote: > On 6/15/05, Dustin Navea <speeddymon(a)gmail.com> wrote: > >>I'd have to agree with you guys on this one. One thing I can think of >>that I would like to take on (given enough time to do it all) is create >>a wiki page that I can use to document all of the fixme's, warn's and >>err's that occur in the source, and then ask anyone that is contributing >>code to update it when they add/remove one of those. For example, it >>might be helpful to a user to know that "err:midi:OSS_MidiInit ioctl on >>midi info for device 0 failed" is more of a fixme than an error, and >>exactly what that "gibberish" means, so that they dont go reporting it >>(making a dupe report), etc.. > > > Well, this is completely different than the config option (registry > value) argument.. > > I don't think it's worth spending any time on. It doesn't provide > that much useful information and it will quickly rot - people won't > keep it updated. > > But that's just my $.02. > > -Brian >

2 1

bit-blit ops
by cdr 19 Jun '05

19 Jun '05

While testing my Win32 application under wine, I came to the conclusion that some bit-blit ops behave differently from when the same code is running under native Windowds. While the subject will be researched further, as a stop-gap measure I have a need to detect - from within my application - that it is running under wine. What is the correct way - if any - to perform such test? tia, crd

7 14

Re: [NtQueryInformationProcess #2] Several stub implementations
by Andreas Mohr 19 Jun '05

19 Jun '05

Hi, On Fri, Jun 17, 2005 at 10:03:49PM +0200, Paul Vriens wrote: > PROCESS_TIMES is a name I made up as I don't seem to be able to find > another struct that matches. Is it ok to put that one in winternl.h ? An explanatory comment would be in order, I think. It's not a good idea to "invent" stuff and pretend it's been there all the time... Andreas Mohr

2 1