June 2005 - Wine-devel - list.winehq.org

Getting civilization 2 to work...
by Kristiaan Lenaerts 14 Jun '05

14 Jun '05

Hello, I've been following the wine-devel lists for some time now, but I never found time to actually work on something... until now. I am trying to get civilization 2 to work (with some succes). I chose that game for some reasons (I like the game and the error looks easy, a bit like the tutorials). I made the following trace: 0013:Call user32.GetWindowLongA(00170034,0000000a) ret=005d2a16 0013:Ret user32.GetWindowLongA() retval=00000000 ret=005d2a16 0013:Call user32.GetClassLongA(00170034,ffffffee) ret=005d2a25 0013:Ret user32.GetClassLongA() retval=0000000c ret=005d2a25 0013:Call user32.GetWindowLongA(00170034,00000004) ret=005d2a39 0013:Ret user32.GetWindowLongA() retval=778bfd70 ret=005d2a39 0013:trace:seh:__regs_RtlRaiseException code=c0000005 flags=0 addr=0x40f81f 0013:trace:seh:__regs_RtlRaiseException info[0]=00000000 0013:trace:seh:__regs_RtlRaiseException info[1]=00000008 0013:trace:seh:__regs_RtlRaiseException eax=00000000 ebx=7793cd94 ecx=00000000 edx=7794dfe4 esi=00170034 edi=000c0054 It shows a call to GetWindowLongA with nIndex = 10, which is not valid, and so it returns NULL. After this the program generates a STATUS_ACCESS_VIOLATION, and hangs. After searching trough win.c I found the following comment: /* * Some programs try to access last element from 16 bit * code using illegal offset value. Hopefully this is * what those programs really expect. */ changing the if statement that follows according to the following patch made civilization 2 work, although the performance is really bad. I tried making a test for this, to check if this behaviour is the same on windows, but I'm unable to make a test that will run. I don't know h ow to make the cbWndExtra and wExtra fields in the WND struct into something usefull, so it will not segfault. Mayby it is possible to leave them empty, but I don't know how, if I leave them empty every test with nIndex > 0 failes. I hope this is somewhat usefull. Krist Index: dlls/user/win.c =================================================================== RCS file: /home/wine/wine/dlls/user/win.c,v retrieving revision 1.6 diff -u -p -r1.6 win.c --- dlls/user/win.c 7 Jun 2005 20:11:17 -0000 1.6 +++ dlls/user/win.c 13 Jun 2005 19:08:25 -0000 @@ -1863,8 +1863,7 @@ static LONG_PTR WIN_GetWindowLong( HWND * code using illegal offset value. Hopefully this is * what those programs really expect. */ - if (type == WIN_PROC_16 && - wndPtr->cbWndExtra >= 4 && + if (wndPtr->cbWndExtra >= 4 && offset == wndPtr->cbWndExtra - sizeof(WORD)) { INT offset2 = wndPtr->cbWndExtra - sizeof(LONG);

2 2

tester needed
by Ivan Leo Puoti 14 Jun '05

14 Jun '05

Hello, I need a fairly simple test run for me on windows service 2003 *without* service pack 1, if you can do this please drop me a line. Ivan.

3 2

Re: [QUARTZ] Add FFMpeg video wrapper filter (take 3)
by Christian Costa 14 Jun '05

14 Jun '05

> Message du 14/06/05 13:24 > De : "Marcus Meissner" > A : "Christian Costa" > Copie à : "Marcus Meissner" , "Alexandre Julliard" , "Brian Vincent" , wine-devel(a)winehq.com > Objet : Re: [QUARTZ] Add FFMpeg video wrapper filter (take 3) > > On Tue, Jun 14, 2005 at 01:05:37PM +0200, Christian Costa wrote: > > > > What do you mean by dlls? > > A shared version of libavcodec or a quartz.dll with libavcodec linked statically? > > I meant seperate DLLs (dll.so files for WINE actually). > > Is all needed to be in quartz.dll directly? > > Or can you split off parts into quartz_codec1.dll , q_codec2.dll or > similar? > Since filters are COM objects, we can embed them in separate dlls but this would kill the concept of a generic libavcodec wrapper. And anyway this will not help us that much because the libavcodec is a big one peace of code and this would require to rewrite the building system to split codecs. Bye, Christian

2 1

Re: [QUARTZ] Add FFMpeg video wrapper filter (take 3)
by Christian Costa 14 Jun '05

14 Jun '05

Alexandre, If the possible (even rare) presence of a libavcodec.so lib can causes troubles. Would it be acceptable to force static linking with a configure check such as this one? dnl **** Check for avcodec lib **** AVCODECLIBS="" LIBS="/usr/lib/libavcodec.a -lz -lm" AC_CHECK_HEADERS(ffmpeg/avcodec.h, [AC_TRY_LINK([#include ],[avcodec_init();], [AC_DEFINE(HAVE_LIBAVCODEC, 1, [Define if you have the avcodec library (libavcodec.a)]) AVCODECLIBS="/usr/lib/libavcodec.a -lz -lm"])]) LIBS=""; AC_SUBST(AVCODECLIBS) Bye, Christian

1 0

Re: [QUARTZ] Add FFMpeg video wrapper filter (take 3)
by Christian Costa 14 Jun '05

14 Jun '05

Alexandre, If the possible (even rare) presence of a libavcodec.so lib can causes troubles. Would it be acceptable to force static linking with a configure check such as this one? dnl **** Check for avcodec lib **** AVCODECLIBS="" LIBS="/usr/lib/libavcodec.a -lz -lm" AC_CHECK_HEADERS(ffmpeg/avcodec.h, [AC_TRY_LINK([#include <ffmpeg/avcodec.h>],[avcodec_init();], [AC_DEFINE(HAVE_LIBAVCODEC, 1, [Define if you have the avcodec library (libavcodec.a)]) AVCODECLIBS="/usr/lib/libavcodec.a -lz -lm"])]) LIBS=""; AC_SUBST(AVCODECLIBS) Bye, Christian

1 0

Debugger under Solaris
by Robert Lunnon 14 Jun '05

14 Jun '05

I need some help to implement the debugger under Solaris. In particular I need help with how ptrace interacts with the threading model under Linux which I understand uses processes for threads. Since Solaris has user mode threads, stopping a pid stops all the threads in the debugee which used to deadlock the debugger. This suggests I need to operate on threads within processes rather than the processes themselves. This is possible with a few IPC tricks, but I need to understand the semantics Any volunteers ?

3 4

Re: [QUARTZ] Add FFMpeg video wrapper filter (take 3)
by Christian Costa 14 Jun '05

14 Jun '05

What do you mean by dlls? A shared version of libavcodec or a quartz.dll with libavcodec linked statically? Bye, Christian > Message du 14/06/05 08:50 > De : "Marcus Meissner" > A : "Brian Vincent" > Copie à : "Alexandre Julliard" , titan.costa(a)wanadoo.fr, wine-devel(a)winehq.com > Objet : Re: [QUARTZ] Add FFMpeg video wrapper filter (take 3) > > On Mon, Jun 13, 2005 at 11:08:00AM -0600, Brian Vincent wrote: > > On 13 Jun 2005 18:11:14 +0200, Alexandre Julliard > > wrote: > > > > > > > > > If there's only a static lib then I guess it's fine. Is that the case > > > on all major distros? > > > > > > > > I just dug through a bunch of distros and no one ships ffmpeg by default. > > That includes Fedora 4, SuSE 9.2/9.3, Mandriva 10.1, and Slackware 10.1. > > It's marked "optional" on Debian sarge. > > I think I ran into this same issue with xine a while ago. I believe they > > ship ffmpeg, but can't remember. > > SUSE does not ship it for the usual legal reasons. > > I would suggest making this an addon package for distributions, to drop > it right beside a normal WINE installation when needed. (with dlls and > regsvr and .inf files or so). > > Ciao, Marcus > >

2 1

SetThreadPriority??
by Andreas Mohr 14 Jun '05

14 Jun '05

Hi guys, has ANYONE done any testing with my experimental SetThreadPriority patch which I mailed on May 15? So far I haven't received any replies, despite this probably being rather interesting, given that it is implemented by many of our winmm threads... Or should this remain untested until I will have a sizeable amount of time for testing myself during LinuxTag? Andreas Mohr

3 2

Flattening dll directories.
by Glen Kaukola 14 Jun '05

14 Jun '05

Hi there, I was looking over the Janitorial section on the wiki, and it seems like flattening dlls is something I could definitely handle. Is this something that's still needed or wanted? And then how would that work? Would I need cvs write access to get anything done? Or can diff produce a patch that handles moving things around like that? Glen -- Free will is just an illusion.

3 2

Re: [QUARTZ] Add FFMpeg video wrapper filter (take 3)
by Christian Costa 14 Jun '05

14 Jun '05

Well, it was meant to link with the static library only however I admit my configure check is not that good. The FFMpeg build the static lib by default and it's not likely you find a shared version lying somewhere when building Wine. > Message du 13/06/05 15:12 > De : "Alexandre Julliard" > A : "Christian Costa" > Copie à : wine-devel(a)winehq.com > Objet : Re: [QUARTZ] Add FFMpeg video wrapper filter (take 3) > > Christian Costa writes: > > > Moved avcodec.h include into the #ifdef section. > > > > Changelog: > > Added FFMpeg video wrapper filter. > > You should dlopen the library to avoid creating a run-time dependency. > > -- > Alexandre Julliard > julliard(a)winehq.org > > >

6 5