June 2005 - Wine-devel - list.winehq.org

Re: Clear Out Parameters in ITypeInfo::Invoke
by Marcus Meissner 10 Jun '05

10 Jun '05

On Fri, Jun 10, 2005 at 12:25:39PM -0500, Robert Shearman wrote: > Hi, > > I plan to rewrite ITypeInfo::Invoke because at the moment it is very > buggy, incomplete and too big (over 250 lines). I heard that ;) make that "slighty buggy, very incomplete and too messy". Good luck to you :/ Ciao, Marcus

1 0

Re: LoadImage: respect the desired size when loading a bitmap
by Alexandre Julliard 10 Jun '05

10 Jun '05

Huw D M Davies <h.davies1(a)physics.ox.ac.uk> writes: > + orig_bm = SelectObject(screen_mem_dc, hbitmap); > + StretchDIBits(screen_mem_dc, 0, 0, new_width, new_height, 0, 0, width, height, bits, fix_info, DIB_RGB_COLORS, SRCCOPY); > + SelectObject(screen_mem_dc, orig_bm); That's not thread safe, you either need a critical section around the global screen_mem_dc, or probably better simply create a mem DC local to the function. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Resend: Try 3: user32.dll fix and test ShowOwnedPopups
by Vitaliy Margolen 10 Jun '05

10 Jun '05

Any reason why the whole patch wasn't committed? Vitaliy Margolen Sunday, June 5, 2005, 5:43:14, Vitaliy Margolen wrote: > It looks like DefWinProc needs to be smarter about WM_SHOWWINDOW when lParam!=0. > Added more tests for WM_SHOWWINDOW to test that it could be used as > ShowOwnedPopup (for single window). > This time with input from Dmitry. Moved tests to msg.c > ShowOwnedPopups should handle none WS_POPUP style windows as well. DefWinProc > should do the same for WM_SHOWWINDOW. > Match names for WM_SHOWWINDOW status codes to MSDN > ShowWindow(hwnd, SW_HIDE) should change Z-order thus omit SWP_NOZORDER from call > to SetWindowPos, but only for none active windows also adding SWP_NOACTIVATE > Vitaliy Margolen > changelog: > include/winuser.h > Match names for WM_SHOWWINDOW status codes to MSDN > dlls/user/win.c > ShowOwnedPopups should handle none WS_POPUP style windows as well. > dlls/user/defwnd.c > WM_SHOWWINDOW should show/hide none WS_POPUP style windows as well. > dlls/user/tests/msg.c > Tests for ShowOwnedPopups > dlls/x11drv/winpos.c > Fix flags in ShowWindow(,SW_HIDE) for active/none active windows

2 1

Re: Small fix for GetCurrentDirectoryA()
by Andreas Mohr 10 Jun '05

10 Jun '05

Hi, On Fri, Jun 10, 2005 at 07:26:33AM +0200, Felix Nawothnig wrote: > This makes Yoda Stories (which is shipped with a broken wavmix32.dll) > run out of the box. > > ChangeLog: > When emulating Win9x return ERROR_INVALID_PARAMETER if a bad buffer is > passed to GetCurrentDirectoryA(). Does Win9x GetCurrentDirectoryA() really use an IsBadWritePtr to protect against invalid output buffers? Somehow I slightly doubt it... (IsBadWritePtr isn't the fastest thing in the world...) Aren't you covering up a previous bug with buffer allocation or so? Andreas Mohr

4 4

Re: Wine on x86 OS/X
by Pierre d'Herbemont 10 Jun '05

10 Jun '05

> Hi All, > So what are everyone's thoughts on doing it? If there are any > darwine people lurking I am > interested in knowning if any of you are registered developers and > will be getting a copy of the > preview release and evaluation hardware. I can't afford the developers program, though the port can be done on OpenDarwin/x86, since we don't use any of the closed source framework. I think that WineLib app should run fine with my latest patch, and Win32 binary compat has to be tested. Pierre. > Thanks > Steven

1 0

ISvItemCm_fnQueryContextMenu load menu from .rc: Patch writing problems
by Tobias Burnus 10 Jun '05

10 Jun '05

Hello, I'd like to modify ISvItemCm_fnQueryContextMenu (shell32/shv_item_cmenu.c) in a way that it loads the strings from the .rc file. But I have some trouble. I modified the shell32_En.rc to look like the created context menu, but which puzzles me is that there are two times the same ID: FCIDM_SHVIEW_OPEN for "&Select" and for "&Open" which are shown at the same time! Depending on context (i.e. flags), I need to remove the "&Select" and switch the order of Explore and Open. But somehow the code below does not work (I think MF_BYPOSITION might cause the problem, but since Select and Open have the same id, I cannot use MF_BYCOMMAND). Any pointer what I'm doing wrong? Tobias shell32_En.rc =================================================================== MENU_SHV_FILE MENU DISCARDABLE BEGIN POPUP "" BEGIN + MENUITEM "&Select", FCIDM_SHVIEW_OPEN MENUITEM "E&xplore", FCIDM_SHVIEW_EXPLORE MENUITEM "&Open", FCIDM_SHVIEW_OPEN MENUITEM SEPARATOR MENUITEM "C&ut", FCIDM_SHVIEW_CUT MENUITEM "&Copy", FCIDM_SHVIEW_COPY MENUITEM SEPARATOR - MENUITEM "Create &Link", FCIDM_SHVIEW_CREATELINK +/* MENUITEM "Create &Link", FCIDM_SHVIEW_CREATELINK*/ MENUITEM "&Delete", FCIDM_SHVIEW_DELETE MENUITEM "&Rename", FCIDM_SHVIEW_RENAME - MENUITEM SEPARATOR - MENUITEM "&Properties", FCIDM_SHVIEW_PROPERTIES +/* MENUITEM SEPARATOR + MENUITEM "&Properties", FCIDM_SHVIEW_PROPERTIES*/ END END =================================================================== Index: shv_item_cmenu.c (deleted lines omitted in the ISvItemCm_fnQueryContextMenu function) =================================================================== @@ -36,6 +36,7 @@ #include "shell32_main.h" #include "shellfolder.h" +#include "shresdef.h" WINE_DEFAULT_DEBUG_CHANNEL(shell); @@ -208,57 +209,127 @@ InsertMenuItemA( hmenu, indexMenu, fByPosition, &mii); } + /************************************************************************** * ISvItemCm_fnQueryContextMenu() -* FIXME: load menu MENU_SHV_FILE out of resources instead if creating -* each menu item by calling _InsertMenuItem() */ static HRESULT WINAPI ISvItemCm_fnQueryContextMenu( IContextMenu2 *iface, - HMENU hmenu, + HMENU hMenu, UINT indexMenu, UINT idCmdFirst, UINT idCmdLast, UINT uFlags) { + const DWORD buflen = 80; + WCHAR szString[buflen]; + HMENU hMyMenu; + HRESULT hr; + UINT idMax; + MENUITEMINFOW mii; + + ItemCmImpl *This = (ItemCmImpl *)iface; + + TRACE("(%p)->(hMenu=%p indexmenu=%x cmdfirst=%x cmdlast=%x flags=%x )\n",This, hMenu, indexMenu, idCmdFirst, idCmdLa st, uFlags); + + if (idCmdFirst != 0) + FIXME("We should use idCmdFirst=%d and idCmdLast=%d for command ids\n", idCmdFirst, idCmdLast); + + if(!(CMF_DEFAULTONLY & uFlags) && This->cidl>0) + { + hMyMenu = LoadMenuA(shell32_hInstance, "MENU_SHV_FILE"); + + if((uFlags || CMF_EXPLORE)) { /* Remove "&Select" */ + RemoveMenu(hMyMenu, 0, MF_BYPOSITION); + } + if(!This->bAllValues) { / * Change order of OPEN and EXPLORE */ + GetMenuItemInfoW(hMyMenu, 2, TRUE, &mii); + DeleteMenu(hMyMenu, 2, MF_BYPOSITION); + InsertMenuItemW(hMyMenu, 1, TRUE, &mii); + } + + if(ISvItemCm_CanRenameItems(This) == MFS_DISABLED) { + EnableMenuItem(hMyMenu, FCIDM_SHVIEW_RENAME, MFS_DISABLED); + } + + idMax = Shell_MergeMenus (hMenu, GetSubMenu(hMyMenu,0), indexMenu, + idCmdFirst, idCmdLast, MM_SUBMENUSHAVEIDS); + hr = MAKE_HRESULT(SEVERITY_SUCCESS, FACILITY_NULL, idMax-idCmdFirst+1); + SetMenuDefaultItem(hMenu, 0, MF_BYPOSITION); + + DestroyMenu(hMyMenu); + } + else { + return MAKE_HRESULT(SEVERITY_SUCCESS, 0, 0); + } + TRACE("(%p)->returning 0x%lx\n",This,hr); + return hr; }

1 0

extracting window icons
by Brian Vincent 10 Jun '05

10 Jun '05

Is there a way to extract an icon from a DLL? Wine seems to do this automatically when programs are installed, I just can't figure out how. Is there a way to do it from the commandline? -Brian

3 3

Re: ViaVoice (98) in Wine
by René Rebe 10 Jun '05

10 Jun '05

Hi, my NaturallySpeaking 8 does (after installing IE) not really start to install: err:ole:marshal_object couldn't get IPSFactory buffer for interface {00000131-0000-0000-c000-000000000046} err:ole:marshal_object couldn't get IPSFactory buffer for interface {00000131-0000-0000-c000-000000000046} err:ole:proxy_manager_create_ifproxy Could not get IPSFactoryBuffer for interface {00000131-0000-0000-c000-000000000046}, error 0x80040155 err:ole:CoUnmarshalInterface IMarshal::UnmarshalInterface failed, 0x80040155 and a dialog is displayed: The InstallShield Engine (iKernel.exe) could not be launched. (0x80040155) Google had some hits - but no real solution. Yours, -- René Rebe - Rubensstr. 64 - 12157 Berlin (Europe / Germany) http://www.exactcode.de | http://www.t2-project.org +49 (0)30 255 897 45

5 11

Re: Window geometry problem
by Pavel Troller 10 Jun '05

10 Jun '05

Hi! I have a small update: Stuart Axon sent me a screenshot of the same app from wxp. Thanks! I placed the image together with the first (bad) one, the URL is http://www.sinus.cz/~patrol/ircape-wxp.png . Comparing the two images, one can find, that 1) Size of both is identical 2) Basic graphic elements are also identical 3) The slider is much bigger and incorrectly positioned 4) The same applies to the text window 5) Other elements are not present at all (Insert time info, Insert pause time) 6) The lonely checkbox may belong to "auto line change" text Observing this, can anybody determine a part of wine (dll or so), which is responsible for this ? Could I try it as native to see what would change ? Which regards, Pavel Troller

1 0

Re: Wine does not build [ wined3d ]
by Dmitry Timoshkov 10 Jun '05

10 Jun '05

"Ivan Gyurdiev" <ivg2(a)cornell.edu> wrote: > > I agree with Mike, how hard would it be to send an one-liner patch > > instead of complaining? > > Probably about as hard as checking that code submissions to > CVS actually compile, before merging them? > > Just hard enough to make me complain, as opposed to sending a patch? > > Hard enough to make you complain that I don't send a patch in > the first place? > > :) > > The only reason I spam the list with build failures, is that I'm > not convinced they will get fixed soon if I don't. If you'd like me > to stop, then please let me know, and no more build failures will > be reported. The thing is that Wine actually compiled for me (and apparently for Alexandre as he doesn't commit the patches that doesn't compile) without any warning or an error. A reason it didn't compile for you is a more recent gcc version you are using. If you could take that into consideration before complaining or blaming somebody next time that would be really nice. -- Dmitry.

3 2