August 2005 - Wine-devel - list.winehq.org

Frequent and annoying Wine bug
by Robbert Xerox 15 Aug '05

15 Aug '05

Hi , i know this is not a wine-bug channel, but this bug is affecting quite some apps, and seems to affect more and more ... At least five apps from wine-bug mailinglist throw up an exception which either reads: "Assertion Failed !bogus context in Local_Unwind()" or "in Exception_Handler". As a reference a filed 2 bugs, and commented another one where you can read the +relay,+seh logs: Bug 3097 Bug 3127 Bug 3139 Some googling around makes me believe that this is a Borland specific error. I tried to install Demo Borland compiler in wine to see if i could reproduce this error, but unfortunately it fails with exactly the same error. all programs show the same pattern before an exception is thrown: they call LoadstringA() ,with something like L"Failed to get data for '%s'" or L"Access violation at address %p in module '%s'. %s of address %p" See the bugs for more info. I think this bug is really affecting quite some more apps then the ones mentioned in wine-bugs so would be great if anyone could shine a light on this, as of how to solve the bug. Regards ___________________________________________________________ How much free photo storage do you get? Store your holiday snaps for FREE with Yahoo! Photos http://uk.photos.yahoo.com

3 3

Re: PATCH: GlobalAddAtomA check for invalid ptr
by Saulius Krasuckas 15 Aug '05

15 Aug '05

* On Tue, 9 Aug 2005, Marcus Meissner wrote: > > The Ikea kitchen planner passed 0xcccccccc for some reason and works > much better after this patch. It if uninitialized memory in a case of MSVC and MSVCRTD, I guess. BUUUUG in the app. :-)

6 8

Re: AppDB - set default comments mode to threaded for new users
by Tony Lambregts 14 Aug '05

14 Aug '05

Chris Morgan wrote: > Chris Morgan <cmorgan(a)alum.wpi.edu> > include/user.php > Set default comments mode to threaded for new users > Index: include/user.php > =================================================================== > RCS file: /opt/cvs-commit/appdb/include/user.php,v > retrieving revision 1.46 > diff -u -r1.46 user.php > --- include/user.php 14 Aug 2005 18:49:21 -0000 1.46 > +++ include/user.php 14 Aug 2005 19:32:59 -0000 > @@ -88,7 +88,11 @@ > $sValues = "({$aInsert['VALUES']}, password('".$sPassword."'), NOW(), NOW() )"; > > query_appdb("INSERT INTO user_list $sFields VALUES $sValues", "Error while creating a new user."); > - return $this->login($sEmail, $sPassword); > + > + $retval = $this->login($sEmail, $sPassword); > + $this->setPref("comments:mode", "threaded"); /* set the users default comments:mode to threaded */ > + > + return $retval; > } > } > Looks good to me... -- Tony Lambregts

1 0

Wine book
by Christian Britz 14 Aug '05

14 Aug '05

Hi, some days ago someone wrote a mail to this list regarding a book that he or she is writing about wine. Unfortunately I lost this mail, could the person please contact me privately? Regards, Christian

1 0

Regression in DVD Shrink
by Jonathan Ernst 14 Aug '05

14 Aug '05

Since latest Wine release DVD Shrink cannot open a DVD anymore. Error message in the GUI: DVD Shrink encountered an error and cannot continue. Failed to read file "D:\" Not ready ---------------------------------------------------------------- Error messages in terminal: fixme:ole:CoRegisterMessageFilter stub err:x11drv:X11DRV_CreateWindow invalid window height 2142303666 err:x11drv:X11DRV_CreateWindow invalid window height 2142303666 err:listview:LISTVIEW_WindowProc unknown msg 1044 wp=00000000 lp=7fb1e324 fixme:quartz:Filtergraph_QueryInterface unknown interface {03a1eb8e-32bf-4245-8502-114d08a9cb88} epoll_ctl: Operation not permitted fixme:ole:CoRegisterMessageFilter stub ---------------------------------------------------------------- Links and related bugs: http://appdb.winehq.org/appview.php?versionId=2230 -- Jonathan Ernst <Jonathan(a)ErnstFamily.ch>

2 2

RichEdit flicker
by Phil Krylov 14 Aug '05

14 Aug '05

Hi Krzysztof, I want to change wrapping and painting code to minimize flickering and maximize performance. >From what I see, the following could be done: The paragraph structure should include not MEPF_REWRAP and MEPF_REPAINT flags, but indexes of rows from which to start re-wrapping and repainting (e.g. nStartRewrap and nStartRepaint). The wrapping routine should check if it has actually changed wrapping and set nStartRepaint accordingly. ME_Repaint should not call ME_PaintContent directly. Instead, the wrapping routine (and probably others) should call InvalidateRect for screen areas that need to be repainted. What do you as the author of that code think about my suggestions? Or it's possible that you are working in the same direction, and then it would be silly to implement one thing twice? -- Ph.

1 2

Re: [commdlg] Create interface for path related operations
by Robert Shearman 13 Aug '05

13 Aug '05

Troy Rollo wrote: >This patch creates an interface for path name related operations (including >things such as finding the file name part, extension, identifying the path >separator character, qualifying file names, changing directories, verifying >file existence) used by the file open dialogs that depend on the path being a >Win32 path name, thus making the file dialog code less dependent on the >structure of path names. > >ChangeLog: > Create an interface for path related operations used by the file dialogs > to reduce their dependency on Win32 format paths. > > Why do you want to do that? -- Rob Shearman

2 1

SHGetPathFromIDList problem
by Ge van Geldorp 13 Aug '05

13 Aug '05

Since this patch: http://www.winehq.org/hypermail/wine-cvs/2005/06/0338.html SHGetPathFromIDList() seems broken. The problem is that files stored in the Desktop directory don't get the path to the Desktop directory prepended. I've tried to fix it in the attached patch and added a testcase, but the shell COM interfaces easily confuse me, so perhaps someone with a better understanding of this stuff should look it over before I submit it to wine-patches. Ge van Geldorp. Index: dlls/shell32/pidl.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/pidl.c,v retrieving revision 1.133 diff -u -r1.133 pidl.c --- dlls/shell32/pidl.c 8 Jul 2005 14:18:32 -0000 1.133 +++ dlls/shell32/pidl.c 12 Aug 2005 15:04:05 -0000 @@ -1242,6 +1242,7 @@ BOOL WINAPI SHGetPathFromIDListW(LPCITEMIDLIST pidl, LPWSTR pszPath) { HRESULT hr; + BOOL result; LPCITEMIDLIST pidlLast; LPSHELLFOLDER psfFolder; DWORD dwAttributes; @@ -1258,13 +1259,34 @@ dwAttributes = SFGAO_FILESYSTEM; hr = IShellFolder_GetAttributesOf(psfFolder, 1, &pidlLast, &dwAttributes); - if (FAILED(hr) || !(dwAttributes & SFGAO_FILESYSTEM)) return FALSE; + if (FAILED(hr) || !(dwAttributes & SFGAO_FILESYSTEM)) { + IShellFolder_Release(psfFolder); + ILFree((LPITEMIDLIST) pidlLast); + return FALSE; + } hr = IShellFolder_GetDisplayNameOf(psfFolder, pidlLast, SHGDN_FORPARSING, &strret); - if (FAILED(hr)) return FALSE; - - hr = StrRetToBufW(&strret, pidlLast, pszPath, MAX_PATH); IShellFolder_Release(psfFolder); + if (FAILED(hr)) { + ILFree((LPITEMIDLIST) pidlLast); + return FALSE; + } + + /* Check for a PIDL rooted at desktop level */ + if (_ILIsValue(pidl) || _ILIsFolder(pidl)) { + result = SHGetSpecialFolderPathW(NULL, pszPath, CSIDL_DESKTOPDIRECTORY, FALSE); + if (! result) { + ILFree((LPITEMIDLIST) pidlLast); + return FALSE; + } + PathAddBackslashW(pszPath); + } else { + pszPath[0] = '\0'; + } + + hr = StrRetToBufW(&strret, pidlLast, pszPath + lstrlenW(pszPath), + MAX_PATH - lstrlenW(pszPath)); + ILFree((LPITEMIDLIST) pidlLast); TRACE_(shell)("-- %s, 0x%08lx\n",debugstr_w(pszPath), hr); return SUCCEEDED(hr); Index: dlls/shell32/tests/shlfolder.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/tests/shlfolder.c,v retrieving revision 1.29 diff -u -r1.29 shlfolder.c --- dlls/shell32/tests/shlfolder.c 12 Aug 2005 10:33:37 -0000 1.29 +++ dlls/shell32/tests/shlfolder.c 12 Aug 2005 15:04:06 -0000 @@ -584,6 +584,11 @@ WCHAR wszMyComputer[] = { ':',':','{','2','0','D','0','4','F','E','0','-','3','A','E','A','-','1','0','6','9','-', 'A','2','D','8','-','0','8','0','0','2','B','3','0','3','0','9','D','}',0 }; + WCHAR wszFileName[MAX_PATH]; + LPITEMIDLIST pidlTestFile; + HANDLE hTestFile; + static WCHAR wszTestFile[] = { + 'w','i','n','e','t','e','s','t','.','f','o','o',0 }; if(!pSHGetSpecialFolderPathW) return; @@ -604,15 +609,52 @@ hr = IShellFolder_ParseDisplayName(psfDesktop, NULL, NULL, wszMyComputer, NULL, &pidlMyComputer, NULL); ok (SUCCEEDED(hr), "Desktop's ParseDisplayName failed to parse MyComputer's CLSID! hr = %08lx\n", hr); - IShellFolder_Release(psfDesktop); - if (FAILED(hr)) return; + if (FAILED(hr)) { + IShellFolder_Release(psfDesktop); + return; + } SetLastError(0xdeadbeef); result = SHGetPathFromIDListW(pidlMyComputer, wszPath); ok (!result, "SHGetPathFromIDList succeeded where it shouldn't!\n"); ok (GetLastError()==0xdeadbeef, "SHGetPathFromIDList shouldn't set last error! Last error: %08lx\n", GetLastError()); + if (result) { + IShellFolder_Release(psfDesktop); + return; + } IMalloc_Free(ppM, pidlMyComputer); + + result = pSHGetSpecialFolderPathW(NULL, wszFileName, CSIDL_DESKTOPDIRECTORY, FALSE); + ok(result, "SHGetSpecialFolderPathW failed! Last error: %08lx\n", GetLastError()); + if (!result) { + IShellFolder_Release(psfDesktop); + return; + } + PathAddBackslashW(wszFileName); + lstrcatW(wszFileName, wszTestFile); + hTestFile = CreateFileW(wszFileName, GENERIC_WRITE, 0, NULL, CREATE_NEW, 0, NULL); + ok(hTestFile != INVALID_HANDLE_VALUE, "CreateFileW failed! Last error: %08lx\n", GetLastError()); + if (hTestFile == INVALID_HANDLE_VALUE) { + IShellFolder_Release(psfDesktop); + return; + } + CloseHandle(hTestFile); + + hr = IShellFolder_ParseDisplayName(psfDesktop, NULL, NULL, wszTestFile, NULL, &pidlTestFile, NULL); + ok (SUCCEEDED(hr), "Desktop's ParseDisplayName failed to parse filename hr = %08lx\n", hr); + IShellFolder_Release(psfDesktop); + DeleteFileW(wszFileName); + if (FAILED(hr)) { + IMalloc_Free(ppM, pidlTestFile); + return; + } + + result = SHGetPathFromIDListW(pidlTestFile, wszPath); + ok(result, "SHGetPathFromIDListW failed! Last error: %08lx\n", GetLastError()); + IMalloc_Free(ppM, pidlTestFile); + if (!result) return; + ok(0 == lstrcmpW(wszFileName, wszPath), "SHGetPathFromIDListW returned incorrect path for file placed on desktop\n"); } static void test_EnumObjects_and_CompareIDs(void)

2 1

World of Warcraft
by cyrix12＠cox.net 13 Aug '05

13 Aug '05

It's me again. The latest WoW patch (1.5.1) broke stuff again, and now I'm unable to click on anything outside of menu items in game. The issue seems to be related to camera angle, as I am able to click on items/people when I have my camera positioned just right. It's basically unplayable at the moment though. Anyway, I'd appreciate it if one of the OpenGL/D3D guys (it's most likely something that would be easily fixed by one of you) could take a look at it if they have some free time. Thanks again, Darckness

10 21

Help please
by Fabio Duarte Vilas Boas 13 Aug '05

13 Aug '05

i got a problem with the "wine". when i minimize this program it goes to the corner __________________________________________________ Converse com seus amigos em tempo real com o Yahoo! Messenger http://br.download.yahoo.com/messenger/

1 0