September 2005 - Wine-devel

Re: kernel: Forward Atom APIs to ntdll
by Dmitry Timoshkov 09 Sep '05

09 Sep '05

"James Hawkins" <truiken(a)gmail.com> wrote: > + if (!table) > { > - req->atom = atom; > - req->table = table; > - wine_server_set_reply( req, full_name, sizeof(full_name) ); > - if (!wine_server_call_err( req )) > + ATOM_BASIC_INFORMATION *abi; > + > + size = sizeof(*abi) + MAX_ATOM_LEN * sizeof(WCHAR); > + abi = HeapAlloc(GetProcessHeap(), 0, size); Using HeapAlloc will considerably slowdown the function, you can safely allocate the necessary buffer on the stack. The same for GetAtomNameW. -- Dmitry.

1 0

appdb developers please read
by Ivan Leo Puoti 08 Sep '05

08 Sep '05

Hello, if you look at http://www.winehq.com/pipermail/wine-devel/2005-September/039837.html you'll see there was a project at some point to make a decent patch management system, but apparently due to the complexity of it and Newman being constantly overloaded with work, it never got anywhere, do you guys think it's doable/would you be willing to volunteer to build something of the sort? It would make wine development easier quicker (No more wondering "should I ask Alexandre about that patch? Is it too soon? should I wait a little longer? should I rewrite it? to be or not to be?") and would be great value for the project as it would probably make it easier for new developers to join. Ivan.

5 8

winnt32.exe on AMD64
by Tom Kennedy 08 Sep '05

08 Sep '05

All I have install Wine one an AMD 64 bit system running Redhat 3 update 2. I am trying to run the winnt32.exe prgram and I am getting the following load error. root(a)cert-amd1 ~]# wine "y:\amd64\winnt32.exe" Trying to load PE image for unsupported architecture (Unknown-8664) wine: could not load L"Y:\\amd64\\winnt32.exe" as Win32 binary [root(a)cert-amd1 ~]# I assue the 32 in the name of the executabel means it is a 32 bit binary, but wine is telling me it is not. Any clues as to why I am getting this error message. Thanks. Tom

2 1

Re: DSOUND: tolerate inexact conversion between different frequencies
by Robert Reif 08 Sep '05

08 Sep '05

Alex Villacís Lasso wrote: > During the winealsa tests, I am frequently annoyed by the following: > say, in playing a 11050Hz secondary buffer with an 8000Hz primary > buffer, the number of samples are converted form secondary->primary > and back. In the process, the number of consumed samples in the > secondary buffer drifts by a few frames from the actual value, and > this triggers the warning about "problem with underflow detection". > This patch allows a tolerance of up to 4 bytes before issuing the > message. > > Alex Villacís Lasso Or you could keep track of the round off errors (fractions) like winex does.

1 0

Re: Suggestions for improvement of the emulator
by Juan Lang 08 Sep '05

08 Sep '05

> This of course points to another problem with the existing system - > if a patch has been rejected, it should be a necessary consequence > that the submitter is informed with reasons - they shouldn't have to > be chasing up Alexandre to find out if the patch was rejected or > merely missed (which happens often). (snip) > What is needed is a system that records all patches, together with > their current status (NEW, APPLIED, REJECTED (with reasons), and > whatever other status), informs the submitter of any change, and does > not allow for a patch merely to be forgotten. What this misses is the most common status that causes us all to argue: uncomitted, because Alexandre's not sure about it. Perhaps he has a gut feeling that the approach is not right, but hasn't taken the time to identify any particular flaw. Perhaps it merits additional thought. Perhaps it's too big to review quickly. Perhaps he hopes the submitter will realize it's not up to snuff, and resubmit a better patch. There are probably other reasons, but these all come to mind from my own experience. And no system can appropriately capture that, when the answer is not as clearly defined as one of the above states. This is frustrating, and some people do seem to be put off by it. I have no idea how many potential contributors we lose this way. On the other hand, this is Alexandre's style, and we've all had to get used to it. Any alternative that involves Alexandre doing more work will get summarily rejected--he does a great deal as it is, more I think than any one of us would be willing to do (or perhaps could do). The only credible alternative is a multi-maintainer system. This could allow faster development of some larger features, or more invasive ones, or more exploratory ones. The problem I see with this is one of quality: We have a large code churn rate, and, corresponding with that, a high bug churn rate. That makes regression testing and choosing an appropriate wine version both very difficult. Having multiple maintainers multiplies the number of possible configurations. Yes, I know we could have official releases and the like, but who of us would resist trying out some as-yet-unmerged DX9 patch from Oliver, or experimenting with safedisc? Continuing in that vein, we're all lazy about merging in large patch sets. I'm merging in a fairly large set of changes at the moment, and the slower pace has allowed me to catch issues that may not have surfaced otherwise. Having several competing trees with substantial differences would, in my opinion, reduce the overall quality of the project. So I see a tradeoff between development speed and quality. We may be perceived as having issues with speed, but I think we do pretty well with our small stable of developers. We do have issues with quality, IMHO, so I'd be reluctant to endorse any radical changes. What does seem to work is picking up for Alexandre by reviewing patches on wine-devel, and helping newcomers along. We seem to have picked up a few lately that don't mind the public thrashing :) There does seem to be some more collaborative development going on lately, too. Perhaps we should be more vocal about how we do business, what kind of feedback to expect, and how to get help? --Juan ______________________________________________________ Click here to donate to the Hurricane Katrina relief effort. http://store.yahoo.com/redcross-donate3/

7 7

ShellExecuteExW
by Ge van Geldorp 08 Sep '05

08 Sep '05

This patch: http://www.winehq.org/pipermail/wine-cvs/2005-August/017595.html broke execution of Control Panel items. The cpanel code would concatenate the name of the .cpl file and the display name and pass that in the lpFile member of the SHELLEXECUTEINFO struct. This is solved by passing .cpl in lpFile and display name in lpParameters. I ran into another problem: just before calling the execfunc(), any parameters would be appended to wszApplicationName. Unfortunately, sei_tmp.lpFile points to wszApplicationName at that point, so if the execfunc() fails (e.g. for a .cpl file) sei_tmp.lpFile is messed up. Fixing this allowed one of the todo tests to succeeed. Since looking at/tracing through the ShellExecuteEx code makes me scream in agony every time, I would appreciate a review of the patch below. Ge van Geldorp. Index: dlls/shell32/cpanelfolder.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/cpanelfolder.c,v retrieving revision 1.20 diff -u -r1.20 cpanelfolder.c --- dlls/shell32/cpanelfolder.c 27 Jul 2005 11:10:52 -0000 1.20 +++ dlls/shell32/cpanelfolder.c 8 Sep 2005 21:38:08 -0000 @@ -970,6 +970,7 @@ SHELLEXECUTEINFOW sei_tmp; PIDLCPanelStruct* pcpanel; WCHAR path[MAX_PATH]; + WCHAR params[MAX_PATH]; BOOL ret; int l; @@ -990,12 +991,13 @@ /* pass applet name to Control_RunDLL to distinguish between applets in one .cpl file */ path[l++] = '"'; - path[l++] = ' '; + path[l] = '\0'; - MultiByteToWideChar(CP_ACP, 0, pcpanel->szName+pcpanel->offsDispName, -1, path+l, MAX_PATH); + MultiByteToWideChar(CP_ACP, 0, pcpanel->szName+pcpanel->offsDispName, -1, params, MAX_PATH); memcpy(&sei_tmp, psei, sizeof(sei_tmp)); sei_tmp.lpFile = path; + sei_tmp.lpParameters = params; sei_tmp.fMask &= ~SEE_MASK_INVOKEIDLIST; sei_tmp.lpVerb = wCplopen; Index: dlls/shell32/shlexec.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/shlexec.c,v retrieving revision 1.71 diff -u -r1.71 shlexec.c --- dlls/shell32/shlexec.c 8 Sep 2005 18:54:52 -0000 1.71 +++ dlls/shell32/shlexec.c 8 Sep 2005 21:38:09 -0000 @@ -1263,9 +1263,10 @@ lpFile = wfileName; + strcpyW(wcmd, wszApplicationName); if (sei_tmp.lpParameters[0]) { - strcatW(wszApplicationName, wSpace); - strcatW(wszApplicationName, wszParameters); + strcatW(wcmd, wSpace); + strcatW(wcmd, wszParameters); } /* We set the default to open, and that should generally work. @@ -1273,7 +1274,7 @@ if (!sei_tmp.lpVerb) sei_tmp.lpVerb = wszOpen; - retval = execfunc(wszApplicationName, NULL, FALSE, &sei_tmp, sei); + retval = execfunc(wcmd, NULL, FALSE, &sei_tmp, sei); if (retval > 32) return TRUE; Index: dlls/shell32/tests/shlexec.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/tests/shlexec.c,v retrieving revision 1.5 diff -u -r1.5 shlexec.c --- dlls/shell32/tests/shlexec.c 23 Aug 2005 09:37:30 -0000 1.5 +++ dlls/shell32/tests/shlexec.c 8 Sep 2005 21:38:09 -0000 @@ -704,9 +704,7 @@ okChildInt("argcA", 5); okChildString("argvA3", "Open"); sprintf(filename, "%s\\test file.shlexec", tmpdir); - todo_wine { okChildPath("argvA4", filename); - } sprintf(filename, "%s\\test_shortcut_exe.lnk", tmpdir); rc=shell_execute_ex(SEE_MASK_NOZONECHECKS, NULL, filename, NULL, NULL);

1 0

Spam in wine-announce?
by Anssi Hannula 08 Sep '05

08 Sep '05

This just came in from wine-announce list. -- Anssi Hannula julliard(a)winehq.com wrote: > Warning: This message has had one or more attachments removed > Warning: (document.txt .scr, document.zip). > Warning: Please read the "yoursite-Attachment-Warning.txt" attachment(s) for more information. > > Here are your banks documents. > > > > ------------------------------------------------------------------------ > > This is a message from the MailScanner E-Mail Virus Protection Service > ---------------------------------------------------------------------- > The original e-mail attachment "document.zip" > was believed to be infected by a virus and has been replaced by this warning > message. > > If you wish to receive a copy of the *infected* attachment, please > e-mail helpdesk and include the whole of this message > in your request. Alternatively, you can call them, with > the contents of this message to hand when you call. > > At Thu Sep 8 11:27:12 2005 the virus scanner said: > ClamAV: document.txt .scr contains Worm.Mytob.H-1 > MailScanner: Windows Screensavers are often used to hide viruses (document.txt .scr) > > Note to Help Desk: Look on the yoursite MailScanner in /var/spool/MailScanner/quarantine/20050908 (message j88GR1Ks012044).

3 2

Need ideas about ntoskrnl
by Vitaliy Margolen 08 Sep '05

08 Sep '05

We need ntoskrnl to run some subset of drivers on wine. Notably cd protection drivers. They are not a hardware drivers, but a means to access something that is not accessible from user space. So in a sense ntoskrnl is just a process to run those drivers in, and send/receive requests to/from those drivers. You need to keep in mind that this is a kernel level, so some things will not work, and some things have to work that normally do not in the user space. Also ntoskrnl for windows _is_ what wineserver for wine. User space programs talk to these drivers in the following way: 1. At the start up, driver creates symbolic link in "\DosDevices\something". 2. Program calls CreateFile("\\.\something",..) to get a handle to the device. 3. Uses ReadFile/WriteFile/DeviceIoControl on that handle. (For now we need only DeviceIoControl. Read/Write could be added later.) Here is a list of the most pressing problem and the way to solve them. Any ideas and comments will be greatly appreciated, Vitaliy. Problems: 1. Open handle to a device - NtCreateFile. 2. Call DeviceIoControl on a device. (This also includes (1) since we need to know that this is not a cdrom, vxd or something else.) 3. Resolve user space handle to the DEVICE_OBJECT. (Assuming that we don't call ntoskrnl through wineserver). Solutions for (1): 1.1. Use a hack to determine that passed name is a device name. (Device names don't have colon in them). 1.2. Check against all possible names other then device names. (A:..Z:, etc.) 1.3. Try it last if all else fails. (since name spaces don't intersect this should work.) 1.4. Use object manager to lookup the name to find out what is it. (Unless we open all handles using this method it will add one extra wineserver call.) Solutions for (2): ntdll->ntoskrnl 2.1. Use named pipe to communicate with ntoskrnl process. Pass commands over the pipe in internal format. 2.2. Use UNIX IPC to talk to ntoskrnl. (pipe, socket, etc.) ntdll->wineserver->ntoskrnl 2.3. Call wineserver which will call ntoskrnl using 2.1. or 2.2. 2.4. Call wineserver which will call ntoskrnl using proper IoXXX functions from ntoskrnl to create an IRP. ntoskrnl will process them and notify wineserver when call is complete. (This is the most complicated and closer represents what windows does. There are still a problem communicating to ntoskrnl. It is probably the way to go in the future. But that will require number of things implemented which are not trivial.) Solutions for (2): MSDN quote: "Note that handles are not used for accessing device objects or driver objects." 3.1. Use wineserver to resolve handle to some internal identifier and pass it to ntoskrnl. 3.2. Pass handle and calling process id (pid, global handle, etc.) to ntoskrnl. ntoskrnl will call wineserver to resolve handle to internal id. (This handle will have to be either cached, or it will have to be created for every call.) 3.3. (requires 2.3. or 2.4.) Wineserver will resolve handle and pass internal id to ntoskrnl. (Unless we want wineserver do much more than that.)

14 31

wineserver keeps running after wine exits
by ivan vadovič 08 Sep '05

08 Sep '05

Hi, This is what's going on using wine-20050725 and 20050830 under gentoo: $ ls -l user.reg; wine winecfg; ls -l user.reg # winecfg did some changes ... 7517 Sep 2 16:00 user.reg ... 7517 Sep 2 16:00 user.reg $ sleep 5 $ ls -l user.reg ... 7629 Sep 2 16:13 user.reg So, wine exits, but wineserver keeps running and finishes a second or two later. As a result it rewrites the config files AFTER the command completion. That confuses scripts reading and manipulating the registers. Well, it confuses wine too, if I try to run wine immediately after exiting wine. Is that on purpose? Is there any workaround? Am I doing something wrong here? Ivan

2 1

Re: hhctrl: Load the default Url in the HTML Pane
by Jacek Caban 08 Sep '05

08 Sep '05

Hello. James Hawkins wrote: >Hi, > >Changelog >* Add the WebBrowser implementation. >* Load the default Url in the HTML Pane. > > ... >+static HRESULT STDMETHODCALLTYPE UI_ShowContextMenu(IDocHostUIHandler *iface, DWORD dwID, POINT __RPC_FAR *ppt, IUnknown __RPC_FAR *pcmdtReserved, IDispatch __RPC_FAR *pdispReserved) > > You don't need to add __RPC_FAR here. Same in few other places. >+BOOL WB_EmbedBrowser(WBInfo *pWBInfo, HWND hwndParent) >+{ >+ IOleClientSiteImpl *iOleClientSiteImpl; >+ IOleObject *browserObject; >+ IWebBrowser2 *webBrowser2; >+ HRESULT hr; >+ RECT rc; >+ >+ static const WCHAR hostNameW[] = {'H','o','s','t',' ','N','a','m','e',0}; >+ >+ iOleClientSiteImpl = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, >+ sizeof(IOleClientSiteImpl)); >+ if (!iOleClientSiteImpl) >+ return FALSE; >+ >+ iOleClientSiteImpl->ref = 0; >+ iOleClientSiteImpl->lpVtbl = &MyIOleClientSiteTable; >+ iOleClientSiteImpl->lpvtblOleInPlaceSite = &MyIOleInPlaceSiteTable; >+ iOleClientSiteImpl->lpvtblOleInPlaceFrame = &MyIOleInPlaceFrameTable; >+ iOleClientSiteImpl->hwndWindow = hwndParent; >+ iOleClientSiteImpl->lpvtblDocHostUIHandler = &MyIDocHostUIHandlerTable; >+ >+ hr = OleCreate(&CLSID_WebBrowser, &IID_IOleObject, OLERENDER_DRAW, 0, >+ (IOleClientSite *)iOleClientSiteImpl, &MyIStorage, >+ (void **)&browserObject); >+ if (FAILED(hr)) goto error; >+ >+ /* make the browser object accessible to the IOleClientSite implementation */ >+ iOleClientSiteImpl->pBrowserObject = browserObject; >+ IOleObject_SetHostNames(browserObject, hostNameW, 0); >+ >+ GetClientRect(hwndParent, &rc); >+ >+ hr = OleSetContainedObject((struct IUnknown *)browserObject, TRUE); >+ if (FAILED(hr)) goto error; >+ >+ hr = OleSetContainedObject((struct IUnknown *)browserObject, TRUE); >+ if (FAILED(hr)) goto error; > > Why do you call OleSetContainedObject twice? >+ >+ hr = IOleObject_DoVerb(browserObject, OLEIVERB_SHOW, NULL, >+ (IOleClientSite *)iOleClientSiteImpl, >+ -1, hwndParent, &rc); >+ if (FAILED(hr)) goto error; >+ >+ >+ hr = IOleObject_QueryInterface(browserObject, &IID_IWebBrowser2, >+ (void **)&webBrowser2); >+ if (SUCCEEDED(hr)) >+ { >+ IWebBrowser2_put_Left(webBrowser2, 0); >+ IWebBrowser2_put_Top(webBrowser2, 0); >+ IWebBrowser2_put_Width(webBrowser2, rc.right); >+ IWebBrowser2_put_Height(webBrowser2, rc.bottom); >+ >+ pWBInfo->pOleClientSite = (IOleClientSite *)iOleClientSiteImpl; >+ pWBInfo->pBrowserObject = browserObject; >+ pWBInfo->pWebBrowser2 = webBrowser2; >+ pWBInfo->hwndParent = hwndParent; >+ >+ return TRUE; >+ } >+ >+error: >+ WB_UnEmbedBrowser(pWBInfo); >+ >+ if (webBrowser2) >+ IWebBrowser2_Release(webBrowser2); >+ >+ HeapFree(GetProcessHeap(), 0, iOleClientSiteImpl); >+ >+ return FALSE; >+} >+ > ... >+ >+BOOL WB_Navigate(WBInfo *pWBInfo, LPCWSTR szUrl) >+{ >+ IWebBrowser2 *pWebBrowser2 = pWBInfo->pWebBrowser2; >+ VARIANT myURL; >+ >+ if (!pWebBrowser2) >+ return FALSE; >+ >+ VariantInit(&myURL); >+ myURL.n1.n2.vt = VT_BSTR; >+ >+ myURL.n1.n2.n3.bstrVal = SysAllocString(szUrl); > > It's better to use macros to use VARIANT type: V_VT(&myURL) = VT_BSTR; V_BSTR(&myURL) =SysAllocString(szUrl); >+ >+ if (!myURL.n1.n2.n3.bstrVal) >+ return FALSE; >+ >+ IWebBrowser2_Navigate2(pWebBrowser2, &myURL, 0, 0, 0, 0); >+ VariantClear(&myURL); >+ >+ return TRUE; >+} >+ > > Jacek

1 0