January 2006 - Wine-devel - list.winehq.org

Unixfs as ShellFSFolder?
by Michael Jung 18 Jan '06

18 Jan '06

Hi all, I guess I'm responsible for a lot of redundant code between the implementations of filesystem shellfolders in shell32/shlfdr_fs.c and shfldr_unixfs.c. While I've always tried to re-use as much code as possible, unixfs by nature has to use posix apis to get hold of the unix filesystem. In current cvs, unixfs can be used as a drop-in replacement for the old CLSID_ShellFSFolder implementation and if you apply the attached small patch, it will be. It would be nice if some people could try this in their local tree and report problems with it. What do people think about getting rid of shfldr_fs.c in the long run, in order to remove the redundancy? Does ReactOS use wine's shell32.dll? I guess it would be a problem for them? ChangeLog: shell32: Use shfldr_unixfs CLSID_ShellFSFolder implementation instead of the one from shfldr_fs dlls/shell32/shellole.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

2 2

HW address w/o connection in iphlpapi
by most＠museresearch.com 18 Jan '06

18 Jan '06

We ran into an obscure problem with iphlpapi that I'd like to get help with. When you boot a linux box without an ethernet connection, and eth0 configuration fails, GetAdaptersInfo does not return MAC address info for eth0. The problem seems to be that enumerateInterfaces (in dlls/iphlpapi/ifenum.c) doesn't create a record for eth0, because SIOCGIFCONF doesn't return one. Then when GetAdaptersInfo (in dlls/iphlpapi/iphlpapi_main.c) is looping through the interfaces, eth0 isn't there so it doesn't call getInterfacePhysicalByIndex to get the MAC address. I verified that if I hack an eth0 entry into the table built by enumerateInterfaces, the call to getInterfacePhysicalByIndex works just fine. So the problem is simply a disconnect between what enumerateInterfaces is scanning and what GetAdaptersInfo is trying to scan. Near as I can tell (and I am no networking guru by any stretch) GetAdaptersInfo is supposed to return MAC info for eth0, even if eth0 has no IP address. Near as I can tell too Windows does return MAC info in this situation. So this looks, again near as I can tell %), like a Wine bug. Is it a wine bug? Any suggestions for a fix? ... mo PS: I cc'd Juan Lang who is noted as the author of the code. I hope that isn't bad etiquette...?

2 3

winspool/tests: a Space before the printername is invalid
by Detlef Riekenberg 17 Jan '06

17 Jan '06

Am Dienstag, den 17.01.2006, 13:08 -0600 schrieb Wine Bugs: > ------- Additional Comments From michal.okresa(a)ifne.sk 2006-17-01 13:08 ------- > And to make it complete, space before printer name in customized printing dialog > is still present. > (mayby small bug in ISS?) This Patch validates, that the failure of OpenPrinter is not a wine Problem. Win9x: ERROR_INVALID_PARAMETER WinNT: ERROR_INVALID_PRINTER_NAME Changelog: - winspool/tests: a Space before the printername is invalid -- By By ... ... Detlef

1 0

TaxAct 2005 file problem
by James E. LaBarre 17 Jan '06

17 Jan '06

As usual, this year's version of TaxAct has the same defect (or programming screw-up) it's had for years now that prevents it from being usable under Wine. The app installs fine, and will start to run as if it was sufficiently compatible with Wine. The problem with TA is that it *always* tries to first load a default data file (even if you give it a different filename as a command parameter), and the default filename is "2005 Tax Return File.ta5". It seems they are using a faulty or non-standard method of calling the default data file, as it will put up an error dialogue that it was unable to find it's default file, after which it exits. The specific message, captured by running a +msgbox debug switch is: ================================== 1729146:0009:Call kernel32.lstrlenA(7e0a2ea0 "Unable to open \"2005 Tax Return File.ta5\".\n\nPlease verify that C:\\Apps\\TaxACT2005\\2005 Tax Return File.ta5 exists on your hard drive, if it does not you will need to reinstall TaxACT.") ================================== I have a full "WINEDEBUG=+relay,+msgbox" capture of the programme run till failure & exit, but it's 117M uncompressed (1.4M bz2 file). The app is also available as a free "standard" version (in fact, that's what I'm working with); the Deluxe version is merely an unlock code for the free download. https://www.taxact.com/s_taxact/free_taxact.asp?where=Register&product_id=0 5STDW&ad=0&s=Y&sc=051200003 I had tried doing a WINEDLLOVERRIDE for shlwapi, ntdll & kernel32 (various combinations) as these seemed to be the major dlls being loaded. But no success there. Please email me if you'd like more info from the debug file, or the file itself. Not being a developer, I don't frequent this list (just the wine-users list).

1 0

[rpcrt4] Properly created named pipes
by Thomas Weidenmueller 17 Jan '06

17 Jan '06

Created the named pipes with the FILE_FLAG_OVERLAPPED flag, otherwise the call to ConnectNamedPipe() will block the server thread if no connection can be established, which causes the rpc server to dead-lock during startup. - Thomas -- P.S.: Please let me know if there's something wrong with this patch or tell me why it was rejected. Otherwise I'm going to assume the fixes aren't appreciated or necessary because the implementation is considered mature and stable. Index: dlls/rpcrt4/rpc_binding.c =================================================================== RCS file: /home/wine/wine/dlls/rpcrt4/rpc_binding.c,v retrieving revision 1.39 diff -u -r1.39 rpc_binding.c --- dlls/rpcrt4/rpc_binding.c 6 Sep 2005 10:26:14 -0000 1.39 +++ dlls/rpcrt4/rpc_binding.c 16 Jan 2006 23:00:15 -0000 @@ -142,7 +142,7 @@ pname = HeapAlloc(GetProcessHeap(), 0, strlen(prefix) + strlen(Connection->Endpoint) + 1); strcat(strcpy(pname, prefix), Connection->Endpoint); TRACE("listening on %s\n", pname); - Connection->conn = CreateNamedPipeA(pname, PIPE_ACCESS_DUPLEX, + Connection->conn = CreateNamedPipeA(pname, PIPE_ACCESS_DUPLEX | FILE_FLAG_OVERLAPPED, PIPE_TYPE_MESSAGE | PIPE_READMODE_MESSAGE, PIPE_UNLIMITED_INSTANCES, RPC_MAX_PACKET_SIZE, RPC_MAX_PACKET_SIZE, 5000, NULL); HeapFree(GetProcessHeap(), 0, pname); @@ -166,7 +166,7 @@ pname = HeapAlloc(GetProcessHeap(), 0, strlen(prefix) + strlen(Connection->Endpoint) + 1); strcat(strcpy(pname, prefix), Connection->Endpoint); TRACE("listening on %s\n", pname); - Connection->conn = CreateNamedPipeA(pname, PIPE_ACCESS_DUPLEX, + Connection->conn = CreateNamedPipeA(pname, PIPE_ACCESS_DUPLEX | FILE_FLAG_OVERLAPPED, PIPE_TYPE_MESSAGE | PIPE_READMODE_MESSAGE | PIPE_WAIT, PIPE_UNLIMITED_INSTANCES, RPC_MAX_PACKET_SIZE, RPC_MAX_PACKET_SIZE, 5000, NULL); HeapFree(GetProcessHeap(), 0, pname);

2 5

dlls/wined3d/device.c GetCreationParameters
by Al Tobey 17 Jan '06

17 Jan '06

I'd just post to wine-patches, but I think this needs another set of eyes. According to MSDN, this just sets a pointer to the creation parameters. The attached patch makes this function work, but I'm not sure if returning a pointer to the original parameters is the right approach or if they should be copied first. This patch makes a bunch of the Ogre3d demos work, which are great for testing since you can run the same demo in OpenGL, D3D9, and D3D7 modes. http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/directx9_c… http://www.ogre3d.org/index.php?option=com_remository&Itemid=57&func=select… http://easynews.dl.sourceforge.net/sourceforge/ogre/OgreDemos-1.0.4.zip I'm currently playing with compiling Ogre3d against winelib and finding it's shaking out a bunch of missing stuff in d3d9 - patches may follow. -Al Tobey

6 15

Re: WINED3D: [02/02] IWineD3DSurfaceImpl_SetContainer & IWineD3DVolumeImpl_SetContainer refcount fixes.
by H. Verbeet 17 Jan '06

17 Jan '06

What is wrong with this patch / what can I do to fix it?

1 0

Re: More implementation of IRecordInfo
by Dan Kegel 17 Jan '06

17 Jan '06

In March 2005, in message http://www.winehq.com/hypermail/wine-patches/2005/03/0155.html, jacek wrote: > This patch makes IRecordInfo almost complete. > If anyone knows any application using it I could test on, > please let me know. The freely downloadable app TTQV4 fails at the moment; one of the last messages is fixme:ole:IRecordInfoImpl_IsMatchingType (0x7c729280)->(0x7bd04210) stub I think that's in the code you were asking for test cases for... I ran into this on wine-users: http://www.winehq.org/pipermail/wine-users/2006-January/020161.html Here's the text of that message. - Dan ---------- Forwarded message ---------- From: Dan Kegel <dank(a)kegel.com> Date: Jan 12, 2006 10:47 PM Subject: Re: could not load ... as Win32 binary To: wine-users(a)winehq.com, postit(a)weiglwelt.de > > I am using Debian (Etch) und wine 0.9.5-winehq-1. > > When I try to install a Program the installation routine hangs ... > > ... In December it worked already. Now it doesn't any more (after a apt-get > > upgrade with many, many packages). > [The app is] TTQV4 (a GPS and Navigation software) see > http://www.ttqv.de/main.php?content=14 and > http://www.ttqv.de/main.php?content=21&download=13 With a fresh copy of wine from cvs, it installed fine once I copied msvc40.dll into windows/system32. The app started ok, too, but died after putting up the main window, complaining about a type mismatch. It'd probably work better with native COM libraries, but I don't have time to try that right now. For the record, the last two lines on the console were fixme:ole:MSFT_ReadValue BSTR length = -1? fixme:ole:IRecordInfoImpl_IsMatchingType (0x7c729280)->(0x7bd04210) stub ... -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

winspool: What can I do to get my Patches into CVS?
by Detlef Riekenberg 16 Jan '06

16 Jan '06

Hi. What can I do to get my Patches into CVS? 2006.01.07: http://www.winehq.org/pipermail/wine-patches/2006-January/023276.html Changelog: - winspool/tests: filter more results 2006.01.08: http://www.winehq.org/pipermail/wine-patches/2006-January/023284.html Changelog: - kernel/tests: report only 99 failures on WinNT 3.51 2006.01.13: http://www.winehq.org/pipermail/wine-patches/2006-January/023420.html Changelog: - Add Function "validate_envW" to validate the user-supplied Printing Environment (respect "Windows Version" - Setting) - Change GetPrinterDriverDirectoryW on top of "validate_envW" to Report the same Path as NT does - 2 Tests are now working in Wine Synced to current git-version with suggestions from Alexandre: Do not compare every allowed Value, use a loop Do not check for "Windows 4.0"-Only on Win9x. 2006.01.13: http://www.winehq.org/pipermail/wine-patches/2006-January/023430.html Changelog: - winspool: added a comment how to add printers from /etc/printcap to wine (registry section: "PPD Files") 2006.01.14: http://www.winehq.org/pipermail/wine-patches/2006-January/023436.html updated after comments from Huw Changelog: - winspool: updated some traces for bug 4268 (when loading the System-Printers) -- By By ... ... Detlef

1 0

[rpcrt4] Properly created named pipes
by Thomas Weidenmueller 16 Jan '06

16 Jan '06

Created the named pipes with the FILE_FLAG_OVERLAPPED flag, otherwise the call to ConnectNamedPipe() will block the server thread if no connection can be established, which causes the rpc server to dead-lock during startup. - Thomas Index: dlls/rpcrt4/rpc_binding.c =================================================================== RCS file: /home/wine/wine/dlls/rpcrt4/rpc_binding.c,v retrieving revision 1.39 diff -u -r1.39 rpc_binding.c --- dlls/rpcrt4/rpc_binding.c 6 Sep 2005 10:26:14 -0000 1.39 +++ dlls/rpcrt4/rpc_binding.c 16 Jan 2006 23:00:15 -0000 @@ -142,7 +142,7 @@ pname = HeapAlloc(GetProcessHeap(), 0, strlen(prefix) + strlen(Connection->Endpoint) + 1); strcat(strcpy(pname, prefix), Connection->Endpoint); TRACE("listening on %s\n", pname); - Connection->conn = CreateNamedPipeA(pname, PIPE_ACCESS_DUPLEX, + Connection->conn = CreateNamedPipeA(pname, PIPE_ACCESS_DUPLEX | FILE_FLAG_OVERLAPPED, PIPE_TYPE_MESSAGE | PIPE_READMODE_MESSAGE, PIPE_UNLIMITED_INSTANCES, RPC_MAX_PACKET_SIZE, RPC_MAX_PACKET_SIZE, 5000, NULL); HeapFree(GetProcessHeap(), 0, pname); @@ -166,7 +166,7 @@ pname = HeapAlloc(GetProcessHeap(), 0, strlen(prefix) + strlen(Connection->Endpoint) + 1); strcat(strcpy(pname, prefix), Connection->Endpoint); TRACE("listening on %s\n", pname); - Connection->conn = CreateNamedPipeA(pname, PIPE_ACCESS_DUPLEX, + Connection->conn = CreateNamedPipeA(pname, PIPE_ACCESS_DUPLEX | FILE_FLAG_OVERLAPPED, PIPE_TYPE_MESSAGE | PIPE_READMODE_MESSAGE | PIPE_WAIT, PIPE_UNLIMITED_INSTANCES, RPC_MAX_PACKET_SIZE, RPC_MAX_PACKET_SIZE, 5000, NULL); HeapFree(GetProcessHeap(), 0, pname);

1 0