January 2006 - Wine-devel - list.winehq.org

Re: RESEND: winecfg: Added "Use PRIMARY selection" option
by Alexandre Julliard 10 Jan '06

10 Jan '06

Phil Krylov <phil(a)newstar.rinet.ru> writes: > ChangeLog: > > Added support for "Use PRIMARY selection" clipboard option. I don't think we want a new property sheet page for that, it should go with the other X11 options. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: WineDbg: Implemented harware assisted breakpoints.
by Eric Pouech 10 Jan '06

10 Jan '06

Eric Pouech wrote: > one can now set a hardware breakpoint in winedbg (it will not insert an > INT 3 command in the code, but rather use the x86 debug registers). > handy for debugging trashed code for example > > all the syntaxic forms of the 'break' command can be used for this new > hbreak command. > (only works on x86 for now) > > ChangeLog: > Implemented harware assisted breakpoints > merci de ne pas appliquer tel quel. J'ai une nouvelle version moins buggée. A+ -- Eric Pouech

1 0

RFC: implementation of driver functionality in msacm (RESEND)
by Alex Villacís Lasso 10 Jan '06

10 Jan '06

(resent because previous attempt never appeared in wine-devel) This patch is the preliminary result of some work I have been doing in order to add missing functionality to builtin msacm32.dll. I am submitting this to wine-devel rather than wine-patches, and in one big patch rather than several because I would like comments on some choices I made while adding features. The following is the list of features added by the patch: * Implementation of acmDriverAddW(), and delegation of acmDriverAddA() to acmDriverAddW() * Working implementation of modes of operation of acmDriverAdd[AW]: add driver by new registry entry (ACM_DRIVERADDF_NAME), add (local) driver by combination of hModule/acmDriverProc (ACM_DRIVERADDF_FUNCTION), add notification window for event broadcasts (ACM_DRIVERADDF_NOTIFYHWND) * Implementation of broadcasts to notification windows on driver add/remove, enabling/disabling, and priority changes * Fix for implementation quirks of acmDriverMessage() in order to allow native codecs to display configuration dialogs * Working implementation of acmDriverPriority(), with support of delayed notification broadcasts (for one process only). Includes saving new priorities and enabled status to registry * Loading of codec priorities and enabled status from registry * Support for ACM_METRIC_DRIVER_SUPPORT in acmMetrics() I must note that in order to provide support for acmDriverAddW() in ACM_DRIVERADDF_FUNCTION mode, it is necessary to treat an application-supplied module with an application-supplied driverProc as a full-blown winmm driver. Therefore, the patch includes a new procedure in winmm called wineAddDriver(), that instructs winmm to build a hDrvr from a supplied hModule/driverProc pair, rather than loading both from a DLL, as OpenDriver() does. This allows the rest of the code to continue using SendDriverMessage() as usual. Alex Villacís Lasso

2 2

Starter projects for new Wine contributors?
by Dan Kegel 10 Jan '06

10 Jan '06

Hi all! I'm looking for suggestions for starter projects for new contributors that would take something like a week to do, and wouldn't require much knowledge of Wine ahead of time. http://wiki.winehq.org/TodoList is the place we've gathered that stuff, but nothing there really grabs me. I suppose the tasks http://wiki.winehq.org/CrossCallsWtoA http://wiki.winehq.org/ConstifyData http://wiki.winehq.org/SpecDiscrepencies might qualify. Do they still need doing? http://winehq.org/site/fun_projects has some cool stuff on it, particularly the idea of using Mono's libgdiplus to implement gdi+ in Wine. (That's probably more than a week's worth of work, though.) http://wiki.winehq.org/SummerOfCode has very cool stuff in it, but that's all about 100x times harder than what I'm looking for. And then there's riched20. It's missing quite a few little features; see the 11 open bugs here: http://bugs.winehq.org/buglist.cgi?product=Wine&component=wine-richedit&bug… Might some of those be doable in a couple days? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

5 4

static COM VTables?
by Stefan Dösinger 10 Jan '06

10 Jan '06

Hello, I just read the "constify data" todo, and I thought it would be good to make the VTables in my ddraw implementation const. The old ddraw implementation also declares them static. Is there any advantage in it? My C book just says that they can only be referenced from the local module, which is correct. But are there any other effects? Stefan

2 1

RFC: implementation of driver functionality in msacm
by Alex Villacís Lasso 10 Jan '06

10 Jan '06

This patch is the preliminary result of some work I have been doing in order to add missing functionality to builtin msacm32.dll. I am submitting this to wine-devel rather than wine-patches, and in one big patch rather than several because I would like comments on some choices I made while adding features. The following is the list of features added by the patch: * Implementation of acmDriverAddW(), and delegation of acmDriverAddA() to acmDriverAddW() * Working implementation of modes of operation of acmDriverAdd[AW]: add driver by new registry entry (ACM_DRIVERADDF_NAME), add (local) driver by combination of hModule/acmDriverProc (ACM_DRIVERADDF_FUNCTION), add notification window for event broadcasts (ACM_DRIVERADDF_NOTIFYHWND) * Implementation of broadcasts to notification windows on driver add/remove, enabling/disabling, and priority changes * Fix for implementation quirks of acmDriverMessage() in order to allow native codecs to display configuration dialogs * Working implementation of acmDriverPriority(), with support of delayed notification broadcasts (for one process only). Includes saving new priorities and enabled status to registry * Loading of codec priorities and enabled status from registry * Support for ACM_METRIC_DRIVER_SUPPORT in acmMetrics() I must note that in order to provide support for acmDriverAddW() in ACM_DRIVERADDF_FUNCTION mode, it is necessary to treat an application-supplied module with an application-supplied driverProc as a full-blown winmm driver. Therefore, the patch includes a new procedure in winmm called wineAddDriver(), that instructs winmm to build a hDrvr from a supplied hModule/driverProc pair, rather than loading both from a DLL, as OpenDriver() does. This allows the rest of the code to continue using SendDriverMessage() as usual. Alex Villacís Lasso

1 0

test exploit for WMF / SETABORTPROC vulnerability
by Marcus Meissner 10 Jan '06

10 Jan '06

Hi, If someone needs an exploit for the WMF / SETABORTPROC vulnerability that works under WINE (<0.9.5) to verify fixed packages, feel free to mail me offline. Ciao, Marcus

1 0

Re: COMCTL32: Invalidate the entire progress bar any time it changes.
by Dmitry Timoshkov 10 Jan '06

10 Jan '06

"Mike McCormack" <mike(a)codeweavers.com> wrote: > This is an old patch, but the code that is in comctl32 now is wrong. > This fixes it, and there's no known regressions. Unfortunately there's > no way to fix this "efficiently". > > Mike > > > ChangeLog: > Invalidate the entire progress bar any time it changes. > Fixes the progress bar so it paints properly in InstallShield. My (old) tests show that native comctl32 invalidates the entire progress bar once it changes, so that change is OK. But it's smart enough to not invalidate the background if new bar position is larger than an old one, that reduces the flicker. -- Dmitry.

1 0

Loader Optimization Benchmarks
by Robert Shearman 10 Jan '06

10 Jan '06

Hi, I thought it would be good to post some benchmarks for the patch I just sent to wine-patches: http://www.winehq.org/pipermail/wine-patches/2006-January/023323.html I tested the loader code using the following in both cases: int i; DWORD dwTicksAfter; DWORD dwTicksBefore = GetTickCount(); for (i = 0; i < 1000; i++) LoadLibrary("ole32"); dwTicksAfter = GetTickCount(); trace("time taken = %ld ms\n", dwTicksAfter - dwTicksBefore); Before the patch: time taken = 658 ms time taken = 661 ms time taken = 661 ms time taken = 658 ms time taken = 659 ms After the patch was applied: time taken = 12 ms time taken = 12 ms time taken = 12 ms time taken = 13 ms time taken = 12 ms So it should be obvious that there are some very real gains from using this patch in the test case. You might think that an application loading a DLL 1000 times is very unlikely, but bear in mind that the ole32 marshal tests load ole32 76 times. It is therefore conceivable that something more complex like InstallShield could load ole32 over 100 times. -- Rob Shearman

1 0

(no subject)
by Curro Amores 10 Jan '06

10 Jan '06

I get this error when trying to install j2se with wine, i think is has something to do with windows installer, but ihave installed InstMSIA.exe manually with wine ( i dont get any error or see any installation box with "wine InstMSI.exe"). Has somebody tried to install JAva with wine? This is the output WINEDBG=+loaddll wine jdk-1_5_0_06-windows-i586-p.exe wine: Unhandled page fault on read access to 0x80002b1c at address 0x4d5d5b (thread 000c), starting debugger... WineDbg starting on pid 0x9 Unhandled exception: page fault on read access to 0x80002b1c in 32-bit code (0x004d5d5b). In 32 bit mode. Register dump: CS:0073 SS:007b DS:007b ES:007b FS:1007 GS:0033 EIP:004d5d5b ESP:7fc8fd24 EBP:7fc8fd64 EFLAGS:00010282( - 00 - RIS1) EAX:00000009 EBX:00000000 ECX:80002b08 EDX:0000000c ESI:80002b08 EDI:00000000 Stack dump: 0x7fc8fd24: 00000048 004d5b8f 00000000 004d17c6 0x7fc8fd34: 7fec0b40 004d15a4 00bfd1b0 00911f7c 0x7fc8fd44: 7fc8fd64 00911fa2 7fc8fd34 7fc8f8e0 0x7fc8fd54: 7fc8ff2c 004d53e8 00514a70 ffffffff 0x7fc8fd64: 7fc8fd84 00bcc611 004d0000 00000001 0x7fc8fd74: 00000001 00000001 00000001 00bfd1b0 0200: sel=1007 base=7befc000 limit=00001fff 32-bit rw- Backtrace: =>1 0x004d5d5b in rpcrt4 (+0x5d5b) (0x004d5d5b) 2 0x00bcc611 call_dll_entry_point+0x15 in ntdll (0x00bcc611) 3 0x00bcd252 MODULE_InitDLL+0x12a [/home/curro/WineHQrpm/wine-0.9.5/dlls/ntdll/loader.c:816] in ntdll (0x00bcd252) 4 0x00bcda98 process_attach+0x98 [/home/curro/WineHQrpm/wine-0.9.5/dlls/ntdll/loader.c:891] in ntdll (0x00bcda98) 5 0x00bcda6e process_attach+0x6e [/home/curro/WineHQrpm/wine-0.9.5/dlls/ntdll/loader.c:883] in ntdll (0x00bcda6e) 6 0x00bcda6e process_attach+0x6e [/home/curro/WineHQrpm/wine-0.9.5/dlls/ntdll/loader.c:883] in ntdll (0x00bcda6e) 7 0x00bcfe19 LdrInitializeThunk+0x319(main_file=0x0, unknown2=0x0, unknown3=0x0, unknown4=0x0) [/home/curro/WineHQrpm/wine-0.9.5/dlls/ntdll/loader.c:2001] in ntdll (0x00bcfe19) 8 0x005eff1f start_process+0x8b(arg=0x0) [/home/curro/WineHQrpm/wine-0.9.5/dlls/kernel/process.c:1017] in kernel32 (0x005eff1f) 9 0x0033185b _IO_vfprintf_internal in libc.so.6 (0x0033185b) 0x004d5d5b: cmpl 0x14(%esi),%eax Modules: Module Address Debug info Name (43 modules) ELF 0x0025f000-00299000 Deferred advapi32<elf> \-PE 0x00270000-00299000 \ advapi32 ELF 0x002c8000-002cd000 Deferred libxxf86vm.so.1 ELF 0x002d2000-002ee000 Deferred ld-linux.so.2 ELF 0x002ee000-0031c000 Deferred libfontconfig.so.1 ELF 0x002ee000-0031c000 Deferred libfontconfig.so.1 ELF 0x002f4000-0041e000 Export libc.so.6 ELF 0x00346000-0043c000 Deferred libwine_unicode.so.1 ELF 0x00420000-00426000 Deferred libxxf86dga.so.1 ELF 0x00420000-00426000 Deferred libxxf86dga.so.1 ELF 0x00446000-0044a000 Deferred libdl.so.2 ELF 0x0044a000-004cb000 Deferred gdi32<elf> \-PE 0x0044c000-0045f000 \ libz.so.1 \-PE 0x00460000-004cb000 \ gdi32 \-PE 0x00460000-004cb000 \ gdi32 PE 0x004d0000-00522000 Deferred rpcrt4 ELF 0x00537000-00549000 Deferred libpthread.so.0 ELF 0x0054b000-0055a000 Deferred libxext.so.6 ELF 0x0055c000-00565000 Deferred libsm.so.6 ELF 0x00567000-00581000 Deferred libice.so.6 ELF 0x00583000-005a2000 Deferred libexpat.so.0 ELF 0x00583000-005a2000 Deferred libexpat.so.0 PE 0x005b0000-0067e000 DIA kernel32 PE 0x005b0000-0067e000 DIA kernel32 PE 0x005b0000-0067e000 DIA kernel32 PE 0x00680000-0086c000 Deferred msi ELF 0x0086c000-0097a000 Deferred user32<elf> \-PE 0x00890000-0097a000 \ user32 \-PE 0x00890000-0097a000 \ user32 ELF 0x00975000-009f0000 Deferred libgl.so.1 ELF 0x00975000-009f0000 Deferred libgl.so.1 PE 0x009f0000-00a59000 Deferred winex11 ELF 0x00b2d000-00b4c000 Deferred ximcp.so.2 ELF 0x00b4c000-00b67000 Deferred imm32<elf> \-PE 0x00b50000-00b67000 \ imm32 ELF 0x00b99000-00c09000 Stabs ntdll<elf> \-PE 0x00bb0000-00c09000 \ ntdll ELF 0x00ea3000-00ea5000 Deferred xlcutf8load.so.2 ELF 0x00ef1000-00f07000 Deferred msiexec<elf> \-PE 0x00f00000-00f07000 \ msiexec ELF 0x00fed000-00ff8000 Deferred libnss_files.so.2 PE 0x65f00000-65fc2000 Deferred ole32 ELF 0x7bf00000-7bf03000 Deferred <wine-loader> Threads: process tid prio (all id:s are in hex) 00000009 (D) C:\windows\system32\MSIEXEC.EXE 0000000c 0 <== 00000047 00000008 0 0000001e 00000026 2 0000001f 0 WineDbg terminated on pid 0x9

4 4