January 2006 - Wine-devel - list.winehq.org

Some patch statistics
by Hans Leidekker 03 Jan '06

03 Jan '06

I was curious how we did last year so I dug up some numbers with the help of git. I counted patches applied to the tree starting from 1999: year # patches 1999 2656 2000 2722 2001 1885 2002 3094 2003 3283 2004 3851 2005 6037 Total: 23528 This is almost too good to be true isn't it? I worried for a while that these figures might be influenced by the switch from cvs to git, e.g. that cvs history somehow shows up compressed in git. On second look though it really seems that the past year has seen an impressive increase in productivity, compared to the previous years. -Hans

2 1

RFC/PATCH: avoid metafilevirus problems
by Marcus Meissner 03 Jan '06

03 Jan '06

Hi, requesting comments... This patch reduces the attack vector on metafiles. I originally wanted to filter only SETABORTPROC, but there are a lot of things that might be used to inject code. Comments? Ciao, Marcus Changelog: Only allow whitelisted escape codes when playing metafiles. Index: dlls/gdi/metafile.c =================================================================== RCS file: /home/wine/wine/dlls/gdi/metafile.c,v retrieving revision 1.10 diff -u -r1.10 metafile.c --- dlls/gdi/metafile.c 5 Nov 2005 10:45:02 -0000 1.10 +++ dlls/gdi/metafile.c 2 Jan 2006 20:52:42 -0000 @@ -1121,10 +1121,57 @@ GDIRealizePalette(hdc); break; - case META_ESCAPE: + case META_ESCAPE: { + BOOL passdown = FALSE; + + switch (mr->rdParm[0]) { + case SETABORTPROC: + FIXME("NOTE: Suppressing SETABORTPROC in metafile, possible exploit.\n"); + break; + case STARTDOC: + case ABORTDOC: + case ENDDOC: + case NEWFRAME: + case NEXTBAND: + case SETCOPYCOUNT: + case SETCOLORTABLE: + case FLUSHOUTPUT: + case DRAFTMODE: + case SELECTPAPERSOURCE: + case SETLINECAP: + case SETLINEJOIN: + case SETMITERLIMIT: + case DRAWPATTERNRECT: + case ENABLEDUPLEX: + case EPSPRINTING: + case SETDIBSCALING: + case EXTTEXTOUT: + case ENABLEPAIRKERNING: + case SETCHARSET: + case SETKERNTRACK: + case SETALLJUSTVALUES: + case STRETCHBLT: + case BEGIN_PATH: + case CLIP_TO_PATH: + case END_PATH: + case SET_ARC_DIRECTION: + case SET_BACKGROUND_COLOR: + case SET_POLY_MODE: + case SET_SCREEN_ANGLE: + case SET_SPREAD: + case TRANSFORM_CTM: + case SET_CLIP_BOX: + case SET_BOUNDS: + case SET_MIRROR_MODE: + passdown = TRUE; + break; + default: + FIXME("Ignoring strange Escape code %d in Metafile.\n"); + break; + } Escape(hdc, mr->rdParm[0], mr->rdParm[1], (LPCSTR)&mr->rdParm[2], NULL); break; - + } case META_EXTTEXTOUT: MF_Play_MetaExtTextOut( hdc, mr ); break;

3 2

Re: OLEAUT32: Revert back to an older more informative error message.
by Marcus Meissner 03 Jan '06

03 Jan '06

On Tue, Jan 03, 2006 at 07:00:15PM +0900, Mike McCormack wrote: > > Many installers cause Wine's oleaut32 to output alot of FIXME messages > like this: > > fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion > from 0x4003 -> 0xb) 0000ffff > > This message is somewhat frustrating, as although it warns of a > potential problem, it provides no insight into the solution. > > I found the patch that introduced the problem (using git): > > git-whatchanged -p -C -S'Should not use VariantChangeType' > commit hash -> 49eaa0db2b3f7443ead40ef4a5d5b3d650c11384 > > It removed an (IMO) slightly more useful message: > > "argument was coerced in-place (0x%x -> 0x%x); source data has been > modified!!!\n" > > Can anybody help suggest the real way to fix the problem? Is it that we > have to make a copy of the args array before modifying it? Maybe we can > put a comment in the code about how to fix it, some somebody looking at > it in the future will know how to solve it right? I was not fully sure what problems might arise out of just copying the variant as I wrote this code. Its a pretty messy approach. It should work fine when the variant is self contained at least. I think Rob wants to get rid of this function anyway. Ciao, Marcus

1 0

Re: OLE32: Allow _invoke to handle up to 17 parameters.
by Robert Shearman 03 Jan '06

03 Jan '06

Mike McCormack wrote: > > This looks like it might be better handled in assembly... I agree. We can let these patches go in until it is written in assembly though. -- Rob Shearman

1 0

Re: OLEAUT32: Revert back to an older more informative error message.
by Robert Shearman 03 Jan '06

03 Jan '06

Mike McCormack wrote: > Many installers cause Wine's oleaut32 to output alot of FIXME messages > like this: > > fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion > from 0x4003 -> 0xb) 0000ffff > ... > Can anybody help suggest the real way to fix the problem? Is it that > we have to make a copy of the args array before modifying it? Maybe > we can put a comment in the code about how to fix it, some somebody > looking at it in the future will know how to solve it right? Yes. I have a patch that fixes this and several other problems with the function and I've been sending patches in the last week preparing for this. -- Rob Shearman

1 0

issues compiling ReactOS newdev on wine
by Damjan Jovanovic 03 Jan '06

03 Jan '06

I tried to get the ReactOS NEWDEV.DLL to compile on wine, and there were many problems. Firstly, why can't winelibs include <windows.h> and <tchar.h>? Are TCHARs even usable in winelibs? Secondly, what the whole story with WCHARs? Why do L"Unicode string" type strings work in wine apps but not in winelibs? And NEWDEV.DLL needs GWL_USERDATA, DWL_MSGRESULT and PSH_WIZARD97, all of which are within "#ifndef __WINESRC__" sections. Does wine assume DLLs never do user-interface stuff? __________________________________________ Yahoo! DSL Something to write home about. Just $16.99/mo. or less. dsl.yahoo.com

3 2

help with bug
by Curro Amores 03 Jan '06

03 Jan '06

hi everbody, i have posted my bug in bugzilla. I know that the process is a bit slow but i would like somebody help me. There you have the links for downloading the standalone application and the process to get the bug. If you have any doubt you can email me. Thanks all Happy new Year! BUG IS 4126

1 0

Success running VistaTask!
by Dan Kegel 02 Jan '06

02 Jan '06

The fourth "automate other windows apps" app I tried, VistaTask, passed the "can control notepad" test with flying colors! A free trial is available at http://www.vista-software.com/ I don't know how close that tool is to being useful for software testing -- it's not specifically aimed at it -- but it's nice to see at least one such app actually working on Wine. Again, kudos to the Wine developers for getting Wine to this point! - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 1

Error running app delphi based.
by Fernando - SuporteInfo 02 Jan '06

02 Jan '06

Hi, I'm trying run an application developed in delphi and receive the follow errors: err:shell:HCR_GetFolderAttributes HCR_GetFolderAttributes should be called for simple PIDL's only! err:syslevel:_CheckNotSysLevel Holding lock 0x7fa4dba0 level 2 wine: Unhandled exception 0x80000003 at address 0x0000:0x7fc5fd60 (thread 0009), starting debugger... WineDbg starting on pid 0x8 In 32 bit mode. 0x00000000: addb %al,0x0(%eax) Modules: Module Address Debug info Name (87 modules) PE 0x00400000-00f3e000 Deferred at PE 0x10000000-10018000 Deferred hhctrlui PE 0x1f430000-1f4a7000 Deferred msado15 PE 0x1f660000-1f67f000 Deferred msdart PE 0x5d300000-5d37f000 Deferred hhctrl PE 0x5f300000-5f329000 Deferred olepro32 PE 0x65340000-653d2000 Deferred oleaut32 PE 0x65f00000-65fc2000 Deferred ole32 PE 0x70100000-70153000 Deferred rpcrt4 PE 0x70bd0000-70c35000 Deferred shlwapi PE 0x78000000-78044000 Deferred msvcrt ELF 0x7bf00000-7bf03000 Deferred <wine-loader> ELF 0x7ddcc000-7dde0000 Deferred msimg32<elf> \-PE 0x7ddd0000-7dde0000 \ msimg32 ELF 0x7e47b000-7e490000 Deferred midimap<elf> \-PE 0x7e480000-7e490000 \ midimap ELF 0x7e5b0000-7e5d2000 Deferred msacm32<elf> \-PE 0x7e5c0000-7e5d2000 \ msacm32 ELF 0x7e5d2000-7e5e9000 Deferred msacm<elf> \-PE 0x7e5e0000-7e5e9000 \ msacm ELF 0x7e5e9000-7e630000 Deferred wineoss<elf> \-PE 0x7e600000-7e630000 \ wineoss ELF 0x7ec4f000-7ec80000 Deferred uxtheme<elf> \-PE 0x7ec60000-7ec80000 \ uxtheme ELF 0x7f1ef000-7f1f7000 Deferred libxrender.so.1 ELF 0x7f20a000-7f226000 Deferred imm32<elf> \-PE 0x7f210000-7f226000 \ imm32 ELF 0x7f226000-7f243000 Deferred ximcp.so.2 ELF 0x7f243000-7f246000 Deferred xlcdef.so.2 ELF 0x7f246000-7f2aa000 Deferred libgl.so.1 ELF 0x7f2bd000-7f388000 Deferred libx11.so.6 ELF 0x7f388000-7f39f000 Deferred libice.so.6 ELF 0x7f39f000-7f423000 Deferred winex11<elf> \-PE 0x7f3b0000-7f423000 \ winex11 ELF 0x7f423000-7f443000 Deferred libexpat.so.1 ELF 0x7f443000-7f472000 Deferred libfontconfig.so.1 ELF 0x7f477000-7f485000 Deferred libxext.so.6 ELF 0x7f485000-7f499000 Deferred libz.so.1 ELF 0x7f499000-7f506000 Deferred libfreetype.so.6 ELF 0x7f519000-7f537000 Deferred iphlpapi<elf> \-PE 0x7f520000-7f537000 \ iphlpapi ELF 0x7f537000-7f561000 Deferred ws2_32<elf> \-PE 0x7f540000-7f561000 \ ws2_32 ELF 0x7f561000-7f57b000 Deferred wsock32<elf> \-PE 0x7f570000-7f57b000 \ wsock32 ELF 0x7f57b000-7f5fc000 Deferred winmm<elf> \-PE 0x7f590000-7f5fc000 \ winmm ELF 0x7f5fc000-7f696000 Deferred comdlg32<elf> \-PE 0x7f610000-7f696000 \ comdlg32 ELF 0x7f696000-7f763000 Deferred shell32<elf> \-PE 0x7f6b0000-7f763000 \ shell32 ELF 0x7f763000-7f78e000 Deferred winspool<elf> \-PE 0x7f770000-7f78e000 \ winspool ELF 0x7f78e000-7f843000 Deferred comctl32<elf> \-PE 0x7f7a0000-7f843000 \ comctl32 ELF 0x7f843000-7f857000 Deferred lz32<elf> \-PE 0x7f850000-7f857000 \ lz32 ELF 0x7f857000-7f870000 Deferred version<elf> \-PE 0x7f860000-7f870000 \ version ELF 0x7f870000-7f88d000 Deferred mpr<elf> \-PE 0x7f880000-7f88d000 \ mpr ELF 0x7f88d000-7f8cb000 Deferred advapi32<elf> \-PE 0x7f8a0000-7f8cb000 \ advapi32 ELF 0x7f8cb000-7f958000 Deferred gdi32<elf> \-PE 0x7f8e0000-7f958000 \ gdi32 ELF 0x7f958000-7fa80000 Deferred user32<elf> \-PE 0x7f970000-7fa80000 \ user32 ELF 0x7fbd8000-7fce0000 Deferred kernel32<elf> \-PE 0x7fbf0000-7fce0000 \ kernel32 ELF 0x7fdf2000-7fdfb000 Deferred libxcursor.so.1 ELF 0x7fdfb000-7fe00000 Deferred libxxf86vm.so.1 ELF 0x7fe00000-7fe0c000 Deferred libnss_files.so.2 ELF 0x7fe0c000-7fe16000 Deferred libnss_nis.so.2 ELF 0x7fe16000-7fe2c000 Deferred libnsl.so.1 ELF 0x7fe2c000-7fe35000 Deferred libnss_compat.so.2 ELF 0x7fe37000-7fe40000 Deferred libsm.so.6 ELF 0x7fe42000-7fe48000 Deferred libxxf86dga.so.1 ELF 0x7fe4b000-7fe70000 Deferred libm.so.6 ELF 0x7fe70000-7ff67000 Deferred libwine_unicode.so.1 ELF 0x7ff67000-7ffe0000 Deferred ntdll<elf> \-PE 0x7ff80000-7ffe0000 \ ntdll ELF 0xb7db3000-b7db7000 Deferred libdl.so.2 ELF 0xb7db7000-b7eee000 Deferred libc.so.6 ELF 0xb7eee000-b7f00000 Deferred libpthread.so.0 ELF 0xb7f00000-b7f1a000 Deferred libwine.so.1 ELF 0xb7f1a000-b7f1d000 Deferred iso8859-1.so ELF 0xb7f2e000-b7f45000 Deferred ld-linux.so.2 Threads: process tid prio (all id:s are in hex) 00000008 (D) C:\callisto\at.exe 0000000a 0 00000009 0 <== WineDbg terminated on pid 0x8 Excuse my english. []'s Fernando.

1 0

What is the proper value for ACM_DRIVERADDF_NAME?
by Alex Villacís Lasso 02 Jan '06

02 Jan '06

I am working on a set of patches for msacm, and I want to add support for ACM_DRIVERADDF_NAME. The problem is that Wine does not have a definition for this value, which is supposed to be used in acmDriverAdd[AW]. It does not appear in any header of MSVC either. I searched MSDN and Google, and it does not appear either. MSDN mentions its use, but does not mention its specific value. Has anybody seen the value for this definition, and if so, can you please forward it to me? Thanks in advance. BTW, what happened to the two MSACM patches sent in December 28? Alex Villacís Lasso

2 2