January 2006 - Wine-devel - list.winehq.org

re: sudo vs su in wineinstall
by Dan Kegel 30 Jan '06

30 Jan '06

Let's simply delete the wineinstall script. It's not really needed anymore, it was just there for compatibility. People have been talking about doing it for some time: http://winehq.org/site/?issue=227#Nuking%20Wineinstall perhaps now's the time. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 2

Re: [patch] updated riched20 conformance test
by Phil Krylov 29 Jan '06

29 Jan '06

On Tue, 24 Jan 2006 12:23:09 -0800 Thomas Kho <tkho(a)ucla.edu> wrote: > Attached is a small patch to add a riched20 conformance test. I think it's a good test, but I'd add "flags %08x",...flags to the failing test messages, because all these failures are due to unimplemented flags. And probably the message names should be printed as well... -- Ph.

1 0

re: Regression problems in app - help with debugging?
by Dan Kegel 29 Jan '06

29 Jan '06

Smashing analysis! You might want to repost your note as a bug report at http://bugs.winehq.org. Set the 'component' field of the report to wine-ole, and put 'download' in the 'keyword' field. This will get the attention of the right folks somewhat more reliably than a post to wine-devel. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Sweet sassy molassy, OOo2.0.1 and OOo testtool run!
by Dan Kegel 29 Jan '06

29 Jan '06

OK, OpenOffice 2.0.1 does indeed seem to run with yesterday's cvs, as does the corresponding automated test tool! I haven't tried running any real tests with the test tool yet, but seems like that ought to be a rich source of regression information for us going forward. The curious can try it out themselves fairly easily, it's at http://qa.openoffice.org/qatesttool/ - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

DLL Help Database on microsoft.com
by Detlef Riekenberg 29 Jan '06

29 Jan '06

Just found the DLL Help Database (with Details on Product, Version, Exports, Dependencies) on microsoft.com. General Search: http://support.microsoft.com/dllhelp/ Search a dll by Filename (Language is en_US): http://support.microsoft.com/dllhelp/?dlltype=file&l=55&S=1&alpha= You can add the dllname to the end of the url. Example: http://support.microsoft.com/dllhelp/?dlltype=file&l=55&S=1&alpha=winspool.… -- By By ... ... Detlef

1 0

The Dogfood Challenge: use Wine to run your web browser, etc.
by Dan Kegel 29 Jan '06

29 Jan '06

Say, if we're expecting people to use Wine for real work, maybe we should start doing that ourselves. Firefox-1.5 runs pretty well on Wine. How many Wine developers use it on Wine as their main web browser? Maybe we could raise that number from zero to somewhere around ten, and flush out a couple bugs. Speaking of flushing out bugs, OpenOffice 1.1 was said to work well under wine a couple years ago (though I don't think I ever saw it do so myself). Sadly, although OpenOffice 1.1.5 seems to install fine under current wine, it crashes quickly on startup, so I guess we have a bit of work to do first. The extra payoff would be being able to use http://qa.openoffice.org/qatesttool/ to run OpenOffice's automated test suite as an automated regression test for wine. One complication in all this is having to teach yourself to not automatically blow away your ~/.wine directory when trying a new app! OK, baby's waking up, time to go. Cheers, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 2

Re: MSI: Implementation of the MsiVerifyDiskSpace function
by Thomas Weidenmueller 29 Jan '06

29 Jan '06

MattK wrote: > ChangeLog: > Implementation of the MsiVerifyDiskSpace function > > dlls/msi/msiquery.c | 32+- > 1 files changed, 32 insertions(+), 0 deletions(-) > > > ------------------------------------------------------------------------ > > This patch doesn't look right. 1. GetDiskFreeSpace is called with a uninitialized buffer 2. GetDiskFreeSpaceEx should be used to support big partitions 3. missing error checks lead to bogus calculations 4. calculating whether there's enough space is completely wrong - Thomas

2 1

NetUserEnum
by suppandi 29 Jan '06

29 Jan '06

Hi, I was trying to run notes7 and it was crashing because NetUserEnum() was not implemented. So i tried writing a simple implementation. Could anybody have a look at this, and tell me whats wrong. Now notes just crashes without any doc. unfortunately i amn't a windows programmer to write a simple program to make the call. NetUserEnum(LPCWSTR servername, DWORD level, DWORD filter, LPBYTE* bufptr, DWORD prefmaxlen, LPDWORD entriesread, LPDWORD totalentries, LPDWORD resume_handle) { struct USER_INFO_20 { LPWSTR usri20_name; LPWSTR usri20_full_name; LPWSTR usri20_comment; DWORD usri20_flags; DWORD usri20_user_id; }; switch(level) { case 20: { struct USER_INFO_20 *data; char user[]={'t','e','s','t'}; NetApiBufferAllocate(sizeof(struct USER_INFO_20), (LPVOID *) bufptr); data = (struct USER_INFO_20 *)malloc(sizeof(struct USER_INFO_20)); data->usri20_name = (LPWSTR)malloc(20); memcpy((void*)data->usri20_name,user,4); data->usri20_full_name = (LPWSTR)malloc(20); memcpy((void*)data->usri20_full_name,user,4); data->usri20_comment = (LPWSTR)malloc(20); memcpy((void*)data->usri20_comment,user,4); data->usri20_flags = UF_NORMAL_ACCOUNT; data->usri20_user_id = 1000; *entriesread = *totalentries = 1; return 0; } break; default: FIXME("(%s,%ld, 0x%ld,%p,%ld,%p,%p,%p) stub!\n", debugstr_w(servername), level, filter, bufptr, prefmaxlen, entriesread, totalentries, resume_handle); return ERROR_ACCESS_DENIED; break; } }

2 1

Re: Fix: tab-control flickering
by Vitaliy Margolen 28 Jan '06

28 Jan '06

Saturday, January 28, 2006, 4:21:21 AM, Tobias Loew wrote: > Changelog: > dlls/comctl32/tab.c > Tobias Loew <tobi(a)die-loews.de> > Fix: tab-control flickering; tab-control redraws itself after a call to SetCurSel also > when the selection doesn't change > Tobias Loew > Index: dlls/comctl32/tab.c > =================================================================== > RCS file: /home/wine/wine/dlls/comctl32/tab.c,v > retrieving revision 1.122 > diff -u -p -r1.122 tab.c > --- dlls/comctl32/tab.c 8 Nov 2005 12:52:35 -0000 1.122 > +++ dlls/comctl32/tab.c 28 Jan 2006 10:25:40 -0000 > @@ -261,9 +261,11 @@ static inline LRESULT TAB_SetCurSel (TAB > if (iItem >= 0 && iItem < infoPtr->uNumItem) { > prevItem=infoPtr->iSelected; - infoPtr->>iSelected=iItem; > - TAB_EnsureSelectionVisible(infoPtr); > - TAB_InvalidateTabArea(infoPtr); + if (infoPtr->>iSelected != iItem) { + infoPtr->>iSelected=iItem; > + TAB_EnsureSelectionVisible(infoPtr); > + TAB_InvalidateTabArea(infoPtr); > + } > } > return prevItem; > } Please follow the same formatting as the rest of the file/function. In this case it is 4 spaces indent. Vitaliy Margolen

1 0

Re: NetUserEnum
by Vijay Kiran Kamuju 28 Jan '06

28 Jan '06

Hi, If you could also post the FIXME message or the winedebug trace it would be helpful. It would help us to locate if its a regression or unimplemented case. Thanks, VJ On 1/28/06, suppandi <suppandi(a)gmail.com> wrote: > Hi, > > I was trying to run notes7 and it was crashing because NetUserEnum() was not > implemented. So i tried writing a simple implementation. Could anybody have > a look at this, and tell me whats wrong. Now notes just crashes without any > doc. unfortunately i amn't a windows programmer to write a simple program > to make the call. > > NetUserEnum(LPCWSTR servername, DWORD level, DWORD filter, LPBYTE* bufptr, > DWORD prefmaxlen, LPDWORD entriesread, LPDWORD totalentries, > LPDWORD resume_handle) > { > struct USER_INFO_20 > { > LPWSTR usri20_name; > LPWSTR usri20_full_name; > LPWSTR usri20_comment; > DWORD usri20_flags; > DWORD usri20_user_id; > }; > > switch(level) > { > case 20: > { > struct USER_INFO_20 *data; > char user[]={'t','e','s','t'}; > NetApiBufferAllocate(sizeof(struct USER_INFO_20), > (LPVOID *) bufptr); > data = (struct USER_INFO_20 *)malloc(sizeof(struct USER_INFO_20)); > data->usri20_name = (LPWSTR)malloc(20); > memcpy((void*)data->usri20_name,user,4); > data->usri20_full_name = (LPWSTR)malloc(20); > memcpy((void*)data->usri20_full_name,user,4); > data->usri20_comment = (LPWSTR)malloc(20); > memcpy((void*)data->usri20_comment,user,4); > data->usri20_flags = UF_NORMAL_ACCOUNT; > data->usri20_user_id = 1000; > *entriesread = *totalentries = 1; > return 0; > } > break; > default: > FIXME("(%s,%ld, 0x%ld,%p,%ld,%p,%p,%p) stub!\n", > debugstr_w(servername), level, > filter, bufptr, prefmaxlen, entriesread, totalentries, > resume_handle); > > return ERROR_ACCESS_DENIED; > break; > } > } > > > > >

1 0