October 2006 - Wine-devel - list.winehq.org

Force a Display/Input-Driver? (Re: [PATCH 2/5] dinput: Use x11_[acquire|unacquire]_mouse to stop mouse from escaping in exclusive mode.)
by Detlef Riekenberg 08 Oct '06

08 Oct '06

On Do, 2006-10-05 at 08:09 -0600, Vitaliy Margolen wrote: > diff --git a/dlls/dinput/dinput_main.c b/dlls/dinput/dinput_main.c > + if ((mod = GetModuleHandleA( "winex11.drv" ))) When we force wine to use a specific Display/Input-Driver, the driver-selection by reading the Registry is unneeded and should be removed. IMHO, the clean way is to use the dynamic Driver Name, build from the Registry (preferable by a common used wine specific Function in a dll). > + = (void*) GetProcAddress(mod, "wine_tsx11_acquire_mouse"); The exported name is also not generic. And we have both issues already: $ grep -i --line-number "winex11.drv" dlls/*/* dlls/imm32/imm.c:143: x11drv = GetModuleHandleA("winex11.drv"); dlls/opengl32/wgl.c:637: HMODULE mod = GetModuleHandleA( "winex11.drv" ); dlls/wined3d/wined3d_main.c:113: mod = GetModuleHandleA( "winex11.drv" ); dlls/wintab32/wintab32.c:77: hx11drv = GetModuleHandleA("winex11.drv"); Exported Name: dlls/wined3d/wined3d_main.c:116: ... = (void *)GetProcAddress( mod, "wine_tsx11_lock" ); -- By by ... Detlef

2 2

Re: [PATCH 1/3] lz32/tests: Test more last errors set by LZOpenFile[AW].
by Dmitry Timoshkov 08 Oct '06

08 Oct '06

"Saulius Krasuckas" <saulius.krasuckas(a)ieee.org> wrote: > memset(&filled_0xA5, 0xA5, OFS_MAXPATHNAME); > memset(&test, 0xA5, sizeof(test)); > full_file_path_name_in_a_CWD(filename_, expected, FALSE); > + SetLastError(0xfaceabee); Please use a usual value we all agreed to use: 0xdeadbeef. It makes sense to check last error value only if an API has failed, while you are adding last error checks everywhere. Unless you have an application that depends on it, that's wrong. -- Dmitry.

3 4

Client-side DIB copy optimization patch on Bugzilla
by Willie Sippel 08 Oct '06

08 Oct '06

Hi there. A patch by Iulian Marinescu was posted on Bugzilla a few days ago to optimize client-side DIB copy operations. I tested it, and it definitely improves the performance of a few applications quite a bit (Propellerhead Reason for example). Even though I can't comment on the quality of the patch, it seems to work as advertised, and I didn't notice any regressions. Would be nice to see it in Wine, so I hope someone more competent could look into the patch and see if it's OK. It's available at: http://bugs.winehq.org/show_bug.cgi?id=3902 Since the patch wasn't posted on wine-patches AFAIK, I thought I should mention it here so it doesn't get overlooked. Ciao, Willie -- Willie Sippel //////// | Tritium Studios // | ______________________________ //// /// | http://www.tritium-studios.com <willie(a)froq.net>

2 1

Re: [Tools/Wine.inf] Set Internet Explorer version
by Sven Paschukat 08 Oct '06

08 Oct '06

Maarten Lankhorst schrieb: > Windows seems to set internet explorer only during a new installation or > upgrade of internet explorer, so I put it in wine.inf, which seemed > appropriate. > > Changelog: > Set version strings for Internet Explorer so programs dependent on it > can install. This breaks installation of real IE. Setting version to IE 5.5 would give the users a chance to install at least version 6.0. BTW, you should fix the typo in the third line. Sven

7 8

d3d9 make test failure
by Mike McCormack 08 Oct '06

08 Oct '06

Since we're trying to get "make test" working nicely on everybody's machine, here's the failure of the day for me. This is on Debian/unstable for AMD64, with libGL and libGLU provided by ia32-libs 1.15. Mike make[2]: Entering directory `/home/mike/wine/dlls/d3d9/tests' ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so surface.c && touch surface.ok fixme:d3d:IWineD3DDeviceImpl_GetAvailableTextureMem (0x15a508) : stub, simulating 64MB for now, returning 64MB left err:d3d:IWineD3DDeviceImpl_SetRenderState Multisample antialiasing not supported by gl surface.c:131: Test succeeded inside todo block: Got pitch 12, expected 12

2 1

Re: [D3D9] fix for SetFVF memleak [2nd try+patch]
by H. Verbeet 08 Oct '06

08 Oct '06

On 07/10/06, Karsten Elfenbein <kelfe(a)gmx.de> wrote: > * don't prevent IUnknown_Release of pDecl in the exit section and fix > for http://bugs.winehq.org/show_bug.cgi?id=5656 > As mentioned on IRC, this can't work. Releasing the declaration there will cause it to be destroyed and break GetVertexDeclaration(). Instead, we should store the declaration we just created and release it on the next call to either SetVertexDeclaration() or SetFVF(), and when the device is destroyed.

1 0

ListView_InsertColumn() question
by Andrew Talbot 07 Oct '06

07 Oct '06

Can you verify something for me, please? The SDK declares ListView_InsertColumn() as: int ListView_InsertColumn( HWND hwnd, int iCol, const LPLVCOLUMN pcol ); In commctrl.h, we have: #define ListView_InsertColumnA(hwnd,iCol,pcol) \ (INT)SNDMSGA((hwnd),LVM_INSERTCOLUMNA,(WPARAM)(INT)(iCol),(LPARAM)(const LVCOLUMNA *)(pcol)) #define ListView_InsertColumnW(hwnd,iCol,pcol) \ (INT)SNDMSGW((hwnd),LVM_INSERTCOLUMNW,(WPARAM)(INT)(iCol),(LPARAM)(const LVCOLUMNW *)(pcol)) #define ListView_InsertColumn WINELIB_NAME_AW(ListView_InsertColumn) Given (for a type T) that const T * and T const * are equivalent, and given the left-to-right nature of pointer declarations, am I not right in thinking that const LPLVCOLUMN pcol is really equivalent to: LVCOLUMN * const pcol; not const LVCOLUMN *pcol; ? Thanks, -- Andy.

2 6

Re: include: Safely discard the const qualifier using the discard_const macro
by Andrew Talbot 07 Oct '06

07 Oct '06

James Hawkins wrote: > Hi, > > This patch is based on a patch written by Stefan Huehner in 2005. > With the -Wcast-qual warning turned on, these five wine-internal > unicode functions produce over 1400 warnings: > > strchrW, strrchrW, strpbrkW, memchrW, memrchrW > > This patch gets rid of those warnings. Any ideas about this guys? > [...] I think this sort of double casting is the way to go. I would just mention a couple of possible caveats. When I discussed this with Alexandre, some time back, he expressed a concern that he didn't want to see this kind of thing proliferate throughout the code base, so I would suggest that this type of fix should be confined to a small number of very specific functions (typically string functions that take in a const string and return a non-const version: there are others like this elsewhere) and be applied inline, rather than with a macro, so as not to put temptation in anyone's way. The second point I would make is that - and I haven't tested this on gcc - if, say, ULONG_PTR is bigger than the size of a WCHAR * on any system we support, the compiler might warn of a possible truncation loss when the outer (WCHAR *) cast converts back to a pointer, which would be rather unfortunate. :) I presume ULONG_PTR is good for both Win32 and Win64. -- Andy.

2 3

Re: SHELL32: fix product version
by Vitaly Lipatov 07 Oct '06

07 Oct '06

В сообщении от 4 октября 2006 20:19 Vitaly Lipatov написал(a): > I discover there is missed correct Product Version for shell32.dll Anybody can check it? > Changelog: > - set ProductVersion for shell32.dll > - fix rule in Makefile for version.rc -- Lav Виталий Липатов Россия, Санкт-Петербург. www.etersoft.ru GNU! ALT Linux Team! WINE! WIKI! LaTeX! LyX!

1 0

Re: shdocvw [3/3]: Add a stub implementation of the IOleCache interface
by Jacek Caban 07 Oct '06

07 Oct '06

Hi James, James Hawkins wrote: > Hi, > > Changelog: > * Add a stub implementation of the IOleCache interface. > It's the same situation as in your patch for IRunnableObject. WebBrowser shouldn't implement IOleCache interface. Thanks, Jacek

1 0