October 2006 - Wine-devel - list.winehq.org

Re: [crypt32] Win64 printf format warning fixes
by Paul Vriens 03 Oct '06

03 Oct '06

On Tue, 2006-10-03 at 11:18 +0200, Paul Vriens wrote: > Hi, > > leftover after Juan's patch. > > Changelog > Win64 printf format warning fixes > > Cheers, > Forget this one, Juan already sent in a patch (and it was applied). Cheers, Paul.

1 0

Re: [gdi32 1/6]: Cleanup the update_font_list().
by Huw Davies 03 Oct '06

03 Oct '06

On Tue, Oct 03, 2006 at 01:39:23PM +0900, Byeong-Sik Jeon wrote: > Cleanup the update_font_list(). I'm not convinced this is a cleanup, see below for comments. > +#define AddNlsFontToRegistry(hKey, ValueNameA, Data, bForce) do\ > + {\ > + DWORD reg_type;\ > + if(bForce == TRUE ||\ > + RegQueryValueExA(hKey, ValueNameA, 0, &reg_type, NULL, NULL) != ERROR_SUCCESS ||\ > + reg_type != REG_SZ)\ > + {\ > + RegSetValueExA(hKey, ValueNameA, 0, REG_SZ, (const BYTE *)Data, (DWORD)(strlen(Data) + 1));\ > + }\ > + } while(0) Please avoid macro abuse like this and use an inlined function instead. It's also nicer to call it something like add_nls_font_to_registry so that it's easier to read and doesn't look like a Windows API. > + RegCreateKeyExW(HKEY_LOCAL_MACHINE, > + is_win9x() ? win9x_font_reg_key : winnt_font_reg_key, > + 0, NULL, 0, KEY_ALL_ACCESS, NULL, &hkey, NULL); > + AddNlsFontToRegistry(hkey, "Courier" , matched_nls_font_list->courier, TRUE); > + AddNlsFontToRegistry(hkey, "MS Serif" , matched_nls_font_list->serif, TRUE); > + AddNlsFontToRegistry(hkey, "MS Sans Serif", matched_nls_font_list->sserif, TRUE); > + AddNlsFontToRegistry(hkey, "Small Fonts" , matched_nls_font_list->small, TRUE); > + RegCloseKey(hkey); Here you only create either the win9x key or the winnt key. I'd prefer that you created both like the old code did. Thanks, Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: [PATCH] added debugregisters testcase
by Dmitry Timoshkov 03 Oct '06

03 Oct '06

"Marcus Meissner" <marcus(a)jet.franken.de> wrote: >> exception.c:281: Test failed: failed to set debugregister 7 to 0x155, got >> 555 > > Interesting, it apparently changed the 0x155 from my code to > 0x555, turning a single byte watch into a 2 byte watch. Or perhaps > it did not use my code, but had something set there already. Looks like 0x400 is already set there, because changing 0x155 to 0x55 leads to the following: exception.c:281: Test failed: failed to set debugregister 7 to 0x55, got 455 -- Dmitry.

1 0

Re: [gdi32 5/6]: Use the [HKLM\...\GRE_Initialize] for languagedependent stock fonts.
by Dmitry Timoshkov 03 Oct '06

03 Oct '06

"Byeong-Sik Jeon" <wjsqudtlr(a)gmail.com> wrote: > diff --git a/dlls/gdi/gdiobj.c b/dlls/gdi/gdiobj.c > index 3d5450d..740504c 100644 > --- a/dlls/gdi/gdiobj.c > +++ b/dlls/gdi/gdiobj.c > +static LOGFONTW SystemFont = > +static LOGFONTW DeviceDefaultFont = > +static LOGFONTW SystemFixedFont = > +static LOGFONTW DefaultGuiFont = Any reason you don't make LOGFONTs above const? -- Dmitry.

1 0

Re: [PATCH] added debugregisters testcase
by Dmitry Timoshkov 03 Oct '06

03 Oct '06

"Marcus Meissner" <marcus(a)jet.franken.de> wrote: > + ctx.ContextFlags = CONTEXT_DEBUG_REGISTERS; > + res = pNtGetContextThread(GetCurrentThread(), &ctx); > + ok (res == STATUS_SUCCESS,"NtGetContextThread failed with %lx", res); > + ok(ctx.Dr7 == 0x155,"failed to set debugregister 7 to 0x155"); This test fails for me under XP SP2 with all updates: exception.c:281: Test failed: failed to set debugregister 7 to 0x155, got 555 -- Dmitry.

1 0

Re: DDraw: Don't destroy complex attached surfaces even if explicitely requested as they will be liquidated anyway when the root is destroyed.
by Stefan Dösinger 03 Oct '06

03 Oct '06

Am Freitag 22 September 2006 16:55 schrieb Elie Morisse: > A new version of my refcounting patch, lighter and honoring Stefan Dösinger > proposal. Is there any reason why this patch wasn't applied? It looks ok to me, and it complies with the wording of the msdn(complex surfaces can only be destroyed by destroying the root). It might be good to have a test case, but how can we test if something has been destroyed?

1 0

Re: DDraw: Implement depth filling through blit. ( Resubmit )
by Stefan Dösinger 03 Oct '06

03 Oct '06

Am Freitag 22 September 2006 17:12 schrieb Elie Morisse: > Resubmit of my previous patch. Be aware that it is completing an older > Stefan Dosinger patch which hasn't been accepted, but can be applied > independently ( it'll be quite useless nevertheless.. ) I think you should replace the 4294967295.0 by something more meaningful like (float) DWORD_MAX, or how the constant is called.

1 0

RFC: dlls/user/tests/win.c fix
by Juan Lang 03 Oct '06

03 Oct '06

The attached patch (sorry, crappy mailer) fixes the win.c failure I was seeing. Is it correct? --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 7

Re: Request for Test: exception handling test
by Stefan Leichter 02 Oct '06

02 Oct '06

Am Thursday 01 January 1970 01:00 schrieb Marcus Meissner: > Hi, > > Can someone with ability to run the testsuite on Windows please test > the following new 2 testcases under Windows? > > They succeed in WINE now, but I wonder if they will work in Windows. > > Ciao, Marcus Hi, i don't get any new error on win2k. Attached is the logging of the modified test target. Bye Stefan

1 0

Scrambled VB Fonts improving.
by Joe Baker 02 Oct '06

02 Oct '06

2 1