October 2006 - Wine-devel - list.winehq.org

Re: [PATCH] fixed NULL ptr crash
by Marcus Meissner 25 Oct '06

25 Oct '06

On Sun, Sep 16, 2001 at 10:00:00PM +0000, Marcus Meissner wrote: > Hi, > > If nsIWebBrowser_GetContentDOMWindow fails we must > not deallocate dom_window ... Only after the nsres > check. > > Ciao, Marcus > > --- > > dlls/mshtml/olecmd.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > f44a99d8c152ad21911b2d3ac42f84211d9a734d > diff --git a/dlls/mshtml/olecmd.c b/dlls/mshtml/olecmd.c > index fa4afb4..0ab2ad6 100644 > --- a/dlls/mshtml/olecmd.c > +++ b/dlls/mshtml/olecmd.c > @@ -422,12 +422,12 @@ static void setup_ns_editing(NSContainer > } > > nsres = nsIWebBrowser_GetContentDOMWindow(This->webbrowser, &dom_window); > - nsIDOMWindow_Release(dom_window); > if(NS_FAILED(nsres)) { > ERR("Could not get content DOM window: %08x\n", nsres); > nsIEditingSession_Release(editing_session); > return; > } > + nsIDOMWindow_Release(dom_window); > > nsres = nsIEditingSession_MakeWindowEditable(editing_session, dom_window, NULL, FALSE); > nsIEditingSession_Release(editing_session); Looking back this does not make sense either, since dom_window is now invalid after the release, but we access it. Jacek, can you check there? Ciao, Marcus

2 1

winhlp32 implementation
by lich＠math.spbu.ru 25 Oct '06

25 Oct '06

Hi, all! I intend to implement winhlp32 utility looks like native one (font size changing, GID and CNT files support, etc...). Please, share your opinion, has this idea any sense, or *.hlp died long ago and only few persons need it? Inspired by bug http://bugs.winehq.org/show_bug.cgi?id=5926 Thanks.

2 1

Wine packages for WBEL 3
by Lei Zhang 25 Oct '06

25 Oct '06

Hi, I built a set of Wine RPMs for WBEL 3. They should be compatible with RHEL 3 as well. I have not tested them extensively so any feedback would be great. The RPMs are linked from: http://linux.ucla.edu/~leiz/software/wine/ - Lei

1 0

Propability that application X works in wine
by Stefan Dösinger 25 Oct '06

25 Oct '06

Hi, Beeing asked how it happenes that a comparably small application fails in wine while something bigger like office 2003 and half-life 2 works I thought how one could mathematically express that some application works in wine. There seem to be a few factors: * Some propability that some behavior Y causes a bug in wine. I assume that is fixed, perhaps a per-dll value, perhaps not * Of course the application size. How many different things does the app do. The bigger, the more likely it is that something of that fails. * People often complain that only popular apps work in wine, so the popularity of the app seems to be important. This manifests in the fact that bugs hit by popular apps are more likely to be fixed first. Ok, so how do these factors relate? Popularity seems to be the most important, but I am not sure how app size and the bug propability relate. Especially the bug propability would be interesting I think, as it might be some measure of the maturity of wine :-) Any ideas about that? Stefan

4 3

Re: [PATCH 4/5] quartzdrv: Add thread data management to the quartzdrv.
by Dmitry Timoshkov 25 Oct '06

25 Oct '06

"Pierre d'Herbemont" <pdherbemont(a)free.fr> wrote: > +#ifndef __WINE_QUARTZDRV_H > +#define __WINE_QUARTZDRV_H > + > +#ifndef __WINE_CONFIG_H > +# error You must include config.h to use this header > +#endif This header doesn't use any HAVE_xxx macros unlike an original one this check was copied from, so it should be removed. -- Dmitry.

1 0

Re: advapi32:Get HW_PROFILE_INFO from registry (partially based on patch from Ben Collins) (try2)
by Robert Shearman 25 Oct '06

25 Oct '06

Louis. Lenders wrote: > diff --git a/dlls/advapi32/Makefile.in b/dlls/advapi32/Makefile.in > index 1b4cf5b..da7aec4 100644 > --- a/dlls/advapi32/Makefile.in > +++ b/dlls/advapi32/Makefile.in > @@ -5,7 +5,7 @@ SRCDIR = @srcdir@ > VPATH = @srcdir@ > MODULE = advapi32.dll > IMPORTLIB = libadvapi32.$(IMPLIBEXT) > -IMPORTS = kernel32 ntdll > +IMPORTS = kernel32 ntdll rpcrt4 > Please make this a DELAYIMPORTS if you have to import a function from rpcrt4. > > C_SRCS = \ > advapi.c \ > diff --git a/dlls/advapi32/advapi.c b/dlls/advapi32/advapi.c > index 04a520a..fd2f576 100644 > --- a/dlls/advapi32/advapi.c > +++ b/dlls/advapi32/advapi.c > @@ -33,6 +33,7 @@ #include "winreg.h" > #include "winternl.h" > #include "winerror.h" > #include "appmgmt.h" > +#include "rpc.h" > > #include "wine/library.h" > #include "wine/debug.h" > @@ -116,11 +117,54 @@ GetUserNameW( LPWSTR lpszName, LPDWORD l > */ > BOOL WINAPI GetCurrentHwProfileA(LPHW_PROFILE_INFOA pInfo) > { > - FIXME("(%p) semi-stub\n", pInfo); > - pInfo->dwDockInfo = DOCKINFO_DOCKED; > - strcpy(pInfo->szHwProfileGuid,"{12340001-1234-1234-1234-1233456789012}"); > - strcpy(pInfo->szHwProfileName,"Wine Profile"); > - return 1; > + UUID __RPC_FAR* Uuid=0; > + HKEY hkey; > + DWORD size; > + DWORD dockingstate = 0x00000000; > + CHAR profilename[] = "Wine Profile"; > + > + RegCreateKeyA(HKEY_LOCAL_MACHINE, "System\\CurrentControlSet\\Control\\IDConfigDB\\Hardware Profiles\\0001", &hkey); > + > + size = HW_PROFILE_GUIDLEN; > + /*If the ProfileGuid is not in the registry, create it, and write it to the registry*/ > + if(ERROR_SUCCESS != RegGetValueA(hkey, 0, "HwProfileGuid", RRF_RT_REG_SZ, 0, pInfo->szHwProfileGuid, &size)) > + { > + Uuid = HeapAlloc(GetProcessHeap(), 0, sizeof(*Uuid)); > You don't need to allocate memory for this variable. > + > + if(RPC_S_OK != UuidCreate(Uuid)) > + { > + ERR("UuidCreate failed to create a UUID"); > + HeapFree( GetProcessHeap(), 0, Uuid ); > + return FALSE; > + } > + > + RegSetValueExA(hkey, "HwProfileGuid", 0, REG_SZ, (const BYTE*) debugstr_guid(Uuid), strlen(debugstr_guid(Uuid))); > You shouldn't be using a debugging command for formating a GUID to a string, as the function could change its output later on and break this function. > + } > + > + RegGetValueA(hkey, 0, "HwProfileGuid", RRF_RT_REG_SZ, 0, pInfo->szHwProfileGuid, &size); > + HeapFree( GetProcessHeap(), 0, Uuid ); > + > + size = MAX_PROFILE_LEN; > + /*If the ProfileName is not in the registry create it, and write to the registry*/ > + if(ERROR_SUCCESS != RegGetValueA(hkey, 0, "FriendlyName", RRF_RT_REG_SZ, 0, pInfo->szHwProfileName, &size)) > + RegSetValueExA(hkey, "FriendlyName", 0, REG_SZ, (const BYTE*) profilename, sizeof(profilename)); > + RegGetValueA(hkey, 0, "FriendlyName", RRF_RT_REG_SZ, 0, pInfo->szHwProfileName, &size); > + > + RegCloseKey(hkey); > + > + RegCreateKeyA(HKEY_LOCAL_MACHINE, "System\\CurrentControlSet\\Control\\IDConfigDB\\CurrentDockInfo", &hkey); > + > + size = sizeof(DWORD); > + /*If the DockingState is not in the registry create it, and write to the registry*/ > + if(ERROR_SUCCESS != RegGetValueA(hkey, 0, "DockingState", RRF_RT_DWORD , 0, &pInfo->dwDockInfo, &size)) > + RegSetValueExA(hkey, "DockingState", 0, REG_DWORD, (const BYTE*) &dockingstate, sizeof(DWORD)); > + RegGetValueA(hkey, 0, "DockingState", RRF_RT_DWORD, 0, &pInfo->dwDockInfo, &size); > + > + RegCloseKey(hkey); > + > + TRACE("DockInfo = %x, Profile Guid = %s, Friendly Name = %s\n", pInfo->dwDockInfo, pInfo->szHwProfileGuid, pInfo->szHwProfileName); > + > + return 1; > } > > /****************************************************************************** > You could also do with some error checking here. -- Rob Shearman

1 0

Re: dwarf.c small botch
by Dmitry Timoshkov 24 Oct '06

24 Oct '06

"David Anderson" <davea42(a)earthlink.net> wrote: > @@ -1095,7 +1095,7 @@ static unsigned dwarf2_map_register(int > > switch (regno) > { > - case Wine_DW_no_register: FIXME("What the heck\n"); reg = 0; break; > + case Wine_DW_no_register: FIXME("What the heck map reg 0x%x\n",(unsigned int)regno); reg = 0; break; There is no need for a cast here. > /* FIXME: this is a dirty hack */ > case Wine_DW_frame_register: reg = 0; break; > case 0: reg = CV_REG_EAX; break; > @@ -1394,8 +1394,16 @@ static struct symt* dwarf2_parse_subprog > > subpgm.ctx = ctx; > subpgm.compiland = compiland; > - if (dwarf2_compute_location(ctx, di, DW_AT_frame_base, &subpgm.frame_offset, &subpgm.frame_reg)) > + if (dwarf2_compute_location(ctx, di, DW_AT_frame_base, &subpgm.frame_offset, &subpgm.frame_reg)) { > TRACE("For %s got %ld/%d\n", name.u.string, subpgm.frame_offset, subpgm.frame_reg); > + if (subpgm.frame_reg == Wine_DW_no_register) { > + /* Likely a constant, meaning a location list offset. > + We do not handle those yet. */ > + /*FIXME("need to handle location lists\n"); */ > + subpgm.frame_reg = 0; > + subpgm.frame_offset = 0; > + } > + } Please follow the formatting style of the code you're changing: in placing braces, using spaces instead of tabs, formatting of the comments. -- Dmitry.

1 0

Question: Convert source tarball to GIT repository
by Matthew Kehrer 24 Oct '06

24 Oct '06

Is there a way I can convert a source tarball I download to a local GIT repository? I have dial-up a home, but I know of a place where I can bring my flash drive and use it to get the tarball as GIT does not have resume support. Is this possible? Thanks.

7 11

use wine as screensaver for x
by Detlef Riekenberg 24 Oct '06

24 Oct '06

Hi. While waiting for the commit of my localspl-Patches, i want to picked up an fun project: Has anyone an Idea, how to modify "user32.dll" and "winex11.drv" to open a Window, when I already have the X11 Window-ID (example: XSCREENSAVER_WINDOW=0x280020)? My Idea is to include the wrapper code in explorer.exe and use similar code as already present for "/desktop". The Window width and height is not known on startup and does not match a well-known Desktop Size. I think, I need to add an Export to winex11.drv to fetch the size and reuse "X11DRV_create_desktop()" or add an Export to someting similar as "X11DRV_create_desktop()". The client registers a Window Class with a known name ("WindowsScreenSaverClass") and then CreateWindowEx must be redirected to the already created X11-Window. A lightwight solution might be to implement minimal features from "scrsave.lib" (RegisterClass) in "explorer.exe" and then call "ScreenSaverProc" directly. Any Ideas? -- By by ... Detlef

2 2

Re: [PATCH 5/5][resent] Implement MsgWaitForMultipleObjectsEx and initial Carbon event handling.
by Mike McCormack 24 Oct '06

24 Oct '06

Pierre d'Herbemont wrote: > dlls/winequartz.drv/Makefile.in | 4 +- > dlls/winequartz.drv/event.c | 74 > +++++++++++++++++++++++++++++++ > dlls/winequartz.drv/quartzdrv.h | 5 ++ > dlls/winequartz.drv/quartzdrv_carbon.c | 46 +++++++++++++++++++ > dlls/winequartz.drv/winequartz.drv.spec | 2 - For the quartz driver, as it's not going to cause regressions in existing code, you're probably better off submitting the entire thing in one big patch. Show us what the completed thing looks like, then we can give you better feedback on it. If it's too big to post to wine-patches, try put it on a website, and submit a link to it. Mike

2 1