November 2006 - Wine-devel - list.winehq.org

oleaut32: ITypeInfo_fnInvoke behavior on PARAMFLAG_FOPT without PARAMFLAG_FHASDEFAULT
by a_villacis＠palosanto.com 13 Nov '06

13 Nov '06

In a tax app written in Visual Basic/ADO, I found the following problem: In dlls/oleaut32/typelib.c, in function ITypeInfo_fnInvoke(), the following code is found (around line 5569). VARIANTARG *missing_arg = INVBUF_GET_MISSING_ARG_ARRAY(buffer, func_desc->cParams); V_VT(arg) = VT_VARIANT | VT_BYREF; V_VARIANTREF(arg) = &missing_arg[i]; V_VT(V_VARIANTREF(arg)) = VT_ERROR; V_ERROR(V_VARIANTREF(arg)) = DISP_E_PARAMNOTFOUND; This code runs when a parameter is found that has the PARAMFLAG_FIN and PARAMFLAG_FOPT flags, but not the PARAMFLAG_FHASDEFAULT flag. As far as I understand, this code is supposed to supply a variant that might hold an output value. However, in the Append method of the Fields object within the Recordset object of Microsoft ADODB 2.7, the following declaration is found: trace:ole:ITypeInfo_fnInvoke invoking: L"Append"(5) parm0: L"Name" parm1: L"Type" parm2: L"DefinedSize" parm3: L"Attrib" parm4: L"FieldValue" memid is 00000003 Param 0: tdesc.vartype 8 (VT_BSTR) u.paramdesc.wParamFlags PARAMFLAG_FIN u.paramdesc.lpex (nil) Param 1: tdesc.vartype 29 (VT_USERDEFINED ref = 2bc) u.paramdesc.wParamFlags PARAMFLAG_FIN u.paramdesc.lpex (nil) Param 2: tdesc.vartype 29 (VT_USERDEFINED ref = 1c84) u.paramdesc.wParamFlags PARAMFLAG_FIN PARAMFLAG_FOPT PARAMFLAG_FHASDEFAULT u.paramdesc.lpex 0x199868 Param 3: tdesc.vartype 29 (VT_USERDEFINED ref = 320) u.paramdesc.wParamFlags PARAMFLAG_FIN PARAMFLAG_FOPT PARAMFLAG_FHASDEFAULT u.paramdesc.lpex 0x1998d0 Param 4: tdesc.vartype 12 (VT_VARIANT) u.paramdesc.wParamFlags PARAMFLAG_FIN PARAMFLAG_FOPT u.paramdesc.lpex (nil) funckind: 1 (pure virtual) invkind: 1 (func) callconv: 4 (stdcall) oVft: 52 cParamsOpt: 1 wFlags: 0 elemdescFunc (return value type): tdesc.vartype 25 (VT_HRESULT) u.paramdesc.wParamFlags PARAMFLAGS_NONE u.paramdesc.lpex (nil) helpstring: (null) entry (ordinal): 0x0000 The implementation of the method in Microsoft ADODB 2.7 last parameter (FieldValue) absolutely refuses to accept a VT_VARIANT | VT_BYREF variant. This result is not dependent of the type of variant pointed to by the first-level variant - changing VT_ERROR to VT_EMPTY has no effect. Only by passing a VT_EMPTY instead of a VT_VARIANT | VT_BYREF can the application proceed normally. All oleaut32 tests still pass. Please comment if this is an appropriate fix for this issue. Changelog: * (PARAMFLAG_FIN | PARAMFLAG_FOPT) & ~PARAMFLAG_FHASDEFAULT should result in a default parameter of VT_EMPTY, not a VT_VARIANT | VT_BYREF in ITypeInfo_fnInvoke Alex Villacís Lasso

3 5

Re: setupapi: The inf section suffix that corresponds to __x86_64 is .ntamd64.
by Michael Stefaniuc 13 Nov '06

13 Nov '06

Hans Leidekker wrote: > -Hans > > Changelog > The inf section suffix that corresponds to __x86_64 is .ntamd64. > > > ------------------------------------------------------------------------ > > fe843f1050d9673354e0ae2329d86a6df67b7dfb > diff --git a/dlls/setupapi/install.c b/dlls/setupapi/install.c > index f6a541b..4c60b86 100644 > --- a/dlls/setupapi/install.c > +++ b/dlls/setupapi/install.c > @@ -995,7 +995,7 @@ void WINAPI InstallHinfSectionW( HWND hw > #ifdef __i386__ > static const WCHAR nt_platformW[] = {'.','n','t','x','8','6',0}; > #elif defined(__x86_64) > - static const WCHAR nt_platformW[] = {'.','n','t','i','a','6','4',0}; > + static const WCHAR nt_platformW[] = {'.','n','t','a','m','d','6','4',0}; There was also a Windows for IA64 aka Itanium CPUs. Not sure if the .ntia64 needs to stay in. bye michael > #else /* FIXME: other platforms */ > static const WCHAR nt_platformW[] = {'.','n','t',0}; > #endif > > > ------------------------------------------------------------------------ > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: [PATCH] ntdll: round section parameters on 0x200
by Dmitry Timoshkov 13 Nov '06

13 Nov '06

"Andrey Turkin" <pancha(a)mail.nnov.ru> wrote: > if (map_file_into_view( view, fd, 0, header_size, 0, VPROT_COMMITTED | VPROT_READ, > - removable ) != STATUS_SUCCESS) goto error; > + TRUE ) != STATUS_SUCCESS) goto error; This chunk has nothin to do with the patch description and simply is wrong. > - sec->PointerToRawData, (int)pos, file_size, map_size, > + (int)start, (int)pos, file_size, map_size, ... > - sec->PointerToRawData, sec->SizeOfRawData, > + (int)start, sec->SizeOfRawData, Please use a proper format specifier instead of a cast. -- Dmitry.

3 7

Re: setupapi: Implement SetupGetSourceFileLocation{A,W}. 1/5
by Alexandre Julliard 13 Nov '06

13 Nov '06

Hans Leidekker <hans(a)it.vu.nl> writes: > + if (!SetupFindFirstLineW( hinf, SourceDisksNames, source_id, context ) && > + !SetupFindFirstLineW( hinf, SourceDisksNames_x86, source_id, context )) I believe x86 is supposed to take precedence. You may have to support nt and ntx86 prefixes too. > +@ stdcall SetupGetSourceFileLocationA(ptr ptr str ptr ptr long) > +@ stdcall SetupGetSourceFileLocationW(ptr ptr wstr ptr ptr long) This doesn't match the prototype. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: include: Add credui.h header file.
by Paul Vriens 13 Nov '06

13 Nov '06

On Mon, 2006-11-13 at 13:28 +0000, Robert Shearman wrote: > --- > include/Makefile.in | 1 + > include/wincred.h | 98 > +++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 99 insertions(+), 0 deletions(-) Hi, the patch description and Makefile.in reference credui.h. The patch itself however creates wincred.h. Cheers, Paul.

2 1

Re: [msi] Remove todo_wine for succeeding test
by Paul Vriens 13 Nov '06

13 Nov '06

On 11/12/06, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > this test succeeds (at least on my box). > > Changelog > Remove todo_wine for succeeding test > > Cheers, > > Paul. > --- > dlls/msi/tests/suminfo.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/msi/tests/suminfo.c b/dlls/msi/tests/suminfo.c > index 869495d..6e912b3 100644 > --- a/dlls/msi/tests/suminfo.c > +++ b/dlls/msi/tests/suminfo.c > @@ -393,7 +393,7 @@ static void test_summary_binary(void) > > r = MsiSummaryInfoGetProperty(hsuminfo, PID_WORDCOUNT, &type, &ival, NULL, NULL, NULL); > ok(r == ERROR_SUCCESS, "MsiSummaryInfoGetProperty failed\n"); > - todo_wine ok( ival == 0, "value incorrect\n"); > + ok( ival == 0, "value incorrect\n"); > > /* looks like msi adds some of its own values in here */ > count = 0; > -- > 1.4.3.4 > > Forget this one. This test should fail on Wine as shown by Mike's patch (msi: Fix an uninitialized variable in the test cases.). Cheers, Paul.

1 0

Re: [comdlg32] Remove unused variable (Coverity)
by Paul Vriens 12 Nov '06

12 Nov '06

On 11/12/06, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > > Hi, > > hResource16 is not used. > > Will fix Coverity-17. > > Changelog > Remove unused variable > > Cheers, > > Paul. > --- > dlls/comdlg32/fontdlg16.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/dlls/comdlg32/fontdlg16.c b/dlls/comdlg32/fontdlg16.c > index 4b13c2d..c5f11df 100644 > --- a/dlls/comdlg32/fontdlg16.c > +++ b/dlls/comdlg32/fontdlg16.c > @@ -164,7 +164,7 @@ INT16 WINAPI FontStyleEnumProc16( SEGPTR > BOOL16 WINAPI ChooseFont16(LPCHOOSEFONT16 lpChFont) > { > HINSTANCE16 hInst; > - HANDLE16 hDlgTmpl16 = 0, hResource16 = 0; > + HANDLE16 hDlgTmpl16 = 0; > HGLOBAL16 hGlobal16 = 0; > BOOL16 bRet = FALSE; > LPVOID template; > @@ -255,7 +255,6 @@ BOOL16 WINAPI ChooseFont16(LPCHOOSEFONT1 > hInst = GetWindowLongPtrA(HWND_32(lpChFont->hwndOwner), > GWLP_HINSTANCE); > bRet = DialogBoxIndirectParam16(hInst, hDlgTmpl16, > lpChFont->hwndOwner, > (DLGPROC16) ptr, (DWORD)lpChFont); > - if (hResource16) FreeResource16(hDlgTmpl16); > if (hGlobal16) > { > GlobalUnlock16(hGlobal16); > -- > 1.4.3.5 Forget this one as I'm not sure whether hDlgTmpl16 needs to be freed. Cheers, Paul.

1 0

Unimplemented Functionality
by Martin Owens 12 Nov '06

12 Nov '06

Hey all, How easy would it be for one of you guys to add this missing functionality (see log below)? It prevents the installer working for "Nations WWII Fighter Command" and yet the game should work once installed. $ wine SETUP.EXE SpaceListA Stub fixme:setupapi:SetupAddInstallSectionToDiskSpaceListA Stub fixme:setupapi:SetupAddInstallSectionToDiskSpaceListA Stub fixme:setupapi:SetupAddInstallSectionToDiskSpaceListA Stub fixme:setupapi:SetupAddInstallSectionToDiskSpaceListA Stub fixme:setupapi:SetupAddInstallSectionToDiskSpaceListA Stub fixme:setupapi:SetupAddInstallSectionToDiskSpaceListA Stub fixme:setupapi:SetupAddInstallSectionToDiskSpaceListA Stub fixme:setupapi:SetupAddInstallSectionToDiskSpaceListA Stub fixme:setupapi:SetupAddInstallSectionToDiskSpaceListA Stub fixme:setupapi:SetupAddInstallSectionToDiskSpaceListA Stub fixme:setupapi:SetupAddInstallSectionToDiskSpaceListA Stub wine: Call from 0x7b840790 to unimplemented function setupapi.dll.SetupGetSourceFileSizeA, aborting wine: Unimplemented function setupapi.dll.SetupGetSourceFileSizeA called at address 0x7b840790 (thread 0010), starting debugger... Unhandled exception: unimplemented function setupapi.dll.SetupGetSourceFileSizeA called in 32-bit code (0x7b840808). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:7b840808 ESP:0033f09c EBP:0033f100 EFLAGS:00000212( - 00 - -IA1) EAX:7b82bd41 EBX:7b8a8f60 ECX:00000000 EDX:00000000 ESI:00000000 EDI:0033f1ac Stack dump: 0x0033f09c: 0033f124 00000008 7b8a8f60 0000004b 0x0033f0ac: 80000100 00000001 00000000 7b840790 0x0033f0bc: 00000002 7e86eba0 7e870942 7b8a8f60 0x0033f0cc: 7b8a8f60 0033f140 7b877540 00110000 0x0033f0dc: 00000000 0019d320 0000004c 0033f160 0x0033f0ec: 00000400 00000000 00000000 00000000 fixme:ntdll:RtlNtStatusToDosErrorNoTeb no mapping for c0000119 Backtrace: =>1 0x7b840808 RaiseException+0x78 in kernel32 (0x0033f100) 2 0x7e86eb21 in setupapi (+0x2eb21) (0x0033f130) 3 0x7e852203 in setupapi (+0x12203) (0x00000000) 0x7b840808 RaiseException+0x78 in kernel32: movl 0xfffffffc(%ebp),%ebx Modules: Module Address Debug info Name (78 modules) PE 400000-4bc000 Deferred setup ELF 7b800000-7b91a000 Export kernel32<elf> \-PE 7b820000-7b91a000 \ kernel32 ELF 7bc00000-7bc81000 Deferred ntdll<elf> \-PE 7bc10000-7bc81000 \ ntdll ELF 7bf00000-7bf03000 Deferred <wine-loader> ELF 7c45d000-7c472000 Deferred midimap<elf> \-PE 7c460000-7c472000 \ midimap ELF 7c498000-7c4b0000 Deferred msacm32<elf> \-PE 7c4a0000-7c4b0000 \ msacm32 ELF 7c4b0000-7c568000 Deferred libasound.so.2 ELF 7c568000-7c591000 Deferred winealsa<elf> \-PE 7c570000-7c591000 \ winealsa ELF 7c5be000-7c5f0000 Deferred uxtheme<elf> \-PE 7c5d0000-7c5f0000 \ uxtheme ELF 7d811000-7d816000 Deferred libxfixes.so.3 ELF 7d816000-7d81f000 Deferred libxcursor.so.1 ELF 7d81f000-7d83b000 Deferred imm32<elf> \-PE 7d830000-7d83b000 \ imm32 ELF 7d83b000-7d859000 Deferred ximcp.so.2 ELF 7d859000-7d85c000 Deferred libxrandr.so.2 ELF 7d85c000-7d864000 Deferred libxrender.so.1 ELF 7d864000-7d867000 Deferred libxinerama.so.1 ELF 7dd7e000-7e541000 Deferred libglcore.so.1 ELF 7e541000-7e5c6000 Deferred libgl.so.1 ELF 7e5c6000-7e68f000 Deferred libx11.so.6 ELF 7e68f000-7e69c000 Deferred libxext.so.6 ELF 7e69c000-7e6b4000 Deferred libice.so.6 ELF 7e6b4000-7e741000 Deferred winex11<elf> \-PE 7e6c0000-7e741000 \ winex11 ELF 7e741000-7e75f000 Deferred libexpat.so.1 ELF 7e75f000-7e78e000 Deferred libfontconfig.so.1 ELF 7e78e000-7e7a2000 Deferred libz.so.1 ELF 7e7a2000-7e80c000 Deferred libfreetype.so.6 ELF 7e80c000-7e820000 Deferred lz32<elf> \-PE 7e810000-7e820000 \ lz32 ELF 7e820000-7e839000 Deferred version<elf> \-PE 7e830000-7e839000 \ version ELF 7e839000-7e894000 Export setupapi<elf> \-PE 7e840000-7e894000 \ setupapi ELF 7e894000-7e91d000 Deferred winmm<elf> \-PE 7e8a0000-7e91d000 \ winmm ELF 7e91d000-7e9dd000 Deferred comctl32<elf> \-PE 7e930000-7e9dd000 \ comctl32 ELF 7e9dd000-7ea35000 Deferred shlwapi<elf> \-PE 7e9f0000-7ea35000 \ shlwapi ELF 7ea35000-7eb1f000 Deferred shell32<elf> \-PE 7ea50000-7eb1f000 \ shell32 ELF 7eb1f000-7eb32000 Deferred libresolv.so.2 ELF 7eb32000-7eb50000 Deferred iphlpapi<elf> \-PE 7eb40000-7eb50000 \ iphlpapi ELF 7eb50000-7eba2000 Deferred rpcrt4<elf> \-PE 7eb60000-7eba2000 \ rpcrt4 ELF 7eba2000-7ebad000 Deferred libgcc_s.so.1 ELF 7ec8c000-7ed42000 Deferred gdi32<elf> \-PE 7eca0000-7ed42000 \ gdi32 ELF 7ed42000-7ee78000 Deferred user32<elf> \-PE 7ed60000-7ee78000 \ user32 ELF 7ee78000-7eebe000 Deferred advapi32<elf> \-PE 7ee80000-7eebe000 \ advapi32 ELF 7eebe000-7ef52000 Deferred ole32<elf> \-PE 7eed0000-7ef52000 \ ole32 ELF 7ef52000-7ef5d000 Deferred libnss_files.so.2 ELF 7ef5d000-7ef73000 Deferred libnsl.so.1 ELF 7ef73000-7ef7c000 Deferred libnss_compat.so.2 ELF 7ef7c000-7ef7e000 Deferred xlcutf8load.so.2 ELF 7ef80000-7ef85000 Deferred libxdmcp.so.6 ELF 7ef85000-7ef8e000 Deferred libsm.so.6 ELF 7efc8000-7efee000 Deferred libm.so.6 ELF 7efef000-7eff1000 Deferred libnvidia-tls.so.1 ELF 7eff1000-7eff6000 Deferred libxxf86vm.so.1 ELF 7eff6000-7f000000 Deferred libnss_nis.so.2 ELF b7cd0000-b7cd3000 Deferred libxau.so.6 ELF b7cd4000-b7cd8000 Deferred libdl.so.2 ELF b7cd8000-b7e0c000 Deferred libc.so.6 ELF b7e0c000-b7e1f000 Deferred libpthread.so.0 ELF b7e31000-b7f42000 Deferred libwine.so.1 ELF b7f44000-b7f5f000 Deferred ld-linux.so.2 Threads: process tid prio (all id:s are in hex) 0000000f (D) C:\windows\temp\setup.exe 00000010 0 <== 0000000c 0000000e 0 0000000d 0 Best Regards, Martin Owens

2 1

Ignition app (GPL source) dosnt work
by Matheus Izvekov 11 Nov '06

11 Nov '06

The app called Ignition does runtime patching and dll loading into another process space. It currently fails silently, without both the app and wine reporting any errors. Its source code (GPL) is availiable for download here: http://www.beosil.com/ignition/download.html Is it some known issue? if so, what needs to be done to make it work? Thanks in advance

1 0

Re: Damjan Jovanovic : winex11.drv: Fix copying top-down/bottom-up DIBs.
by Robert Reif 11 Nov '06

11 Nov '06

This patch http://www.winehq.org/pipermail/wine-cvs/2006-November/027732.html breaks http://angusj.com/sudoku/

2 2