February 2006 - Wine-devel - list.winehq.org

Re: riched20: Implements FR_MATCHCASE for EM_FINDTEXT
by Phil Krylov 25 Feb '06

25 Feb '06

On Tue, 21 Feb 2006 14:08:38 -0800 Lei Zhang <leiz(a)ucla.edu> wrote: > On Tuesday 21 February 2006 12:42 pm, you wrote: > > On Tue, 21 Feb 2006 10:19:01 -0800 > > > > Lei Zhang <leiz(a)ucla.edu> wrote: > > > - while (pCurItem && > > > pCurItem->member.run.strText->szData[nCurEnd - nMatched - 1] == > > > text[nLen - nMatched - 1]) + while > > > (ME_CharCompare(pCurItem->member.run.strText->szData[nCurEnd - > > > nMatched - 1], text[nLen - nMatched - 1], (flags & FR_MATCHCASE))) > > > > You've dropped pCurItem NULL check here. Probably just a typo... > > > > -- Ph. > > Hi Phil, > > Ya, it's a typo. Thanks for catching it. Could you kindly fix it then? As this patch was accepted unfixed. -- Ph.

3 5

getwinegit.sh 0.2
by Christian Lachner 25 Feb '06

25 Feb '06

I decided to make this release a bit more complete than the other ones i did before. Bugfree (i hope ;)) and with readme. current version is 0.2. this is the readme's content: getwinegit.sh-README :: Intro getwinegit is a script which was designed to download/update, compile and install the current wine-git-source-tree. :: Usage Usage: /usr/bin/getwinegit.sh -mode modes: -0 update the local source-tree -1 + compile the source -2 + install -3 no update; just compile the local source-tree and install -h help ;) :: Install Just copy getwinegit.sh wherever you want, make it executable and create a softlink at /usr/bin. Then (or before) configure the script by editing the variables in the head with your favourite editor. (minimum is to set ENABLE="yes") :: Changes 0.2 first stable release. :: Future? Tell me what you need and i will implement it... maybe :D :: Where are you at home? gladiac.onetrix.net :: Bugs? Report them to gladiac at gmail dot com ;) Thanks for reading, bye glad

2 4

Debugging
by Rich Gilson 24 Feb '06

24 Feb '06

I'm kind of new to the Wine schene. I've dabled in it from time to time; but, seeing the progress it has made I am making a serious effort to get my applications running through Wine rather than VMWare. As such, I'm looking for a little advice on debugging issues when apps don't work (yes, I've read what's on winehq.) I have the application KeePass (keepass.sourceforge.net) which installs just fine. When I go to run it, it just drops me right back to the prompt. With WINEDEBUG, I've tried monitoring the fixme (no results at all), ole, dll, loaddll, system, ntdll, oledlg, olerelay, and rundll32, none of which produced any output that seemed to inducate a problem. I suppose that if Wine sent it a value that it didn't like and they have really good error trapping, the apps could have just shut itself down, but I would think that something must be going wrong somewhere in Wine, but I'm at a loss as to how to find it. I have tried it with the version set to win98 as wekk as win2k and I'm running Wine 0.9.8 (without Winetools), with IE6 installed as per the instructions on appdb.winehq.com. Any advise as to what I can try next or what I should be looking for would be greatly appreciated. -- -- In a world without fences, who needs Gates?

2 2

Re: Prepare the unicodification of advpack.dll
by James Hawkins 24 Feb '06

24 Feb '06

On 2/24/06, Francois Gouget <fgouget(a)free.fr> wrote: > > All functions that manipulate strings should have an Ansi and a > Unicode variant. Does it matter that native advpack only has Ansi functions? I think we should leave it the way it is, because any application that uses advpack will only know of Ansi API and adding unicode handling adds more complexity and chances for error. -- James Hawkins

2 2

WineD3D refcounting fun part II :)
by Roderick Colenbrander 24 Feb '06

24 Feb '06

Hi, During the d3d8 -> wined3d transition I noticed one huge refcounting issue which affects both d3d8 and d3d9. The issue is illustrated by running http://www.codesampler.com/source/dx9_multitexture.zip (the same demo is available for dx8) and then modify wined3d's globalChangeGlRam in wined3d_main.c to let it output how it adjusts the memory. If you run the test on d3d9 or using oliver's full d3d8 patch, you'll notice that not all memory is returned when quitting the program. (In 3dmark2001 this is a big issue as because of this we are out of memory after running a few demos) The problem appears that wined3d surfaces contain a reference to the wined3d device. So when you run a game the d3d8 and wined3d device refcounts are out of sync (the wined3d refcount is a lot higher because of all the refcounts from the surfaces). At the moment you quit a game the d3d8 device refcount nicely becomes zero and the object tries to kill itself. The release function also calls the wined3d device release function but the wined3d device object won't kill itself because its refcount doesn't become zero due to all the surfaces which still contain a reference to it. (the surfaces which useally are front-, backbuffers and more are normally released in the wined3d device release call when the refcount becomes zero) One way to 'fix' the problem is to let d3d8/d3d9 handle the reference counts (remove the refcounts from wined3d; and let d3d8/d3d9 call some cleanup function to remove the garbage in case its refcount becomes zero) Does anyone have a better solution? Roderick

4 7

Palm Desktop conduits through Wine?
by Rich Gilson 24 Feb '06

24 Feb '06

Has there every been any luck/attempts at running Palm Desktop conduits through wine? I'd drop Palm Desktop altogether, but I have Documents-To-Go and Passwords Plus, which both only run through Palm Desktop. >From what I can gather from searching around, I'm not going to get Palm Desktop to work on Wine right now, so I'm looking for other alternatives. Thanks. -- -- In a world without fences, who needs Gates?

2 1

AOL
by TWhaymand05＠aol.com 24 Feb '06

24 Feb '06

Would AOL work on WINE? I would be really greatful if you could e-mail back directly because I plaining to move to Linux within the next few days Sincely Toby

3 2

Re: Fix ExitWindows()
by Robert Shearman 24 Feb '06

24 Feb '06

Francois Gouget wrote: > >- if (SendMessageTimeoutW( *phwnd, WM_QUERYENDSESSION, 0, 0, send_flags, INFINITE, &result) && !result) break; >+ if (SendMessageTimeoutW( *phwnd, WM_QUERYENDSESSION, 0, 0, send_flags, 0, &result)) > > Was this change deliberate to remove the check of result? If so, I don't see where else the result of the message can be properly checked. -- Rob Shearman

2 2

re: Problems with Sockets and TCL
by Dan Kegel 24 Feb '06

24 Feb '06

You wrote: >I've found a bug that can be reproduced with two lines of TCL: Great! Can you post a bug report at http://bugs.winehq.org and cc me on it? Be sure to include a full recipe for reproducing the bug, especially the version of tcl and where to download it. I'm glad to see an ISV interested in supporting Wine like this! Is this official interest, or just something you're trying on the side? Thanks, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

[PATCH] Implement GetCurrentHwProfileA() fully
by Ben Collins 24 Feb '06

24 Feb '06

I setup Wine mainly to make use of some online poker clients that I use a lot. I experienced some known bugs related to advapi32.dll, specifically GetCurrentHwProfileA()'s semi-stub. The first issue was that the szHwProfileGuid was being set to a string that was one byte too long. This resulted in it actually being a concantenation of szHwProfileGuid and szHwProfileName. Fixing that, programs like FullTiltPoker.exe were able to work. The website suggested changing the return value to 0 (false), but that was just so things got ignored. The second issue with this function was more related to the hard coding of the GUID. Some sites, such as PacificPoker and ParadisePoker, can and will kill user access to the site. They do not do this by username, but but the Profile GUID (I didn't realize this till I started reading bug reports, and checking things). Presumably, this reduces the chance that someone simply changes their username. They pretty much block the user's system, unless they reinstall, or manually change the GUID. Because of this, all wine installs by default are not allowed to login to these sites (it only took one person to get kicked before the GUID was dead). So, to get things done to my liking, I just bit the bullet and implemented GetCurrentHwProfileA() correctly. The patch below has two parts 1. Implement GetCurrentHwProfileA() fully. It will read the current profile (0x0000 value), and obtain the values from this profile for docking state, profile name, and profile GUID. 2. Add default registry entries for the HWLK\*\IDConfigDB\* values. This still results in a default profile GUID. If anyone knows a way to generate a value for this during wineboot, that's probably the best solution. diff -urN wine-0.9.6/dlls/advapi32/advapi.c wine-0.9.6-ben/dlls/advapi32/advapi.c --- wine-0.9.6/dlls/advapi32/advapi.c 2006-01-19 14:13:51.000000000 +0000 +++ wine-0.9.6-ben/dlls/advapi32/advapi.c 2006-02-24 02:18:26.000000000 +0000 @@ -116,11 +116,57 @@ */ BOOL WINAPI GetCurrentHwProfileA(LPHW_PROFILE_INFOA pInfo) { - FIXME("(%p) semi-stub\n", pInfo); - pInfo->dwDockInfo = DOCKINFO_DOCKED; - strcpy(pInfo->szHwProfileGuid,"{12340001-1234-1234-1234-1233456789012}"); - strcpy(pInfo->szHwProfileName,"Wine Profile"); - return 1; + CHAR profile[32]; + DWORD type; + DWORD size; + DWORD ret; + DWORD val; + HKEY hkey; + BOOL profile_result = 0; + + ret = RegOpenKeyA(HKEY_LOCAL_MACHINE, "System\\CurrentControlSet\\Control\\IDConfigDB", + &hkey); + + if (ret != ERROR_SUCCESS) + goto profile_error; + + ret = RegGetValueA(hkey, NULL, "CurrentConfig", RRF_RT_DWORD, + &type, &val, &size); + if (ret != ERROR_SUCCESS || size != 4 || type != REG_DWORD) + goto profile_error; + + /* At least, I think the profile names are hex */ + sprintf(profile, "Hardware Profiles\\%04x", (WORD)(val & 0xffff)); + + /* Set the profile name */ + size = MAX_PROFILE_LEN; + ret = RegGetValueA(hkey, profile, "FriendlyName", RRF_RT_REG_SZ, + &type, pInfo->szHwProfileName, &size); + + if (ret != ERROR_SUCCESS || type != REG_SZ) + goto profile_error; + + /* Now get the GUID of this profile */ + size = HW_PROFILE_GUIDLEN; + ret = RegGetValueA(hkey, profile, "HwProfileGuid", RRF_RT_REG_SZ, + &type, pInfo->szHwProfileGuid, &size); + + if (ret != ERROR_SUCCESS || type != REG_SZ) + goto profile_error; + + /* And finally the docking state */ + ret = RegGetValueA(hkey, "CurrentDockInfo", "DockingState", RRF_RT_DWORD, + &type, &pInfo->dwDockInfo, &size); + + if (ret != ERROR_SUCCESS || size != 4 || type != REG_DWORD) + goto profile_error; + + /* Success */ + profile_result = 1; + +profile_error: + RegCloseKey(hkey); + return profile_result; } /****************************************************************************** diff -urN wine-0.9.6/tools/wine.inf wine-0.9.6-ben/tools/wine.inf --- wine-0.9.6/tools/wine.inf 2006-01-19 14:14:43.000000000 +0000 +++ wine-0.9.6-ben/tools/wine.inf 2006-02-24 02:19:19.000000000 +0000 @@ -211,6 +211,23 @@ HKLM,System\CurrentControlSet\Control\Session Manager\Environment,"windir",,"%10%" HKLM,System\CurrentControlSet\Control\Session Manager\Environment,"winsysdir",,"%11%" +[IDConfigDB] +HKLM,System\CurrentControlSet\Control\IDConfigDB,"CurrentConfig",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB,"UserWaitInterval",,0x0000001e +HKLM,System\CurrentControlSet\Control\IDConfigDB,"IsPortable",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB\Alias\0000,"DockingState",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB\Alias\0000,"Capabilities",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB\Alias\0000,"DockID",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB\Alias\0000,"SerialNumber",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB\Alias\0000,"ProfileNumber",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB\Hardware Profiles,"Unknown",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB\Hardware Profiles\0000,"PreferenceOrder",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB\Hardware Profiles\0000,"FriendlyName",,"Wine Profile" +HKLM,System\CurrentControlSet\Control\IDConfigDB\Hardware Profiles\0000,"Aliasable",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB\Hardware Profiles\0000,"Cloned",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB\Hardware Profiles\0000,"HwProfileGuid",,"{12340001-1234-1234-1234-123345678901}" + + [Fonts] HKLM,%FontSubStr%,"Arial CE,238",,"Arial,238" HKLM,%FontSubStr%,"Arial CYR,204",,"Arial,204" -- Ubuntu - http://www.ubuntu.com/ Debian - http://www.debian.org/ Linux 1394 - http://www.linux1394.org/ SwissDisk - http://www.swissdisk.com/

2 1