March 2006 - Wine-devel - list.winehq.org

Re: GDI32: freetype.c add more font selecting&linking mechanism support.
by Huw D M Davies 07 Mar '06

07 Mar '06

As Mike has said the patch is too long to review properly, so please break it down into much smaller pieces. On Tue, Mar 07, 2006 at 04:29:04PM +0900, Byeong-Sik Jeon wrote: > and, I add some basic registry value. "Tahoma", "Gulim", "MS UI Gothic", > "Simsun", "PMingLiU". One thing that caught my eye was that these strings are locale dependent rather like the bitmap font strings (see update_font_info). Keep up the good work! Huw. -- Huw Davies huw(a)codeweavers.com

2 4

Re: GDI32: freetype.c add more font selecting&linking mechanism support.
by Mike McCormack 07 Mar '06

07 Mar '06

Byeong-Sik Jeon wrote: > ChangeLog: > - add more font selecting & linking mechanism support. Nice work! Some comments: * Please split each fix into a separate patch. This makes patch reviews and isolating regressions easier. A number of small patches will be accepted into the Wine tree faster than one big patch. * There's also alot of unnecessary formatting changes in your patch, which could be avoided. eg. > - LIST_FOR_EACH_ENTRY(family, &font_list, Family, entry) > - { > + LIST_FOR_EACH_ENTRY(family, &font_list, Family, entry) { * Please stick to coding style in the file you're change, so that we don't end up with a mix of many different coding styles in the same file. (and you don't add unnecessary changes like the above). thanks, Mike

2 1

Re: advpack: Forward OpenINFEngineA and TranslateInfString/ExA to their unicode counterparts
by Alexandre Julliard 07 Mar '06

07 Mar '06

"James Hawkins" <truiken(a)gmail.com> writes: > + > + res = TranslateInfStringW(filenameW.Buffer, installW.Buffer, > + translateW.Buffer, keyW.Buffer, NULL, > + dwBufferSize, &len, NULL); > + > + if (res == S_OK) > + { > + bufferW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + > + res = TranslateInfStringW(filenameW.Buffer, installW.Buffer, > + translateW.Buffer, keyW.Buffer, bufferW, > + dwBufferSize, &len, NULL); > + > + *pdwRequiredSize = WideCharToMultiByte(CP_ACP, 0, bufferW, -1, > + pszBuffer, dwBufferSize, > + NULL, NULL); > + The buffer size and overflow handling is not correct here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winegdb: Fix crash in empty first command
by Eric Pouech 07 Mar '06

07 Mar '06

2006/3/6, Vitor T. Sessak <vitor.sessak(a)m4x.org>: > > Changelog: > winegdb: Fix crash in empty first command > > Winedbg crashes when pressing enter as its first command. this is wrong as the last_line will be HeapFree'd when the next command is keyed in.

1 0

Re: riched20: Implements FR_WHOLEWORD for EM_FINDTEXT
by Phil Krylov 07 Mar '06

07 Mar '06

On Sun, 05 Mar 2006 14:20:47 -0800 Lei Zhang <leiz(a)ucla.edu> wrote: > + if ((flags & FR_WHOLEWORD) && iswalnum(wLastChar)) Probably a test checking if native richedit does not use user's word breaking procedure (set via EM_SETWORDBREAKPROC) for FR_WHOLEWORD searches would be cool. -- Ph.

2 1

How to link and run applications using WinLib
by Arun Kumar Khandelwal 07 Mar '06

07 Mar '06

Hi All, I am able to compile and link my test program using winemaker. It generates a test.exe.so and not test.exe. I do not know how to run this *.so? What should I do to link and run program using winlib? Thanks, Arun

3 2

Re: PATCH: define __user
by Robert Shearman 07 Mar '06

07 Mar '06

dmitry serpokryl wrote: > Hi, > > please beg my pardon for the kind of a possible stupidity, but: > > 1. I'm using SuSE kernel for SuSE 10 x86-64, so all compiliation goes > into x86-64 (not in i386) mode by default Wine automatically adds the -m32 flag to gcc to force it to compile in i386 mode. > 2. gcc - 4.0.2 (release): > Target: x86_64-unknown-linux-gnu > Configured with: ../configure --prefix=/usr/local/gcc-4.0.2 > Thread model: posix > gcc version 4.0.2 That's fine. > 3. $ wine --version > Wine 0.9.7 > (compiled some times ago from CVS. I make CVS updates monthly) As is this. > 4. $ locate unistd.h | egrep usr/include > /usr/include/asm-i386/unistd.h > /usr/include/asm-x86_64/ia32_unistd.h > /usr/include/asm-x86_64/unistd.h > /usr/include/asm.default/ia32_unistd.h > /usr/include/asm.default/unistd.h > /usr/include/kpathsea/c-unistd.h > /usr/include/linux.default/unistd.h > /usr/include/sys/unistd.h > /usr/include/unistd.h > > > 5. /usr/include/asm is a symlink, pointing to -> > /usr/src/linux/include/asm/ I think this is the problem. Is this a default symlink on your distro or was it put there by installing kernel source? > So, I'm not quite understand the reason of compiliation error at this > time. In 32-bit mode the i386 headers should be used instead of x86-64 ones. On your system this isn't happening, although the headers are there. Try looking in /usr/include/asm.default and seeing whether they try to do the right thing and select the right unistd.h for the environment. > > Please beg my pardon for the disturbing. > > Thanks, > > My best regards, > Dmitry > > > > On Tue, 28 Feb 2006 08:08:45 -0300, Robert Shearman > <rob(a)codeweavers.com> wrote: > >> dmitry serpokryl wrote: >> >>> Hi, thanks for your feedback. >>> >>> I just updated wine cvs, no ./configure errors but still "make" >>> unable to complete: >>> >>> gcc -m32 -c -I. -I. -I../../include -I../../include >>> -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe >>> -fno-strict-aliasing -gstabs+ -Wdeclaration-after-statement >>> -Wpointer-arith -g -O2 -o signal_i386.o signal_i386.c >>> signal_i386.c: In function ‘wine_sigaction’: >>> signal_i386.c:123: error: ‘__NR_sigaction’ undeclared (first use in >>> this function) >> >> >> >> You're using some buggy headers that define SYS_sigaction, but don't >> define __NR_sigaction. You should have /usr/include/asm/unistd.h >> that includes /usr/include/asm-i386/unistd.h if not compiling in >> x86_64 mode, and the latter should have a define for __NR_sigaction. >> > > > -- Rob Shearman

1 0

Error while compiling code using wineg++ / winegcc on solaris
by Vikas Gera 06 Mar '06

06 Mar '06

Hi!! I am not able to compile a test program on solaris using winegcc tool. Can anybody help? Here's the program source code: // file test.cpp #include <stdio.h> #include <windows.h> int main () { SYSTEMTIME lpSystemTime; GetSystemTime(&lpSystemTime); printf("Today is: %d/%d/%d\n", lpSystemTime.wYear, lpSystemTime.wMonth, lpSystemTime.wDay); return 0; } When I try to compile it using winegcc, it gives following error message: testuser(a)testbox:~/test >wineg++ test.cpp winegcc: -fshort-wchar failed. On adding a flag '-v' with wineg++, a detailed error message is displayed: testuser(a)testbox:~/test >wineg++ -v test.cpp -fshort-wchar -DWINE_UNICODE_NATIVE -D_REENTRANT -fPIC -DWIN32 -D_WIN32 -D__WIN32 -D__WIN32__ -D__WINNT -D__WINNT__ -D__stdcall=__attribute__((__stdcall__)) -D__cdecl=__attribute__((__cdecl__)) -D__fastcall=__attribute__((__fastcall__)) -D_stdcall=__attribute__((__stdcall__)) -D_cdecl=__attribute__((__cdecl__)) -D_fastcall=__attribute__((__fastcall__)) -D__declspec(x)=__declspec_##x -D__declspec_align(x)=__attribute__((aligned(x))) -D__declspec_allocate(x)=__attribute__((section(x))) -D__declspec_deprecated=__attribute__((deprecated)) -D__declspec_dllimport=__attribute__((dllimport)) -D__declspec_dllexport=__attribute__((dllexport)) -D__declspec_naked=__attribute__((naked)) -D__declspec_noinline=__attribute__((noinline)) -D__declspec_noreturn=__attribute__((noreturn)) -D__declspec_nothrow=__attribute__((nothrow)) -D__declspec_novtable=__attribute__(()) -D__declspec_selectany=__attribute__((weak)) -D__declspec_thread=__thread -D__WINE__ -D__int8=char -D__int16=short -D__int32=int -D__int64=long long -c -o test-9pH6Aj.o -v test.cpp -isystem/opt/cfw/wine/include/wine/windows winegcc: -fshort-wchar failed. I can see a lot of compile flags/options. I want to be able to enable/disable these options. Or if there is some other way to be able to compile the code using wingcc, pleae tell me. The code works well on windows. I even managed to compile it using gcc, but it resulted in coredump. If somebody can guide me how to compile an application using winelib, which can run on solaris. I am getting linker/loader errors. thanks!! Vikas Gera

3 2

Re: KERNEL32: Improve descriptions
by Alexandre Julliard 06 Mar '06

06 Mar '06

Vitaly Lipatov <lav(a)etersoft.ru> writes: > -UINT WINAPI GetTempFileNameW( LPCWSTR path, LPCWSTR prefix, UINT unique, LPWSTR buffer ) > +UINT WINAPI GetTempFileNameW( LPCWSTR lpPathName, LPCWSTR lpPrefixString, UINT uUnique, LPWSTR lpTempFileName ) *Please* don't change nice readable parameter names into the horrible Hungarian line noise format. -- Alexandre Julliard julliard(a)winehq.org

4 3

Re: FONTS: fix Courier font
by Dmitry Timoshkov 06 Mar '06

06 Mar '06

"Vitaly Lipatov" <lav(a)etersoft.ru> wrote: > The main change is > -Ascent: 11 > -Descent: 2 > +Ascent: 10 > +Descent: 3 Last time I asked Huw said that this is a bug in fontforge, the font files have correct values. -- Dmitry.

3 6