March 2006 - Wine-devel - list.winehq.org

Re: [PATCH 2/3] [Dnsapi.dll] Implement Dnsapi.dll
by Mike McCormack 02 Mar '06

02 Mar '06

Also, please disable your challenge/response spam "filter". Solving your spam problem by spamming everybody else is not cool. You wrote to us with a patch, you solicited our response, so why are you spamming us back? I'd advise others to not respond to spam from bluebottle.com. Mike

1 0

Re: [PATCH 2/3] [Dnsapi.dll] Implement Dnsapi.dll
by Dmitry Timoshkov 02 Mar '06

02 Mar '06

"MattK" <mekjedi(a)bluebottle.com> wrote: > + if(fdwReason == DLL_THREAD_ATTACH) > + { > + DisableThreadLibraryCalls(hinstDLL); > + return TRUE; > + } This is not an appropriate place to call DisableThreadLibraryCalls, how did you come with it when there are a lot of examples in the Wine tree? -- Dmitry.

1 0

Re: x11drv fix for bug#4506: page fault on read access
by Alexandre Julliard 02 Mar '06

02 Mar '06

Rein Klazes <wijn(a)wanadoo.nl> writes: > Fixing bug #4506: unaligned 32bit access, can access one byte beyond the > pixel buffer. > > Changelog: > dlls/x11drv : dib_convert.c > Avoid unaligned 32 bit reads, and reads beyond the input pixel buffer in > the convert_888_to_0888_* functions. This will badly hurt performance, you don't want to check alignment on every pixel. You should only check on the first one and copy 1 to 3 pixels as needed to align things properly, then do the 4 pixels at a time thing. -- Alexandre Julliard julliard(a)winehq.org

3 2

[wined3d] glStencilOpSeparate & glStencilFuncSeparate symbol errors
by Aric Cyr 02 Mar '06

02 Mar '06

The recent patch: http://winehq.org/pipermail/wine-patches/2006-February/024656.html can cause linker errors for the two symbols glStencilOpSeparate and glStencilFuncSeparate. The reason being that these are only exported in OpenGL 2.0 compatible libraries, and in particular, are not present in ATI's binary driver. This causes wined3d to fail to build (compiles fine but linking fails). I suspect that Vitaly is already working on fixing this, but thought I'd mention it anyways since other might run into the same problem. Cheers, Aric

1 0

Re: [PATCH 2/3] [Dnsapi.dll] Implement Dnsapi.dll
by Mike McCormack 02 Mar '06

02 Mar '06

MattK wrote: > +BOOL WINAPI DnsNameCompare_A(LPSTR pName1, LPSTR pName2) > +{ > + TRACE("(%s %s)\n",pName1, pName2); > + > + LPSTR name1 = pName1; > + LPSTR name2 = pName2; > + > + RemovePeriods(name1); > + RemovePeriods(name2); > + > + int equal; > + > + equal = lstrcmpiA(name1,name2); > + > + return !equal; > +} This is still not correct. You can't modify name1, and name2 in place. You shouldn't use inline declarations (ie. the "int equal" should be after the bracket.) There's also no in assigning pName1 to name1, it doesn't make a copy of the string as you suspect, it makes a copy of the pointer to the string. > + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} You SetLastError or return an error code, not both. > diff -Nu dlls/dnsapi/utils.c dlls/dnsapi/utils.c There's no need to make a seperate file for this. > +LPSTR RemovePeriods(LPSTR string) > +{ > + if(string == NULL) > + return NULL; > + DWORD d = 0; > + > + while(string[d] == '.') > + { > + string--; > + } > + > + return string; > +} This won't work at all... If you wrote some better test cases you would discover these problems. How about testing: DnsNameCompare_A(NULL, NULL) DnsNameCompare_A("", ".") DnsNameCompare_A("..........", "..........") DnsNameCompare_A(".a.b.c.d.e.", "abcde") DnsNameCompare_A("a.com.","a.com") DnsNameCompare_A("A.com", "a.com") DnsNameCompare_A(".A.com", "a.com") DnsNameCompare_A("Acom", "acom") etc. Mike

1 0

Re: wined3d: Fix compile for older OpenGL headers.
by H. Verbeet 01 Mar '06

01 Mar '06

Although #ifdef GL_VERSION_2_0 will make compilation work with older OpenGl headers, it's not the way to fix this. Basically, wined3d should check for functionallity during runtime with GL_SUPPORT and call extensions with GL_EXTCALL. The issue has come up a few times before with patches from the same author, and I think he should be aware of the issue by now.

3 3

Re: [PATCH 1/4] [WineDbg]: main_loop
by Alexandre Julliard 01 Mar '06

01 Mar '06

Eric Pouech <eric.pouech(a)wanadoo.fr> writes: > - split dbg_main_loop in two parts (one for finishing the debuggee > attachment, the second one really for handling the main loop) > - removed now longer needed dbg_main_loop Auto mode is still broken with this patch... did you really test it? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: wined3d: Implemented WINED3DRS_DEPTHBIAS
by H. Verbeet 01 Mar '06

01 Mar '06

On 01/03/06, Vitaly Budovski <vbudovsk(a)cs.rmit.edu.au> wrote: > + glPolygonOffset(*((float*)&This->stateBlock->renderState[WINED3DRS_SLOPESCALEDEPTHBIAS]), tmpvalue.f); Does this compile?

1 0

Re: wined3d: Add function pointers to glSupportOpSeparate and glSupportFuncSeparate
by H. Verbeet 01 Mar '06

01 Mar '06

On 01/03/06, Vitaly Budovski <vbudovsk(a)cs.rmit.edu.au> wrote: > wined3d: Add function pointers to glSupportOpSeparate and > glSupportFuncSeparate > That's not going to help much if you don't actually use them. Also, you probably want to be able to detect if the functions are actually available, instead of just dereferencing a NULL pointer if they aren't.

1 0

Re: riched20: EM_AUTOURLDETECT/EM_GETAUTOURLDETECT implementation
by Alexandre Julliard 01 Mar '06

01 Mar '06

Brandon Woodmansee <bwood(a)ucla.edu> writes: > + case EM_AUTOURLDETECT: > + { > + if (wParam==1) > + { > + editor->AutoURLDetect_bEnable=1; > + return 0; > + } > + > + if (wParam==0) > + { > + editor->AutoURLDetect_bEnable=0; > + return 0; > + } > + return E_INVALIDARG; E_INVALIDARG is a pretty strange return value for a window procedure. Do you have a test case for that? -- Alexandre Julliard julliard(a)winehq.org

1 0