June 2006 - Wine-devel - list.winehq.org

Re: configure: Fix test for ability to link with ICU libraries.
by Alexandre Julliard 14 Jun '06

14 Jun '06

Scott Bambrough <scottb(a)xandros.com> writes: > @@ -603,8 +603,8 @@ if test "$ac_cv_header_unicode_ubidi_h" > then > saved_libs="$LIBS" > ICU_LIB_DIR="${ICU_LIB_DIR-/usr/lib}" > - ICUUC_LIB="${ICUUC_LIB-$ICU_LIB_DIR/libsicuuc.a}" > - ICUDATA_LIB="${ICUDATA_LIB-$ICU_LIB_DIR/libsicudata.a}" > + ICUUC_LIB="${ICUUC_LIB-$ICU_LIB_DIR/libicuuc.a}" > + ICUDATA_LIB="${ICUDATA_LIB-$ICU_LIB_DIR/libicudata.a}" The libraries have different names on different setups, that's why there are environment variables you can set. If you want a better fix you need to make configure probe for the various names. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [Setuapi] implement SetupDiCreateDeviceInfoListExW - try 3
by Juan Lang 14 Jun '06

14 Jun '06

Hi Christian, > I want to make a generic setupapi.dll and I will remove old serial > device list, but as too big patches wont get accepted, I will do this in > one of my next patches. I put that hacky serial device list in there. I don't actually use the app that fixed under Wine, as 1) Wine's serial code never worked for the app, and 2) I no longer have the device it used. So, I don't know if that'll convince AJ or not, but I'm fine with you axing it. Leaving half-working code in there is more likely to get rejected than a big patch, IMO, so I'd suggest you remove it. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 1

Duplicate message by configure
by Gerald Pfeifer 14 Jun '06

14 Jun '06

Disclaimer: I am aware that the system I tested this on is lacking a required library, this is not what I'm trying to describe. When running configure, I get the following message twice: checking for xmlParseMemory in -lxml2... yes checking for xmlReadMemory in -lxml2... yes Package libxslt was not found in the pkg-config search path. Perhaps you should add the directory containing `libxslt.pc' to the PKG_CONFIG_PATH environment variable No package 'libxslt' found -> Package libxslt was not found in the pkg-config search path. -> Perhaps you should add the directory containing `libxslt.pc' -> to the PKG_CONFIG_PATH environment variable -> No package 'libxslt' found checking for libxslt/pattern.h... no checking for libxslt/transform.h... no Where does this come from? Can we fix this somehow? Gerald

2 1

How are we doing?
by Mike Hearn 14 Jun '06

14 Jun '06

As the Summer Of Code begins and new blood joins us all at once, I thought it'd be a good time to open a discussion on how we are doing as a project. Questions to consider: * Is Wine improving or is the regression rate matching the improvement rate? * Are we producing a quality product, from the perspective of non-technical end users? (I appreciate this isn't a goal for everyone) * Are we turning away potential developers for any reason? Could we do more to attract new hackers? * Are the projects fundamental processes serving us well? * Any other thoughts for improvement? In case it's not clear, I'm talking about the project as a community adventure here rather than technical aspects of the codebase. >From my own perspective I think Wine is doing better than ever before. What prompted this email is the realisation that in the past few days I've used Wine nearly every day to run a variety of apps - from games to utilities - and it's succeeded with every single one. Not always perfect but always good enough. I am no longer surprised when Wine runs an app correctly as I was when I first came to the project, these days I nearly take it for granted. Though this may be due to having developed a feel for what will work and what won't :) So clearly we're doing something right ... I also think we are doing OK with attracting and keeping new hackers. The influx of new Direct3D talent lately is fabulous for instance. The experiences of our SoC students will be useful in assessing how to improve the learning curve and we need to tap this resource better than we did last year. In other words, I think we're doing pretty well. I feel more positive about the project that I have done for a long time. It seems like as Win32 stagnated and slowed down over the past 6 years we've been able to turn the tide and add our own code faster than Microsoft can, which is the tipping point. So areas for improvement? * We seem to be doing very well in recruiting hackers who work on one particular DLL or area and solidly improve that, but a less well when it comes to 'general purpose' hackers who just take random apps and make them work. It might just be that I'm out of touch but I don't see as much patch traffic these days along the lines of "This patch set fixes XYZ app" followed by 6 patches to 6 different DLLs. Discussion on IRC/wine-devel is * No clear roadmap to 1.0 - for 0.9 we had Dimis TODO list and it was quite satisfying to see them go green as tasks were completed. I guess we have a 1.0 TODO list too but I never see any updates to it :( * Integration with other projects is still a weak area. Desktop/kernel/X integration could all use some work. I know I know, I'm guilty in not doing my bit here too .... maybe I will find my hack-fu returning sometime soon and work on the fullscreen patch again :) * App specific patches. Well I don't expect policy here to change anytime soon but extreme cases like the WoW VMA layout problem which affects tons of users do highlight the issue. * A few random things I already got into arguments about (forums, libwine api etc) :) What do you guys think? thanks -mike

34 69

Re: msvcrt[2/3]: add initial tests for dlls/msvcrt/data.c [try 2]
by Uwe Bonnes 14 Jun '06

14 Jun '06

>>>>> "Andrew" == Andrew Ziem <ahziem1(a)mailbolt.com> writes: Andrew> because tests yield inconsistent results */ +#if 0 + /* address #if 0 in a patch is depreciated. If the test fails on wine, butt succeeds in windows, use todo_wine(). If there are other conditions that must be met, tell these conditions, perhaps like #define SOME_SPECIAL_TEST 0 #ifdef SOME_SPECIAL_TEST so that others can decipher what you mean. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

3 2

Re: [Setuapi] implement SetupDiCreateDeviceInfoListExW - try 3
by Detlef Riekenberg 14 Jun '06

14 Jun '06

Hi Christian Gmeiner: > Sorry for the new version, but i got rid of the whitspace stuff and also > added a check if Reserved != NULL. > > I hope that this patch is ready to commit now. + if (MachineName != NULL) + { + FIXME("remote support is not implemented"); + goto cleanup; + } A failure should always set an error. You should add a test for this in the testsuite. (winspool as example uses an empty servername the same way as NULL). For external Servers, ERROR_ACCESS_DENIED is a very common Result. + if (Reserved != NULL) + { + SetLastError(ERROR_INVALID_PARAMETER); + goto cleanup; + } Same here. This is simple to test in the testsuite. - SerialPortList *list = (SerialPortList *)devinfo; + struct DeviceInfoSet *list = (struct DeviceInfoSet *)devinfo; - if (list->magic == SETUP_SERIAL_PORT_MAGIC) + if (list->magic == SETUP_DEVICE_INFO_SET_MAGIC) { This is wrong. Read: static HDEVINFO SETUP_CreateSerialDeviceList(void) (line 904) --------------- In your test: + // create empty DeviceInfoList C++ comments are not allow (not supported by some compiler) + devlist = SetupDiCreateDeviceInfoListExW(NULL, NULL, NULL, NULL); + + ok(devlist && devlist != INVALID_HANDLE_VALUE, "SetupDiCreateDeviceInfoListExW failed : %p %ld\n", devlist, GetLastError()); - You missed the "SetLastError(0xdeadbeef);" before the tested function. - The first Part of your "ok()" - message ("SetupDiCreateDeviceInfoListExW failed :") has no additional infos. When a test fails, you will already get: "__FILE__:__LINE__: Test failed:" You know the dll, file and line of the failing "ok()" - statement. Example: info.c:932: Test failed: returned 0 with 1801 (expected '!=0' or '0' with ERROR_INVALID_PARAMETER) You may want to look at my recent Tests / Implementations for GetPrintProcessorDirectory or AddMonitor/DeleteMonitor (winspool.drv), but do not use the macro "MAGIC_DEAD" in the tests (it works, but 0xdeadbeef has more advantages). As an Example, that we really need tests for every API-Function: The second Parameter of "DeleteMonitor" is ignored in all tested Windows-Versions. -- By By ... ... Detlef

2 1

Re: wine XShm problem on remote display
by Benjamin Fabricius 14 Jun '06

14 Jun '06

Am Dienstag, den 13.06.2006, 16:22 +0200 schrieb Alexandre Julliard: > Benjamin Fabricius <benjamin.fabricius(a)lawo.de> writes: > > > vst:/opt/fst # ./fst /mnt/testsuite/oberon4/Oberon-8.dll > > yo... lets see... > > The program 'fst.exe.so' received an X Window System error. > > This probably reflects a bug in the program. > > The error was 'BadAccess (attempt to access private resource denied)'. > > (Details: serial 114 error_code 10 request_code 144 minor_code 1) > > (Note to programmers: normally, X errors are reported asynchronously; > > that is, you will receive the error a while after causing it. > > To debug your program, run it with the --sync command line > > option to change this behavior. You can then get a meaningful > > backtrace from your debugger if you break on the gdk_x_error() > > function.) > > Wine will handle that error properly, but here it sounds like fst (or > more likely Gtk) has replaced the Wine error handler with its own, so > Wine doesn't get a chance to handle it. > thanks for the hint, isn't there a possibility in wine to turn of the use of the xshm extension globally? i read that there used to be wine.conf with [x11drv] ...... ; Use XFree86 DGA extension if present UseDGA = Y ; Use XShm extension if present UseXShm = Y ...... is there a mechanism to do this in my wine version (20050725) or current builds? or do you see a way different way to workaround this, i. e. to write an own error handler. i'm not to deep into the x matter though... thanks again bf -- ------------------- Benjamin Fabricius German Student Lawo AG

2 1

Re: Implement more GLSL instructions
by Ivan Gyurdiev 14 Jun '06

14 Jun '06

> As of this patch, Wine now supports more opcodes in GLSL than > ARB_vp/fp and we can handle many of the shader 2.0+ instructions not > available before. There are a few missing texture operations compared > to ARB still, and we're not properly handling textures for any shaders > <2.0, but that's true in ARB as well. Yes, the missing texture operations are kind of important, I think [ but they are valid in SM 1.x only ]. Other suggestions I have: - fix swizzle, make it work consistently across all instructions (see cmp). - may be a good idea to centralize casting in one place to avoid failures [ yes, I probably should have done that when adding casting in my patch :) - merge the rest of the SHADER_ARB code, and organize it the same as the SHADER_GLSL code (in arb_shader.c or something like that). Then go through and compare the two and make sure modifiers and other such things work the same way. ===== For 1.x texture support we could delay compilation until we know what kind of textures will be bound, and then recompile if textures change their dimensionality [ which hopefully they won't ].

1 0

One more shot at ntoskrl implementation
by Vitaliy Margolen 14 Jun '06

14 Jun '06

Here is last instalment of safedisc support in Wine. The major change from last version is the way user space talks to ntoskrnl. Now I'm passing the information through wineserver with a help of 4 server calls. There are still some areas that require work. I will appreciate any input that you guys might have about any part of this code. It's been on my lap for way too long. It would be really cool to finally get it in. PS: Diffed against 1d40bf0141b7f67b1188555962698f5dab631bc3. Need to run tools/make_reqwests. -- Best regards, Vitaliy

2 2

Re: msi: Add tests for MsiInstallProduct
by James Hawkins 13 Jun '06

13 Jun '06

On 6/12/06, James Hawkins <truiken(a)gmail.com> wrote: > Hi, > > Changelog: > * Add tests for MsiInstallProduct. > Ignore this patch for now. Eclipse changed necessary tabs to spaces, and I forgot to include module imports for Makefile.in. I'll resend it tonight. -- James Hawkins

1 0