July 2006 - Wine-devel - list.winehq.org

Re: SetLastError in CreateWindowEx
by James Hawkins 08 Jul '06

08 Jul '06

On 7/7/06, Dan Hipschman <dsh(a)linux.ucla.edu> wrote: > I noticed that sometimes when CreateWindowEx fails and the app tries to > display a helpful error message, you get something like "Couldn't create > window: Success." These are the error codes that XP sets for the given > failures. > > ChangeLog: > * Correctly call SetLastError in a few places where CreateWindowEx fails. This is a great candidate for a conformance test. -- James Hawkins

1 0

Possible bug in WINE or NDISWRAPPER
by Jacob Reynoldson 08 Jul '06

08 Jul '06

Greetings! First off, let me say that I recently switched to Ubuntu Linux from WinXP, and with Wine powering the only Windows program I ever used (that doesnt have a Linux version like Firefox, GAIM, OO.o, etc), and I couldnt be happier. Secondly, I apologize for contacting in this manner, since the FAQ says this is where suggestions go, so I hope this is where you want this comment. Now on to what I believe might be a repeatable bug. Setup: Ubuntu 6.06 (Dapper), fully updated as of 7/7/2006. D-Link wireless USB DWL-G132. Wine 0.9.16 (current). I have been using NDISWRAPPER to use my wireless device, a Dlink DWL-G132. I have not had any trouble with this device since I got it running in Linux. Wine has been running without error, and the programs I have been running are AORC+ (1.0.56 version), and Anarchy Online (Fully upgraded, all expansions). I am able to achieve 20-60 FPS with Anarchy Online, which rivals my Windows Install (but I am running only 16 bit graphics to do it). The issue is this: I am uncertain which is the culprate (my guess is NDISWRAPPER), but when I run Anarchy Online for more than a few minutes, my network cuts out (the program doesnt close or crash), and I am unable to reconnect to the Internet using any method I know (Soft reboot Gnome, removing Wine from memory, disabling and re-enabling the wireless device). To reconnect, I have to reboot. When I run off of my ethernet card (Nvidia Nforce2, on board), everything runs flawlessly until I chose to quit. Since I am unable to isolate (given my current toolset) whether it is Wine or Ndiswrapper, it appears that the interaction between the two buckle under the strain of playing a MMO... unless my wireless device is faulty. I have not had these troubles in Windows XP (Service Pack 2), and Wine works fine when I run from my ethernet port. I hope this is useful, I just wasnt sure who needed to be contacted in regards to this possible conflict. Sincerely, Jacob Reynoldson, new Ubuntu convert. -- Jacob Reynoldson Currently located in: Huntington Beach, California

1 0

Re: msi: appsearch
by Juan Lang 07 Jul '06

07 Jul '06

> if trying to find a DLL that is located in the system directory, also check for > a builtin version Can't this be done by putting a fake dll entry in wine.inf? --Juan

2 2

Re: ole32: Get the threading model value for inproc classes and output a fixme if we should create it in an apartment of another type.
by Alexandre Julliard 07 Jul '06

07 Jul '06

Robert Shearman <rob(a)codeweavers.com> writes: > dlls/ole32/compobj.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 45 insertions(+), 0 deletions(-) This one crashes the urlmon tests: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so url.c && touch url.ok wine: Unhandled page fault on read access to 0x0000000c at address 0x407536a9 (thread 0323), starting debugger... WineDbg starting on pid 0x322 Unhandled exception: page fault on read access to 0x0000000c in 32-bit code (0x407536a9). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:407536a9 ESP:406cf6b0 EBP:406cfb58 EFLAGS:00010202( - 00 - -RI1) EAX:00000000 EBX:407ab11c ECX:40380020 EDX:40380024 ESI:40034000 EDI:0000005c Stack dump: 0x406cf6b0: 40380000 00000008 00000010 406cfb44 0x406cf6c0: 406cfb2c 406cfb48 406cf6d8 406cf71c 0x406cf6d0: 00000040 406cf82c 0000004a 401cdc5e 0x406cf6e0: 403ce208 406cf704 406cf718 00000498 0x406cf6f0: 406cfb48 406cfb44 401ed0eb 406f9df0 0x406cf700: 406cfc80 406cf75c 406cf798 401f18ed Backtrace: =>1 0x407536a9 get_inproc_class_object+0xa9(hkeydll=0x5c, rclsid=0x406cfc80, riid=0x406f9df0, ppv=0x406cfd64) [/home/julliard/wine/wine/dlls/ole32/compobj.c:1593] in ole32 (0x407536a9) 2 0x4075407e CoGetClassObject+0x1fe(rclsid=0x406cfc80, dwClsContext=0x1, pServerInfo=0x0, iid=0x406f9df0, ppv=0x406cfd64) [/home/julliard/wine/wine/dlls/ole32/compobj.c:1710] in ole32 (0x4075407e) 3 0x406ed5b6 get_protocol_iface+0x1a6(schema=0x406cfce0, schema_len=<register not in topmost frame>, ret=0x406cfd64) [/home/julliard/wine/wine/dlls/urlmon/session.c:95] in urlmon (0x406ed5b6) 4 0x406ed88f get_protocol_info+0xff(url=0x403ce460) [/home/julliard/wine/wine/dlls/urlmon/session.c:124] in urlmon (0x406ed88f) 5 0x406e9c12 CoInternetCombineUrl+0x32(pwzBaseUrl=0x403ce460, pwzRelativeUrl=0x405b8cf6, dwCombineFlags=0x0, pwzResult=0x403ce3a0, cchResult=0x3d, pcchResult=0x406cfe10, dwReserved=0x0) [/home/julliard/wine/wine/dlls/urlmon/internet.c:197] in urlmon (0x406e9c12) 6 0x406f1ef6 CreateURLMoniker+0x166(pmkContext=0x403ce320, szURL=0x405b8cf6, ppmk=0x406cfe94) [/home/julliard/wine/wine/dlls/urlmon/umon.c:1077] in urlmon (0x406f1ef6) 7 0x405b4881 func_url+0xa1 [/home/julliard/wine/wine/dlls/urlmon/tests/url.c:109] in urlmon_test (0x405b4881) 8 0x405b58c1 run_test+0x121(name=0x403804a7) [/home/julliard/wine/wine/dlls/urlmon/tests/../../../include/wine/test.h:365] in urlmon_test (0x405b58c1) 9 0x405b5be9 __wine_spec_exe_entry+0x99(peb=0x40219820) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:37] in urlmon_test (0x405b5be9) 10 0x405000bb start_process+0xeb(arg=0x0) [/home/julliard/wine/wine/dlls/kernel/process.c:832] in kernel32 (0x405000bb) 11 0x4001da77 wine_switch_to_stack+0x17 in libwine.so.1 (0x4001da77) 0x407536a9 get_inproc_class_object+0xa9 [/home/julliard/wine/wine/dlls/ole32/compobj.c:1593] in ole32: movl 0xc(%eax),%eax 1593 if (apt->multi_threaded) Wine-dbg> -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: DDraw: Split up the ddraw refcount
by Alexandre Julliard 07 Jul '06

07 Jul '06

Stefan Dösinger <stefandoesinger(a)gmx.at> writes: > + if(ref == 0) InterlockedDecrement(&This->numIfaces); > > - /* This is for the dll cleanup code in DllMain() */ > - if(!This->DoNotDestroy) > - IDirectDrawImpl_Destroy(This); > - } > + /* Checks the refcount before actually destroying the object */ > + IDirectDrawImpl_Destroy(This); This isn't thread safe, you should only call Destroy when the InterlockedDecrement returns 0, otherwise there's no point in using interlocked functions at all. Also you should get rid of the DoNotDestroy flag and use the refcount for that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oleaut32: Copying a NULL BSTR should result in an empty BSTR in VariantCopy
by Robert Shearman 07 Jul '06

07 Jul '06

qingdoa daoo wrote: >Hi, > >This patch should fix Bug 4141 > >Changelog: > Copying a NULL BSTR should result in an empty BSTR in VariantCopy > >------------------------------------------------------------------------ > >--- dlls/oleaut32/variant.c.cvs 2006-07-05 17:23:04.000000000 +0800 >+++ dlls/oleaut32/variant.c 2006-07-05 17:31:53.000000000 +0800 >@@ -719,13 +719,16 @@ HRESULT WINAPI VariantCopy(VARIANTARG* p > else if (V_VT(pvargSrc) == VT_BSTR) > { > if (V_BSTR(pvargSrc)) >- { > V_BSTR(pvargDest) = SysAllocStringByteLen((char*)V_BSTR(pvargSrc), SysStringByteLen(V_BSTR(pvargSrc))); >- if (!V_BSTR(pvargDest)) >- { >- TRACE("!V_BSTR(pvargDest), SysAllocStringByteLen() failed to allocate %d bytes\n", SysStringByteLen(V_BSTR(pvargSrc))); >- hres = E_OUTOFMEMORY; >- } >+ else >+ { >+ OLECHAR c = 0; >+ V_BSTR(pvargDest) = SysAllocString(&c); >+ } >+ if (!V_BSTR(pvargDest)) >+ { >+ TRACE("Allocation failed for destination BSTR\n"); >+ hres = E_OUTOFMEMORY; > } > } > else if (V_VT(pvargSrc) == VT_RECORD) > > I think you could get the same result by just removing the "if (V_BSTR(pvargSrc)" check. This should result in simpler code. -- Rob Shearman

1 0

Re: [AppDB] - cleanup require/require_once()/include()
by Jonathan Ernst 07 Jul '06

07 Jul '06

Le vendredi 07 juillet 2006 à 00:37 -0400, Chris Morgan a écrit : > Use require() for path.php and include/incl.php. We can't proceed without > these files. Use require_once() for all include/*.php files. To simplify > inclusion each file includes the other files it needs. In this manner we > don't have to include "mail.php" when we include "application.php", something > that was done all over the place in the appdb. Remove unnecessary includes > of mail.php and other classes that weren't being used. Add missing includes > for some classes that were being used but not being included. > > Chris > That makes sense to me.

1 0

Re: [ntdll/tests] Added some NULL testing
by Alexandre Julliard 07 Jul '06

07 Jul '06

Paul Vriens <Paul.Vriens(a)xs4all.nl> writes: > Hi, > > added some tests with NULL parameters. > > Changelog > Added some NULL testing I appreciate your willingness to write tests, but please don't spend too much effort on testing NULL inputs, it's not an interesting case unless there's a specific app that depends on it. Otherwise we end up adding NULL checks all over the place for no good reason. It's much more interesting to test valid inputs. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: FIXED: Running siap and modules under wine, first steps
by Alex Villacís Lasso 07 Jul '06

07 Jul '06

Maximiliano Curia wrote: > On Monday 12 June 2006 14:59, you wrote: > >> As of 2006-06-09, the CVS snapshot of Wine seems to run SIAP correctly. >> No crashes at all. Could you please be so kind as to test with the *most >> recent CVS snapshot* and confirm? >> > > I tested SIAP under one of the 0.9.15 nightly snapshots, and another > 0.9.16 nightly snapshot. It did work better than before, but some > things are still not working right. > > One thing is that the installations done by "WineTools" are needed to > get SIAP working, and the latest Wine does not work with WineTools. > However, I used a previous "drive_c" with WineTools already applied to > it, and got the app to start and could test it. > > Currently, the Siap program itself works fine, but when you load any > external modules, it doesn't work correctly. Some modules won't load at > all, some other would crash and the wine debugger would be called, and > some of them would load ok. > > This is quite difficult to debug, since the program itself is really > messy. It's amazing the job that has been done by the Wine team up to > now. Anyway, if you want to download them, these are some of the > conflicting modules: > > ftp://www.afip.gov.ar/sicore/sicorev62r0.exe > ftp://www.afip.gov.ar/multinota/multinota.exe > > The first one doesn't even load, the second one loads, but crashes when > clicking on something. > > Also, after trying several things the siap installation broke. > > First, could you please *not* use WineTools with recent Wine versions? There has been lots of discussions in wine-devel over whether WineTools is actually damaging a Wine installation instead of helping it. If you want to keep a WineTools-modified .wine directory, please rename it, then re-install SIAP. The .wine directory will be recreated if it does not exist. All of my tests are done without WineTools, in order to remove interference. Could you please provide me with the valid format of a CUIT number for a record? I need it in order to create a record that is accepted by the plugin modules - all of them require a record with a CUIT in order to run. Alex Villacís Lasso

1 0

Re: [AppDB] - preferences.php cleanups
by Jonathan Ernst 07 Jul '06

07 Jul '06

Le vendredi 07 juillet 2006 à 01:06 -0400, Chris Morgan a écrit : > Stop using global variables in preferences.php. Reorder functions so we don't > have php code running and functions in the middle of it. Rename a couple of > variables to match our current variable naming convention. > > Chris > This one will conflict with the filter.php enabling in this file, can you redo it afterwards ? Thanks.

1 0