July 2006 - Wine-devel - list.winehq.org

Re: [dinput-0/6] multiple devices - Resend #2
by Robert Reif 05 Jul '06

05 Jul '06

The iteration is already done for you in IDirectInputWImpl_EnumDevices . You only need to probe for the specified device in joydev_enum_deviceW where id is the index of the device being probed ("/dev/input/event%d", id). Pass the id to joydev_have(). Look at the linux_input code to see how it is done.

2 1

Re: WineD3D: Flip WINED3DFMT_R8G8B8 to GL_RGB
by Ivan Gyurdiev 05 Jul '06

05 Jul '06

Stefan Dösinger wrote: > WINED3DFMT_R8G8B8 means that the 8 most significant bits contain the red color > channel, and the 8 least significant ones the blue channel. But in memory the > least significant bits are at the highest address, so the surface ends up as > BGR in memory. This patch finally changes that after the surface format > cleanup has been done as requested by AJ. > > To my knowledge this format has been changed at least 3 times. Originally(in > old d3d8) it was GL_RGB as this seems most intuitive. Then Oliver noticed the > endianity problem and flipped it to GL_BGR, but incorrectly changed > WINED3DFMT_R5G6B6 too, which caused gl errors with the 16 bit format. Some > time later a patch for WINED3DFMT_R5G6B6 was sent which incorrectly changed > WINED3DFMT_R8G8B8 back to GL_RGB too. This patch only modifies > WINED3DFMT_R8G8B8 and leaves the other formats in peace :-) > And what about LockRect() ?

2 2

wine bugzilla questions
by Molle Bestefich 05 Jul '06

05 Jul '06

Regarding the Wine bugzilla "keywords": http://bugs.winehq.org/describekeywords.cgi 1) Where are they documented? 2) What does FIXME mean (seems superfluous)? 3) Should there be an "installer" keyword to easily pinpoint installer problems?

1 0

Re: [dinput-0/6] multiple devices - Resend #2
by Robert Reif 05 Jul '06

05 Jul '06

Christoph Frick wrote: >hiho > >this is again my patch for handling more than one /dev/input/event* >joystick within dinput. there are several other patches now to follow, >that expect this patch to be applied. so i label this one 0 of 6. >against the previous version it only has some "detect first joystick" >code moved around. > >License: LGPL >ChangeLog: >2006-07-02 Christoph Frick <rid(a)zefix.tv> >multiple /dev/input/event* joysticks > > > Why are you changing the code outside of joystick_linuxinput?

3 3

Re: msvcrt [2/4]: Change the do-while loop to a while loop as arg can be NULL before the loop
by Alexandre Julliard 05 Jul '06

05 Jul '06

"James Hawkins" <truiken(a)gmail.com> writes: > Changelog: > * Change the do-while loop to a while loop, as arg can be NULL before the loop. I'm not sure what code checker you are using for these things, but please don't blindly quiet the warnings, try to understand the code and fix it the right way. Pretty much every one of your NULL check patches has the same problem. -- Alexandre Julliard julliard(a)winehq.org

1 0

wine and serial port - again
by Pavel Troller 05 Jul '06

05 Jul '06

Hi! From time to time, complaints can be heard about functionality of the serial port implementation in wine. Just now I have one of examples of the serial communication problem. There is a very simple program, called ft or softjump, intended to dump or modify some particular addresses of an EEPROM of an amateur radio. It uses a serial port in non-canonical mode, writing always 5 binary chars into it and reading (also binary) reply. I've run this program under wine but there were problems - the program never dumped any data. The source is included in the program archive; it was about 30 minutes of work to convert it for Linux. After successfull compilation, I've run the resulting Linux program (pure Linux, not winelib) and it worked as expected. For the testing purposes, I've then compiled the original windows version using winegcc. I was able to run the program, but the results were identical to those with original windows binary (no data). The windows binary output shows this: patrol(a)arcus:~/ft817$ wine ft.exe ft.exe by Peter May, VK2JCG, vk2jcg(a)yahoo.com.au This program uses undocumented CAT commands to read or update the EEPROM in the Yaesu FT817 and FT897 Radios. The soft jumper settings are stored in location 4 and 5 of the EEPROM. Power the radio off and on to activate the new settings. If you do a reset of the radio, you will have to run this program again to rewrite the values The program assumes that the radio is connected to COM1: and the CAT rate is set to 38400 baud *** USE AT YOUR OWN RISK *** Serial port COM1: successfully reconfigured. Read current data from EEPROM gives : patrol(a)arcus:~/ft817$ Its Linux version works well: patrol(a)arcus:~/ft817/Source$ ft ft by Peter May, VK2JCG, vk2jcg(a)yahoo.com.au This program uses undocumented CAT commands to read or update the EEPROM in the Yaesu FT817 and FT897 Radios. The soft jumper settings are stored in location 4 and 5 of the EEPROM. Power the radio off and on to activate the new settings. If you do a reset of the radio, you will have to run this program again to rewrite the values. *** USE AT YOUR OWN RISK *** Linux version by Pavel Troller - OK1XPT, <patrol(a)sinus.cz> Serial port /dev/tts/0 successfully reconfigured. Read current data from EEPROM gives : DD BF patrol(a)arcus:~/ft817/Source$ Do you see ? The windows version doesn't output the actual EEPROM data. +file,+comm trace from wine looks like this: trace:file:CreateFileW L"COM1:" GENERIC_READ GENERIC_WRITE creation 3 attributes 0x0 trace:file:RtlDosPathNameToNtPathName_U (L"COM1:",0x7fb3fdd0,(nil),(nil)) trace:file:RtlGetFullPathName_U (L"COM1:" 520 0x7fb3fb44 (nil)) trace:file:get_dos_device L"COM1" -> "/dev/ttyS0" trace:file:CreateFileW returning 0x2c trace:comm:GetCommState handle 0x2c, ptr 0x7fb3fe70 trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_GET_BAUD_RATE (nil) 0 0x7fb3fe18 4 0x7fb3fdb0 trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_GET_LINE_CONTROL (nil) 0 0x7fb3fe1d 3 0x7fb3fdb0 trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_GET_HANDFLOW (nil) 0 0x7fb3fe00 16 0x7fb3fdb0 trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_GET_CHARS (nil) 0 0x7fb3fe12 6 0x7fb3fdb0 trace:comm:GetCommState OK trace:comm:dump_dcb bytesize=8 baudrate=38400 fParity=0 Parity=0 stopbits=2 trace:comm:dump_dcb ~IXON ~IXOFF trace:comm:dump_dcb fOutxCtsFlow=0 fRtsControl=0 trace:comm:dump_dcb fOutxDsrFlow=0 fDtrControl=1 trace:comm:dump_dcb ~CRTSCTS trace:comm:dump_dcb bytesize=8 baudrate=38400 fParity=0 Parity=0 stopbits=2 trace:comm:dump_dcb ~IXON ~IXOFF trace:comm:dump_dcb fOutxCtsFlow=0 fRtsControl=0 trace:comm:dump_dcb fOutxDsrFlow=0 fDtrControl=0 trace:comm:dump_dcb ~CRTSCTS trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_SET_BAUD_RATE 0x7fb3fe18 4 (nil) 0 0x7fb3fdb0 trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_SET_LINE_CONTROL 0x7fb3fe1d 3 (nil) 0 0x7fb3fdb0 trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_SET_HANDFLOW 0x7fb3fe00 16 (nil) 0 0x7fb3fdb0 trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_SET_CHARS 0x7fb3fe12 6 (nil) 0 0x7fb3fdb0 trace:comm:SetCommTimeouts (0x2c, 0x7fb3fe5c) trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_SET_TIMEOUTS 0x7fb3fe0c 20 (nil) 0 0x7fb3fdb0 trace:file:WriteFile 0x8 0x7fb3f9cc 48 0x7fb3fdd4 (nil) Serial port COM1: successfully reconfigured. trace:file:WriteFile 0x2c 0x7fb3fe54 5 0x7fb3fe4c (nil) trace:file:ReadFile 0x2c 0x7fb3fe8c 4 0x7fb3fe4c (nil) trace:file:WriteFile 0x8 0x7fb3f9b4 38 0x7fb3fdbc (nil) Read current data from EEPROM gives : trace:file:WriteFile 0x8 0x7fb3f9b8 2 0x7fb3fdc0 (nil) You can see the port configuration phase, as well 5 bytes being written and a read being attempted. However, resulting "count" variable (see source) is probably 0, because there is no output of values read. I don't know, whether it is due to wrong command being written to the radio, or failure to read its response. Original package can be downloaded freely for example here: http://www.817-onair.de/download.php?id=6&sid=c66545090cd6b5cbc2e1c06321ff9… My Linux variant is attached to this mail. Sorry for the lengthy mail, but I hope that it can really help to improve the serial communication support in wine. With regards, Pavel Troller

2 1

Re: [PATCH 1/2] kernel/tests: Implement safe local strcat function.
by Dmitry Timoshkov 05 Jul '06

05 Jul '06

"Saulius Krasuckas" <saulius.krasuckas(a)ieee.org> wrote: > +static void safe_strcatA(char *dst, DWORD dst_len, const char *src) > +{ > + UINT length; > + char *buff; > + > + length = lstrlenA(dst); > + length += lstrlenA(src); > + buff = HeapAlloc(GetProcessHeap(), 0, length + 1); > + > + lstrcpyA(buff, dst); > + lstrcatA(buff, src); > + lstrcpynA(dst, buff, dst_len); > + > + HeapFree(GetProcessHeap(), 0, buff); > +} This kind of "safe" wrappers doesn't makes the code be safer in reality, needlessly clobbering the code instead. -- Dmitry.

2 7

Question about regedit:listview.c:AddEntryToList()
by Andrew Talbot 04 Jul '06

04 Jul '06

In the above function, am I right in thinking that the "(not set)" string literal ought to be represented by something of type LPTSTR? Thanks, -- Andy.

1 0

Re: [wininet][3] Use a blank password if a NULL password is given
by James Hawkins 04 Jul '06

04 Jul '06

On 7/4/06, Paul Vriens <Paul.Vriens(a)xs4all.nl> wrote: > > Hi, > > > MSDN states that we should use a blank password when a NULL password is > given together with a NON-NULL username. > > Ethereal confirms this :-) > Changelog > Use a blank password if a NULL password is given > uh oh: > Hi, > > See msdn: > http://msdn.microsoft.com/library/default.asp?url=/library/en-us/wininet/wi… > Changelog: > * Use a blank password if none is provided in FTP_Connect. http://winehq.org/pipermail/wine-patches/2006-July/028265.html -- James Hawkins

1 0

Strange behavior in debugging of bug #5245, looking for comments
by Alex Villacís Lasso 04 Jul '06

04 Jul '06

Last weekend, I was trying to trace down bug #5245 (Run-Time error '6' overflow in terragen). With current CVS, the bug manifests itself with an "Overflow" dialog when starting up Terragen. However, this bug does *not* go away with a native oleaut32.dll (taken from win98), so this does not seem like an OLE bug. When running the program with the debugger, the underlying exception trapped before displaying the dialog reads "inexact float result", with a backtrace that comes out of the bowels of msvbvm60.dll (weird - NOT inside Terragen.exe, and NOT inside Terragen.dll). However, if the user types "pass" at the debugger prompt, the dialog box does not appear, and the program continues "normally". The exception occurs again whenever a File Open dialog is dismissed, and again, typing "pass" lets the program run normally. Several questions: - Can programs that execute floating-point instructions get the "inexact float result" exception without any explicit setup, or do they have to call some API in order to enable this notification? If so, is it described in MSDN? - Is the described behavior normal for the "pass" command? I was expecting the command to make the app show the Overflow dialog and then exit. Alex Villacís Lasso

3 4