August 2006 - Wine-devel - list.winehq.org

Re: regedit: Write-strings warnings fix and remove superfluous casts (Resend)
by Alexandre Julliard 16 Aug '06

16 Aug '06

Andrew Talbot <Andrew.Talbot(a)talbotville.com> writes: > Please tell me what is wrong with this patch. Thank you. It's causing warnings: gcc -c -I. -I. -I../../include -I../../include -I../../include/msvcrt -DNO_LIBWINE_PORT -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -gstabs+ -Wdeclaration-after-statement -Wpointer-arith -g -O2 -fno-builtin -o childwnd.o childwnd.c childwnd.c: In function 'GetItemFullPath': childwnd.c:135: warning: passing argument 1 of 'CombinePaths' from incompatible pointer type childwnd.c: In function 'GetPathFullPath': childwnd.c:144: warning: passing argument 1 of 'CombinePaths' from incompatible pointer type -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winecfg: Use WCHARs for window title
by Alexandre Julliard 16 Aug '06

16 Aug '06

Frank Richter <frank.richter(a)gmail.com> writes: > From 8aaa9ca3552c7e3662c58671c9bc789b1492aa32 Mon Sep 17 00:00:00 2001 > From: Frank Richter frank.richter(a)gmail.com <frank.richter(a)gmail.com> > Date: Wed, 16 Aug 2006 05:44:29 +0200 > Subject: [PATCH] winecfg: Use WCHARs for window title You should switch the app name to Unicode too, this way you wouldn't need to change all the format strings. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/5] kernel: add VirtualAllocEx remote thread conformance tests (updated)
by Alexandre Julliard 16 Aug '06

16 Aug '06

tkho(a)ucla.edu (Thomas Kho) writes: > diff --git a/dlls/kernel/tests/Makefile.in b/dlls/kernel/tests/Makefile.in > index bfeae14..5f6c12e 100644 > --- a/dlls/kernel/tests/Makefile.in > +++ b/dlls/kernel/tests/Makefile.in > @@ -3,7 +3,7 @@ TOPOBJDIR = ../../.. > SRCDIR = @srcdir@ > VPATH = @srcdir@ > TESTDLL = kernel32.dll > -IMPORTS = kernel32 > +IMPORTS = kernel32 user32 It would be cleaner to avoid importing user32 in the kernel tests. What you probably should do is have the test create more instances of itself the way the process test does. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advapi32: add GetComputerObjectName tests (resend)
by Paul Vriens 16 Aug '06

16 Aug '06

On Tue, 2006-08-15 at 19:01 -0400, Robert Reif wrote: > plain text document attachment (secur32.tests.diff.txt) > diff -puN wine.cvs/dlls/secur32/tests/Makefile.in wine/dlls/secur32/tests/Makefile.in > + rc = GetComputerObjectNameW(formats[i], nameW, &size); > + ok(rc || ((formats[i] == NameUnknown) && > + (GetLastError() == ERROR_INVALID_PARAMETER)) || > + (GetLastError() == ERROR_CANT_ACCESS_DOMAIN_INFO), > + "GetComputerObjectNameW(%d) failed: %ld\n", > + formats[i], GetLastError()); > + } > +} > + > +START_TEST(secur32) > +{ > + testGetComputerObjectName(); > +} Hi Robert, you must likely have to change the tests to check: a) if secur32 is available (NT4 seems to lack this one) b) W-calls are (sometimes) not present on non-unicode versions of windows. http://test.winehq.org/data/200608151000/ already shows errors with secur32 and NT4 (I get a pop-up that it can't find secur32.dll). Cheers, Paul.

1 0

RFC: XEmbed Systray Patches
by James Liggett 16 Aug '06

16 Aug '06

Hello everyone, After a long hiatus, I'm trying again to get XEmbed systray support into Wine. I've been working on it for the past few days and I've got these patches. These are based on the system tray code from the Wine version used in the Linux port of Picasa [1] (which in turn was based on the work of Mike Hearn and Rob Shearman.) These patches are basically the same thing, with some fixes: 1. Use proper wine_tsx11 locking. 2. Clean up inappropriate C++ comments in that code. 3. Properly populated the XEvent structure to send docking messages. (According to the XEmbed systray spec [2], any unused fields in the message must be set to 0.) 4. Broken into five atomic patches against today's GIT. In my testing on Gnome 2.14, these patches dock much more reliabaly than the last ones, but they're still not quite perfect. In most cases, programs dock fine until about the seventh consecutive run (behavior observed with Steam and a small test program I wrote.) However, I noticed that it works perfectly if I enabled a +x11drv trace, so I suspect that this has something to do with stack problems, but I've been unable to find the source of the problem. I'd appreciate it if someone could give me some assistance on tracking down this issue. If you'd like to test these, please apply them in the order that they're numbered. Any comments/suggestions appreciated. Thnaks, James Liggett [1]: http://code.google.com/wine.html [2]: http://standards.freedesktop.org/systemtray-spec/systemtray-spec-0.2.html#m…

2 13

Re: oleaut32: Added insufficient memory check to ITypelib2:GetDocumentation2
by Dan Kegel 16 Aug '06

16 Aug '06

2006/8/15, Benjamin Arai <me(a)benjaminarai.com>: > ChangeLog: > - Added insufficient memory check to ITypelib2::GetDocumentation2 > - Returns MSDN specified value STG_E_INSUFFICIENTMEMORY Have you *ever* seen this run out of memory in real life? - Dan

1 0

Re: oleaut32: Added insufficient memory check to ITypelib2:GetDocumentation2
by Frank Richter 16 Aug '06

16 Aug '06

On 16.08.2006 04:23, Benjamin Arai wrote: > if(pbstrHelpString) > + { > *pbstrHelpString=SysAllocString(This->DocString); > + if(!*pbstrHelpString) > + return STG_E_INSUFFICIENTMEMORY; > + } > if(pdwHelpStringContext) > *pdwHelpStringContext=This->dwHelpContext; > if(pbstrHelpStringDll) > + { > *pbstrHelpStringDll=SysAllocString(This->HelpStringDll); > + if(!pbstrHelpStringDll) > + return STG_E_INSUFFICIENTMEMORY; > + } Hm, shouldn't pbstrHelpString be freed in case the 2nd allocation fails? -f.r.

1 0

Re: kernel32: add GetNativeSystemInfo (Try 2)
by Dan Kegel 15 Aug '06

15 Aug '06

This patch is good, and helps fix MS Photostory 2 LE's installer ( http://bugs.winehq.org/show_bug.cgi?id=5966 ). Robert, you might need to repost, though; there was a wrapped line.

1 0

[meta-bug] I can not contact Jeremy Newman
by Jérôme Bouat 15 Aug '06

15 Aug '06

Hello, I can not reach Jeremy Newman. I hope he goes well. A very important bug still exist for years but its bugzilla issue gets no response at all : http://bugs.winehq.org/show_bug.cgi?id=5202 Please, say something (i.e. WONTFIX, INVALID, LATER, ...). I hope someone will respond. Thanks.

4 4

Re: user: Pass all required information with internal message when chaining hooks
by Alexandre Julliard 15 Aug '06

15 Aug '06

Vitaliy Margolen <wine-patch(a)kievinfo.com> writes: > This patch deals with two sides of this problem. And actually saves > some time by not calling server one extra time. I don't think that's a good thing, now you risk calling a hook that has been deleted already. You really want to fetch the hook info from the destination thread. -- Alexandre Julliard julliard(a)winehq.org

2 2