August 2006 - Wine-devel - list.winehq.org

Re: winhelp: bug fix in LZ77 decompressor
by HolyLich 08 Aug '06

08 Aug '06

> HolyLich wrote: > > ChangeLog: > > Fix rather unusual bug in LZ77 decompressor. We cannot use memcpy > > with overlapped areas because of unpredictable result. We must copy > > byte-by-byte. > Why don't you use memmove instead? The man page for memcpy says: > Use memmove(3) if the memory areas do overlap. We cannot use memmove. It provides different functionality. It moves blocks, but LZ77 decompress algorithm copies bytes. Let's suppose: 012 XYZ When we say 'memmove(1, 0, 2)' we will get: 012 XXY But we (LZ77 algorithm) expect: 012 XXX (three 'X'). memcpy is rather clever (it optmizes process by coping INT instead of BYTES). This optimization is fatal for LZ77. For more information, please, refer to patch. It contains some useful comment. --HolyLich

2 1

Font metrics
by Jeff L 08 Aug '06

08 Aug '06

People, I am working on ScriptStringXtoCP etc in usp10. In setting up the tests for this I notice that ABC widths returned ScriptPlace (*/GetCharABCWidthsI) /*is not the same as Windows does. Have tried an couple of fonts and the results are the subtly different. Before I get too carried away with this, are the ABC widths supposed to be the same in Wine and Windows? Jeff Latimer

1 0

dinput & [Get|Set]CursorPos conandrum
by Vitaliy Margolen 08 Aug '06

08 Aug '06

Some one few weeks ago mentioned that they needed SetCursorPos to work globally (between processes). Well it seems after all we do need that to fix few lots of things, including most mouse related bugs in dinput. Actually the problem I have is not as much with SetCursorPos as with the fact that with multiple processes only one gets MotionNotify (and other notify) events. This gets cursor position out of sync between two processes and causes interesting side-effects. It's not something major but an annoyance. There are could be more serious problems however. The possible solutions might be: 1. Store cursor_pos in wineserver and call wineserver whenever we need it or need to modify it. Seems straight forward but how expensive it would be? 2. Use shared memory. That means we have to allocate it first (will SharedUserData work for this?). And use mutex for sync. 3. Query X for it's cursor position. Pretty much what we do, except that needs to be fixed: Current dinput has lots of problems with lots of games for number of different reasons (and I'm talking about just mouse). To fix some(all) of them we need to move managing of mouse warping to x11drv - only it has enough information about what programs doing to the cursor. And to make it work all we really need is to make GetCursorPos returned cached cursor position and not the latest from X. Any ideas appreciated. Vitaliy

2 4

Re: winhelp: bug fix in LZ77 decompressor
by Michael Stefaniuc 08 Aug '06

08 Aug '06

HolyLich wrote: > ChangeLog: > Fix rather unusual bug in LZ77 decompressor. We cannot use memcpy > with overlapped areas because of unpredictable result. We must copy > byte-by-byte. Why don't you use memmove instead? The man page for memcpy says: Use memmove(3) if the memory areas do overlap. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: WineD3D: shader cap fixes
by Roderick Colenbrander 08 Aug '06

08 Aug '06

Use this updated patch. I forgot to initialize some constants to zero and made the diff against a wrong file because of which some crucial changes were missed. Roderick > Hi, > > This patch adds most missing shader capabilities. Some capabilitise are > read from OpenGL but not everything is mappable to Direct3D in some cases an > extension from lets say Nvidia can be used but it is not really worth it. > If there's no OpenGL cap the minimum required values as required by the > shader specs are used. > > Regards, > Roderick Colenbrander -- "Feel free" – 10 GB Mailbox, 100 FreeSMS/Monat ... Jetzt GMX TopMail testen: http://www.gmx.net/de/go/topmail

1 0

Constifying Undocumented Code?
by Andrew Talbot 08 Aug '06

08 Aug '06

Where we emulate undocumented code, is it acceptable to constify the formal arguments, where appropriate? Thanks, -- Andy.

3 3

HAL and Copy Protection
by Jesse Allen 08 Aug '06

08 Aug '06

Does anyone have HAL and SecuRom copy protection working? I'm starting to get support questions with people using HAL and I'm not sure how to help them. I need information now that HAL support is in Wine on whether SecuRom works with it and how to get it to work as I don't have HAL. Jesse

2 6

Re: wined3d: stub out remaining renderstates
by Stefan Dösinger 07 Aug '06

07 Aug '06

Am Dienstag 08 August 2006 00:06 schrieb Jan Zerebecki: > If this patch is rejected from inclusion, please tell me why, as i would > have to ask anyway. It looks like you forgot d3d7 render states like TEXTUREMAPBLEND. This state isn't really important for this patch, I will send an implementation for it tomorrow, but other d3d7 render states are perhaps needed.

1 0

Re: wintrust: Always return ERROR_SUCCESS in WinVerifyTrust [RESEND]
by Paul Vriens 07 Aug '06

07 Aug '06

On Mon, 2006-08-07 at 11:11 -0700, James Hawkins wrote: > Hi, > > Accoring to recent comments by Paul Vriens, Process Explorer now > accepts ERROR_SUCCESS from WinVerifyTrust, and several installers > require ERROR_SUCCESS in order to continue, so everyone is happy. > Fixes bugs 5573 and 3619. > > http://bugs.winehq.org/show_bug.cgi?id=5573 > http://bugs.winehq.org/show_bug.cgi?id=3619 > > Changelog: > * Always return ERROR_SUCCESS in WinVerifyTrust. > > dlls/wintrust/wintrust_main.c | 18 +++++------------- > 1 files changed, 5 insertions(+), 13 deletions(-) > When I run process explorer without tracing/debugging everything is fine. As soon as I add +wintrust,+heap it fails again. There is most likely some heap corruption somewhere (couldn't be more vague). Alexandre's patch to add more free list entries only masked the problem, as far as I can see from the results. Cheers and sorry for the misleading remarks, Paul.

2 2

Re: user[2/2]: Preserve LastError.
by Vitaliy Margolen 07 Aug '06

07 Aug '06

Saturday, July 29, 2006, 7:28:10 PM, Vitaliy Margolen wrote: > ChangeLog: > user: Preserve LastError. > dlls/user/tests/input.c | 4 ++++ > dlls/winex11.drv/x11drv.h | 3 +++ > 2 files changed, 7 insertions(+), 0 deletions(-) Anything wrong with this patch? Test case clearly shows that we should preserve the LastError. Vitaliy Margolen

2 3