August 2006 - Wine-devel - list.winehq.org

Re: WineD3D: Avoid wasting a shader constant
by Stefan Dösinger 30 Aug '06

30 Aug '06

Am Dienstag 29 August 2006 22:16 schrieb Stefan Dösinger: > My previous half pixel correction patch loaded an extra row from the > transform matrix into a new constant to access one float value, altough the > already loaded 2nd row had 2 unused floats. This patch puts the x offset > into the z value of the 2nd row and loads only that row. This doesn't look > nice, but it doesn't require an additional shader parameter, so the > constant is available for use by the game. Of course comments are added to > document this :-) Please do not apply this patch, I will send another patch which uses a real uniform instead of abusing the projection matrix

1 0

question about selecting of locale and font
by Sergei Butakov 30 Aug '06

30 Aug '06

Hi My native language is Russian but I prefer English for menu, messages, date ... So my locale defined as # export LANG="POSIX", LC_CTYPE="ru_RU.CP1251", LC_COLLATE="ru_RU.CP1251" (LC_ALL is not setted). With wine-0.9.8 and before this works OK. With wine-0.9.9 appear disadvantages: built-in font become serif (before was sans), smaller in height and ugly (it's look like hinting is bad); widgets (windows, buttons, ...) also become smaller in height about 20%. With wine-0.9.10 (and till now - 0.9.20) appear one more disadvantage: when application use System (built-in) font, then wine select Western type (not Cyrillic). So Russian output is corrupted. All became correct if I run as $ LC_ALL=ru_RU.CP1251 wine some_program but I want menu on English. In that time input work correctly - which Russian key is pressed that corresponding code is getted by Wine. -------------- So, is it ability of using for menu (, pop-up windows, ...) not native language is removed by developers specially and now the only right way to run Wine is "LC_ALL=my_locale wine some_program"? Or there are bugs in Wine? If the first answer is "yes" then it's very regrettably. (BTW if I run $ LC_ALL=ru_RU.CP1251 wine wordpad then in editor place all output is corrupted - no Russian,no English, no numerals, rightly work only "Enter". Is it trouble with richedit? If I run $ wine wordpad then don't work output for Russian letters only.) If the second is "yes" then I can write more detailed. -- Sergei Butakov

1 0

wine's fullscreen code has no effect on metacity
by Vincent Povirk 30 Aug '06

30 Aug '06

Some patches were committed to wine recently to make it use _NET_WM_STATE_FULLSCREEN for fullscreen apps. These patches appear to work in kwin but not metacity (I was using firefox as a test). In metacity, it appears wine recognizes that it needs to make a window fullscreen and send the appropriate message, but nothing happens (panels are still on top of firefox in fullscreen mode). I've mentioned this on wine's bug (http://bugs.winehq.org/show_bug.cgi?id=3312) but I suspect it's probably caused by some quirk in metacity that wine triggers by doing some rather odd things itself. That's why I've CC'd the metacity-devel list (to which I and probably anyone on any wine mailing lists are not subscribed). So, uh, metacity people, under what circumstances would metacity be likely to put a window that had sent the proper _NET_WM_STATE_ADD message for _NET_WM_STATE_FULLSCREEN behind panels? -- Vincent Povirk

6 37

Re: [wintrust] Add framework and initial tests (resend)
by Mike McCormack 30 Aug '06

30 Aug '06

Paul Vriens wrote: > configure | 3 - > configure.ac | 1 > dlls/Makefile.in | 1 > dlls/wintrust/tests/Makefile.in | 13 +++ > dlls/wintrust/tests/register.c | 176 +++++++++++++++++++++++++++++++++++++++ > programs/winetest/Makefile.in | 3 + You only need to send changes for dlls/wintrust/tests. Other files are updated automatically by scripts (eg. autoconf, dlls/make_dlls, programs/make_tests). Mike

1 0

Does WIDL support include <xxx.idl>
by Vijay Kiran Kamuju 29 Aug '06

29 Aug '06

Hi, I am cleaning up msxml*.idl files. It seems that msxml.idl and msxml2.idl are incompatible. msxml.idl includes xmldso.idl and xmldom.idl (eg: include "xmldso.idl") where as msxml2.idl explicitly declares the interface defined by xmldso.idl and xmldom.idl. This is done so that we there would be no clashes beteen msxml2.0 and msxml3.0 implementation. As in msxml2.0 and msxml3.0 there were some GUID changes. Does MIDL put the expansion of the included idl file. ie, in a.idl we have a line include "b.idl" what i want ask is does a.h will contain all the contents of b.h(b.h is output when we run midl on b.idl) when we run midl on a.idl. I want to generalize the msxml implementation. Thanks, VJ

2 4

Re: widl [2/6]: Handle more pointer types in write_type
by Robert Shearman 29 Aug '06

29 Aug '06

Dan Hipschman wrote: >So write_type can handle more than just full pointers. > Hi Dan, I see from a couple of patches back that you intend to move the representation of pointers out of the var_t type. How do you intend to represent "char **" for example? type: FC_RP, ref: { type: FC_RP, ref: { type: FC_CHAR } } or: type: FC_CHAR, ptr_level: 2 It seems to me you're going down the first route (and there's nothing wrong with that as far as I can see). I'm just interested to know which approach you are taking. -- Rob Shearman

2 1

Re: widl [3/6]: Represent typedefs with easier to use structures
by Robert Shearman 29 Aug '06

29 Aug '06

Dan Hipschman wrote: >diff --git a/tools/widl/header.c b/tools/widl/header.c >index 3a4cea9..5de43c0 100644 >--- a/tools/widl/header.c >+++ b/tools/widl/header.c >@@ -203,13 +203,14 @@ void write_type(FILE *h, type_t *t, cons > { > int c; > >+ if (t->is_const) fprintf(h, "const "); >+ > if (n) fprintf(h, "%s", n); >+ else if (t->kind == TKIND_ALIAS) fprintf(h, "%s", t->name); > > I'm not really sure we should be depending on a typelib thing for a fundamental concept such as this. In fact, I think the kind field of the type_t structure could probably be removed and generated as needed in the typelib generation code. >@@ -902,6 +885,7 @@ static type_t *make_int(int sign) > > void init_types(void) > { >+ decl_builtin("void", 0); > decl_builtin("byte", RPC_FC_BYTE); > decl_builtin("wchar_t", RPC_FC_WCHAR); > decl_builtin("int", RPC_FC_LONG); /* win32 */ > > This would seem as though it would make widl incorrectly accept "int func(void a);" as a valid statement. I think you need to try to fix this case. >@@ -1147,6 +1131,7 @@ static type_t *make_type(unsigned char t > t->type = type; > t->ref = ref; > t->attrs = NULL; >+ t->orig = NULL; > t->funcs = NULL; > t->fields = NULL; > t->ifaces = NULL; >@@ -1175,8 +1160,15 @@ static typeref_t *uniq_tref(typeref_t *r > typeref_t *t = ref; > type_t *tp; > if (t->uniq) return t; >- tp = make_type(0, t->ref); >- tp->name = t->name; >+ >+ if (t->name) >+ { >+ tp = duptype(t->ref, 0); >+ tp->name = t->name; >+ } >+ else >+ tp = duptype(t->ref, 1); >+ > t->name = NULL; > t->ref = tp; > t->uniq = 1; >@@ -1311,11 +1303,27 @@ static unsigned char get_pointer_type( t > return RPC_FC_FP; > } > >-static type_t *reg_types(type_t *type, var_t *names, int t) >+static type_t *reg_typedefs(type_t *type, var_t *names, attr_t *attrs) > { > type_t *ptr = type; > int ptrc = 0; > >+ /* We must generate names for tagless enum, struct or union. >+ Typedef-ing a tagless enum, struct or union means we want the typedef >+ to be included in a library whether it has other attributes or not, >+ hence the public attribute. */ >+ if ((type->kind == TKIND_ENUM || type->kind == TKIND_RECORD >+ || type->kind == TKIND_UNION) && ! type->name && ! parse_only) >+ { >+ if (! is_attr(attrs, ATTR_PUBLIC)) >+ { >+ attr_t *new_attrs = make_attr(ATTR_PUBLIC); >+ LINK(new_attrs, attrs); >+ attrs = new_attrs; >+ } > > I'm not sure it is necessary to include this change with the rest of the patch. I'm also not sure what you are trying to accomplish here (as we always add the type to a typelib, no matter whether the type has the public attribute). >+ type->name = gen_name(); >+ } >+ > while (names) { > var_t *next = NEXT_LINK(names); > if (names->name) { >@@ -1323,8 +1331,7 @@ static type_t *reg_types(type_t *type, v > int cptr = names->ptr_level; > if (cptr > ptrc) { > while (cptr > ptrc) { >- int t = get_pointer_type( cur ); >- cur = ptr = make_type(t, cur); >+ cur = ptr = make_type(RPC_FC_RP, cur); > ptrc++; > } > } else { > > Thanks and keep up the good work! -- Rob Shearman

3 2

Re: widl: Remove use of type_t "ref" field for base types
by Robert Shearman 29 Aug '06

29 Aug '06

Dan Hipschman wrote: >diff --git a/tools/widl/widltypes.h b/tools/widl/widltypes.h >index d39def3..cf0f246 100644 >--- a/tools/widl/widltypes.h >+++ b/tools/widl/widltypes.h >@@ -207,6 +207,7 @@ struct _type_t { > func_t *funcs; /* interfaces and modules */ > var_t *fields; /* interfaces, structures and enumerations */ > ifref_t *ifaces; /* coclasses */ >+ type_t *orig; /* dup'd types */ > int ignore, is_const, sign; > int defined, written, user_types_registered; > int typelib_idx; > You add a new field to type_t, yet no code uses it. Will it have some future purpose? -- Rob Shearman

2 1

Re: [wintrust] Add some documentation
by James Hawkins 29 Aug '06

29 Aug '06

On 8/29/06, Paul Vriens <Paul.Vriens(a)xs4all.nl> wrote: > Hi, > > I thought I'd start with some documentation. The tests are already > there so what's missing is the implementation :-). > > > /*********************************************************************** > * WintrustAddActionID (WINTRUST.@) > + * > + * Add a Trust provider. Or actually the functions it performs. > + * Can you rewrite this sentence? It's not grammatically correct, and I don't understand what you're saying. -- James Hawkins

2 2

Keyboard freeze - Max Payne
by Jeremy Newman 29 Aug '06

29 Aug '06

Just going through my list of issues I'd like resolved, and discovered this bug/regression. In Max Payne 1 / Max Payne 2 it seems the game freezes up for a few seconds when you hold down any key in the game. For example using 'W' to move forward, hold it down you take like 1 step and it freezes up. Letting go and waiting a few seconds gets the game back to normal. As you can imagine, this makes it unplayable. Before I go and enter this as a bug, I was wondering if anyone knows about this and/or has a fix.

2 4