August 2006 - Wine-devel - list.winehq.org

Re: msi: increase MSIMAXHANDLES to 2048
by Alexandre Julliard 23 Aug '06

23 Aug '06

"Dan Kegel" <dank(a)kegel.com> writes: > This lets http://bugs.winehq.org/show_bug.cgi?id=4227 > get to the next problem. (1024 handles wasn't enough, I checked. > 2048 might not be enough for a truly huge app, but this should > hold us for a while.) Dynamic allocation would be better, it's really not hard to do in this case. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: developers-hints 2 -- second try
by Alexandre Julliard 23 Aug '06

23 Aug '06

"Tom Wickline" <twickline(a)gmail.com> writes: > Changelog: add newly implemented dlls and update http links I think the DEVELOPERS-HINTS contents should really be moved to the Wiki, it would be a lot easier to keep up to date there. Does anybody feel like doing that? -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: resend add missing glyph code to GetGlyphIndices
by Dmitry Timoshkov 23 Aug '06

23 Aug '06

"Jeff L" <lats(a)yless4u.com.au> wrote: > if(dc->gdiFont) > - ret = WineEngGetGlyphIndices(dc->gdiFont, lpstr, count, pgi, flags); > + ret = WineEngGetGlyphIndices(hdc, dc->gdiFont, lpstr, count, pgi, flags); ... > + GetTextMetricsW(hdc, &textm); As an additional optimization, probably it would be better to call WineEngGetTextMetrics instead of GetTextMetricsW to avoid introducing hdc as another parameter of WineEngGetGlyphIndices. -- Dmitry.

2 1

Re: opengl pixel format regression
by Roderick Colenbrander 23 Aug '06

23 Aug '06

> Hello > > > Both of you try to remove the following code from > src/winex11.drv/opengl.c: > > /* Aux buffers */ > > pglXGetFBConfigAttrib(gdi_display, cfgs[fmt_index], > GLX_AUX_BUFFERS, > > &value); if (ppfd->cAuxBuffers && !value) { > > goto choose_exit; > > } > > Is this code in current CVS/GIT? I'm currently using 0.9.19 and could not > find > the code in wine sources (gentoo). I have fixed a bug related to the pixel format which should be in cvs now. So your bug might be fixed in cvs. Could you try it and could you also attach a log of glxinfo? I need that log to fix some other opengl issues and I don't have have data from cards like yours. Thanks, Roderick -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

1 0

Re: regedit[1/2]: remove custom filter from open/save dialogs
by Alexandre Julliard 23 Aug '06

23 Aug '06

Mikołaj Zalewski <mikolaj(a)zalewski.pl> writes: > --- framewnd_orig.c 2006-08-10 15:15:12.000000000 +0200 > +++ framewnd.c 2006-08-22 22:10:05.000000000 +0200 Please generate diffs from the top-level directory. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi: resend add missing glyph code to GetGlyphIndices
by Alexandre Julliard 23 Aug '06

23 Aug '06

Jeff L <lats(a)yless4u.com.au> writes: > for(i = 0; i < count; i++) > + { > pgi[i] = get_glyph_index(font, lpstr[i]); > - > + if (pgi[i] == 0) > + { > + if (flags & GGI_MARK_NONEXISTING_GLYPHS) > + pgi[i] = 0x001f; /* Indicate non existance */ > + else > + { > + /* Note that the call to GetTextMetricsW is made in the loop * > + * because it is less likely to have non existant glyphs * > + * and hence we should have few calls to GetTextMetricsW as * > + * a result */ > + GetTextMetricsW(hdc, &textm); > + pgi[i] = textm.tmDefaultChar; It's a good idea to not call GetTextMetrics unless you need it, but there's no reason to call it multiple times. It isn't hard to call it only the first time you need the default char. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: user: [2/2] Pass hook handle to the destination thread. Call server to get hook information
by Vitaliy Margolen 23 Aug '06

23 Aug '06

Thursday, August 17, 2006, 8:46:12 AM, Vitaliy Margolen wrote: > ChangeLog: > user: Pass hook handle to the destination thread. Call server to get hook > information for inter-thread hooks. > Currently Wine has a major problem with LL hooks (low level hooks) when > second hook is installed in a separate thread - the second hook callback is > never called. And while attempting to call it Wine almost locks up in never > ending loop. This happening because instead of calling current thread's > hook callback Wine restarts the whole hook chain from the start. > This patch deals with both sides of this problem. > Fixes Bug [5803], [5712] and possibly others. > dlls/user/hook.c | 41 +++++++++++++++++++++++++++++++++++++---- > dlls/user/message.c | 13 +++++++++---- > dlls/user/user_private.h | 7 +++++++ > server/hook.c | 29 +++++++++++++++++++++++++++++ > server/protocol.def | 13 +++++++++++++ > 5 files changed, 95 insertions(+), 8 deletions(-) Why wasn't this patch accepted? Alexandre on IRC said that there are some race conditions here. I don't see how and where. The only possible place that I can think of is passing handle from one thread to the other thread using internal message. But that is covered. If the hook gets removed, we don't remove it in the server: http://source.winehq.org/source/server/hook.c#L291 When new hook is added, it's being placed ahead of all others, so it's not a problem either - we can't call it anyway after hook-chain has been started. Am I missing something here? Vitaliy Margolen

1 0

Re: msiexec: Add handling for msiexec's regserver option
by Vitaliy Margolen 23 Aug '06

23 Aug '06

Tuesday, August 22, 2006, 7:56:00 PM, James Hawkins wrote: > Hi, > More and more installers are expecting the MSI service to exist, or at > least be installable using msiexec /regserver. This patch is the > first step in fixing bug 5540. > + if (!scm) > + { > + fprintf(stderr, "Failed to open the service control manager.\n"); > + return 1; > + } Please use proper WINE_[ERR|WARN|FIXME|TRACE] macros. Vitaliy Margolen

2 1

regression with gothic1/2
by Sebastian Schlingmann 22 Aug '06

22 Aug '06

Hi everybody, I noticed yesterday that the gothic 1/2 demos don't work anymore. Console output is the following: ... err:ntdll:RtlpWaitForCriticalSection section 0x7fe90020 "heap.c: main process heap section" wait timed out in thread 000f, blocked by 0009, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x7bc7ef44 "loader.c: loader_section" wait timed out in thread 0009, blocked by 000f, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x7fe90020 "heap.c: main process heap section" wait timed out in thread 000d, blocked by 0009, retrying (60 sec) ... A regression test came up with the following result: $ git bisect bad 13163349521e50e7039e188a22b6a814dcfcfc37 is first bad commit commit 13163349521e50e7039e188a22b6a814dcfcfc37 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jul 21 11:53:24 2006 +0200 ntdll: Add a few more free list entries to the heap. :040000 040000 dba2d276a01c6d148826a913f4163e0db0ed4689 eb1abe2301ff4698ac939b7e1b1fa225ceca4338 M dlls I can provide traces and additional info if needed. Bye Sebastian

3 4

Re: riched20: add EM_EXSETSEL conformance tests and fixes bug 4462
by Matt Finnicum 22 Aug '06

22 Aug '06

Hi, Is there something wrong with this patch / a reason it's not being accepted? Sorry if this might have been answered this on IRC last night - X died while I was away, so I'd have missed it. Thanks, --Matt Finnicum On 8/19/06, Matt Finnicum <mattfinn(a)gmail.com> wrote: > Hi, > I've cleaned up / re-diffed this patch from Brian Chang. It fixes bug > 4462 by handling several odd ways in which EM_EXSETSEL can be called. > It also make the message return a proper value, not just zero. > > --Matt Finnicum (Please commit as Brian Chang) > > The last version of this patch can be found here: > http://www.winehq.com/pipermail/wine-patches/2006-March/024976.html > > --- > dlls/riched20/editor.c | 25 +++++++++++++++++--- > dlls/riched20/tests/editor.c | 52 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 73 insertions(+), 4 deletions(-) > > >

2 1