September 2006 - Wine-devel

Re: [crypt32] Fix TRACE when using a numeric identifier
by Detlef Riekenberg 06 Sep '06

06 Sep '06

Hi Paul: > When tracing is on for crypt we crashed. > + if (!HIWORD(pszOID)) > + TRACE("(%lx, %s, #%d, %s, %s)\n", dwEncodingType, pszFuncName, LOWORD(pszOID), > + debugstr_w(pwszDll), pszOverrideFuncName); debugstr_a() does this for you. + TRACE("(%lx, %s, %s, %s, %s)\n", dwEncodingType, pszFuncName, + debugstr_w(pszOID), debugstr_w(pwszDll), pszOverrideFuncName); You might want to use debugstr_a() also for the other strings (*FuncName) -- By by ... Detlef

1 0

Re: [wintrust] Add a bunch of CryptRegisterOIDFunction calls
by Paul Vriens 06 Sep '06

06 Sep '06

On Wed, 2006-09-06 at 13:16 +0200, Paul Vriens wrote: > Hi, > > 2/3 of the registration of wintrust is done with this patch. The only thing > left is some CryptSIPAddProvider calls. > > Changelog > Add a bunch of CryptRegisterOIDFunction calls > > Cheers, > > Paul. > --- Wait with this one, I'll sent a new one soon, that also takes care of possible errors returned by CryptRegisterOIDFunction. That however means changing CryptRegisterOIDFunction as well. Cheers, Paul.

1 0

Re: LPGL functions in Reactos that are stub in Wine
by jimtabor 06 Sep '06

06 Sep '06

Julien wrote: >/ I was very interested in comparing the implementation status of reactos />/ and wine. So I coded a little python script to list all the api that are />/ implemented in reactos AND are only stub in wine. Attached to this mail />/ is the list of identified functions. />/ />/ One may note that most of these functions are in the setupapi dll. This />/ is particularly interesting as the setupapi code is LGPL-licenced in />/ Reactos (and was already part of the audit). / Code that originates in ReactOS will generally not be accepted into Wine due to that project's acceptance of developers that participate in "dirty" reverse engineering (ie. translating assembly code to C). Please don't submit code from ReactOS to wine-patches. Mike Hi Mike, Please do not post things like this. Thanks, James

2 1

Re: [wintrust 1/8] Register WIN_SPUB_ACTION_PUBLISHED_SOFTWARE
by James Hawkins 06 Sep '06

06 Sep '06

On 9/5/06, Paul Vriens <Paul.Vriens(a)xs4all.nl> wrote: > Hi, > > first patch of 8 to add several Trust Provider to the registry. I've decided > to have a function for every Trust Provider instead of grouping common stuff > together as this can change. The MSDN pages for wintrust seem to be changing > a lot lately. > > Once the last registration patch is done (and that will take another week or > so) I'll cleanup up the unnecessary comments and TRACE's. > If they're unnecessary and you're going to take them out at some point, why not just leave them out of the patches from the beginning? -- James Hawkins

2 1

Temporary Git tree available
by Mike McCormack 05 Sep '06

05 Sep '06

Hi All, As Alexandre has gone on holidays for a week, I've made available a temporary Git tree containing most patches sent to wine-patches. You can pull my branch into your existing Git checkout as follows: git fetch http://mandoo.dyndns.org/wine.git master:mmbranch git rebase mmbranch If you have an existing mmbranch, you probably want to delete it using: git branch -d mmbranch Mike $ git log origin.. commit 5d6e51717f24a594d793e8fde930a4a28df37ef0 Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Aug 29 17:19:21 2006 -0700 widl: Remove obsolete handling of typedefs commit f5fc2d59c121d13fe86d13d21c02ec6c6ba29eef Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Aug 29 14:29:06 2006 -0700 widl: Generate an error for "int f(void a)" commit c0299c2b3e6c1fa4e14feeab1723ca7c545e9699 Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Aug 29 14:28:05 2006 -0700 widl: Print pointers using better style commit 41f540217f9bd03819be3f6154c03c06d98ec031 Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Aug 29 14:27:27 2006 -0700 widl: Add an is_ptr function commit e20f80716e8b352d72a1d86381d1f405e58ee19e Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Aug 29 14:26:43 2006 -0700 widl: Factor the entry_t structure commit cd0ee17b195070962f97c5ac16b73dfd37e63620 Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Aug 29 14:26:03 2006 -0700 widl: Represent typedefs with easier to use structures commit 52ad5914edf8169610cb20ed20de6c2ec21869b4 Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Aug 29 14:25:19 2006 -0700 widl: Generate names for tagless structs, unions and enums commit e6bde7d70b930e37079faa46a340b206e1276933 Author: Paul Vriens <Paul.Vriens(a)xs4all.nl> Date: Tue Aug 29 17:57:35 2006 +0200 wintrust: Add some extra tests for WintrustRemoveActionID commit 13651132d7337f90d6d0b403261e5e30bc35a04d Author: James Hawkins <truiken(a)gmail.com> Date: Tue Aug 29 15:12:39 2006 -0700 advpack: Add the regsvr action to the SetupInstallFromInfSection call commit 6d26805474edc8bbdd201fdeb070e766e3102485 Author: James Hawkins <truiken(a)gmail.com> Date: Tue Aug 29 15:12:22 2006 -0700 advpack: Get the proper working directory in install_init commit e090dee9838d5dcfcc73464e7427f075e7d19bdc Author: Roderick Colenbrander <thunderbird2k(a)gmx.net> Date: Tue Aug 29 16:58:49 2006 +0200 opengl32: import glx makecurrent/wglsharelists commit 8d410088146faa56701c440daa4ae350985feff9 Author: Roderick Colenbrander <thunderbird2k(a)gmx.net> Date: Tue Aug 29 16:56:57 2006 +0200 opengl32: import glx context code commit e012ffe349a279b939a7b49f7439dd1cd1cd901e Author: Benjamin Arai <me(a)benjaminarai.com> Date: Tue Aug 29 17:51:27 2006 -0700 oleaut32: Test for correct error codes and return type for VarAnd commit 4dec3ee04b237a615bf0eb228c3b343ea537a6ca Author: Benjamin Arai <me(a)benjaminarai.com> Date: Tue Aug 29 17:50:05 2006 -0700 oleaut32: Updates variant:VarAnd to pass all failures exposed from conformance test commit 9e1fa3f6afb808eb0750404180ec7ff30c0a4db0 Author: Benjamin Arai <me(a)benjaminarai.com> Date: Tue Aug 29 17:49:29 2006 -0700 oleaut32: Conformance test for vartest:VarAnd checks for correct result values commit 75d7a735bc4447d099968b78b08de8cc7db8ebe2 Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Tue Aug 29 21:46:49 2006 +0200 wined3d: Avoid wasting a uniform commit 4056ee5dae9ce52b94f518a850c13dfee478e56d Author: Robert Reif <reif(a)earthlink.net> Date: Tue Aug 29 19:34:31 2006 -0400 advapi32: fix lsa tests on windows98 commit b09802de14406bf2a358c256f2b186e15efde08d Author: mike <mike(a)codeweavers.com> Date: Wed Aug 30 12:55:27 2006 +0900 ddraw: Make tests pass when OpenGL libraries aren't present. commit 835596de7066b84a88f6182d4fab4dda1832456a Author: Andrew Talbot <Andrew.Talbot(a)talbotville.com> Date: Tue Aug 29 23:12:16 2006 +0100 comctl32: Cast-qual warnings fix commit b40c568d9215e906ca1521197fd3060c75fb6e5a Author: Robert Shearman <rob(a)codeweavers.com> Date: Tue Aug 29 21:16:44 2006 +0100 rpcrt4: Make the reference counting in the standard proxy thread-safe. commit 5bf357288caf3b5eb5766d6bcade4f49fbd80084 Author: Robert Shearman <rob(a)codeweavers.com> Date: Tue Aug 29 21:14:42 2006 +0100 rpcrt4: Fix NdrStubGetBuffer to use the IRpcChannelBuffer object since IRpcChannelBuffer_GetBuffer may put extra data onto the wire for ORPC calls. commit d63bda52650573e7ec62ca3fae707a231cfbbc6c Author: Robert Shearman <rob(a)codeweavers.com> Date: Tue Aug 29 21:14:05 2006 +0100 rpcrt4: Remove some unused code. commit e888c667006107145f719537f3a169b797720cfd Author: Robert Shearman <rob(a)codeweavers.com> Date: Tue Aug 29 21:12:42 2006 +0100 rpcrt4: Move NdrStub* functions to cstub.c and move NdrProxy* functions to cproxy.c since both sets of functions depend on the implementations of the standard stubs and proxies. commit 0879b1e305e4ad329f35c22d97a4765ea54be3c9 Author: Robert Shearman <rob(a)codeweavers.com> Date: Tue Aug 29 21:12:16 2006 +0100 oleaut32: Delay the creation of the stub object for IDispatch until it is actually used. commit 337f886bab59f5fd7ab22d74ae3c712b593bd1e6 Author: Robert Shearman <rob(a)codeweavers.com> Date: Tue Aug 29 21:11:12 2006 +0100 oleaut32: Fix a leak of the module reference count. commit d77bea6f8c896304a809e0b9834b1b52072a1901 Author: Andrew Talbot <Andrew.Talbot(a)talbotville.com> Date: Tue Aug 29 20:12:39 2006 +0100 advpack: Cast-qual warnings fix commit 206411e8032c25f82f738cf065cb2497aa63d96f Author: Paul Vriens <Paul.Vriens(a)xs4all.nl> Date: Tue Aug 29 19:33:00 2006 +0200 wintrust: Add some documentation commit 91a8502d1dcb65509128c602211b87d05aec8e6d Author: Renu Rajput <renu.rajput(a)gmail.com> Date: Tue Aug 29 13:50:16 2006 +0530 comdlg32: Send missing CDN_FOLDERCHANGE

2 4

Re: [wintrust] Register WINTRUST_ACTION_GENERIC_VERIFY_V2 (TRY 2)
by Juan Lang 04 Sep '06

04 Sep '06

Hi Paul, + * Write a singe value and it's data to: s/singe/single/, s/it's/its/ + /* Turn OID into a wide-character string */ + Len = MultiByteToWideChar( CP_ACP, 0, OID, -1, NULL, 0 ); + OIDW = HeapAlloc( GetProcessHeap(), 0, Len * sizeof(WCHAR) ); + MultiByteToWideChar( CP_ACP, 0, OID, -1, OIDW, Len ); + + /* Allocate the needed space for UsageKey */ + UsageKey = HeapAlloc(GetProcessHeap(), 0, (lstrlenW(Trust) + lstrlenW(Usages) + Len) * sizeof(WCHAR)); You can avoid one HeapAlloc by calculating Len as you do, but not converting OID to a wide-char string until you've allocated UsageKey. Something like: len = MultiByteToWideChar( CP_ACP, 0, OID, -1, NULL, 0 ); UsageKey = HeapAlloc(GetProcessHeap(), 0, (lstrlenW(Trust) + lstrlenW(Usages) + len) * sizeof(WCHAR)); lstrcpyW(UsageKey, Trust); lstrcatW(UsageKey, Usages); MultiByteToWideChar( CP_ACP, 0, OID, -1, UsageKey + lstrlenW(Trust) + lstrlenW(Usages), len ); Note also that OID can't contain multibyte characters, so you may use a loop to copy it character by character to UsageKey instead of calling MultiByteToWideChar, if you prefer. + HeapFree(GetProcessHeap(), 0, OIDW); You leak UsageKey here. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

LPGL functions in Reactos that are stub in Wine
by Julien 04 Sep '06

04 Sep '06

Hello all, I was very interested in comparing the implementation status of reactos and wine. So I coded a little python script to list all the api that are implemented in reactos AND are only stub in wine. Attached to this mail is the list of identified functions. One may note that most of these functions are in the setupapi dll. This is particularly interesting as the setupapi code is LGPL-licenced in Reactos (and was already part of the audit). I tried to port some of these to Wine, but this requires more knowledge than I have. So, is someone interested to port these functions? Best, Julien AssertFail CMP_Init_Detection CMP_Report_LogOn CM_Add_IDA CM_Add_IDA CM_Add_IDW CM_Add_IDW CM_Add_ID_ExA CM_Add_ID_ExA CM_Add_ID_ExW CM_Add_ID_ExW CM_Connect_MachineA CM_Connect_MachineA CM_Create_DevNodeA CM_Create_DevNodeA CM_Create_DevNodeW CM_Create_DevNodeW CM_Create_DevNode_ExA CM_Create_DevNode_ExA CM_Create_DevNode_ExW CM_Create_DevNode_ExW CM_Delete_Class_Key CM_Delete_Class_Key CM_Delete_Class_Key_Ex CM_Delete_Class_Key_Ex CM_Disable_DevNode CM_Disable_DevNode CM_Disable_DevNode_Ex CM_Disable_DevNode_Ex CM_Enable_DevNode CM_Enable_DevNode CM_Enable_DevNode_Ex CM_Enable_DevNode_Ex CM_Enumerate_Classes CM_Enumerate_Classes CM_Enumerate_Classes_Ex CM_Enumerate_Classes_Ex CM_Enumerate_EnumeratorsA CM_Enumerate_EnumeratorsA CM_Enumerate_EnumeratorsW CM_Enumerate_EnumeratorsW CM_Enumerate_Enumerators_ExA CM_Enumerate_Enumerators_ExA CM_Enumerate_Enumerators_ExW CM_Enumerate_Enumerators_ExW CM_Get_Child CM_Get_Child CM_Get_Child_Ex CM_Get_Child_Ex CM_Get_Class_Key_NameA CM_Get_Class_Key_NameA CM_Get_Class_Key_NameW CM_Get_Class_Key_NameW CM_Get_Class_Key_Name_ExA CM_Get_Class_Key_Name_ExA CM_Get_Class_Key_Name_ExW CM_Get_Class_Key_Name_ExW CM_Get_Class_NameA CM_Get_Class_NameA CM_Get_Class_NameW CM_Get_Class_NameW CM_Get_Class_Name_ExA CM_Get_Class_Name_ExA CM_Get_Class_Name_ExW CM_Get_Class_Name_ExW CM_Get_Depth CM_Get_Depth CM_Get_Depth_Ex CM_Get_Depth_Ex CM_Get_DevNode_Registry_PropertyA CM_Get_DevNode_Registry_PropertyA CM_Get_DevNode_Registry_PropertyW CM_Get_DevNode_Registry_PropertyW CM_Get_DevNode_Registry_Property_ExA CM_Get_DevNode_Registry_Property_ExA CM_Get_DevNode_Registry_Property_ExW CM_Get_DevNode_Registry_Property_ExW CM_Get_DevNode_Status CM_Get_DevNode_Status CM_Get_DevNode_Status_Ex CM_Get_DevNode_Status_Ex CM_Get_Device_IDW CM_Get_Device_IDW CM_Get_Device_ID_ExA CM_Get_Device_ID_ExA CM_Get_Device_ID_ExW CM_Get_Device_ID_ExW CM_Get_Device_ID_ListW CM_Get_Device_ID_ListW CM_Get_Device_ID_List_ExA CM_Get_Device_ID_List_ExA CM_Get_Device_ID_List_ExW CM_Get_Device_ID_List_ExW CM_Get_Device_ID_List_SizeA CM_Get_Device_ID_List_SizeA CM_Get_Device_ID_List_SizeW CM_Get_Device_ID_List_SizeW CM_Get_Device_ID_List_Size_ExA CM_Get_Device_ID_List_Size_ExA CM_Get_Device_ID_List_Size_ExW CM_Get_Device_ID_List_Size_ExW CM_Get_Device_ID_Size_Ex CM_Get_Device_ID_Size_Ex CM_Get_Global_State CM_Get_Global_State CM_Get_Global_State_Ex CM_Get_Global_State_Ex CM_Get_Parent CM_Get_Parent CM_Get_Parent_Ex CM_Get_Parent_Ex CM_Get_Sibling CM_Get_Sibling CM_Get_Sibling_Ex CM_Get_Sibling_Ex CM_Get_Version CM_Get_Version CM_Get_Version_Ex CM_Get_Version_Ex CM_Is_Dock_Station_Present CM_Is_Dock_Station_Present CM_Locate_DevNodeA CM_Locate_DevNodeA CM_Locate_DevNodeW CM_Locate_DevNodeW CM_Locate_DevNode_ExA CM_Locate_DevNode_ExA CM_Locate_DevNode_ExW CM_Locate_DevNode_ExW CM_Move_DevNode CM_Move_DevNode CM_Move_DevNode_Ex CM_Move_DevNode_Ex CM_Open_Class_KeyA CM_Open_Class_KeyA CM_Open_Class_KeyW CM_Open_Class_KeyW CM_Open_Class_Key_ExA CM_Open_Class_Key_ExA CM_Open_Class_Key_ExW CM_Open_Class_Key_ExW CM_Reenumerate_DevNode CM_Reenumerate_DevNode CM_Reenumerate_DevNode_Ex CM_Reenumerate_DevNode_Ex CM_Request_Eject_PC CM_Request_Eject_PC CM_Run_Detection CM_Run_Detection CM_Run_Detection_Ex CM_Run_Detection_Ex CM_Set_DevNode_Problem CM_Set_DevNode_Problem CM_Set_DevNode_Problem_Ex CM_Set_DevNode_Problem_Ex CM_Set_DevNode_Registry_PropertyA CM_Set_DevNode_Registry_PropertyA CM_Set_DevNode_Registry_PropertyW CM_Set_DevNode_Registry_PropertyW CM_Set_DevNode_Registry_Property_ExA CM_Set_DevNode_Registry_Property_ExA CM_Set_DevNode_Registry_Property_ExW CM_Set_DevNode_Registry_Property_ExW CM_Setup_DevNode CM_Setup_DevNode CM_Setup_DevNode_Ex CM_Setup_DevNode_Ex CM_Uninstall_DevNode CM_Uninstall_DevNode CM_Uninstall_DevNode_Ex CM_Uninstall_DevNode_Ex CenterWindowRelativeToParent ConcatenatePaths GetSetFileTimestamp GetVersionInfoFromImage MyGetFileTitle RpcBindingCopy RpcSmDestroyClientContext RpcSsDestroyClientContext SetupDiBuildDriverInfoList SetupDiChangeState SetupDiCreateDevRegKeyA SetupDiCreateDevRegKeyW SetupDiDeleteDeviceInfo SetupDiDestroyDriverInfoList SetupDiEnumDriverInfoA SetupDiEnumDriverInfoW SetupDiGetClassDevPropertySheetsA SetupDiGetClassDevPropertySheetsW SetupDiGetDeviceInfoListClass SetupDiGetDeviceInstallParamsW SetupDiGetDeviceInstanceIdA SetupDiGetDeviceInstanceIdW SetupDiGetDeviceRegistryPropertyW SetupDiGetDriverInfoDetailA SetupDiGetDriverInfoDetailW SetupDiGetINFClassA SetupDiGetINFClassW SetupDiGetSelectedDevice SetupDiGetSelectedDriverA SetupDiGetSelectedDriverW SetupDiInstallClassExA SetupDiInstallClassExW SetupDiInstallDevice SetupDiInstallDriverFiles SetupDiLoadClassIcon SetupDiOpenDeviceInfoA SetupDiOpenDeviceInfoW SetupDiRegisterDeviceInfo SetupDiRemoveDevice SetupDiSelectDevice SetupDiSetClassInstallParamsW SetupDiSetDeviceInstallParamsW SetupDiSetDeviceRegistryPropertyA SetupDiSetDeviceRegistryPropertyW SetupDiSetSelectedDevice SetupDiSetSelectedDriverA SetupDiSetSelectedDriverW SetupDiUnremoveDevice SetupGetInfFileListA SetupGetInfFileListW SetupInstallServicesFromInfSectionA SetupInstallServicesFromInfSectionExA SetupInstallServicesFromInfSectionExW SetupInstallServicesFromInfSectionW SetupPromptReboot

8 12

Re: wined3d: Avoid crashing when ProcessVertices is called with NULL vertex declaration
by H. Verbeet 04 Sep '06

04 Sep '06

On 04/09/06, Paul Chitescu <pchitescu(a)voip.null.ro> wrote: > Changelog: Avoid a segfault in IWineD3DDeviceImpl_ProcessVertices by checking > if SrcImpl (parameter pVertexDecl) is NULL. > > The function is called from dlls/d3d8/device.c > IDirect3DDevice8Impl_ProcessVertices with an explicit NULL as vertex > declaration parameter. > > Crash was observed in Age of Mythology Trial. > This doesn't look correct to me, the call does effectively nothing for d3d8 now.

3 3

Re: [WINED3D 3/3] Add support for R32F and R16F texture formats
by Frank Richter 04 Sep '06

04 Sep '06

On 04.09.2006 07:33, Ivan Gyurdiev wrote: > ... using: > GL_ARB_texture_float > GL_ARB_half_float_pixel > > The internal format is RGB16/32F, which is wasteful (2 unused colors), > but there's no way around that. What about INTENSITY or LUMINANCE textures? -f.r.

2 1

Re: How to use a windows dll in linux
by mesmith.18885136＠bloglines.com 04 Sep '06

04 Sep '06

Thanks for the helpful replies. I have been working on the Winelib approach suggested by Jeremy. As my first step I wanted to get a windows console application to compile and run anyway. I now have an executable that runs and calls functions in the windows dll, but it does not work correctly. If I run it with winedbg it gives me a backtrace with errors coming from deep inside the dll. I assume there is some problem with the arguments going to the function that serves as the entry to the dll. Is there a way to find out what is getting passed to the dll and/or debugging inside the dll (without source code)? Thanks, Mark

2 1