January 2007 - Wine-devel - list.winehq.org

Re: [user32][test] Add test for messageboxes
by Dmitry Timoshkov 08 Jan '07

08 Jan '07

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > + thread = CreateThread( NULL, 0, create_messagebox_thread, &info, 0, &tid ); > + while(info.hWndDlg == NULL) > + info.hWndDlg = FindWindowA(NULL,info.ch); This is too hackish IMO, if dialog creation fails for some reason the test will hang. > + > + PostMessageA(info.hWndDlg,WM_COMMAND,IDCANCEL,0); > + Sleep(nTimeOut); > + if(info.ret==-1) > + SendMessageA(info.hWndDlg,WM_COMMAND,Data[i].nExitMessage,(LPARAM)GetDlgItem( info.hWndDlg, > Data[i].nExitMessage )); Why don't you check whether 'info.ret==-1' is a legitimate response or not? > + Sleep(nTimeOut); > + ok(info.ret == Data[i].nReact,"This dialogue has incorrect reaction on IDCANCEL!\n"); > + CloseHandle( thread ); > + } > +} And these Sleep() calls are potential races. -- Dmitry.

1 0

Re: Add tests to odbccp32
by Detlef Riekenberg 08 Jan '07

08 Jan '07

On Mo, 2007-01-08 at 09:58 -0800, Bill Medland wrote: > Bill Medland (billmedland(a)shaw.ca) > Add tests structure to odbccp32 > +START_TEST(error) > +{ > +} We really need more tests, but I do not think, that an empty testfile can go in the tree. And as another hint, you should use the same filename. You might want to look, how I add the tests for "localspl.dll": I use the testfile "dlls/localspl/tests/localmon.c" to test the implementation of "dlls/localspl/localmon.c" The History for the tests: http://source.winehq.org/git/wine.git/?a=history;f=dlls/localspl/tests My Patch for the initial test: http://www.winehq.org/pipermail/wine-patches/2006-September/031009.html -- By by ... Detlef

1 0

Compilation problem during regression testing
by L. Rahyen 08 Jan '07

08 Jan '07

I'm doing regression testing of Hogia software and have following compilation problem near wine-0.9.12: ../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./ddraw.spec d3d_utils.o device_main.o device_opengl.o direct3d_main.o direct3d_opengl.o executebuffer.o light.o material.o opengl_utils.o texture.o vertexbuffer.o viewport.o clipper.o ddraw_hal.o ddraw_main.o ddraw_thunks.o ddraw_user.o ddraw_utils.o main.o palette_hal.o palette_main.o regsvr.o surface_dib.o surface_fakezbuffer.o surface_gamma.o surface_hal.o surface_main.o surface_thunks.o surface_user.o surface_wndproc.o version.res -Wl,--rpath, \$ORIGIN/`../../tools/relpath /usr/local/lib/wine /usr/local/lib` -o ddraw.dll.so -L../../dlls -lole32 -luser32 -lgdi32 -ladvapi32 -lkernel32 -lntdll -L../../libs -lwine -ldxguid -luuid -lSM -lICE -lXxf86vm -lXext -lX11 -L../../libs/port -lwine_port surface_dib.o: In function `create_dib': /var/pkgs/wine/wine-git.experimental/dlls/ddraw/surface_dib.c:159: undefined reference to `DIB_CreateDIBSection' collect2: ld returned 1 exit status winegcc: gcc failed. make[2]: *** [ddraw.dll.so] Error 2 make[2]: Leaving directory `/var/pkgs/wine/wine-git.experimental/dlls/ddraw' make[1]: *** [ddraw] Error 2 make[1]: Leaving directory `/var/pkgs/wine/wine-git.experimental/dlls' make: *** [dlls] Error 2 Any idea how to resolve this? I tried to compile with 3.4.6 and 4.1.2 - same result.

1 0

Re: [try 3] systray patches
by Kirill K. Smirnov 08 Jan '07

08 Jan '07

Please, explain me, what is wrong with this serie of patches? What to do to improve them? http://www.winehq.org/pipermail/wine-patches/2007-January/034408.html http://www.winehq.org/pipermail/wine-patches/2007-January/034409.html http://www.winehq.org/pipermail/wine-patches/2007-January/034410.html http://www.winehq.org/pipermail/wine-patches/2007-January/034412.html http://www.winehq.org/pipermail/wine-patches/2007-January/034413.html Regards, Kirill K. Smirnov

2 1

Re: [Fwd: patch for bz 6855]
by James Hawkins 08 Jan '07

08 Jan '07

On 1/7/07, Neil Marko <nmarko(a)isyssoft.com> wrote: > Very sorry, I meant 0.9.28 and I forgot the patch!!! > > Hope this helps. > > Neil Marko > > -------- Original Message -------- > Subject: patch for bz 6855 > Date: Sun, 07 Jan 2007 17:42:56 -0500 > From: Neil Marko <nmarko(a)isyssoft.com> > To: wine-patches(a)winehq.org > > > > Hi all: > > Sorry that this is not in GIT format. I do not have the time to learn > this. I just wanted to get Off2K installed on 9.2.28. > > My determination of this bug is that around version 9.2.20 or so, > dlls/msi/files.c was rewritten. This bug seems to come from that. In > the routine ACTION_InstallFiles, there is a loop of all the file > objects. The first few steps of that loop attempt to detect a media > change. That ultimately causes a call to load_media_info. The select > statement in load_media_info has a where clause where table column > LastSequence is greater than the value of the current file. The problem > I detected is that what is selected in the first pass through the loop > is the media for the next sequence (COMCTL.OCX) and not the current > file. When a successful select occurs, the value of mi->last_sequence > is updated from the select row, which is obviously not correct. When we > loop eventually to the file structure where we should have a media > change (COMCTL.OCX), we do not do the media change and then we do not > extract the compressed file and the install fails. I solved this by > simply setting mi->last_sequence to file->Sequence in the loop in > ACTION_InstallFiles. > > It is possible that maybe changing the ">=" to a "=" in the select in > load_media_info might also solve this but I do not have enough knowledge > about msi to know if that could cause any other problems. I think we > would also have to change the error condition so that not reading rows > there would not cause a failure. That seemed like a lot more work! > > I eventually successfully installed Off2K on 9.2.28 with this. > (Eventually since I have only an "upgrade" version of Off2K and > therefore, some of the registry was not setup correctly. I made it work.) > It would be great if you could add a test for this case to dlls/msi/tests/install.c. That way we can verify that the fix is correct. Thanks, James Hawkins

1 0

Re: Add tests to odbccp32
by James Hawkins 08 Jan '07

08 Jan '07

On 1/8/07, Bill Medland <billmedland(a)shaw.ca> wrote: > Bill Medland (billmedland(a)shaw.ca) > Add tests structure to odbccp32 > You need to add tests for this patch to be accepted. Also, you've labeled the test suite 'error'. How many functions in odbccp32 are you planning on testing in this file? I see only SQLInstallerError and SQLPostInstallerError in the spec file, which is not enough to warrant a whole test file. Please read other test files to get a better of idea what needs to happen with these tests. -- James Hawkins

2 4

Re: dinput, wheel/joystick and richard burns rally
by Vitaliy Margolen 08 Jan '07

08 Jan '07

Christoph Frick wrote: > On Mon, Jan 08, 2007 at 10:28:22AM -0700, Vitaliy Margolen wrote: > >> That is correct. I already fixed mouse and keyboard the proper way. >> Now left to fix joysticks. It seems joysticks are in the worse shape >> that I thought. Number of places using wrong object indexes. > > does that mean, you are already working in this area? > Well I've been looking at what will it take to fix it. Also made few patches for EnumObjects and GetObjectInfo. But I can't send those, because other parts using wrong indexes. And it will really brake things (but should fix the problem Tuomo was talking about). If you want to pick it up, I can move on to something else. Vitaliy.

1 0

dinput, wheel/joystick and richard burns rally
by Tuomo Kohvakka 08 Jan '07

08 Jan '07

Hello, first, appdb entry: http://appdb.winehq.org/appview.php?iVersionId=5934&iTestingId=6382 As shown there, joystick (that ofcourse really means the wheel :) isn't detected by the game with current wine. I decided to take a look at that, figuring that it might be fixable. Well, I managed to "fix" it. Code follows, dlls/dinput/device.c, create_DataFormat() around line 387 says that && (/* Then check if it accepts any instance id, and if not, if it matches Wine's * instance id. */ ((asked_format->rgodf[j].dwType & DIDFT_INSTANCEMASK) == DIDFT_ANYINSTANCE) || (DIDFT_GETINSTANCE(asked_format->rgodf[j].dwType) == 0x00FF) || /* This is mentionned in no DX docs, but it works fine - tested on WinXP */ (DIDFT_GETINSTANCE(asked_format->rgodf[j].dwType) == DIDFT_GETINSTANCE(format->wine_df->rgodf[i].dwType))) && Now, adding || ((asked_format->rgodf[j].dwType&0xff) == (format->wine_df->rgodf[i]. =>dwType&0xff)) into middle of that fixes it. It works fine and doesn't seem to break anything (didn't try other applications thought). It took me a couple of hours to figure above ou, a few more comments more might have helped! :) (code itself is rather easy to follow) Now, my problem is that I don't really know anything about directx or much about windows anyhow. That means that I don't know if above "fix" is really proper way to fix anything. I figure that purpose of this function make a mapping from devices axes and buttons (wine datastructure) into applications preferred structure (which is used later on in fill_DataFormat). Mapping goes wrong without above, as application requests "3" in dwType and wine has something like 0x80ffff03. It's defined in c_dfDIJoystick2, data_formats.c as DIDFT_OPTIONAL|DIDFT_AXIS|DIDFT_ANYINSTANCE. If mapping goes wrong offset_in becomes -1 and that means that default values will be used (button not pressed etc). (If I would submit a patch containing only comments, some probably wrong guesses, would it be accepted?) Someone here on list probably has more insight on this. What is that dwType anyways? :) Is above fix correct, or should dwType be something else from the beginning with, or am I just completely lost? Bottom line ofcourse is that I would like to see a proper fix in wine .29 that would allow rbr and wheel co-operate :) Should I just try to submit this as a patch? -- Tuomo Kohvakka

3 2

Re: odbccp32 SQLGetInstalledDrivers etc
by Bill Medland 08 Jan '07

08 Jan '07

On Fri, 2007-05-01 at 16:14 -0800, Bill Medland wrote: > Bill Medland (billmedland(a)shaw.ca) > Implement SQLGetInstalledDrivers > Implement a basic SQLInstallerError > Add test framework and some initial tests Would it help if this was split into three patches?

1 0

Missing tables in the AppDB dump
by Tony Lambregts 08 Jan '07

08 Jan '07

The dump of the AppDB is missing the following tables appMaintainers, buglinks, appHitStats, catHitStats Could someone please add them to the nightly dump. Thanks -- Tony Lambregts

2 1