November 2007 - Wine-devel - list.winehq.org

server: avoid sending uninitialized bytes in break_thread()
by Dan Kegel 15 Nov '07

15 Nov '07

In break_thread(), generate_debug_event() seems to send the entire ExceptionInformation array regardless of how many entries are used. The smart thing to do would be to send only the used elements, but I couldn't figure out how to do that. So here's a quick fix that just zeroes that array before calling generate_debug_event(). Is there a better way? Found by running the Word Viewer 97 under valgrind: 000d: wait_debug_event() = 0 { pid=000a, tid=000b, wait=(nil), event={exception,{code=80000003,flags=0,rec=(nil),addr=0x40007f0,params={},first=1} } Syscall param writev(vector[1]) points to uninitialised byte(s) at 0x40007F2: (within /lib/ld-2.5.so) by 0x806AF20: call_req_handler (request.c:249) by 0x8056075: main_loop (fd.c:523) Address 0x451AAB8 is 24 bytes inside a block of size 88 alloc'd by 0x806A167: set_reply_data_size (request.c:200) by 0x80510A6: req_wait_debug_event (request.h:96) by 0x806AFC7: call_req_handler (request.c:286) by 0x8056075: main_loop (fd.c:523) BTW, here's how I ran word viewer under valgrind: wordview.sh: WINEDIR=$HOME/wine-git; VALGRIND_CMD="/usr/local/valgrind-3.2.3-wine/bin/valgrind --trace-children=yes --gen-suppressions=all --suppressions=$WINEDIR/tools/valgrind-suppressions --leak-check=full --num-callers=20 " WINE=$WINEDIR/wine wget http://downloads.pcworld.com/pub/new/business/word_processing/wordview.exe cp wordview.exe ~/.wine/drive_c/wvinstall.exe mv ~/.wine/dosdevices/z: ~/.wine/dosdevices/oldz cd ~/.wine/drive_c $VALGRIND_CMD $WINE wvinstall.exe /q cd ../.. mv ~/.wine/dosdevices/oldz ~/.wine/dosdevices/z:

1 1

Re: server: Make timer id allocation algorithm conform to the Windows one
by Uwe Bonnes 14 Nov '07

14 Nov '07

>>>>> "Dmitry" == Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: Dmitry> Hello, this patch should fix the problem reported in the bug Dmitry> 10343. My test which calls SetTimer in an infinite loop shows Dmitry> that XP starts to allocate timer ids at 0x7fff and goes Dmitry> backwards to 0x101, then restarts from 0x7fff. Isn't this worth a test suite case? -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

AppDB down =(
by John Klehm 14 Nov '07

14 Nov '07

Erm yeah the appdb is down... too many connections...sad times. John

3 2

Re: [4/4] msxml: Test for removeAttribute (try 2)
by Alistair Leslie-Hughes 14 Nov '07

14 Nov '07

Hi, Changelog: msxml: Test for removeAttribute Best Regards Alistair Leslie-Hughes

2 1

Re: [4/8] WineD3D: Depth stencil fixes
by H. Verbeet 14 Nov '07

14 Nov '07

On 13/11/2007, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > static void depth_copy(IWineD3DDevice *iface) { > IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface; > - IWineD3DSurfaceImpl *depth_stencil = (IWineD3DSurfaceImpl *)This->depthStencilBuffer; > + IWineD3DSurfaceImpl *depth_stencil = (IWineD3DSurfaceImpl *)This->auto_depth_stencil_buffer; > > /* Only copy the depth buffer if there is one. */ I think this one should be changed to use stencilBufferTarget instead, although not in this patch.

2 2

Re: USER32: Patch 3 of 6: DlgDirList converts path specification to uppercase.
by Alexandre Julliard 14 Nov '07

14 Nov '07

Alex Villacís Lasso <a_villacis(a)palosanto.com> writes: > Observed while preparing conformance tests. The filepath (if valid) gets > converted to uppercase on return. > > Changelog: > * DlgDirList must convert path specification to uppercase. You should do that after the SetCurrentDirectory, uppercasing it first means we are much more likely to have to do a slow case-insensitive search on the whole path. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/4] msxml: Test for removeAttribute
by Robert Shearman 14 Nov '07

14 Nov '07

Alistair Leslie-Hughes wrote: > @@ -589,6 +589,10 @@ static void test_domnode( void ) > ok( !lstrcmpW(V_BSTR(&var), szstr1), "wrong attr value\n"); > VariantClear( &var ); > SysFreeString( str ); > + > + > + str = SysAllocString( szvr ); > + SysFreeString( str ); > > r = IXMLDOMElement_get_attributes( element, &map ); > ok( r == S_OK, "get_attributes returned wrong code\n"); > @@ -1077,7 +1081,7 @@ static void test_create(void) > ok( r == S_OK, "returns %08x\n", r ); > r = IXMLDOMNamedNodeMap_get_length( attr_map, &num ); > ok( r == S_OK, "returns %08x\n", r ); > - ok( num == 1, "num %ld\n", num ); > + ok( num == 1, "num %ld\n", num ); > IXMLDOMNamedNodeMap_Release( attr_map ); > VariantClear(&var); > r = IXMLDOMElement_getAttribute( element, name, &var ); > These two changes don't appear to be relevant to the test you're adding. -- Rob Shearman

1 0

Re: msxml: Implement cloneNode and correct insertBefore
by James Hawkins 14 Nov '07

14 Nov '07

On 11/13/07, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > > Hi James, > Thanks for the pointers. > > I resend the patches shortly. Is there an easy way to split a Diff up? via > git? More to the point changes to a single file (without have to backup it > up every change) > > I just get frustrated with try to keep lots of diffs around. > mailing list etiquette: make sure to bottom-post on this ML and CC wine-devel so others can share in the information exchange. To answer your question, you have to get into the git mindset. That is, you make one fix, commit the fix, write the next fix, etc. It's really a development change. You should know what to fix before you go in to fix it, not hack around until an app works. -- James Hawkins

3 2

Re: msxml: Implement Element removeAttribute
by Steven Edwards 13 Nov '07

13 Nov '07

On Nov 12, 2007 3:57 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > > + > + TRACE("(%p)->%s\n", iface, debugstr_w(p)); > + // TODO Replace if Attribute has a Default value. Also another thing. No C++ style comments in Wine source code. Thanks Steven -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: msxml: Implement cloneNode and correct insertBefore
by James Hawkins 13 Nov '07

13 Nov '07

On 11/12/07, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > Changelog: > InsertBefore is allowed to have outNewChild as NULL > Implement cloneNode > One fix per patch please. Also, please add tests for these fixes. > Best Regards > Alistair Leslie-Hughes > > diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c > index 61d5ab2..86d7614 100644 > --- a/dlls/msxml3/node.c > +++ b/dlls/msxml3/node.c > @@ -373,7 +373,7 @@ static HRESULT WINAPI xmlnode_insertBefore( > > TRACE("(%p)->(%p,var,%p)\n",This,newChild,outNewChild); > > - if (!(newChild && outNewChild)) > + if (!newChild) > return E_INVALIDARG; > > switch(V_VT(&refChild)) > @@ -412,9 +412,13 @@ static HRESULT WINAPI xmlnode_insertBefore( > xmlAddChild(This->node, new_child_node); > } > > - IXMLDOMNode_Release(new); > IXMLDOMNode_AddRef(newChild); > - *outNewChild = newChild; > + IXMLDOMNode_Release(new); > + if(outNewChild) > + { > + *outNewChild = newChild; > + } > + > TRACE("ret S_OK\n"); > return S_OK; > } > @@ -517,8 +521,36 @@ static HRESULT WINAPI xmlnode_cloneNode( > VARIANT_BOOL deep, > IXMLDOMNode** cloneRoot) > { > - FIXME("\n"); > - return E_NOTIMPL; > + xmlnode *This = impl_from_IXMLDOMNode( iface ); > + xmlNodePtr pClone = NULL; > + IXMLDOMNode *pNode = NULL; > + > + TRACE("%p (%d)\n", This, deep); > + > + if(!cloneRoot) > + return E_INVALIDARG; > + > + pClone = xmlCopyNode(This->node, deep ? 1 : 0); > + if(pClone) > + { > + pClone->doc = This->node->doc; > + > + pNode = create_node(pClone); > + if(!pNode) > + { > + ERR("Copy failed\n"); > + return E_FAIL; > + } > + > + *cloneRoot = pNode; > + } > + else > + { > + ERR("Copy failed\n"); > + return E_FAIL; > + } > + > + return S_OK; > } > > static HRESULT WINAPI xmlnode_get_nodeTypeString( > @@ -832,7 +864,7 @@ static ULONG WINAPI Internal_Release( > if ( ref == 0 ) > { > if( This->node ) > - xmldoc_release( This->node->doc ); > + xmldoc_release( This->node->doc ); > Please don't make random whitespace changes. -- James Hawkins

1 0