November 2007 - Wine-devel - list.winehq.org

Re: [5/14] D3D9: Use HAL devices in some tests
by Vitaliy Margolen 07 Nov '07

07 Nov '07

Stefan Dösinger wrote: > > ------------------------------------------------------------------------ > > > > @@ -343,7 +343,7 @@ static void test_refcount(void) > d3dpp.EnableAutoDepthStencil = TRUE; > d3dpp.AutoDepthStencilFormat = D3DFMT_D16; > > - hr = IDirect3D9_CreateDevice( pD3d, D3DADAPTER_DEFAULT, D3DDEVTYPE_NULLREF, hwnd, > + hr = IDirect3D9_CreateDevice( pD3d, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, hwnd, > D3DCREATE_SOFTWARE_VERTEXPROCESSING, &d3dpp, &pDevice ); > ok(SUCCEEDED(hr), "Failed to create IDirect3D9Device (%s)\n", DXGetErrorString9(hr)); > if (FAILED(hr)) goto cleanup; By doing this change you render all VMs useless to run d3d tests. This is much bigger loss then broken tests on vista. Vitaliy

2 1

Re: [14/14] WineD3D: Release the pixel shader function when destroying the shader
by H. Verbeet 06 Nov '07

06 Nov '07

On 06/11/2007, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > It would probably be more proper to do stuff like this (destroying the constants lists as well) in baseshader.c

2 1

Re: RICHED20: fix test failure in test_WM_PASTE
by Alex Villacís Lasso 06 Nov '07

06 Nov '07

Alex Villacís Lasso escribió: > At last! I finally found the way to make native riched20 actually obey > keystrokes involving Ctrl and some other key. It seems that native riched20 > checks the actual keyboard state during WM_KEYDOWN processing, and won't > process keystrokes if the keyboard state does not match the messages being > sent. However, with keybd_event(), native riched20 can be fooled into > accepting > simulated keystrokes. > > Changelog: > * Native riched20 won't obey simple WM_CHAR or WM_KEYDOWN/WM_KEYUP messages > when processing Ctrl-Key keystrokes. Use keybd_event() instead. Fixes one > test failure in Win98 and WinXP-SP2. > * Add more through tests to test_WM_PASTE, to check that text is actually > being modified in intermediate steps. Fixes false test success in Win98 and > WinXP-SP2. Additional tests pass under Win98, WinXP-SP2 and Wine. > ------------------------------------------------------------------------ > Was there something wrong with this patch? Two other patches of mine for riched20 have been committed, but not this one. As it currently stands, it removes the last test failure and also fixes a false test success in WinXP-SP2. -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

1 0

valgrind results 20071106
by Dan Kegel 06 Nov '07

06 Nov '07

http://kegel.com/wine/valgrind/20071106/ Most obvious change since yesterday is Juan fixed the warnings in setupapi, so that DLL is now clean by this test.

1 0

Monday's valgrind results - ten tests fixed!
by Dan Kegel 06 Nov '07

06 Nov '07

Yesterday's git seems to have fixed all the valgrind warnings in ten tests: cabinet/extract cabinet/fdi crypt32/sip d3d8/device dsound/dsound8 mscms/profile mshtml/dom mshtml/htmldoc netapi32/access shdocvw/webbrowser Results are online at http://kegel.com/wine/valgrind/20071105/ (Sorry, I used an old suppressions file, so this has a lot of leak records in it that should have been suppressed. I'll sort that for today's git results.)

1 0

Re: [1/2] explorer: Store current display mode in the registry on startup
by Alexandre Julliard 06 Nov '07

06 Nov '07

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > Changelog: > [1/2] explorer: Store current display mode in the registry on startup. You should either do that only in the case of using the X11 root window, or you need to use a different registry key for each virtual desktop instance. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: USER32: win16 applications should not see long filenames returned from dialog control (try 2)
by Juan Lang 06 Nov '07

06 Nov '07

> What do you think about this version? Better, but still not correct: + ret = DlgDirSelectExA( WIN_Handle32(hwnd), buffer, MAX_PATH, id ); + if (GetLastError() == 0) GetShortPathNameA(buffer, str, len); You shouldn't check GetLastError() for whether DlgDirSelectExA succeeded. Rather, just check ret. You have the same problem in DlgDirSelectComboBoxEx16. --Juan

3 3

Re: #winehq admin troubles
by feba thatl 05 Nov '07

05 Nov '07

> On 11/5/07, Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> wrote: > On Monday 05 November 2007 11:49:52 Hans Leidekker wrote: > > On Monday 05 November 2007 10:39:32 Kai Blin wrote: > > > Personally, I would like to see more people stepping up to help run > > > #winehq instead of just complaining about the work of one of the very few > > > people who actually are out there helping users. > > > > As I understand this history feba thatl tried to do exactly that: help > > others on our user channel... and got banned by vitamin. So if vitamin > > is really under stress from all these complaining users, he's not helping > > himself by kicking out others who try to help. > > > > -Hans > > > No, he was just telling the user to upgrade Wine, which vitamin knew would > have no effect whatsoever. The only thing that could have benefited from > that advice would have been his self-image. > > > > Alexander N. Sørnes > > > What? How does giving someone a basic bit of advice, usually the first advice you hear (It's even in the channel's topic), do anything to improve anyone's self-image? If I was going to try to feel better about myself, it wouldn't be by sitting on IRC acting like I know all the answers to something I don't. I no more help people for my self-image than Vitamin kicks people for entertainment-- that's not the case, and we shouldn't act like it is. Even still, why should someone who helps others because it makes them feel good be shunned? They can still help. Not to mention, where do you draw the line? People who can only give basic advice and their best guess? People who know more than that, but are off the mark? People shouldn't be expected to think in code and memorize every tidbit under the sun if they just want to try to help people, there's no reason someone should be kicked for making a good faith effort, especially without being told otherwise. I could understand if I had been sitting in the channel, and popped in with a comment that was obviously out of place based on what had already been mentioned, or if I had been asked to stop, or if my advice was obviously and intentionally harmful (telling people to rm -rf / and such), but it wasn't. If people really are expected to know everything there is to know before they try to help, is it really such a wonder that there's only a few solid contributors left, and they're stressed from it? This really has little to do with myself, Vitamin, the other person, or what happened; it's about winehq's problems where it should be concerned with helping people. There are definite civility problems; of course on the side of those that seek help (As many feel like customers instead of part of a community), but also on the side of those that give it. Now, I can obviously understand mistreating people who are just screwing around, or treating people who are trying to help them like crap, but it's treating people that are trying to give or get help the same way that bugs me. I can understand it how it happens, like I said above, I'm not saying I'd be better in such a situation. I have nothing to gain from this being corrected that anyone else seeking help wouldn't, and I'm not asking for any action to be taken against Vitamin for anything, at least yet. I've got nothing against him-- I might have a sour taste in my mouth when I cross him, but I don't think he's a bad person. He knows and cares a lot about something, tries to improve and help people with it, and dislikes people who he perceives as stupid or harmful; even to the point where he becomes a bit too annoyed and starts mislabeling people, or treating people who don't deserve it wrongly. I don't blame him for this, as I've done the same myself. Multiple times. Under different circumstances, I could easily see us being friends. What I want to see changed here isn't treatment of any specific person-- in fact I would probably disagree with any action major enough to matter being taken against Vitamin, as again, from what I've seen he seems to be a valuable asset to Wine and #winehq-- just for some sort of adoption of rules for how to treat other people being established, even if they're as simple as: 1. Users: Be nice to the helpers. We are volunteers, not employees, and have no obligation to help you. 2. Helpers and Admins: Remember Hanlon's razor. P.S. I accidentally only sent this to one email address, and had some trouble digging up the sent message to try to get it out again. Sorry about any trouble this might have.

3 2

#winehq admin troubles
by feba thatl 05 Nov '07

05 Nov '07

Sorry if this mailing list is less than appropriate, but from what I've seen this is where the conversation was last time, and there doesn't seem to be much better. A while ago (Probably one-three months), I went to #winehq to ask about something, and was treated rather rudely by vitamin. I got annoyed by him, and made a somewhat rude comment myself (not as rude as he was being, but still probably inappropriate), and he kicked me. I rejoined the channel, and I don't really remember what happened afterwards, but it can't have been too awful as I don't believe I was banned. I do remember being left with a very sour taste with Wine, as I googled vitamin, and found that this was nowhere near the first time he had been needlessly rude to a user and had even given completely unwarranted bans with seemingly no reprimand. I gradually started going back to winehq for help and questions, with no problems. Last night, I went in to ask if anyone wanted to help me get a program working, and vitamin replied. I groaned to myself, but we had a perfectly civil conversation. At one point he stopped replying, but it's not like I haven't had to walk off myself for various reasons, so I just left quietly. Today, I joined #ubuntu to try to get something working, and found someone else asking for help with Wine. I (amongst others) recommended they go to #winehq. They joined, but commented in #ubuntu that, quote: (09:27:58 PM) <Name removed>: man these #winehq people are not friendly at all I joined #winehq and confirmed my fears that vitamin was being rude to someone else. Vitamin asked what version they were running, they answered with 9.46 (the version in the Ubuntu repos, last I checked), and I recommended they go to winehq.org and follow the instructions on how to add the Wine repos. Vitamin said something along the lines of "that isn't the case here", I said that it's still helpful (to have an up to date version of wine). I then asked if Vitamin had got the program we talked about last night working, and seconds later was kicked. No explanation, the kick line just had "(Vitamin)". Utterly confused, I rejoined, for which I do have a chatlog: (09:32:56 PM) The topic for #winehq is:[long topic removed] (09:33:09 PM) ***vitamin fucking tired all knowning noobs! (09:33:15 PM) <Name removed, same person from #ubuntu>: wine: cannot find '/media/cdrom0/intro.exe' (09:33:15 PM) vitamin: usrl, you better leave (09:33:25 PM) usrl: Why? (09:33:32 PM) mode (+b *!*n=feba(a)*.hsd1.ks.comcast.net ) by vitamin (09:33:32 PM) You have been kicked by vitamin: (vitamin) That's the entire chatlog of my second time joining (I didn't think to save a copy of the first), with nothing removed but a bunch of topic stuff nobody wants to read and the fellow from #ubuntu's nick. Now, I not only have been banned for apparently being a noob (Again, it's a best guess, Vitamin did not give any clue at all in his kick messages, let alone a warning in the channel) in a channel that is supposed to support end users, but a few minutes later, I see this, again in #ubuntu: (09:37:15 PM) <Name removed>: well I got banned from winehq for asking a question This person didn't seem rude at all when I was talking to them. Thankfully, they were able to get their problems resolved in #ubuntu. Given that vitamin seems to have had user abuse problems in the past, what is going on here? I can understand not getting professional service in an IRC channel, but why is someone who is so needlessly abusive (again, kicking people for little more than asking a question; when the channel is for support.) entrusted with admin abilities? From what I read on another complaint, he seems to be in this position because he is a developer, not because he is truly a good fit for being a moderator or even a helper. While he might be great at coding, his people skills definitely suffer. I can understand getting angry over people asking their questions right, but when you're trying to support end users, you have to be able to deal with at least some stupidity-- and even disregarding that, if you're going to not only kick someone, but ban them, give them some idea of what they did wrong. It almost seems to me as if he is banning people not because they did something wrong, but because he had a bad day-- like I said, last night he was fairly civil, even though I'm sure I made my share of stupid questions and comments. I'm not sure if this is the only moderator with these sorts of problems, but something needs to be done. Wine is used by all sorts of people, heck, my mother uses it. When all sorts of people are using a program, all sorts of people are going to be having problems with it. I wouldn't expect my mother, or anyone else's, to be able to phrase their question well and make a support person happy, but I also wouldn't expect someone who is supposed to be supporting users insulting them and banning them (not only ignoring their need for help, but effectively making it impossible for many other people to help them as well). Something needs to change, Wine is something a lot of people switching to non-Windows OS are going to use, and many people could be easily turned off when they find the first place they turn to for help, the place that winehq.org leads them to, not only has very rude people in power, but has no checks or guards to keep said people from ruining a user's experience.

13 14

#winehq admin troubles
by Luke Bratch 05 Nov '07

05 Nov '07

Chris Morgan wrote: > Allowing this kind of behavior to continue reflects poorly on us as a > community. I'd like to suggest that this be the last time we hear > about issues like this. If it happens again I'd like to propose a > graduated scale of irc channel bans, starting at one month, for > Vitamin. I don't often hang out in #winehq, but I do follow Bugzilla religiously, and I used to think bad things about Vitamin too, because of the way he would reply to various people (generally newcomers). However as time goes on I can now see that he is quite right in how he deals with people - it is good to be strict with people, as it will hopefully give them a kick up the backside in the right direction. If I blundered into a new online community and didn't behave in a constructive or useful manor, people shouting at me would certainly make me get my act sorted out, whereas people acting normally might make me carry on in the same way. After seeing Vitamin deal with people for a long time now, I can say I totally agree with how he does things. Luke ___________________________________________________________ Want ideas for reducing your carbon footprint? Visit Yahoo! For Good http://uk.promotions.yahoo.com/forgood/environment.html

1 0