December 2007 - Wine-devel - list.winehq.org

Re: [PATCH 04/14] inetcomm: Add self-registration code.
by Detlef Riekenberg 08 Jan '08

08 Jan '08

On Fr, 2007-11-02 at 13:46 +0000, Huw Davies wrote: > + NULL, The char 0x0c looks wrong here. (was already in the Patch from Rob) The Patchset was send twice (xx/14 and xx/18) with the same times. Example from Huw (Rob did the same before): Subject: [PATCH 17/18] inetcomm: Add two missing member functions. Date: Fri, 2 Nov 2007 11:54:03 +0000 (12:54 CET) Subject: [PATCH 13/14] inetcomm: Add two missing member functions. Date: Fri, 2 Nov 2007 11:54:03 +0000 (12:54 CET) -- By by ... Detlef

3 2

What happened to the videos from WineConf?
by Maarten Lankhorst 06 Jan '08

06 Jan '08

I remember at wineconf there were some videos created, what happened with those? I tried to look on youtube for wineconf, but I didn't find anything. Are they online yet? Or will they be put online? -Maarten

5 9

Re: comdlg32: 1/2 PageSetupDlg: Convert paint procs to Unicode
by Dmitry Timoshkov 06 Jan '08

06 Jan '08

"Alexander Nicolaysen Sørnes" <alex(a)thehandofagony.com> wrote: > comdlg32: 1/2 PageSetupDlg: Convert paint procs to Unicod What's the purpose of this patch? It improves nothing IMO except of making the code less readable, making it not thread safe, calling CallWindowProcW where it shouldn't. -- Dmitry.

2 4

Where are the bugzilla admins?
by Vitaliy Margolen 06 Jan '08

06 Jan '08

Where did our buzilla admins go? 3 weeks and nothing is changing! Vitaliy.

3 5

So, you want to fix typos?
by Dan Kegel 03 Jan '08

03 Jan '08

I see somebody's posting a few fix-typo-in-comments patches, e.g. http://www.winehq.org/pipermail/wine-patches/2007-December/048099.html http://www.winehq.org/pipermail/wine-patches/2007-December/048101.html That reminds me that I worked out some time ago how to find such typos efficiently. At the risk of encouraging lots of silly typo-fixing patches, I've documented the process here: http://kegel.com/wine/spellingpolice/ For instance, to find typos in comments in shell32, you can do: sudo apt-get install ispell wget http://kegel.com/wine/spellingpolice/stop.txt wget http://kegel.com/wine/spellingpolice/lspell-pl.txt -O lspell.pl perl lspell.pl stop.txt ~/wine-git/dlls/shell32/*.[ch] This outputs: /home/dank/wine-git/dlls/shell32/autocomplete.c: 1 dispays /home/dank/wine-git/dlls/shell32/brsfolder.c: 1 relativ /home/dank/wine-git/dlls/shell32/dataobject.c: 1 droping /home/dank/wine-git/dlls/shell32/iconcache.c: 1 resoure /home/dank/wine-git/dlls/shell32/pidl.c: 1 relativ /home/dank/wine-git/dlls/shell32/pidl.h: 1 desribes /home/dank/wine-git/dlls/shell32/shell.c: 1 incidently /home/dank/wine-git/dlls/shell32/shfldr_fs.c: 1 spezified /home/dank/wine-git/dlls/shell32/shfldr_unixfs.c: 4 appart relativ savely should'nt /home/dank/wine-git/dlls/shell32/shlexec.c: 1 foward /home/dank/wine-git/dlls/shell32/shlfileop.c: 2 ERRROR INVLID /home/dank/wine-git/dlls/shell32/shlfolder.c: 1 whitch /home/dank/wine-git/dlls/shell32/shlview.c: 2 buily provied /home/dank/wine-git/dlls/shell32/trash.c: 1 DESCRITION

4 4

I am at the Ubuntu Developer Summit, do we need anything from other projects?
by scott＠tuzakey.com 03 Jan '08

03 Jan '08

The other day an X.org developer asked me if Wine needed anything from X. Off the top of my head, all I could think to tell him was relative mouse movements. There are people from many free software projects here, including the kernel and Samba. Should I voice anything else? Thanks, Scott Ritchie

5 5

dlls/wintab32/context.c -- simpflication and HEADS UP!
by Gerald Pfeifer 02 Jan '08

02 Jan '08

This change of mine is obvious since InExt and OutExt are DWORD, thus unsigned, and thus always greater or equal zero so my patch should be fine in any case. However, looking at the else-part of the if-statement, I have some doubts this is working as designed, and in general the abs() invocations are bogus. Any expert who could help with a more extensive patch? Gerald ChangeLog: Simplify condition in ScaleForContext(). Index: dlls/wintab32/context.c =================================================================== RCS file: /home/wine/wine/dlls/wintab32/context.c,v retrieving revision 1.22 diff -u -3 -p -r1.22 context.c --- dlls/wintab32/context.c 21 Sep 2007 12:24:49 -0000 1.22 +++ dlls/wintab32/context.c 30 Nov 2007 23:53:47 -0000 @@ -176,7 +176,7 @@ int TABLET_PostTabletMessage(LPOPENCONTE static inline DWORD ScaleForContext(DWORD In, DWORD InOrg, DWORD InExt, DWORD OutOrg, DWORD OutExt) { - if (((InExt > 0 )&&(OutExt > 0)) || ((InExt<0) && (OutExt < 0))) + if ((InExt > 0) && (OutExt > 0)) return ((In - InOrg) * abs(OutExt) / abs(InExt)) + OutOrg; else return ((abs(InExt) - (In - InOrg))*abs(OutExt) / abs(InExt)) + OutOrg;

2 2

bugs audit volunteers required
by Vijay Kiran Kamuju 02 Jan '08

02 Jan '08

Hi, just like last year we did an audit of all the bugs in bugzilla. I think this year also we should do the same, the bugs are growing large and older bugs are being neglected. just wanted to say that we need to check all the old open bugs, and test them/ask the user for status. Close the bug as Abandoned if there is no response. also test the application yourself on latest git. this is the work to be done. and we need volunteers for this work. need volunteers to clear up the mess(old abandoned bugs) in bugzilla Thanks, vj

7 11

IDirectSound and Unknown IID
by Guillaume B. 02 Jan '08

02 Jan '08

Hi, First post here, so I don't know if it's the right place for this. I'm trying to make the sound and music work in a game with Wine. Currently, the sound doesn't work because the game does some tests to check if everything is OK before it starts the music. For now, it fails early in those tests but I've hacked some things in the latest git source and the game goes a little farther before it stops trying to make the sound and music work. But now I'm stuck so I was wondering if anyone had an idea. Here's a part of the dsound trace: trace:dsound:IDirectSound8_IDirectSound8_QueryInterface (0x2ce8de8 {2a8af120-e9de-4132-aaa5-4bdda5f325b8},0x34d634) trace:dsound:DSOUND_QueryInterface8 (0x2fdc1e0 {2a8af120-e9de-4132-aaa5-4bdda5f325b8},0x34d634) warn:dsound:DSOUND_QueryInterface8 Unknown IID {2a8af120-e9de-4132-aaa5-4bdda5f325b8} So the problem is that the interace {2a8af120-e9de-4132-aaa5-4bdda5f325b8} is not supported by the current Wine implementation. I've searched around but I couldn't find anything about this IID. If I knew what interface it was, maybe I could implement a stub and it might make the sound work. So does anyone as an idea? Thanks, Guillaume B.

4 7

Re: [5/6] ddraw: fix palette copying when destination palette is NULL
by Stefan Dösinger 01 Jan '08

01 Jan '08

Am Montag, 31. Dezember 2007 03:04:02 schrieb Alexander Dorofeyev: > I think there's a bug here. If pal == NULL that implies (because of > preceding code) that wine_pal == NULL. So it's setting a NULL wined3d > palette to the destination wined3d surface, yet increases reference counter > on source palette. I guess it should pass source wined3d palette here, to > make any sense. --- > dlls/ddraw/texture.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) I am not sure about this, but honestly I don't really know much about IDirect3DTexture2::Load is supposed to work. When I ported ddraw.dll to use wined3d I only did routine adjustments to the code to cope with the wined3d objects. I think Lionel Ulmer wrote the original code, maybe he can comment on it? I think we really need a few unit tests for this method. From the docs, it seems that this method is related to IDirect3DDevice9::LoadTexture, maybe we can map it to WineD3D's loadtexture.

3 10