February 2007 - Wine-devel - list.winehq.org

Re: [7/7] cmd.exe: Support rd dir1 dir2 dir3 etc
by Alexandre Julliard 28 Feb '07

28 Feb '07

"Ann & Jason Edmeades" <us(a)edmeades.me.uk> writes: > diff --git a/programs/cmd/wcmd.h b/programs/cmd/wcmd.h > index d6357f0..a7a73ae 100644 > --- a/programs/cmd/wcmd.h > +++ b/programs/cmd/wcmd.h > @@ -27,6 +27,9 @@ > #include <stdio.h> > #include <ctype.h> > > +#include "wine/debug.h" > +WINE_DEFAULT_DEBUG_CHANNEL(cmd); Adding tracing is OK, but this should go in the C files that need it, not in a header. -- Alexandre Julliard julliard(a)winehq.org

1 0

wine and msys rxvt.exe
by Wesley Parish 28 Feb '07

28 Feb '07

I installed msys a couple of years back, and decided to test rxvt.exe: bash-3.1$ wine .wine/drive_c/msys/1.0/bin/rxvt.exe libGL warning: 3D driver claims to not support visual 0x4b fixme:netapi32:NetWkstaUserGetInfo Level 1 processing is partially implemented fixme:advapi:LsaOpenPolicy ((null),0x68f478,0x00000001,0x68f494) stub fixme:advapi:LsaClose (0xcafe) stub fixme:advapi:LsaOpenPolicy ((null),0x68f488,0x000f0fff,0x68f484) stub fixme:netbios:NetServerEnum Stub ((null) 101 0x68ef04 -1 0x68ef08 0x68ef0c 8 L"DOMAIN" (nil)) fixme:advapi:LsaClose (0xcafe) stub fixme:netapi32:NetUserGetInfo Level 3 is not implemented fixme:netapi32:NetUserGetInfo Level 3 is not implemented failed to load libX11.dllbash-3.1$ bash-3.1$ wine --version wine-0.9.29 Those are the error messages. My version of wine is a little old. Have the fixme's been fixed in the latest wine? thanks Wesley Parish -- Clinersterton beademung, with all of love - RIP James Blish ----- Mau e ki, he aha te mea nui? You ask, what is the most important thing? Maku e ki, he tangata, he tangata, he tangata. I reply, it is people, it is people, it is people.

7 8

Re: msi: Add proper parameter handling to OLE automation interfaces.
by Robert Shearman 28 Feb '07

28 Feb '07

Misha Koshelev wrote: > +/* Macros for variant conversions */ > +#define V_DECLARE \ > + VARIANTARG vararg[pDispParams->cArgs]; \ > + int iVarCount; \ > + HRESULT hr = S_OK; \ > + memset(vararg, 0, sizeof(vararg)); > +#define V_PREPARE(n, type) \ > + VariantInit(&vararg[n]); \ > + hr = VariantChangeTypeEx(&vararg[n], &pDispParams->rgvarg[n], lcid, 0, VT_##type); \ > + if (FAILED(hr)) \ > + { \ > + *puArgErr = n; \ > + goto v_finish; \ > + } > +#define V_PREPAREOPT(n, type) \ > + VariantInit(&vararg[n]); \ > + if (FAILED(VariantChangeTypeEx(&vararg[n], &pDispParams->rgvarg[n], lcid, 0, VT_##type))) \ > + VariantClear(&vararg[n]); > +#define V_PREPARED(n) (V_VT(&vararg[n]) != VT_EMPTY) > +#define V(n, type) V_##type(&vararg[n]) > +#define V_RETURN(value, type) \ > + V_VT(pVarResult) = VT_##type; \ > + V_##type(pVarResult) = value; > +#define V_FAIL hr = E_FAIL; > +#define V_DEFAULT \ > + default: \ > + hr = DISP_E_MEMBERNOTFOUND; > +#define V_FINISH \ > + goto v_finish; /* suppress warnings about unused label v_free */ \ > +v_finish: \ > + for (iVarCount = 0; iVarCount < pDispParams->cArgs; iVarCount++) \ > + if (V_PREPARED(iVarCount)) \ > + VariantClear(&vararg[iVarCount]); \ > + return hr; > This is quite ugly. You can at replace at least some of this with calls to DispGetParam. A lot of the methods only have one parameter so will end up simpler without using these macros. -- Rob Shearman

1 0

Re: msi: automation: clean up comments.
by James Hawkins 28 Feb '07

28 Feb '07

On 2/27/07, Misha Koshelev <mk144210(a)bcm.tmc.edu> wrote: > Looking back at James comments, maybe I did have a little too much > commenting there :) > You're sending patches that change code that hasn't been committed yet. Instead, you need to go back and change the original patch and resend. -- James Hawkins

1 0

Re: msi: Expand OLE automation interface parameter handling.
by James Hawkins 28 Feb '07

28 Feb '07

On 2/27/07, Misha Koshelev <mk144210(a)bcm.tmc.edu> wrote: > This applies on top of my other OLE automation patches. Added new > checks: > Why don't you wait until the other patches are committed before sending these new patches? It makes it hard to review, because I don't have your other patches applied. > - Parameter we are looking for is not passed? > - Only set puArgErr if it is passed > - Make sure pVarResult is valid before we write to it > - Don't return S_FAIL. MSDN doesn't mention it in the Invoke help, so we > won't use it. > You need to add tests for these items. -- James Hawkins

1 0

Success story with Flash on Wine
by Dan Kegel 28 Feb '07

28 Feb '07

http://blog.brokenfunction.com/2007/02/27/debugging-flash-on-linux/ says "... How strange, the wine-powered standalone player is the most stable Flash player I've used yet. On Windows it would occasionally be unable to connect to the debugger until I restarted Eclipse, usually related to having to many players open at the same time. On Linux it will crash unexpectedly. Now I can have a dozen debuggers open at the same time with no crashes yet." Cool!

1 0

Re: Make sure keyboard state is up to date before processing GetAsyncKeyState.
by Detlef Riekenberg 28 Feb '07

28 Feb '07

On Di, 2007-02-27 at 20:28 +0900, Aric Stewart wrote: > --- a/dlls/winex11.drv/keyboard.c > +++ b/dlls/winex11.drv/keyboard.c > @@ -94,6 +94,9 @@ static int kcControl, kcAlt, kcShift, kc > > static char KEYBOARD_MapDeadKeysym(KeySym keysym); > > +extern DWORD X11DRV_MsgWaitForMultipleObjectsEx( DWORD count, > + const HANDLE *handles, DWORD timeout, DWORD mask, > DWORD flags); I have no Idea about the code, but... IMHO, that declaration fit perfect into x11drv.h -- By by ... Detlef

2 1

Re: xcopy try 3
by Alexandre Julliard 27 Feb '07

27 Feb '07

"Ann & Jason Edmeades" <us(a)edmeades.me.uk> writes: > diff --git a/programs/xcopy/Makefile.in b/programs/xcopy/Makefile.in > new file mode 100755 All the files you create or modify are marked executable, could you please fix that? -- Alexandre Julliard julliard(a)winehq.org

3 2

Commit 37591409b28c2000e70bd0d3c654a3a7559a4a26 breaks accentuation
by Pedro Araujo Chaves Jr. 27 Feb '07

27 Feb '07

Hi all, After some regression testing, I found out that commit 37591409b28c2000e70bd0d3c654a3a7559a4a26 by Dmitry Timoshkov breaks accentuation - at least for Brazilian Portuguese in Lotus Notes R5. I did some testing and found out that only TrueType fonts are affected - that is, the fonts Notes lists as 'default foo' without the double-T icon are all accented properly. To make matters worse, the affected fonts don't behave the same way. For example, the string áéíóú ÁÉÍÓÚ àèìòù ÀÈÌÒÙ ãõ ÃÕ âêîôû ÂÊÎÔÛ äëïöü ÄËÏÖÜ renders as įéķóś ĮÉĶÓŚ ąčģņł ĄČĢŅŁ ćõ ĆÕ āźīōū ĀŹĪŌŪ äėļöü ÄĖĻÖÜ with Trebuchet MS. You can see they're pretty different - well, most of you, at least. However, that's only a display-and-print issue, as I can copy the text and paste it elsewhere, and the accents are in their right places (and in the right letters, for that matter) - as one would expect. Regarding Microsoft fonts, by the way, Calibri, Candara, Consolas, Constantia, Corbel, Segoe Print, and Segoe Script (couldn't test Cambria) all behave exactly like Trebuchet MS, whereas Segoe UI behaves just like Times New Roman, which shows problems only with graves and tildes. However the behavior is kinda random among the many other fonts (from many unrelated sources, of course) I tested, so I (still) didn't do an exhaustive check for a pattern. Would anybody have any word on this? Cheers, Pedro.

2 2

Re: wininet: Constify a formal parameter of CommitURLCache{A|W}() (Resend)
by James Hawkins 27 Feb '07

27 Feb '07

On 2/26/07, Andrew Talbot <Andrew.Talbot(a)talbotville.com> wrote: > What is wrong with this patch, please? > This isn't how it's defined in the SDK headers. -- James Hawkins

2 5