March 2007 - Wine-devel - list.winehq.org

last year's email
by Bill Medland 21 Mar '07

21 Mar '07

Is there something wrong with the list server? I am being bombarded with last year's emails. Bill Medland

5 6

Re: wined3d: Check for float texture formats correctly.
by Dmitry Timoshkov 21 Mar '07

21 Mar '07

"Vitaly Budovski" <vbudovski(a)gmail.com> wrote: > @@ -1662,6 +1662,20 @@ static HRESULT WINAPI IWineD3DImpl_Check > case WINED3DFMT_P8: > TRACE_(d3d_caps)("[OK]\n"); > return WINED3D_OK; > + case WINED3DFMT_R16F: > + case WINED3DFMT_A16B16G16R16F: > + if (!GL_SUPPORT(ARB_HALF_FLOAT_PIXEL)) { > + TRACE_(d3d_caps)("[FAILED]\n"); > + return WINED3DERR_NOTAVAILABLE; > + } I realize that in the original chunk of code there is no a comment /* fall through */ either, but if it's really an intent please add it. > + case WINED3DFMT_R32F: > + case WINED3DFMT_A32B32G32R32F: > + if (!GL_SUPPORT(ARB_TEXTURE_FLOAT)) { > + TRACE_(d3d_caps)("[FAILED]\n"); > + return WINED3DERR_NOTAVAILABLE; > + } > + TRACE_(d3d_caps)("[OK]\n"); > + return WINED3D_OK; -- Dmitry.

1 0

On bugs and docs
by Tom Spear 21 Mar '07

21 Mar '07

Hi all, just some quick questions. Is it just me or has anyone else noticed that the documentation for wine is kind of scattered all over the place? I mean personally I can name about 8 different places (that are affiliated with winehq) that people can go to get information, not including the mailing lists. IMHO if it were even possible to consolidate all of the information, it would still take months to do, especially with people not knowing to post to the central location. Also, is it against the rules in bugzilla to try to organize the bugs some way? IOW The very old games metabug that I created (bug 1434).. I originally opened it not realizing that if every bug related to a game was attached the page would become overloaded. So I decided a year or two ago to close it. Then I recently realized how I could reorganize it and decided to reopen it, only to have it closed again by someone else who in not so many words told me that I was spamming the bug list and that I was annoying everyone. Basically my idea was to make several tasklists to link to 1434 (bugs like dinput9, d3d8, etc), and then link individual games to each of those, so that someone working on games, and in specific on dinput9 for example could easily find bugs related to dinput 9 without having to do a query. But now I am worried that I am overstepping my bounds by trying to do so. Does anyone _else_ object to this idea? -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

5 12

Re: comctl32: CreateToolbarEx should send TB_SETBITMAPSIZE twice (fixes bug #6392)
by James Hawkins 20 Mar '07

20 Mar '07

On 3/19/07, Mikołaj Zalewski <mikolaj(a)zalewski.pl> wrote: > As can be seen in Spy++ and by the attached tests, CreateToolbarEx sends > TB_SETBITMAPSIZE twice instead of TB_SETBITMAPSIZE and TB_SETBUTTONSIZE. > ShellExViewer depends on this bug. The patch contains also some tests > and fixes for d[xy]Button <= 0. > > From c8a84900ae5d9ca7d77d443990e935b8c268bf4c Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?Miko=C5=82aj_Zalewski?= <mikolaj(a)zalewski.pl> > Date: Mon, 19 Mar 2007 10:40:53 +0100 > Subject: [PATCH] comctl32: CreateToolbarEx should send TB_SETBITMAPSIZE twice (fixes bug #6392) > > --- > dlls/comctl32/commctrl.c | 13 +++++++------ > dlls/comctl32/tests/toolbar.c | 40 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 47 insertions(+), 6 deletions(-) > > diff --git a/dlls/comctl32/commctrl.c b/dlls/comctl32/commctrl.c > index c21cae3..7e44e03 100644 > --- a/dlls/comctl32/commctrl.c > +++ b/dlls/comctl32/commctrl.c > @@ -693,12 +693,13 @@ CreateToolbarEx (HWND hwnd, DWORD style, UINT wID, INT nBitmaps, > SendMessageW (hwndTB, TB_SETBITMAPSIZE, 0, > MAKELPARAM((WORD)dxBitmap, (WORD)dyBitmap)); > > - if (dxButton <= 0) > - dxButton = 24; > - if (dyButton <= 0) > - dyButton = 22; > - SendMessageW (hwndTB, TB_SETBUTTONSIZE, 0, > - MAKELPARAM((WORD)dxButton, (WORD)dyButton)); > + if (dxButton < 0) > + dxButton = dxBitmap; > + if (dyButton < 0) > + dyButton = dyBitmap; > + /* TB_SETBUTTONSIZE -> TB_SETBITMAPSIZE bug introduced for Windows compatibility */ > + if (dxButton != 0 && dyButton != 0) > + SendMessageW(hwndTB, TB_SETBITMAPSIZE, 0, MAKELPARAM(dxButton, dyButton)); > > > /* add bitmaps */ > diff --git a/dlls/comctl32/tests/toolbar.c b/dlls/comctl32/tests/toolbar.c > index 164644e..b583295 100644 > --- a/dlls/comctl32/tests/toolbar.c > +++ b/dlls/comctl32/tests/toolbar.c > @@ -869,6 +869,45 @@ static void test_sizes(void) > DestroyWindow(hToolbar); > } > > + > +static void test_createtoolbarex() > +{ > + HWND hToolbar; > + TBBUTTON btns[3]; > + ZeroMemory(&btns, sizeof(btns)); > + > + hToolbar = CreateToolbarEx(hMainWnd, WS_VISIBLE, 1, 16, GetModuleHandle(NULL), IDB_BITMAP_128x15, btns, > + 3, 20, 20, 16, 16, sizeof(TBBUTTON)); > + CHECK_IMAGELIST(16, 20, 20); > + compare((int)SendMessage(hToolbar, TB_GETBUTTONSIZE, 0, 0), 0x1a001b, "%x"); > + DestroyWindow(hToolbar); > + > + hToolbar = CreateToolbarEx(hMainWnd, WS_VISIBLE, 1, 16, GetModuleHandle(NULL), IDB_BITMAP_128x15, btns, > + 3, 4, 4, 16, 16, sizeof(TBBUTTON)); > + CHECK_IMAGELIST(32, 4, 4); > + compare((int)SendMessage(hToolbar, TB_GETBUTTONSIZE, 0, 0), 0xa000b, "%x"); > + DestroyWindow(hToolbar); > + > + hToolbar = CreateToolbarEx(hMainWnd, WS_VISIBLE, 1, 16, GetModuleHandle(NULL), IDB_BITMAP_128x15, btns, > + 3, 0, 8, 12, 12, sizeof(TBBUTTON)); > + CHECK_IMAGELIST(16, 12, 12); > + compare((int)SendMessage(hToolbar, TB_GETBUTTONSIZE, 0, 0), 0x120013, "%x"); > + DestroyWindow(hToolbar); > + > + hToolbar = CreateToolbarEx(hMainWnd, WS_VISIBLE, 1, 16, GetModuleHandle(NULL), IDB_BITMAP_128x15, btns, > + 3, -1, 8, 12, 12, sizeof(TBBUTTON)); > + CHECK_IMAGELIST(16, 12, 8); > + compare((int)SendMessage(hToolbar, TB_GETBUTTONSIZE, 0, 0), 0xe0013, "%x"); > + DestroyWindow(hToolbar); > + > + hToolbar = CreateToolbarEx(hMainWnd, WS_VISIBLE, 1, 16, GetModuleHandle(NULL), IDB_BITMAP_128x15, btns, > + 3, -1, 8, -1, 12, sizeof(TBBUTTON)); > + CHECK_IMAGELIST(16, 16, 8); > + compare((int)SendMessage(hToolbar, TB_GETBUTTONSIZE, 0, 0), 0xe0017, "%x"); > + DestroyWindow(hToolbar); > +} > + > + > START_TEST(toolbar) > { > WNDCLASSA wc; > @@ -899,6 +938,7 @@ START_TEST(toolbar) > test_add_string(); > test_hotitem(); > test_sizes(); > + test_createtoolbarex(); > > PostQuitMessage(0); > while(GetMessageA(&msg,0,0,0)) { > -- > 1.4.4.2 > If you're testing what message is sent, why not use the message sequence testing code? -- James Hawkins

2 1

Re: wine opinion of a user
by Ann & Jason Edmeades 20 Mar '07

20 Mar '07

> Sage Line 50 already has a bug filed: > http://bugs.winehq.org/show_bug.cgi?id=2956 > but we're hampered because there's no free demo for us to test. > You could register for a free trial cd? http://www.sage.co.uk/considering/TryNow.aspx?tid=213114

1 0

Road to 1.0
by Dave Bialac 20 Mar '07

20 Mar '07

Hi All I've been following the list for about a year now, just reading and learning. Through this process, I've come to wonder about the following question -- what should be the goal for Wine 1.0? I know a lot of development is focused around getting one particular application or another to work, especially from the folks over at Code Weavers, but with version numbers approaching 1.0, should there not be a set goal of functionality? My personal thought is that Wine should head in the direction of 100% compatibility with a particular version of Windows. Anything that ran on that version should run on Wine 1.0 with no problems. Any thoughts? Dave

3 2

re: Resend: Add d3drmdef.h header file - try 3
by Dan Kegel 20 Mar '07

20 Mar '07

Vijay wrote: >Resend. Please let me why this one has been dropped. I'd guess it's because there's no code in the tree that needs it yet, and no tests for it? - Dan

5 8

Re: winex11.drv: GetDeviceCaps(hdc, NUMCOLORS) must return 1 (not -1) if more than 256 colors. Bug 7757
by James Hawkins 20 Mar '07

20 Mar '07

On 3/18/07, Daniel Mario Vega <dv5a(a)dc.uba.ar> wrote: > --- > dlls/winex11.drv/init.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/winex11.drv/init.c b/dlls/winex11.drv/init.c > index cf23866..a60174d 100644 > --- a/dlls/winex11.drv/init.c > +++ b/dlls/winex11.drv/init.c > @@ -213,8 +213,8 @@ INT X11DRV_GetDeviceCaps( X11DRV_PDEVICE *physDev, INT cap ) > case NUMCOLORS: > /* MSDN: Number of entries in the device's color table, if the device has > * a color depth of no more than 8 bits per pixel.For devices with greater > - * color depths, -1 is returned. */ > - return (screen_depth > 8) ? -1 : (1 << screen_depth); > + * color depths, 1 is returned. */ > + return (screen_depth > 8) ? 1 : (1 << screen_depth); > case PDEVICESIZE: > return sizeof(X11DRV_PDEVICE); > case CURVECAPS: > -- > 1.4.4.4 > Please add a test case. -- James Hawkins

1 0

Being rude to users considered harmful
by Dan Kegel 20 Mar '07

20 Mar '07

Now, I'm as much of a BOFH as anybody else. Maybe more. But when I see a Wine developer telling users things like "For me all VB apps have to go to /dev/null without exceptions!" or "It's a minor problem - leave with it or fix it yourself!" I feel quite sad. Can we agree to be a bit more civil with the people who file bugs in bugzilla? Thanks... - Dan

4 3

Menu builder fix found
by Tom Spear 20 Mar '07

20 Mar '07

http://bugs.winehq.org/show_bug.cgi?id=7802 Basically all that should be done (and I dont know why this isnt done anyways) is to have wine (or more likely wineprefixcreate) make ~/.wine/dosdevices/c:/windows/profiles/(user)/Start\ Menu and ~/.wine/dosdevices/c:/windows/profiles/(user)/Start\ Menu/Programs .... Then also make winecfg _not_ default to creating ~/.wine/dosdevices/c:/windows/profiles/(user)/Desktop as a symlink to ~/Desktop.. This can be verified by starting with a clean .wine dir and clean ~/.wine/dosdevices/c: and running wineprefixcreate .. Then run winecfg and make sure to uncheck the Link to box for the Desktop shell folder in the Desktop Integration tab and apply the change. Then manually make ~/.wine/dosdevices/c:/windows/profiles/(user)/Start\ Menu and ~/.wine/dosdevices/c:/windows/profiles/(user)/Start\ Menu/Programs Then get the winrar installer and run it. Check all of the shortcut creation boxes after the install is finished. Then check the above mentioned folders. While I'm at it though I should mention that I have seen several installers fail if they can't find ~/.wine/dosdevices/c:/windows/system32 because for some reason wine doesn't create it either, not even as a symlink. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

1 0