March 2007 - Wine-devel - list.winehq.org

Re: comctl32: register all the controls in DllMain (fixes bug #7641)
by Felix Nawothnig 15 Mar '07

15 Mar '07

Mikołaj Zalewski wrote: > comctl32 version 5.82 (at least the one that comes with a fully patched > Windows XP) and 6.0 register all the controls in DllMain. > InitCommonControlsEx is just a dummy function. Could it be that 6.0 only registers those controls listed using window class dependencies in the manifest file? If what you say about 5.82 is true your patch is correct though ofcourse. Felix

2 1

Help with debug
by Phil Lodwick 15 Mar '07

15 Mar '07

Hi, I have been debugging a problem today and am running low on batteries. I am hoping somebody can look at the attached snippet of log and point me in the right direction. >From what I can tell, there is a DLL called snoopy.dll that does a whole bunch of allocs and reallocs and then tries to reference a NULL pointer which causes an unhandled exception. The code goes through a loop and does not always crash on the same iteration, but it always seems to crash at the same address. This code does not crash on Windows. Just getting lucky? Unfortunately I do not have the sources to this code, so it makes life a little more difficult. Any good ideas for my next step in debugging? Thanks, Phil

2 1

Re: Submitting winetricks to winehq tree?
by Dan Kegel 15 Mar '07

15 Mar '07

Carl-Daniel wrote: > Sorry if this has been answered before, but is winetricks a newer > version of winetools? No. Winetricks (http://www.kegel.com/wine/winetricks ) is a single 11KB shell script. It's a tiny command line tool that only knows how to install Microsoft redistributable libraries (and fonts), and set a registry key or two. For instance, if you're trying to install or run an application, but it fails with "import_dll Library MSVBVM60.DLL not found", you can fix it with $ winetricks vbrun60 Or if you're trying to install an app, but it fails with "Sorry, this application requires IE6", you can fix it without really installing IE6 by setting the right registry key. Winetricks makes this easy; just do $ winetricks fakeie6 etc. etc. Essentially, Winetricks just automates things one would normally have to look up in the Wine wiki, and it does it in the simplest possible way. Winetools ( http://www.von-thadden.de/Joachim/WineTools/ ) can do some of that, but it's really a different beast. It's a set of 150 or so files with a fancy GUI. Each of the files is a recipe for installing a particular Windows application. It is aimed at people who just want to run apps and not understand things. It is bad because, instead of working to improve Wine to make apps easy to install, it papers over the problems. And then there's Wine-Doors ( http://www.wine-doors.org ), which is like Winetools with delusions of grandeur. They seem to want to reinvent apt-get for no particular reason, and as far as I can tell, they intend to have a central server from which you can download copies of e.g. Photoshop with it. This doesn't seem legal, offhand, but I can't find their mailing list archive to see if anyone has asked them about this fine point. IMHO both Winetools and Wine Doors are mostly harmful, but they do have a real benefit for users. Winetricks is a bit like the non-harmful 1% of Winetools. If we don't provide something like Winetricks, more people might be driven to Winetools, and it'd be nice to prevent that. - Dan

2 1

Re: [2/3] kernel32: GlobalMemoryStatusEx: return the size of physicalmemory + swapsize in ullTotalPageFile/ullAvailPageFile
by Dmitry Timoshkov 15 Mar '07

15 Mar '07

"Fabian Bieler" <der.fabe(a)gmx.net> wrote: > - /* Project2k refuses to start if it sees less than 1Mb of free swap */ > - if (lpmemex->ullTotalPageFile < lpmemex->ullTotalPhys) > - lpmemex->ullTotalPageFile = lpmemex->ullTotalPhys; > - if (lpmemex->ullAvailPageFile < lpmemex->ullAvailPhys) > - lpmemex->ullAvailPageFile = lpmemex->ullAvailPhys; > + /* Win98 returns only the swapsize in ullTotalPageFile/ullAvailPageFile, > + WinXP returns the size of physical memory + swapsize; > + mimic the behavior of XP: > + */ > + lpmemex->ullTotalPageFile += lpmemex->ullTotalPhys; > + lpmemex->ullAvailPageFile += lpmemex->ullAvailPhys; Why did you remove a comment about Project2k? It helps to understand what are the constrains of the API, and helps to avoid chasing the same bug once again. -- Dmitry.

1 0

Submitting winetricks to winehq tree?
by Dan Kegel 14 Mar '07

14 Mar '07

I haven't been villified yet, so let me try harder. Should winetricks be committed to the winehq tree? It would be handy for people triaging Wine bugs to see if e.g. native dcom, odbc, or corefonts hide a bug. I've uploaded a new version to http://kegel.com/wine/winetricks Mainly it adds a -q option to make all the installers quiet, but it also includes lots of little improvements sent in by Detlef and Saulius. Here's the new usage message: Usage: winetricks [options] package [package] ... This script can help you prepare your system for Windows applications that mistakenly assume all users' systems have all the needed redistributable runtime libraries or fonts. Options: -q quiet. You must have already agreed to the EULAs. -v Verbose Packages: art2kmin Access 2000 runtime. License required! corefonts Install MS Times, Arial fonts dcom98 Install native DCOM, override the Wine implementation fakeie6 Set registry to claim IE6sp1 is installed mdac27 Microsoft ODBC drivers, etc. mfc40 mono1.1 mono 1.1.13-gtksharp-2.8.2 mono1.2 mono 1.2.3.1-gtksharp-2.8.3 vbvm50 Visual Basic 5 runtime vbrun60 Visual Basic 6 runtime vcrun6 vc6redist from VS6sp4, including mfc42 wsh51 Windows Scripting Host 5.1

5 4

Re: Makefiles: Be less verbose when performing make rules by only printing the command being executed and the source and/or target file.
by Eric Pouech 14 Mar '07

14 Mar '07

Robert Shearman a écrit : > > The old behaviour can be turned back on by setting the V environment > variable to "1" (e.g. make V=1). a couple of more comments (mostly not yet converted rules): - the MAKEDEP rule in Make.rules.in isn't handled yet (suggestion [DEPEND] $SRC(DIR)) - most of exec rule in tools/*/Makefile.in miss the MAKERULE stuff - ditto in loader (and the version-stamp could be handled too) - in dlls/Makedlls.rules.in, all lib/def/.a stuff isn't handled is there any reason why the Linking... rule has a different format than the others ? now I wish we could also get rid of the message for recursive calls to make A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Re: [advapi32/tests 1/2] Use GetModuleHandle and skip
by Francois Gouget 14 Mar '07

14 Mar '07

On Tue, 13 Mar 2007, Paul Vriens wrote: [...] > as advapi32 is already linked to, we can use GetModuleHandle. - if (!(module = LoadLibrary( "advapi32.dll" ))) return; + if (!(module = GetModuleHandleA( "advapi32.dll" ))) return; Well, since we're already linked to advapi32.dll, there's no need to check that GetModuleHandleA() does not return NULL. Plus if we were to check we should use skip(). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ May your Tongue stick to the Roof of your Mouth with the Force of a Thousand Caramels.

2 1

A SoC proposal for discussion: PE Packers
by Julien 14 Mar '07

14 Mar '07

Hello all, I didn't find a webpage on the wiki about SoC'07. However, I would like to suggest a SoC proposal for your comments. It seems to me that there are many bugs floating in bugzilla that are related to PE packers. Because applications just crash due to being packed, this seems a requirement for Wine 1.0. For a SoC, it would be very interesting if one student takes the mission of fixing bugs related to PE packers such as: - Shrinker (#2608, #2619) - Neolite (seems ok see #4709) - Aspack (#6129) - Armadillo (#219) This would require to define the list of PE packers to support and which versions (as anti debugging tricks may differ depending of the version). Best, Julien

2 1

Re: Add very basic initial tests for d3drm
by Dmitry Timoshkov 14 Mar '07

14 Mar '07

"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote: > +START_TEST(vector) > +{ > + init_function_pointers(); > + > + VectorTest(); > + QuaternionTest(); What happens if init_function_pointers() failed? -- Dmitry.

2 1

Re: Alexandre Julliard : ntdll: Add a wrapper to call the thread entry point for broken apps.
by Ken Thomases 14 Mar '07

14 Mar '07

On Mar 14, 2007, at 7:25 AM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 7744443febb04213cf014b007a83744a66544d6c > URL: http://source.winehq.org/git/wine.git/? > a=commit;h=7744443febb04213cf014b007a83744a66544d6c > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Wed Mar 14 12:28:38 2007 +0100 > > ntdll: Add a wrapper to call the thread entry point for broken apps. > > --- > > dlls/ntdll/thread.c | 25 ++++++++++++++++++++++--- > 1 files changed, 22 insertions(+), 3 deletions(-) > > diff --git a/dlls/ntdll/thread.c b/dlls/ntdll/thread.c > index 9656331..d0871a1 100644 > --- a/dlls/ntdll/thread.c > +++ b/dlls/ntdll/thread.c > @@ -349,6 +349,26 @@ static PUNHANDLED_EXCEPTION_FILTER > get_unhandled_exception_filter(void) > return unhandled_exception_filter; > } > > +#ifdef __i386__ > +/* wrapper for apps that don't declare the thread function > correctly */ > +extern DWORD call_thread_entry_point( PRTL_THREAD_START_ROUTINE > entry, void *arg ); > +__ASM_GLOBAL_FUNC(call_thread_entry_point, > + "pushl %ebp\n\t" > + "movl %esp,%ebp\n\t" > + "subl $4,%esp\n\t" > + "pushl 12(%ebp)\n\t" > + "movl 8(%ebp),%eax\n\t" > + "call *%eax\n\t" > + "leave\n\t" > + "ret" ); > +#else > +static inline DWORD call_thread_entry_point > ( PRTL_THREAD_START_ROUTINE entry, void *arg ) > +{ > + LPTHREAD_START_ROUTINE func = (LPTHREAD_START_ROUTINE)rtl_func; Should the above have "entry" instead of "rtl_func"? > + return func( arg ); > +} > +#endif > + > / > ********************************************************************** > * > * call_thread_func > * > @@ -356,16 +376,15 @@ static PUNHANDLED_EXCEPTION_FILTER > get_unhandled_exception_filter(void) > */ > static void DECLSPEC_NORETURN call_thread_func > ( PRTL_THREAD_START_ROUTINE rtl_func, void *arg ) > { > - LPTHREAD_START_ROUTINE func = (LPTHREAD_START_ROUTINE)rtl_func; > DWORD exit_code; > BOOL last; > > MODULE_DllThreadAttach( NULL ); > > if (TRACE_ON(relay)) > - DPRINTF( "%04x:Starting thread proc %p (arg=%p)\n", > GetCurrentThreadId(), func, arg ); > + DPRINTF( "%04x:Starting thread proc %p (arg=%p)\n", > GetCurrentThreadId(), rtl_func, arg ); > > - exit_code = func( arg ); > + exit_code = call_thread_entry_point( rtl_func, arg ); > > /* send the exit code to the server */ > SERVER_START_REQ( terminate_thread ) > > >

2 1