March 2007 - Wine-devel - list.winehq.org

Is there someone working on dxdiag?
by Mirek 09 Mar '07

09 Mar '07

Hi, I would like to start some applications like Carmageddon TDR 2000 in HW mode, Neverwinter Nights 2 or just GetGPUAndSystemInfo.exe from Nvidia SDK demos and maybe 3DMark with HW info, but there are problems with detecting video card, I assume the main problem is in dxdiag library. So I would like to ask if there is someone working on this library, or if was there some code which was not accepted in wine tree to fix that? I am trying to hack this library, but with only small success. Mirek Slugen

3 3

Re: quartz: Check allocation failure and clear memory in DSound Renderer
by Robert Shearman 09 Mar '07

09 Mar '07

Chris Robinson wrote: > return CLASS_E_NOAGGREGATION; > > pDSoundRender = CoTaskMemAlloc(sizeof(DSoundRenderImpl)); > + if (!pDSoundRender) > + return E_OUTOFMEMORY; > + ZeroMemory(pDSoundRender, sizeof(DSoundRenderImpl)); > > pDSoundRender->lpVtbl = &DSoundRender_Vtbl; > pDSoundRender->IBasicAudio_vtbl = &IBasicAudio_Vtbl; > @@ -325,9 +328,15 @@ HRESULT DSoundRender_create(IUnknown * pUnkOuter, LPVOID * ppv) > pDSoundRender->pClock = NULL; > pDSoundRender->init = FALSE; > pDSoundRender->started = FALSE; > - ZeroMemory(&pDSoundRender->filterInfo, sizeof(FILTER_INFO)); > The check for allocation failure is good, but clearing the memory that is going to be initialised anyway is inefficient and unnecessary. -- Rob Shearman

2 1

Re: [2/2] wined3d: IWineD3DDeviceImpl_UpdateSurface: return D3DERR_INVALIDCALL if source and dest format do not match
by H. Verbeet 09 Mar '07

09 Mar '07

On 09/03/07, Fabian Bieler <der.fabe(a)gmx.net> wrote: > + if (destFormat != srcFormat) { > + WARN("source %p and dest %p must match, returning WINED3DERR_INVALIDCALL\n", pSourceSurface, pDestinationSurface); > + return WINED3DERR_INVALIDCALL; > + } You should probably print the actual formats there, using debug_d3dformat(). Also, a test wouldn't hurt.

1 0

Fwd: wined3d: Update cursor position on ShowCursor
by Erich Hoover 09 Mar '07

09 Mar '07

Request for comments, as per http://www.winehq.com/site/sending_patches. For details on the need for this patch please see Bug #7542<http://bugs.winehq.org/show_bug.cgi?id=7542>. Thanks! Erich Hoover ehoover(a)mines.edu ---------- Forwarded message ---------- From: Erich Hoover <ehoover(a)mines.edu> Date: Mar 3, 2007 6:46 PM Subject: wined3d: Update cursor position on ShowCursor To: wine-patches(a)winehq.org Real Name: Erich Hoover Description: When ShowCursor is first called it should make the cursor appear at the OS's last known cursor position. Because of this, some applications just repetitively call ShowCursor in order to update the cursor's position. This behavior is undocumented. Changelog: wined3d: Update cursor position on ShowCursor

3 2

Re: Alexandre Julliard : advapi32: Fixed registry test that failed because of a buffer overflow.
by James Hawkins 09 Mar '07

09 Mar '07

On 3/8/07, Alexandre Julliard <julliard(a)wine.codeweavers.com> wrote: > Module: wine > Branch: master > Commit: 7e2228f15aa7a6fc0d63fe36c34906035422e95a > URL: http://source.winehq.org/git/wine.git/?a=commit;h=7e2228f15aa7a6fc0d63fe36c… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Thu Mar 8 21:06:31 2007 +0100 > > advapi32: Fixed registry test that failed because of a buffer overflow. > The test passes in Windows, so isn't this hiding a bug in our implementation of RegSetValueW? -- James Hawkins

2 1

How does wine determine to draw non-client area according to managed mode setting?
by Sunil Baek 09 Mar '07

09 Mar '07

Hello, When wine runs on managed mode, it delegate drawing non-client area(caption, frame-border) to window manager. I found NC_DrawCaption function is not invoked on managed mode. On non-managed mode, that function is invoked. I tried to find routine which determine to draw non-client area according to managed mode setting, but I can't. please give me some hints about that. Thank you.

1 0

Re: comctl32: listview tests
by Lei Zhang 09 Mar '07

09 Mar '07

On 3/8/07, George Gov <ggov(a)ucla.edu> wrote: > @@ -573,10 +699,242 @@ static void test_redraw(void) > trace("invalidate & update\n"); > InvalidateRect(hwnd, NULL, TRUE); > UpdateWindow(hwnd); > - ok_sequence(sequences, LISTVIEW_SEQ_INDEX, redraw_listview_seq, "redraw listview", FALSE); > + ok_sequence(sequences, LISTVIEW_SEQ_INDEX, redraw_listview_seq, "redraw listview", TRUE); This test succeeds for me, so I'm not sure why you marked it as todo. - Lei

1 0

Re: quartz: Use proper alloc/free functions for COM objects
by Detlef Riekenberg 09 Mar '07

09 Mar '07

On Do, 2007-03-08 at 03:06 -0800, Chris Robinson wrote: > Subject: [PATCH] quartz: Use proper alloc/free functions for COM > objects > + omr->messages = CoTaskMemAlloc(omr->ring_buffer_size * > sizeof(Event)); > + ZeroMemory(omr->messages, omr->ring_buffer_size * sizeof(Event)); > > + fimpl = CoTaskMemAlloc(sizeof(*fimpl)); > fimpl->IGraphBuilder_vtbl = &IGraphBuilder_VTable; > + This->ppPins = CoTaskMemAlloc((This->cStreams + 2) * sizeof(IPin > *)); > memcpy(This->ppPins, ppOldPins, (This->cStreams + 1) * > sizeof(IPin *)); > + This->ppPins = CoTaskMemAlloc(sizeof(IPin *) * 1); > memcpy(This->ppPins, ppOldPins, sizeof(IPin *) * 1); While reading your Patch, I see the above Places, where the result from the allocation is used without a NULL-check. The other allocations are checked for NULL before used. Is this correct? -- By by ... Detlef

2 1

Command and Conquer 3 Demo
by Matthew Clark 09 Mar '07

09 Mar '07

I just wanted to write to let all of the devs know how proud of the wine project I am. This Demo seems to work for the most part except for the movies in it don't seem to want to resize and when you are under attack the game crashes. Here is the console dump: fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=49332 < primary_done=49356) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=39800 < primary_done=39824) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=35960 < primary_done=35984) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=36008 < primary_done=36032) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=39968 < primary_done=39992) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=36128 < primary_done=36152) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=36128 < primary_done=36152) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=38072 < primary_done=38076) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=38072 < primary_done=38076) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=38072 < primary_done=38076) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=34232 < primary_done=34236) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=38072 < primary_done=38096) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=34232 < primary_done=34256) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=36152 < primary_done=36176) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=36152 < primary_done=36176) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=36152 < primary_done=36176) err:dsound:DSOUND_MixOne underrun on sound buffer 0x210b10 fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=34568 < primary_done=34592) wine: Unhandled page fault on read access to 0x0000fff7 at address 0x7efa2553 (thread 000e), starting debugger... fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=50292 < primary_done=50316) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=40784 < primary_done=40808) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=40784 < primary_done=40808) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=40784 < primary_done=40808) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=40784 < primary_done=40808) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=40784 < primary_done=40808) fixme:alsa:ALSA_AddRingMessage two fast messages in the queue!!!! toget = 52(WINE_WM_RESTARTING), tosave=53(UNKNOWN(0x00000000)) fixme:alsa:ALSA_AddRingMessage two fast messages in the queue!!!! toget = 36(WINE_WM_RESTARTING), tosave=37(UNKNOWN(0x00000000)) hope that helps. Again, greats that that is all that's wrong^_^ The graphics look great, it sounds great, and the videos are crystal clear(though small). -Matthew Clark

3 4

modification to allow -Wcast-qual to find potential warnings without unicode.h causing them
by Andrew Talbot 08 Mar '07

08 Mar '07

Assuming it is valid and does what is required, maybe the following pragma would be more precise. #pragma GCC diagnostic warning "-Wwrite-strings" -- Andy.

1 2