March 2007 - Wine-devel - list.winehq.org

Visualizing skip on test.winehq.org (and getting rid of visible desktop border)
by Paul Vriens 05 Mar '07

05 Mar '07

Hi, currently all tests on test.winehq.org show the blue border to indicate the test is running on a visible desktop. I think we can get rid of this one as winetest will not run if we don't have a visible desktop. My idea is to visualize the skipped tests by using the blue border at the single test level to indicate tests are skipped (see attached picture). Comments, idea's, thoughts? Cheers, Paul.

3 2

fc4 rpms
by Bill Medland 05 Mar '07

05 Mar '07

Is there any chance that someone with the ability can create the fedora core 4 wine rpms for version 0.9.30? Bill Medland

4 4

Re: Problems with Alice
by gslink 05 Mar '07

05 Mar '07

After considerable digging the problems with sound in Alice were traced to a bad software load. While digging another thing came to our attention that may be of interest to others. When we put in the latest fixes to FC6 Wine quit running. This was traced to the fact that the latest fixes contain a set of fixes for the X server and replace the open GL library. The drivers posted by Nvidia, which were installed, have their own GL library and will not work with the RH GL library. If you install an update to FC and are using the Nvidia drivers reinstall the drivers if things in the X server quit working. This is true even if the kernel version is not changed.

1 0

Re: secur32: NTLM's AcquireCredentialHandleA/W should accept domains and usernames with lengths of 0.
by Kai Blin 05 Mar '07

05 Mar '07

On Monday 05 March 2007 13:02, Robert Shearman wrote: > + if(pQuerySecurityPackageInfoA(sec_pkg_name, &pkg_info) != SEC_E_OK) > + { > + trace("NTLM package not installed, skipping test\n"); > + return; > + } I've just started using skip() for skipping tests. Cheers, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

2 1

Writing IDL and other definition files
by Jeff L 05 Mar '07

05 Mar '07

I am looking at writing a piece of IDL and a header file I am wrestling with how to do it without infringing copyright. IDL looks particularly hard to write from first principles and is probably hard to write in a different way as the functions being implemented are defined and require IDL similar code. Is there any advice as to what type of code can be copied and what constitutes a rewrite to avoid copyright? Jeff

2 2

Re: [msi, 1/5, try 5] msi: Add OLE automation conformance test.
by James Hawkins 04 Mar '07

04 Mar '07

On 3/4/07, Misha Koshelev <mk144210(a)bcm.tmc.edu> wrote: > Changes: Ok, try 5. This time there are five patches, as this first > patch is a (moderately) comprehensive conformance test for MSI OLE > automation, which checks all the functions that will be implemented, and > does basic checks like set a property, then get it, is the property what > we set it to? I hope this helps get it into git. > > These patches add partial OLE automation support for MSI and then add > JScript/VBScript support for MSI (as the MSI specs specifically state > that applications that need this functionality must install Windows > Script themselves). As a proof of concept, sufficient automation support > is added to conform to the conformance test and to fix bug #7357. > Doesn't compile: ../../../tools/winegcc/winegcc -B../../../tools/winebuild -mconsole automation.o db.o format.o iface.o install.o msi.o package.o record.o suminfo.o testlist.o -o msi_test.exe.so ../../../libs/port/libwine_port.a -lcabinet -lmsi -lshell32 -lole32 -ladvapi32 -lkernel32 -luuid automation.o: In function `invoke': /home/truiken/wine/dlls/msi/tests/automation.c:389: undefined reference to `VariantInit' /home/truiken/wine/dlls/msi/tests/automation.c:404: undefined reference to `VariantClear' /home/truiken/wine/dlls/msi/tests/automation.c:398: undefined reference to `VariantChangeTypeEx' -- James Hawkins

2 3

Re: [PATCH 1/2] comctl32: Added getter-setter tests for the tab control (second attempt)
by Vitaliy Margolen 04 Mar '07

04 Mar '07

The_Hagop wrote: > @@ -1,5 +1,6 @@ > /* Unit test suite for tab control. > * > + * Copyright 2007 Hagop Hagopian > * Copyright 2003 Vitaliy Margolen > * > * This library is free software; you can redistribute it and/or These are sorted in historical order. > @@ -52,6 +59,8 @@ > > static HFONT hFont = 0; > > +static HWND hTab; > + > static HWND > create_tabcontrol (DWORD style, DWORD mask) > { You using exactly the same name as parameter to all of your functions. This creates lots of confusion. Please remove this global variable and pass it as a function parameter instead. > + /* Creating a tooltip window*/ > + hwndTT = CreateWindowEx(WS_EX_TOPMOST, > + TOOLTIPS_CLASS, > + NULL, > + WS_POPUP | TTS_NOPREFIX | TTS_ALWAYSTIP, > + CW_USEDEFAULT, > + CW_USEDEFAULT, > + CW_USEDEFAULT, > + CW_USEDEFAULT, > + hTab, > + NULL, > + 0, > + NULL > + ); > + > + SetWindowPos(hwndTT, > + HWND_TOPMOST, > + 0, > + 0, > + 0, > + 0, > + SWP_NOMOVE | SWP_NOSIZE | SWP_NOACTIVATE); This looks just plain bad. Please put all parameters one after another. There are absolutely no need to have each on it's own line. > + ti.rect.left = rect.left; > + ti.rect.top = rect.top; > + ti.rect.right = rect.right; > + ti.rect.bottom = rect.bottom; You can assign structures to structures in C: ti.rect = rect; > + todo_wine{ > + /* Testing CurFocus with negative value */ > + SendMessage(hTab, TCM_SETCURFOCUS, -1, 0); > + focusIndex = SendMessage(hTab, TCM_GETCURFOCUS, 0, 0); > + expect(-1, focusIndex); > + } Here and all other places - the only part of the test that's failing is "expect(,)". Add "todo_wine" at front of it only. Also it would be interesting to test larger negative numbers, like -10. This is because number of places use -1 to indicate that nothing is selected. So in a sense you might be getting a correct number. > + expect((int) extendedStyle, (int) prevExtendedStyle); > + todo_wine{ > + extendedStyle = SendMessage(hTab, TCM_GETEXTENDEDSTYLE, 0, 0); > + expect(TCS_EX_FLATSEPARATORS, (int) extendedStyle); > + } Why are you casting DWORD to int? > +static void test_getters_setters(INT nTabs) > +{ > + RECT rTab; > + INT nTabsRetrieved; > + INT rowCount; > + > + hTab = createFilledTabControl(TCS_FIXEDWIDTH, TCIF_TEXT|TCIF_IMAGE, nTabs); > + ok(hTab != NULL, "Failed to create tab control\n"); > + > + SendMessage(hTab, TCM_SETMINTABWIDTH, 0, -1); > + > + /* Testing GetItemCount */ > + nTabsRetrieved = SendMessage(hTab, TCM_GETITEMCOUNT, 0, 0); > + expect(nTabs, nTabsRetrieved); > + > + /* Testing GetRowCount */ > + rowCount = SendMessage(hTab, TCM_GETROWCOUNT, 0, 0); > + expect(1, rowCount); > + > + /* Testing GetItemRect */ > + SendMessage(hTab, TCM_GETITEMRECT, 0 , (LPARAM) &rTab ); > + CheckSize(hTab, TAB_DEFAULT_WIDTH, -1 , "Default Width"); > + > + test_getset_curFocus(hTab, nTabs); > + test_getset_curSel(hTab, nTabs); > + > + test_getset_extendedStyle(hTab); > + test_getset_unicodeFormat(hTab); > + test_getset_item(hTab); > + test_getset_tooltip(hTab); > + > + DestroyWindow(hTab); > +} All your small functions should go inside this function. There is no need to create 100 small functions that do 1-3 tests. > + > + test_getters_setters(5); > } This part part of your patch appears to be malformed. Vitlaiy

2 2

Current wine and HL2 family - well done!
by Pavel Troller 04 Mar '07

04 Mar '07

Hi! Normally I'm writing complaints here, so for a bit of compensation, I would like to inform that yesterday's wine runs HL2 family of games for the first time without an annoying graphics glitch causing parts of skies to be replaced with some bogus contents like white, black, mirrors of a part of ground etc. So, many thanks to all the DirectX developers especially from my sons, they are very pleased and wish you all the best, especially continuous progress in wine development (a bit egocentric from them, but nice :-)) ). With regards, Pavel Troller

2 1

Re: gdi32: Add a EnumFontFamilies test, make it pass under Wine. Try 2
by Dmitry Timoshkov 04 Mar '07

04 Mar '07

"Dmitry Timoshkov" <dmitry(a)codeweavers.com> wrote: > this patch should fix the problem reported in the bug #7571. > > This version of the patch adds a test for the case of enumerating "Symbol"-like > fonts (pointed out by Huw), and makes it pass under Wine as well. > > Changelog: > gdi32: Add a EnumFontFamilies test, make it pass under Wine. Please do not commit this patch, according to the comments in the bug above it needs more work. -- Dmitry.

1 0

Re: Fix compilation on systems that don't support nameless unions.
by Dmitry Timoshkov 04 Mar '07

04 Mar '07

"Francois Gouget" <fgouget(a)free.fr> wrote: > This fixes compilation with gcc 2.95. > > programs/cmd/batch.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) As a more general solution that would also prevent this kind of breakage in future would be to move #define NONAMELESSUNION #define NONAMELESSSTRUCT from directory.c to wcmd.h. -- Dmitry.

1 0